From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00EC4C4345F for ; Thu, 25 Apr 2024 23:49:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 737336B0087; Thu, 25 Apr 2024 19:49:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E6656B008A; Thu, 25 Apr 2024 19:49:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AD7E6B008C; Thu, 25 Apr 2024 19:49:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3BE526B0087 for ; Thu, 25 Apr 2024 19:49:23 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DEEF7120C73 for ; Thu, 25 Apr 2024 23:49:22 +0000 (UTC) X-FDA: 82049698164.27.98D5B91 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 377FD140003 for ; Thu, 25 Apr 2024 23:49:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eKTJZctI; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714088960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qbiJi1CBK7vilE4zwZEF5H8sVx43LgiKbqOxdhCgoIk=; b=5WHFdkeJEw1+KeRO/uGRvBHvcJO69XyDg7YWw/kLJJ3ovL4z7eHxutlCDacyKkU11afwYl GWCI7auIy3G5NOgqrN7YMdF/rNp/EJHyfOjvUrVDwVkdNXI7z7YoiBtGrZtiJ7iYns5x2j wyNdL2pzxhMJDYJTiV3vWR3TrhsKeas= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eKTJZctI; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714088960; a=rsa-sha256; cv=none; b=TVOSW+wZNz0EGu9U7nnet1qR1/nFBURr7at98LcISXbvk1LtAE8nvgv9MMA7EW0zKvBzoM ZbP0Lv57XSZUfADheiOkJKzykFVjNRcI7D9WhL10/A0wfRJZs6DGEd12TmrsxGA2qS+0J+ L4BCZLgNTQNKiyi+CwsxjXr5LdOxE48= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 26B3E61CCB; Thu, 25 Apr 2024 23:49:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DB97C113CC; Thu, 25 Apr 2024 23:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1714088958; bh=xThSuDa7B7/IrHBAvCAlq+cuUm1QUymQXFLtZ01/yBY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eKTJZctIgAnNhEvYPY2857R1t3FtNk6ED3TJMxHDTM4ggwp1v4bCx0sn76PwQ1tM6 a57YFhEymsUHaJEpgUqPEhS82jzBH4j1KLB5q2RRj2NtNf42wkSRgJI4tDt+9jXfhR 6T1kjJKoagm96u759c62opUlD5ELcHmMgxoTiv04= Date: Thu, 25 Apr 2024 16:49:17 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: Kent Overstreet , Kees Cook , Catalin Marinas , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] mm/slub: Avoid recursive loop with kmemleak Message-Id: <20240425164917.8c9603387b4cce11121024a8@linux-foundation.org> In-Reply-To: References: <20240425205516.work.220-kees@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: mznregrwxjdpugxp7q99p1cn3q47bry4 X-Rspamd-Queue-Id: 377FD140003 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1714088960-196489 X-HE-Meta: U2FsdGVkX19DzPHPbGGOxyyvBlZoeKszzKXCxY1xs4T48dpuibhPM3WM22dJG0FG8foOJs6jpWEZD5A5DGoeVGxvks5l2O9cyv9nCTJ/Bukaob5cZMa2kD9nExtpUdePHP3BQwKrWzi7oHhK9Yi2tUxo8ByA0JodmWO8VdN52KKsOy+kZZ6qpEky3FLnqYRvGw6CLe0bZeiFF64J3D/iZaBIJtSXuSRqfFbYBdNEubRpIwG/OBZsO2B6ovNANZRTNfbClftmNnNpZFfuXWIDaPak2nBtbfEpiULiumOESSMEtP3qzYXju1ulBGTuN/msnX1ZML0VPfucQKBw4whC+43GlcvEuNxGkkFYF4iTPQ9hLBbNwKFLp9Jcg2GdPkr9bPjYqp1/deO8ouSddLYGO44CuMRPqyPlvubekO1kU/MDqSjeyhIIb5nPETNfO3o919yyrtDouSxN/CA8AVHICTyXMcCHNTJzv0Qat43CpWblGU3TXS3iprDUZD78Vj4dIQCz2IfgVesXNnDNelfYOjjoIO5hoUbqqpDIenXYUednhQjcgtPecWM7w4zyNuLVctbBWhJRHVa6JapT5Kw7bh/IEqp15xAryIaFlEY56lxZuXfb1uJB5Kj3o+jh8HDZPEn1HVGAPCt/fs9Cdi5Yr9x0ZQOC3xY1D8aRaci0cvuUu1+lglXqn2TKcHRkr4aSxqV6+NmpGyBX4CBtR7+DnbUxcPvkh1rLBVJXGS4w+LX2cVGx9/cwsXbvboigJkW0X4HVpL3isPQhygtggJrhB8K2TRLsZvQc+KEGkc45I1QqekFJj026MqxlZrIme4wapSo3bZcZodH4jMfuRIQKVGh/Nu5DIvZWdm/3tqwHxwxdCpppESd/JXTKY6xWxMnIzkB941ZQv8z51zMK1RR1mJdwff9H42w92T7krrSUk/7D9GovjTZ1mv0f4P30co/oYrIrtgJ41nPsQYBr18d f+WQrP0b eHlhqi3HXEnSWxuozP7Zl+JI9i5jlBIRdjb4rkQK9mYmEBflTw69aPLQJzyncPQwxuetWL8yQSSWXqDipc+dTUGyaRVVNN1lW7ru9euD8ZeI0G+fzQxoYRqkbhU//GAnU18wj/+oKCZ33AQrY0YxlGx51ElNO3fhtjNzE0dEU8AMPE8jf2tx04GWMuiVmf31ckMYLELnuOXOU3g8rPNgytRosACwq4Nf56MUAGChOWBlzDIw5ODBjlSwFH6GDiwMTuEHx1SPKDTYas+tvqL13O/8UL9TptqhdOKKf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 25 Apr 2024 14:30:55 -0700 Suren Baghdasaryan wrote: > > > --- a/mm/kmemleak.c > > > +++ b/mm/kmemleak.c > > > @@ -463,7 +463,7 @@ static struct kmemleak_object *mem_pool_alloc(gfp_t gfp) > > > > > > /* try the slab allocator first */ > > > if (object_cache) { > > > - object = kmem_cache_alloc(object_cache, gfp_kmemleak_mask(gfp)); > > > + object = kmem_cache_alloc_noprof(object_cache, gfp_kmemleak_mask(gfp)); > > > > What do these get accounted to, or does this now pop a warning with > > CONFIG_MEM_ALLOC_PROFILING_DEBUG? > > Thanks for the fix, Kees! > I'll look into this recursion more closely to see if there is a better > way to break it. As a stopgap measure seems ok to me. I also think > it's unlikely that one would use both tracking mechanisms on the same > system. I'd really like to start building mm-stable without having to route around memprofiling. How about I include Kees's patch in that for now?