From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADAFBC4345F for ; Thu, 25 Apr 2024 21:01:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E97436B0099; Thu, 25 Apr 2024 17:01:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E47736B009A; Thu, 25 Apr 2024 17:01:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0F926B009B; Thu, 25 Apr 2024 17:01:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B1BDE6B0099 for ; Thu, 25 Apr 2024 17:01:31 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 75DC61A0696 for ; Thu, 25 Apr 2024 21:01:31 +0000 (UTC) X-FDA: 82049275182.12.44F33AB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 2EB7DC002A for ; Thu, 25 Apr 2024 21:01:29 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=v3QTKtLT; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714078889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rcTZeFfPARSRjujSSHOciln/ZRB7LavlI/8ik1RstSI=; b=028U0Wv27opl0gmqQVEE/NaNnid/pE3PI01hHlxA88NBKj3Dbl+gikWHYsxGvMvIF8qAbt eorHdfv0ZU30X3v6jkX/xpXAXzzkM+GKs2I8Bh6c6OxjzNnWj5MQMAc3AK/S+YHr4Q2af7 TqFgoSE5vZ5P/PNDRBjzkoSg+hXjaGo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=v3QTKtLT; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714078889; a=rsa-sha256; cv=none; b=J9KSmTXhJp//HKget+oFrmRZ63B+gY7//rj/OuWKc6nBHlTDTloONuIuXNl7kQ32W0dpf8 8DwPWgXrnsHyzNVaBs59dxHkfVO0qo5TdZo6jRhdt2Y6PEAtW5oAz5SAyT5Bv92DjND7OU w74bD+W7xb6AGUEyhmXlAQCOcyx4KSk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2568A61ED5; Thu, 25 Apr 2024 21:01:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60154C113CC; Thu, 25 Apr 2024 21:01:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1714078887; bh=WddoWrRbeR1iHMtp/qfJ1PoQ1YAx1kckTTOIrZin9ZU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=v3QTKtLTXH5dOykrJSj2tlJ/7MBrHwawwmkcuOxDVU1yB0fmMRU34CiMK70rfe95P 4hh/P4b5ruo+RX4VlrkSOdwBmeaWQIIjhS6884Mj4sYbChmT8Nyro8fcgcdmqK2WAL GH+nvOrLfYJtvey8FB5I1WWI8rfd1wG6C+HCRwaI= Date: Thu, 25 Apr 2024 14:01:26 -0700 From: Andrew Morton To: Luis Chamberlain Cc: ziy@nvidia.com, linux-mm@kvack.org, fstests@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, hare@suse.de, john.g.garry@oracle.com, p.raghav@samsung.com, da.gomez@samsung.com Subject: Re: [PATCH 1/2] mm/huge_memory: skip invalid debugfs file entry for folio split Message-Id: <20240425140126.2a62a5ec686813ee7deea658@linux-foundation.org> In-Reply-To: <20240424225449.1498244-2-mcgrof@kernel.org> References: <20240424225449.1498244-1-mcgrof@kernel.org> <20240424225449.1498244-2-mcgrof@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 2EB7DC002A X-Stat-Signature: 3psuyz9kh6nsgus6bub614ujri8pqgjs X-HE-Tag: 1714078889-126610 X-HE-Meta: U2FsdGVkX19/bpQvqOFcoSCrO7q3L4kdhjgUDMIimWiOPL7rwsDGNVEMi75vWpLauHgYza5p++YkNVbeZqzgjddGm/h9zRrNdwSLLMWlYZNHe+JQhFyB0S8XBjDwc1/0S7fb73m9AjjDFZz8GsdJlQ3hPLgWi4x2zgg41TgIpUshjzpW9CYPXugbeq23HtXmSce5GYtR271YPuQ/vJ6okdtADIK85UO7GU2EQxFMm7NnB+W2BGxx5+NnJlojythj+2vbvWKZUl5W3wC2jG35uTLYInSEa/WF+V31eOyedkSpueSjCFI7MfcUZrWGVUPfSBDgyiC7o7zTBTX7FdMC2uZdEnz5LkNyr1dCby9vx55/RD315WkT6MM0iRsgfObFVUOJ9lQsoPTYF+tnu5D8OgPCbaObYPbR0RULzVxvylnN3qVUrEAMQCRGe8BTol8G9m6ou7b53DHFP7fn2xKUTyUlphHox7IJIkix4EQZ9372Uh0RXh8Hjp2If3lc9ibG7W6ysf2l1ud2EdQLUgtZK00cXCI29LfEHMLlllZP5N6CazAA3U7LNSIGgzppUBgS76KzvXY6GYUPQkj2Zgo19QheHvz2zFSWhuEyXlBL93IJb7Yg1qhpVIdkrrse1k96a9ks74PUyUi5Jn0d1JDmJriQwvSk13jQz+GtqXMSu/MaXbXan7OYazdVmPQ1VCslHH3NyetLo+2/sqa7TyOuqdd6HgptHS85h3buua4mDgEbTeUhvZuUC/vQcl1PTBAeuZu2jdaGK5D/H646J81Q1xxTZ6hpgfHZA90LNP8H5V1ZvWRbfHwLpXDack4FkL61XF/xneZsdEEjQ3cudElPS7xa7YhYuRFFbWWX0geGc9N0ayT9ScwfirisekyNCsR0HL+IL8sIdkH/LNiQf/xauJ9+BVBwmjDQMU2O2hnFHl0Zy6zlyOkcNy1GkmDR8eqbIJ6UVYbdLBoHnMalxN1 arIGW3yN gQlVBLydoq2cB5MLcaXEwKwusvZMXMvsrhXqGYGQCXuxRfdpd4kmE8XJ6vyiN6Hl08lHGAbMwk6xPvf4sPEyoJZwvM4hzb120MlRLeuajCva3zV5oVK0bPu7A4kavYo5Pwz9ZeLFU2Ud1Tuz2VUuhdLHYzf9rTxCw7Zbq4BHacZ8O9wXpecxY92DHCauARDnXjn4BUhvt25YiTgpqMwlptzulcFoPRLWKc+QE2wqdBLPf3qbMstybTdJDRVPEDi0xAfdO1gCZg+4L+DTL+/3fKPHvMwZlqEPXozlBuKEd13Sg+UjV2jEex4iHh8wNB4IvsTZLFImaQtwhmPlatDXgLablPnit94y+c9XNcLaFdeS7khk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 24 Apr 2024 15:54:48 -0700 Luis Chamberlain wrote: > If the file entry is too long we may easily end up going out of bounds > and crash after strsep() on sscanf(). > Can you explain why? I'm not seeing it.