From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF03BC4345F for ; Thu, 25 Apr 2024 20:54:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67E836B008C; Thu, 25 Apr 2024 16:54:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62CA56B0092; Thu, 25 Apr 2024 16:54:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F5006B0093; Thu, 25 Apr 2024 16:54:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2D9BD6B008C for ; Thu, 25 Apr 2024 16:54:47 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D4C131C18DF for ; Thu, 25 Apr 2024 20:54:46 +0000 (UTC) X-FDA: 82049258172.07.27FC79A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf28.hostedemail.com (Postfix) with ESMTP id DCCE5C0022 for ; Thu, 25 Apr 2024 20:54:44 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MRcSEMCu; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714078485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8v3DG0q+vIy31cnrtcBswhX+XnCHkm8Pbc355Zn6nTw=; b=QoqFBKRCgPOWicR/VltTdWwwAR2t2aEpy/ws3I61oplRdn9F6tnC1vX2ZdxryjDNZBZ9WV 3fhOnlPSd6QuwfOezvNIlQfSlwo6PKaiqgJpmfc0fUEHNlvHlcMhZ3klP+JZiPVmqlkfsk nkwMEcMvOO2ErB0HpUtDdA1SNYDxN+8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MRcSEMCu; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714078485; a=rsa-sha256; cv=none; b=waDx5w4WPw/U4wQ1sf+MXOS77GVEt82cYF8+rDc5FhwMnlqCBo8fv4JfHNNPsxXh/1rabF sjLe3SPszHGAtjdzU5jJrE4kEN+qMogRRrXR6sLJMs3EMw4gA1xAZgYYks+InASzgBJEMP tyyG7ZtEZ35ddm8lA1859bmG+1OLh7E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A6CE1CE1B1F; Thu, 25 Apr 2024 20:54:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9363C113CC; Thu, 25 Apr 2024 20:54:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1714078479; bh=HkEaMkDSe83Oel7YjWVhrbqQRb/xfBb1Z7o8Jai2Jho=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MRcSEMCuH4LKfa5bXWVijgKu2pKiP8qJvOz9lODGW2ALjQnkFewPdzPuAawlVJfC1 SBVWoAk0ilqhRGGez9RuH39rLsOvHSuc3pOmlxyiONTEZTGFsGriQnkxeULLc5mUMQ IK6LFFnFIu1Ob2PPloCWVJ2AUYfFKreftDdm54/8= Date: Thu, 25 Apr 2024 13:54:39 -0700 From: Andrew Morton To: Matthew Wilcox Cc: Peter Xu , linux-mm@kvack.org, Alex Williamson Subject: Re: [PATCH 1/5] mm: Free non-hugetlb large folios in a batch Message-Id: <20240425135439.bff9700db6533dfd19f043c7@linux-foundation.org> In-Reply-To: References: <20240405153228.2563754-1-willy@infradead.org> <20240405153228.2563754-2-willy@infradead.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DCCE5C0022 X-Stat-Signature: j7ii93rkjaoqpzy79ip89aeqhxbcu5gn X-HE-Tag: 1714078484-658880 X-HE-Meta: U2FsdGVkX18bj7m9fn/IEwe5iZ6UpQ1qsEiPN4Lc+FMVKu3GMyRGpe5gPSoc07L5lXdApakVyfa5exqxO81TLgdSBOvwAHR60jSWh2iKVRXdktYkAXs9UL2LsiKLrkJHWCIJlcBIgD7iBw1xxLVi/a11p9Zvkb3CNaNq8CYEANuUUO/HBNkkL+22zOkO8ITWokbWKhbjQ9fVhxutCp+rbT60IGrGA2o10MQ/awQhOpV3bxtiej9frGnqhihXnmG3D9q2byrhxBsApOXhVNcHf93ISnx9DYgaUIaMiO8i8uqQLz2Q4a1rHNpboZKCOWPZzUIL8GutyrXYtmpmRB4gEJkVk3vhFe6t+okeClSHf9qnAtsNWz1s2mXdNqkoV5XSTuOHAZkpd4kwn1SolRTgxpvmt90PX0q9TAKJ6l+UWZCJyCHia5JcF9n9GWkicwY77nA5PUBhnEvx0x+6U0sYtytxgz5zVePHwHm5inBeII5HU8rbEdEFYjXEXT3rq0kBePd2dBB5aWn5OeeTOODP0kQo2YHIqrWptynVSDHokzRG6ld6/fT/YHvfBNoHh0ClBPqMOgnQ/Mmw0I2jUXKC27h6OmaTbBTcpdeiUtGvupEkcw3qYuVZDS+CMulpgbLRKAVw0lIiJ0do1NIBO1ucjEdxCUhAHDlhJfWCSkMIxDYA1kuTQ/FhKK/9rDMhf9kj0eUJ+/WI3tmwyCHXT9K7xkAPXHHj2nXVqxpMWjphX+Ux6Qo69HDVa2ESeemxbfXs05ZaihlYl0mRxafDxt5H9y7T6KEkM25hEJoWSZ2n3I2pdLXfZGitaBncV/2c8Jx3wl4qrs9+ye5nIgpTyJqsi+uV/hG55tGOA4ye34BtRbB6LiJ5UCSqvHtzp6nO65tIz2hcWUzi0q8hFMWoZWY11aNdThuuVNKn+Orhtu33fqQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 25 Apr 2024 04:39:14 +0100 Matthew Wilcox wrote: > Andrew, if you do do that, please also edit out the last couple of > sentences from the commit message: > > free_unref_folios() can now handle non-hugetlb large folios, so keep > normal large folios in the batch. hugetlb folios still need to be handled > - specially. I believe that folios freed using put_pages_list() cannot be > - accounted to a memcg (or the small folios would trip the "page still > - charged to cgroup" warning), but put an assertion in to check that. > + specially. Done, thanks.