From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32E82C4345F for ; Thu, 25 Apr 2024 01:59:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56A996B0087; Wed, 24 Apr 2024 21:59:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51AED6B0089; Wed, 24 Apr 2024 21:59:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BB146B008C; Wed, 24 Apr 2024 21:59:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1F23D6B0087 for ; Wed, 24 Apr 2024 21:59:06 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8FCDC140356 for ; Thu, 25 Apr 2024 01:59:05 +0000 (UTC) X-FDA: 82046396250.13.E38E379 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf29.hostedemail.com (Postfix) with ESMTP id B3FCF120003 for ; Thu, 25 Apr 2024 01:59:03 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jYqRfudF; spf=pass (imf29.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714010343; a=rsa-sha256; cv=none; b=BP2G70GbK2Y7MM+TlrXL2PajcXSRL32qyx1aNTauZlbGvizAOnjDGr7bpGp90af1UopnGP O7xZ/qnR6CidrYqWeHcc6wzORCZjfM20KKNKSELO/1yvM8IT7HsFl1bUc5dCiWVrD8siS2 GRovptUtMUltXb68wfLJnEk+w024MJw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jYqRfudF; spf=pass (imf29.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714010343; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S4qlJ+DG6HoUrdCik4e+F/ZipKmWdndDCcmvcXd31J0=; b=CL2q2xIwCH0k57odNR7s4IgbKPi5czMSQT8kUvpVE8MCn25n8/VE079AdheqheSy9joEZC YpNL6YCsJNUARGRu7MwA6p0qCFth3zh63FMNR8WNrRmhPFJaD4CL5QrUxTn7gUWWUHEEmJ ZcRUuyksrj8HwShSiLvY+4bPtoaRiyU= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6ed2dc03df6so496954b3a.1 for ; Wed, 24 Apr 2024 18:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1714010342; x=1714615142; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=S4qlJ+DG6HoUrdCik4e+F/ZipKmWdndDCcmvcXd31J0=; b=jYqRfudF//LJmlV8Ixmfq7ky15Smc2IXXwF0HJ45jwVj5CHlIR1i1BJo82rd8XSasm ID7ReGdHVNyE834tWnJ70Tve3MVIvhLF2dh5CZTo424yxnVumZ3VYuKDZYRzkOe7kLoB 4jEjf/yiSIfSrMvcSjx0zjx+9w5EwhjIg+VB8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714010342; x=1714615142; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S4qlJ+DG6HoUrdCik4e+F/ZipKmWdndDCcmvcXd31J0=; b=rbm9t6AIFXXKzeveBp8fC4uIDG2NLUYmhmluz55GQm0JG1ZioS316rkeuM5ZT7LHIY df7l+L3R1bmiyoIjhM8z0yC4pceKCNoOAiR+qKwOqDfq3GaVt27d2m9UrMkhnPVwTyZL CD32tzDUaMgc3PyCEy/Y+XZmwygkepuKndjLVtaZ3PCanhOy6tnLLRra+w9N4fRAMFgu 01w5dqEay5iUsZF8ET1Ri+YR++AZ1J6tr+sMs99MYjspYbkcOgbZW7SXZo2vOS9urLK4 QOeVg4ARYTFxspylZYuANqMgycehdhKEs8a0fNsXv0ZrTvpL4eKAshXGQefZenAUWqUf 8u8w== X-Forwarded-Encrypted: i=1; AJvYcCUmR64wUQbut4cGPLZUmvfFxmOttOAPwfDhdjuqBMRqzJo0KLlvUi6B2vRyqejxof2IvZ07D3hxdcCr8H4Ob3mpjEo= X-Gm-Message-State: AOJu0Yw1h1IPv7QvRkWuPLNu5g+hOJD8QSBSW1btjaYel/Opk+Ptz2Vb cWKGhT2e+g+T4DgXnwNUrnaRYNgO0V8HpiebxTH/7fEq5o40xE8U/fWuKzo4nA== X-Google-Smtp-Source: AGHT+IGkZjJaqzTqorNSptD8PIXi42TzKHmNUDMaE6PSSACIxE9KOptwbHMYiF+aQeY3zIEfo+43Lg== X-Received: by 2002:a05:6a00:3ccb:b0:6ed:de30:9e43 with SMTP id ln11-20020a056a003ccb00b006edde309e43mr7198156pfb.32.1714010342547; Wed, 24 Apr 2024 18:59:02 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id v28-20020a63481c000000b005f7536fbebfsm11567520pga.11.2024.04.24.18.59.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 18:59:01 -0700 (PDT) Date: Wed, 24 Apr 2024 18:59:01 -0700 From: Kees Cook To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v6 00/37] Memory allocation profiling Message-ID: <202404241852.DC4067B7@keescook> References: <20240321163705.3067592-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240321163705.3067592-1-surenb@google.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B3FCF120003 X-Stat-Signature: ezdrunotw9rmcrraert8p1178j84c5b9 X-Rspam-User: X-HE-Tag: 1714010343-536608 X-HE-Meta: U2FsdGVkX18HVkfAeJJTr0719odnXhcoDedcqwlQty/Uqivh/80mRj81e9UvdS3f9U4YeFR7C2NyDYEJW55Ml1fYL2SQtYZQ0AjTj14MbNSMNzyQn+ol/RUIwoeOI+d4mcm+Wx8YNjUgOnfV5ThzxveMwm9Dw88opBN0MxhWrSFVvYslG7r7fC7nxFruC13cg9jXI8sQCm75wj/8yDrZLPHDippe5rissN8y9Owe/GP3whK8X3gaUaWE/cDfeAbPniXylDA31PADxAtQ/VXj47hVT0sGRBBGNLvTQwrA9q9HKZhLo2fFpaROUlkGUMWbrbfFWSi8h19Up9NxDUFCs47P415RqZjIbnNcxtg0eQnTam3gvfFXk3fosgwtXBegh50fSugEb6mNTxToTYSxuZfY7DCsez2vUwE+dK2DdkqTA5/GW0pK8QD3E+WDppiDrOhEg8u2Bj6j5MLpxfnDCMWqFE0P6l1Cvf5RIDZ7ZIVsLrUZLqsVsE4mFjlNistnXA7rOMqDggYT52uADuLZn8VOxkmgp2ba6phMH+4kaolcaDCI3h77A2OsXwuyu7kScUaCfHgNaeUWIaoFwqbS/lunEC3J5ocdd6lrKAGrexX2DOTQiuMizSfBpW2653GLhbdKQJAXwR6nkJJ7FW/kKXoO6Y6fYIfomCusVKOuz64ncqzj5Hn6W9eih+CJJPUVUEEtA8POUI4C2TNp5zObaeD/WVWSGnMsYseYbo8h+lV5Oo0Ap2120Fe8EMX+L6qd53zxPnQxqmaWMeLt3BMWjzsqJ9lQN6xzSvbbTqxOrKD2ehYYZf4Nplpder2t22ykr7y90q8hyDn8o3dFkJmssutTiNblvJ+w63zlpXhcz3yGHDxblrlarmEccETOZwYk28mJHD/KzcXFZvlBY6JMnZdPhcS3vbRcUOGC9t1OKvuw9rm3zb5CW4F+LV9lcua50A9CQrMKqO10FXNQHMu mVcDfFor RN+DNYHqFMrgh0VZNfQqnv0huaVsN06omKoeDW8inxv+2WuauzU1aWft9G3rcCR4j9UyjILSCYdTSIAojPtlkP5NpL1APHl8+jLuy8o16FHrYIF/VarJ9FPaYkVp/gw544ZzHTNfW+U0o04WyIDY9otVXKJUhoBjs03gmiEX+RkNJM4O7PpPwqwF1cIcTP3Tn6wTNfABzVll+eR5+yKHwPrTfw1GLZ5iaaYqBkfr+42+lHGZq271/KDzI1QpWgxlG5DYrwYepx+WhxtUs7KjZizWrrAYGLEtpUadksbr+EkwSESAakpDzRYu9hjU3WE8Ql+qyz2cWFMWpKDA1Ol2nhEOo0IJhe8WvkLsHB5eiaWxXzW/RBlGeh5An4qJAXTDQSYnfhSey65bzzZETr1REVJl816CIDjs6JOzm/C5PO1KLoP0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 09:36:22AM -0700, Suren Baghdasaryan wrote: > Low overhead [1] per-callsite memory allocation profiling. Not just for > debug kernels, overhead low enough to be deployed in production. Okay, I think I'm holding it wrong. With next-20240424 if I set: CONFIG_CODE_TAGGING=y CONFIG_MEM_ALLOC_PROFILING=y CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT=y My test system totally freaks out: ... SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=4, Nodes=1 Oops: general protection fault, probably for non-canonical address 0xc388d881e4808550: 0000 [#1] PREEMPT SMP NOPTI CPU: 0 PID: 0 Comm: swapper Not tainted 6.9.0-rc5-next-20240424 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 RIP: 0010:__kmalloc_node_noprof+0xcd/0x560 Which is: __kmalloc_node_noprof+0xcd/0x560: __slab_alloc_node at mm/slub.c:3780 (discriminator 2) (inlined by) slab_alloc_node at mm/slub.c:3982 (discriminator 2) (inlined by) __do_kmalloc_node at mm/slub.c:4114 (discriminator 2) (inlined by) __kmalloc_node_noprof at mm/slub.c:4122 (discriminator 2) Which is: tid = READ_ONCE(c->tid); I haven't gotten any further than that; I'm EOD. Anyone seen anything like this with this series? -Kees -- Kees Cook