From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 792AFC4345F for ; Wed, 24 Apr 2024 21:20:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CBD86B0101; Wed, 24 Apr 2024 17:20:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07C7C6B0104; Wed, 24 Apr 2024 17:20:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EACB16B0105; Wed, 24 Apr 2024 17:20:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CC2EB6B0101 for ; Wed, 24 Apr 2024 17:20:18 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6C1EB410B2 for ; Wed, 24 Apr 2024 21:20:18 +0000 (UTC) X-FDA: 82045693716.11.2C08BCC Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 3E25540009 for ; Wed, 24 Apr 2024 21:20:15 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=M8WWLQWq; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713993616; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g5rokViQMI9btBvu2Lf/EwlosFOZS6MHZutrZA7aAhk=; b=nTKTqGxFYK2dMwfQi8GgYazsS4guMsdLR6ZbGMIBi9lUN7YBwCzh8LqbRBL7HydkXCjPwM /BGOFtAYYZYqgcxsbfxAZUxVKLDVpmgfmp0NW75vBS9p84CEZbALLAHqdAXn3rkqiGObB4 ocMQt1UpWI0bSWwmJYlU+3EfKgywC7E= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=M8WWLQWq; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713993616; a=rsa-sha256; cv=none; b=NURzJ5xcXzUUAHKR5dLRkHey5oCdDpjmBUvvmEV1W157Sh85JXACsZeI0H+Qbdw1Wl5the 71X/p63tQxueDSeKRyUTDvoa7YJIFCVKK/OsieEFAVZHVmflhHri8RhUHsOf4gd3OX+SCS H3GhN+sbrHGoZjbUGW5o/yR1JAobqgU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B3057CE1862; Wed, 24 Apr 2024 21:20:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9D60C113CD; Wed, 24 Apr 2024 21:20:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1713993610; bh=GrjNEdck+k+VpT+CPfrPUvz7/fnE4GeQWJaxKgyyI7Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M8WWLQWqXAGC5AJWDe0qHoNDaRU9IdxcFIfG2aL6YAUWd30ejte+TtJWWSE88qtJ3 AFiACzTGRSUgx/NraUv6oh9V7pvfQnkLZksYEP/Y4xPD3mi56ORmSnVPxS37oPBa6p WrcBJ6ufW+tUtZEDuL3sEjWZCPe0zEYeByuKo56s= Date: Wed, 24 Apr 2024 14:20:09 -0700 From: Andrew Morton To: Lance Yang Cc: Matthew Wilcox , maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] mm/vmscan: avoid split PMD-mapped THP during shrink_folio_list() Message-Id: <20240424142009.149eb988cca33822ce0fd0f1@linux-foundation.org> In-Reply-To: References: <20240422055213.60231-1-ioworker0@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 3E25540009 X-Stat-Signature: habuwbt8b5sw8xpyh4bkc5ia9kuub1oo X-HE-Tag: 1713993615-301912 X-HE-Meta: U2FsdGVkX18yTsVnwDPE7aM6Fdc4AcCLotiAqX6IWs3nBjSVbnuRtFneMHlwaEOAnCTSNHKt8JzwTgB6JiHWosrNpjbJiBfspQi3rxluOiJHw9UuCWOKUhmIhoJXs+nYAaxKVIYI2dGNTWiWTGhyU332N3QO+fXknGSAbKp3me/7inV6MjpEuxcHghdbN8MHMEvGyepaOB5Ety/RsF28chYQSs4U0CjOTNzI2iahEq2o/rPm6saXr+XxE4Kcnk4KKzLr5wZ/q3TI+b8vLGUL440mZGXVrCmbRhQKu+MiRU6gV5H0qhGEugCLUBfC24pFjxX2eAyrJOHNLJdxE/xGbw12dgnN+7v5UU+k0asn1K+kaihyckoKsd2VNhJw/JCuHCixBBnBjr5HktESYA521mIFmVLfMz33UhwyUIt4q5kHWLfrnrWGnIEPaRYCV3u7VeklEvdQ+0LLoEB6vHL2CRP7ltK6FfUBLRs4eZNqwXrndlDdYt2by0iHhM3KvkmjN5sDdxfiYeEZcwTm8Zq/C7k8RbdQOpeGI771ZHA3u6CPpsmeXd6J58AuAEWX6HVBK77lkTBIrJU3rDRSpzSKcoINVc92P9rZ73TCRt4UEl2eKsnMB7JIRVEkTvefdj1MHO3HWmjVahOpxYO6I6UYrOCaT5jeWi/OMJxJIPNw32jT8y3HtcE8aqQJJPw23zem1wPRLAXQzLFTqV/AGFiRgZ3h5vGtECcSNYg4qrWCNY8yY4nylEcujDHRpX1x5HWSIFI4NZySWIYjRRFxIvmlxmlijBIQbJYU0Jo68xbKJgjcD7qZMIIBUvjGTH1WMRbYWbr3aavONST3mSJTQpCKV9JXFnyUoYPJdAcV8Fjy0+pRL0AuMG9/Fv5yoFcBkKtGdc+54xHhcZD4aVEZxU3IVifOzsXIuQ9lwf3NRIoDg1Hr2/9WydwsMY1dZyeX2lEN8YB64z2SUND2xpiJfaI gxB+Jw3/ WTp/VySgKVcw6f4KPy6mzrpkdRMdXHoPMwVOfVVCr+/XwImwieJAleFElzQGnuZWxy+vCa2kKwgH/MVyLQO+5g/Kc9/Hp/XcLfU7rNlLkIDY0rx871rnQqevhEIneFNFlqDb1AKFpgrFf5hqHB0kJ/eYuUDlgVtEbnTRXGtfJN8xat3Pl13qOXT90mIFy8zxrcQMahlzB+ovd4k64Br2cxAvdqbWtyerfw5REZfs+zuqRzQ42bcJf1Y1OXLE/9HJrGMBewQ5Fmy4VhxceazGH6o1TN0lSOYFouNiOgSTYo1wofHF0yMeAdWuIX/GTJTUHHREdWDfJt7OMXPHeh1Up3X/UmgZL/lHChmJw0HqNygy8nzdT/dbgoKV7EalVHWm3U1Rm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 24 Apr 2024 23:46:59 +0800 Lance Yang wrote: > On Wed, Apr 24, 2024 at 12:15 PM Matthew Wilcox wrote: > > > > On Mon, Apr 22, 2024 at 01:52:13PM +0800, Lance Yang wrote: > > > When the user no longer requires the pages, they would use > > > madvise(MADV_FREE) to mark the pages as lazy free. IMO, they would not > > > typically rewrite to the given range. > > > > > > At present, PMD-mapped THPs that are marked as lazyfree during > > > shrink_folio_list() are unconditionally split, which may be unnecessary. > > > If the THP is clean, its PMD is also clean, and there are no unexpected > > "If the THP is clean, its PMD is also clean" can be confusing - sorry. It should > be modified to "If the THP and its PMD are both marked as clean". I made that changelog edit.