From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1703EC4345F for ; Wed, 24 Apr 2024 14:04:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A823C8D000F; Wed, 24 Apr 2024 10:04:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0B556B02A2; Wed, 24 Apr 2024 10:04:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8854D8D000F; Wed, 24 Apr 2024 10:04:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6A4026B02A1 for ; Wed, 24 Apr 2024 10:04:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 05F94161099 for ; Wed, 24 Apr 2024 14:04:34 +0000 (UTC) X-FDA: 82044595668.19.1BC1D79 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf30.hostedemail.com (Postfix) with ESMTP id 542F08002A for ; Wed, 24 Apr 2024 14:04:32 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bj3j7hdS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of hyunminlr@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=hyunminlr@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713967472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CrYFa9qXee7zKnn9ysFlYGgCVscVXbAgHziDV4ylokw=; b=2F6ldP9brB7ZwWNEgYfnXaP+BbvFVl7FqYoGQQYha3WCdJtF6CJRz19nnDOiTTDS4qK5Mg fBmQzqfw8zO4n8gcoJb9iluNIeJqreQlNpX2qMrZHvzUOuGN68tN+Uwa+DLQBeMWi98a+0 wBDA6+NEMSmJFgljS4mpGFWGPM02mmI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bj3j7hdS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of hyunminlr@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=hyunminlr@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713967472; a=rsa-sha256; cv=none; b=jO+czdRoqMb/MVZYplgSkHsKN0NVwdiDygxv+jSoF8Fd+A5mLZXpzswZXPae3KCCQa9vae skWojfpn/tYROWo/mxnclQABfX7cpCnUtf/TcTMt2NX1tiGBMEvYIXXnXGqcYB57LVlSaN jcVlUsXL2IeaBs5C7CHZ6Wc5ObE19cU= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1e86d56b3bcso47314515ad.1 for ; Wed, 24 Apr 2024 07:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713967471; x=1714572271; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CrYFa9qXee7zKnn9ysFlYGgCVscVXbAgHziDV4ylokw=; b=bj3j7hdSQn/Sussl1zWSzx4ahX/Hg5A4hQgrfKEuc6+Ffj7ftllAX/rJw5QMDEZCT5 K8I0Hq9Z/M9Q7Z9DqXYdhIhBp0Xy5Edy+FlJ2/HYZV8521uATwZnmhB/sSrbquEZASrO nne4fxoNCHwb8fdtsusYHD7GbisPJoocW7lpW+P1SKOOU90XVho/MGHxXVM95UHXX47H GP+seVGNMX7lKZFrz4MgMxJisipyKqsz69UbJRF0YcJcZulhazapBbs8XSMbVIW+zLK5 R/16QeUrZhDAZYmL4C5bUANhfLvILmg+28Lu3OTGBXt6k1aMzEDco8QG71L71r8Ybu+F ahrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713967471; x=1714572271; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CrYFa9qXee7zKnn9ysFlYGgCVscVXbAgHziDV4ylokw=; b=tS1VoNV6fkTTOkIKxkLbrUoWN4AKykQAFBJ/PEVw5/Lm9rRa1vU6q6dU/O2UJXeAMM Cb6IyL+ZT7AWGQ03Wsi8tOpNrFnklTxYREmkhD5kYMCCxdCv7mB/KW6+Ed2M5W9UqL/X /JRpFMzcGcG+7HptBOO94s26JYlMJRe/iyrrowTgnkevV+GzJV/uigdIwMaHHxw1ga3Y VjYgD997noaIiGSq0hdFfzANd0rOKzffOqYfiOvMz0i8pkTZ/v/fafqvsd7/MvaZtvpH BdSwXnR1Zt0R72L+nPa0e3VYCWQ22a8UwP73TYHmtY4vZrEGWHUtxL2zWwfQYfIz4TpH xKyQ== X-Gm-Message-State: AOJu0YxNMz+ENinQA0I9WfRgvOioNMUvcqGFA298om4xT/ln41BwVmdw Ogj6Pg9h4hqjSx1iPkBmBfNdW4Vo8tKdVXLcfNoWGYJJccANGeCudnbwnUxzQ6k= X-Google-Smtp-Source: AGHT+IF5FFfSojC+SOMXTBnD21ujT28MqqMJ3AeYL7Fv3C30Yoq4iJ6ZmoTOMi8btYYaZRhm0a81rQ== X-Received: by 2002:a17:902:a50e:b0:1e6:116b:b0d3 with SMTP id s14-20020a170902a50e00b001e6116bb0d3mr2305567plq.28.1713967470574; Wed, 24 Apr 2024 07:04:30 -0700 (PDT) Received: from MinsLaptop.localdomain ([125.177.3.166]) by smtp.gmail.com with ESMTPSA id u9-20020a170902bf4900b001e26b7ac950sm11891042pls.272.2024.04.24.07.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 07:04:30 -0700 (PDT) From: Hyunmin Lee To: linux-mm@kvack.org Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jeungwoo Yoo , Sangyun Kim , Gwan-gyeong Mun Subject: [PATCH v3 1/2] mm/slub: create kmalloc 96 and 192 caches regardless cache size order Date: Wed, 24 Apr 2024 23:04:21 +0900 Message-Id: <20240424140422.12780-2-hyunminlr@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240424140422.12780-1-hyunminlr@gmail.com> References: <20240424140422.12780-1-hyunminlr@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 542F08002A X-Stat-Signature: kt549iagrsis3upfneswhih1w85croo9 X-HE-Tag: 1713967472-933548 X-HE-Meta: U2FsdGVkX18968YEV+Myx1fIuLOGx+zmwJ3D167HQQyeV8wwGz2x6vpBTkI/U89jnJawRPdZEmfWPNI8LdEj/ZWOEtV1GLjQgMBN5mEaq+wqrVA2DJ/wLqIpfTZ/ACWwAeE/p5xn1rf2HazuPx5B8YcunQuWPfCb7Gq72BjzzpaKzl4EltJaTPSkMgs7UFulbHKyDKAOJp/951qr2JQxow+FR3+xkE3G57nah2rTQscRuDu7VmFGgcDiNuqF8vZ6QWkCR8EEq750a02G5H05fr0A0nsEwOnUbFVk5vXQb9FoySyQmW19BiDF6HrZeDiki0IeEtWscDrJ7uVik7OmG1ZdTgWMJc6cJeuPjOxAGBjtVvuWMbWm8PG33HhHs2/lkts/Im+D1sZ0JpLZQqKyQ3vdmSB0muML5ROtrpVEjgPqYYqhOCu4N2fXiQMMIlUCrb22QL/boY+59S0jByEJDy3TaRomQocbb4s/vkW4DhVnb9WnEExrzIdadFMS9P9gPEsA0klrjw7maZY9dbZqftFomvSLvfrK9H/662p78P4idZwavt+nku0OQoVuXOSUoskw3Y4MoJgTAd6weKWsDiDpPcyK4il6Nn+NJnBALBWzfApsTNpuuL7+SfvN960nQTxXOY+FLoUMRVhMlmrXhnMAEs5JgVjbJ6eROvt7hNMVIyVnugjlLXyZyteTBrwaVOHi/hFN7w8a8mrhwF5M2biYfEOsDDuPN9SPBZBfYPxadUv0rRAfnHcSVkUWoZNjKaAQ7HkwbzmxEfzaR5uRdoDRUfU9NR4GY2KuwzCrAsSBxw05oJqowv/rHFFi+nTT+N/NHo/zIRviyPUiyPeNWwQ3DY4DUeCUTp+X4JwWyuzpQcm4Nb1XCmLSGBeyS3zvyYc7BoWGwGJIjfpXAgGFezMoL4P5xc7lHInoetjqWneB/nJd7fs/w5Xbz3L524x4wHZ7yGb42N7GvVmymBt t46SmjEB jAwQAIxvScvdbe7ALwOJigPcGHKmxua6YolF+7txvCNZGLEatrEwSMjoYS54LusFkuBFsS/oT/eEjJebfgpW+nx+ImsFvw1uLadwzupLW1vAr5APZy82hLM9kzT5R+J2o7Zhwhs2FeqL/8TyEeXUZcAu//gAwTmf81iX5XpTCVOMYHvEk3py+IM3lIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: For SLAB the kmalloc caches needed to be created in ascending sizes in order. However, the constraint is not necessary anymore because SLAB has been removed and SLUB doesn't need to comply with the constraint. Thus, kmalloc 96 and 192 caches can be created after the other size kmalloc caches are created instead of checking every time to find their order to be created. Also, this change could prevent engineers from being confused by the removed constraint. Signed-off-by: Hyunmin Lee Co-developed-by: Jeungwoo Yoo Signed-off-by: Jeungwoo Yoo Co-developed-by: Sangyun Kim Signed-off-by: Sangyun Kim Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Gwan-gyeong Mun --- mm/slab_common.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/mm/slab_common.c b/mm/slab_common.c index 3179a6aeffc5..ed7b8592b62c 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -916,21 +916,16 @@ void __init create_kmalloc_caches(void) * Including KMALLOC_CGROUP if CONFIG_MEMCG_KMEM defined */ for (type = KMALLOC_NORMAL; type < NR_KMALLOC_TYPES; type++) { + /* Caches that are NOT of the two-to-the-power-of size. */ + if (KMALLOC_MIN_SIZE <= 32 && !kmalloc_caches[type][1]) + new_kmalloc_cache(1, type); + if (KMALLOC_MIN_SIZE <= 64 && !kmalloc_caches[type][2]) + new_kmalloc_cache(2, type); + + /* Caches that are of the two-to-the-power-of size. */ for (i = KMALLOC_SHIFT_LOW; i <= KMALLOC_SHIFT_HIGH; i++) { if (!kmalloc_caches[type][i]) new_kmalloc_cache(i, type); - - /* - * Caches that are not of the two-to-the-power-of size. - * These have to be created immediately after the - * earlier power of two caches - */ - if (KMALLOC_MIN_SIZE <= 32 && i == 6 && - !kmalloc_caches[type][1]) - new_kmalloc_cache(1, type); - if (KMALLOC_MIN_SIZE <= 64 && i == 7 && - !kmalloc_caches[type][2]) - new_kmalloc_cache(2, type); } } #ifdef CONFIG_RANDOM_KMALLOC_CACHES -- 2.34.1