From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB30BC4345F for ; Wed, 24 Apr 2024 13:27:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 333196B028A; Wed, 24 Apr 2024 09:27:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E3436B028B; Wed, 24 Apr 2024 09:27:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AC266B028C; Wed, 24 Apr 2024 09:27:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EA3976B028A for ; Wed, 24 Apr 2024 09:27:44 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 70C3DA1D7D for ; Wed, 24 Apr 2024 13:27:44 +0000 (UTC) X-FDA: 82044502848.11.C259EB6 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf23.hostedemail.com (Postfix) with ESMTP id 52C92140016 for ; Wed, 24 Apr 2024 13:27:42 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=h1zi04HC; spf=pass (imf23.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713965262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bmaQzf01ImU89PHQrVzq0PujKy/T2pnrZwcrGlSMcAM=; b=8mOQiZJwjlkqHVN3V6nJuzCEcXJs01ZBiiAYFZLbiIgq/OwlXO+MaXzxZJJd+9IFTScba0 dlGhsUPCu2v/popU4ZTmTwGVPhkkNpQQOzZeTUcK7AkAJEiqfvLwwRENIDuskNvsHJ+Li+ OfQTvs/bXyLXuZc7M8qsjFsM7wM5miU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713965262; a=rsa-sha256; cv=none; b=WcagCpJnReiiKRzFTLDAGvjndG0cvpgmtn528fC3A+NBffVjxnl/T6Gksxn3w2QI3sMIpr /Sgtvy6mvrMP6wTnvPxuJC/HwZ0IkSoVieDfHQ9NN7Lst3GIYAuTfqFZWN5AmYyPkNC8IS Y0WGVak+P2X/6BDxcPWaJKeKuAUD71k= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=h1zi04HC; spf=pass (imf23.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-78f05341128so444191585a.0 for ; Wed, 24 Apr 2024 06:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1713965261; x=1714570061; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bmaQzf01ImU89PHQrVzq0PujKy/T2pnrZwcrGlSMcAM=; b=h1zi04HCdh+9V+UuFGQ0qdzZWWzAF1AqjVzBsrTdTrmvxV6PscUQgKS1YonBDtbyP4 5TNX3fYbD+EYLvuo1DAmwGnaVLpiEZqHCT1t1Dy/H/fIfSAQ6zvN4eFpqtalWcuwQvxX sg9Leiow3xdhE8TnR5dxR5FdevtSIkRn9QMdcXv8w7gbK7h4v49Hx9ql/aorAgZ2QM8S +dEBIy6ENIrXrQZVAqsDMzWPvles8vg8gvqiTaoygpMiJuQOd4SSWiPCg6GxZbevXnTT Jlvw+cmhndCjtL54qq9aXIqUc/Z1cdTTLQnnw6HgsC0q7tbrjEvFcOagkwRLphl9MXZ9 9QbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713965261; x=1714570061; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bmaQzf01ImU89PHQrVzq0PujKy/T2pnrZwcrGlSMcAM=; b=nTzR7WafixuCcOb6xhBdMY4rHsks734zcbup/UqVVOFwwCxgX7SFLvwD4RJVLPHThc vsFKhCPs2qwhG3N+0+WFCxYp14aSFP43hrkJoynuPIMzHKt3a2X8PTknshDDNN05OZ4v NuCsU+g/HBVhUlrp+6d50RiMMLxjvEeIIu1BzLmdVyJ/vlR6HvTPtP81YHwjOLTLiK+6 GRlHXXyB4ieZn/O2Q28YVU8pvM6WyO5gE9yHY8n2NpAWksjcZ+ObSRwdF4I6NnFJdQv5 +BqgmcpRWbH3EJnG5Ud0s8zL/cTp7ca5W8PmrdIWDsaKgCyYET+way4nNaQCcLtwHNpd zFOQ== X-Forwarded-Encrypted: i=1; AJvYcCV7bDn5/WvYNcJhTrt+29/mqBRdXexwTLVgE4mrG2VbRaFMVlaA1Qr79zYxKf5qbPXBOU9OATfWMxHlhM9/eR8GEHA= X-Gm-Message-State: AOJu0YxlVCyNPccfr7Q3WLylgzpUAxsLtMY31xHp1aGZwKaFjxHbfgGo pjNVW52EorVPP1Cs4YHqQzM9SQDWGH7WU0lUgEM7zVC9HFrJoHCDzBACEvRIUihKukmWXVpXIFN 9 X-Google-Smtp-Source: AGHT+IG10JNnau66mb0W0bLsv7g+fqp1h/1IvnkN/qI5c9owHC6AC7QHVsin4Z6bVve3680gH3MsyA== X-Received: by 2002:a05:620a:40d5:b0:78e:db54:e5fe with SMTP id g21-20020a05620a40d500b0078edb54e5femr3078820qko.11.1713965261163; Wed, 24 Apr 2024 06:27:41 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:9cfb]) by smtp.gmail.com with ESMTPSA id h6-20020a05620a13e600b0078f044ff474sm6146095qkl.35.2024.04.24.06.27.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 06:27:40 -0700 (PDT) Date: Wed, 24 Apr 2024 09:27:39 -0400 From: Johannes Weiner To: Kemeng Shi Cc: akpm@linux-foundation.org, willy@infradead.org, jack@suse.cz, bfoster@redhat.com, tj@kernel.org, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v5 3/5] writeback: fix build problems of "writeback: support retrieving per group debug writeback stats of bdi" Message-ID: <20240424132739.GD318022@cmpxchg.org> References: <20240423034643.141219-1-shikemeng@huaweicloud.com> <20240423034643.141219-4-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240423034643.141219-4-shikemeng@huaweicloud.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 52C92140016 X-Stat-Signature: igfmbj4i1g8t1k66fhj9yx8dpba3pr4n X-Rspam-User: X-HE-Tag: 1713965262-274377 X-HE-Meta: U2FsdGVkX1/19zbg5dan3B4m43KXV5u9dQNmSYZHHKry03P5ap+OcTlfs5l30E9PiYN31p+XDonOi2MqOx0/ViMiQkZ7Nesc7KMBlpf3REhWSivByzm4GsiGMBF1+Muzob8S02jpN1bksoOG0elpiewcbh4Fh5Umg7hO8rjESTblwrhw9f+TF8Is3FTXq6/pWCpxxgNQHV5Ce39/4jd71t1StQJD6QjfAq/bSRkQYFYuDoSrbCb3KhnDZb+1yKLBOM2jkDT+wmceL4HAi44C43CQq3lHjqVd+gjnh71YL7GERcLxPZS30Xuugw48sFxFahD7r5fcvtyBwucle0bBME1H9FIzPqSbeYsdDb4WeV29YIpWTWOoE21oYyuBGIog4k9tsZTFkw12lZ0PvxBg8GNbCtTOpykKkkQur0EInSBMJCnK6llj0rbgeeIMA5QMBGXf21xD/C1kF3708okSSwYvglRSpLfQyJj280WWPl52dkkRSc3dissjTvf5W/LgZRkVD0/n2OEA7QKYgbVH0uphMr8KVqsn/Jx8YJ0SlC5heaBFiUDFCCiSWIJhdQFaJ4WKebZpGvE0xBrPC2rVv/ZCKskVLQLBGvFs7WbCkUHOPCiABSFtzuo34mkw2uMBVAFcC7sK9kL1mV/DFHuzwj/vhynWlj4xuMzsNeZwkkifrPnEBT4N6sNtXkz0lt+58WF6hUlWGN6CZr62fTjww9MXplzZPveVReIZs5m1AKW+f/I7ZSmiKLlPp15RmTtqFjGbj0iDKNn1LQI9Mw3aN0VvSsqasZOJvzp61A0bCFQYyjEsliDhIjeEY5jeITmeKBqx7QcrtC1tPGu24QXe50vOVF17+mSDVNtbzJ8y2LIaox2zcD3XGVnbxAt5XpvgSf6c2WFhlszPafnV3SrvZS+jEItZqlKy54Rt8ARNrPtJaHlnGuXrzv3jrvGoG7NreFHy5rwW1GVIsP4RTka VvbEzuRe rPzov8DM8dCnk0gv6R0kakScqmvV0OIeN+IIq8EaJhOiFNjKzjBuGb2YWi8DfjAKhRaqy6MytPu3OE9RPbSk4Ti6fmyEn4B1dCRk+6stjN9Ofs+hm72IYZBbF9FxwIeeVC7KJj4NJ1T3hRHU30gL8xRwkKkWxj0meiW472gJmhpxuJVoPONTZUNcXexl2CLGMMWojOKbiABT5dDzeVRS37OX0CFrulqMmSqIREgzubFTXFZPiBmk5vHjvI40phUZgcbcU2xR5/u8ahlYlyYdBji2Y30ao0GfprWLHsoTyHjdhSSZ9aXJIjSbK4ujETiHtzZHIS/YD5FM3FFcdOjS13AthwH21ElugBsbdgKykUkP8M9S3/bn6Yd3EvGaUSl0LSbsGBb2N15E9v9lHVabLSEOOO/j3vjdW6JTL9ZsJuAV8+AdHrwF2V0H3htW5j2zS5r3INK0PMY42FedbnOj1ayxE2Lsc0ixnozGFAaJE4WDtzburD6rgD+i6xQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kemeng, On Tue, Apr 23, 2024 at 11:46:41AM +0800, Kemeng Shi wrote: > Fix two build problems: > 1. implicit declaration of function 'cgroup_ino'. I just ran into this as well, with defconfig on mm-everything: /home/hannes/src/linux/linux/mm/backing-dev.c: In function 'wb_stats_show': /home/hannes/src/linux/linux/mm/backing-dev.c:175:33: error: 'struct bdi_writeback' has no member named 'memcg_css' 175 | cgroup_ino(wb->memcg_css->cgroup), | ^~ make[3]: *** [/home/hannes/src/linux/linux/scripts/Makefile.build:244: mm/backing-dev.o] Error 1 > --- > mm/backing-dev.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/backing-dev.c b/mm/backing-dev.c > index 6ecd11bdce6e..e61bbb1bd622 100644 > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -172,7 +172,11 @@ static void wb_stats_show(struct seq_file *m, struct bdi_writeback *wb, > "b_more_io: %10lu\n" > "b_dirty_time: %10lu\n" > "state: %10lx\n\n", > +#ifdef CONFIG_CGROUP_WRITEBACK > cgroup_ino(wb->memcg_css->cgroup), > +#else > + 1ul, > +#endif > K(stats->nr_writeback), > K(stats->nr_reclaimable), > K(stats->wb_thresh), > @@ -192,7 +196,6 @@ static int cgwb_debug_stats_show(struct seq_file *m, void *v) > unsigned long background_thresh; > unsigned long dirty_thresh; > struct bdi_writeback *wb; > - struct wb_stats stats; > > global_dirty_limits(&background_thresh, &dirty_thresh); The fix looks right to me, but it needs to be folded into the previous patch. No patch should knowingly introduce an issue that is fixed later on. This will break bisection.