From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA29C41513 for ; Wed, 24 Apr 2024 17:01:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 979CA6B02BE; Wed, 24 Apr 2024 13:01:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92A396B02C1; Wed, 24 Apr 2024 13:01:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C9ED6B02C3; Wed, 24 Apr 2024 13:01:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5EC4C6B02BE for ; Wed, 24 Apr 2024 13:01:25 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0C9B11A037F for ; Wed, 24 Apr 2024 17:01:25 +0000 (UTC) X-FDA: 82045041330.07.D3B09A7 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf08.hostedemail.com (Postfix) with ESMTP id ADC6816003C for ; Wed, 24 Apr 2024 17:01:21 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="ckB/6Efj"; spf=pass (imf08.hostedemail.com: domain of quic_eberman@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_eberman@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713978082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v9LyJsiCVlAgeeEWeNcgpjCdd+MkEQSXTQEg+z9k3H4=; b=T+wkX9fGYZQiQZDS22s4yY73eZsCSPZtqIXjNKRu9CggQjPxNyX9tKlaGNZ0ItVw7C3Oil UjqlpkGXgYyCTmgDEVIuztevOC6dpneNw59WhupZ2bXt80jHinpgWEgiUxBVtzqkaQF1Vo Iwe3mf8ic9DP0BDPeXLxUaLAdqVIpQc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713978082; a=rsa-sha256; cv=none; b=YoY7X5/foacaPU8/0gzlTHZJntb2YCG6a3lmoQusc3mHqvTkZThqAl4TeTctFePzdMMd9W 0A0F2cHUnGDTMVCmBhEqLJog67i7dLHoaqLy8Xo/QXwTF+fcP+1P1X1zcDNp2XIvXZoiOc 1gqju1fbxJ84Wm82IsL3zYxc+9l0ZJA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="ckB/6Efj"; spf=pass (imf08.hostedemail.com: domain of quic_eberman@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_eberman@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 43OGr3rP025446; Wed, 24 Apr 2024 17:01:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=qcppdkim1; bh=v9LyJsiCVlAgeeEWeNcgp jCdd+MkEQSXTQEg+z9k3H4=; b=ckB/6EfjQU7QYRxLN63Tx+JX+zZrhrWKcyemC +z0P8/A3nyWPcmnf2SPzCY82w2DROkvZXqlYwQK3lyIjMJgB8HDAICO1dFUuZpj3 6g0WdGHdEGoKH3N4AcDhntJs47rkIsdcO+Ofp1iMWA3YpqWxHwqHr/31RfonbR6h +Rh87jJR8i+8uaYKFcQcjoRhYwjG13czzU8mvVp8D7X+shaHC3P7qFb6yHGhIQqf sAoPi731+YmyHGcGGu7VsFEtfblpNfm6xAnXZ2NxMaSFJp9u5xAEu0D7Z+hipLxF hdxCVjlSlDgdzCWYc1BY0DbeJljbyL1LoxblhlKbJOfANHT9Q== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xpv9e1kxr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Apr 2024 17:01:11 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 43OH1BZa032159 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Apr 2024 17:01:11 GMT Received: from hu-eberman-lv.qualcomm.com (10.49.16.6) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 24 Apr 2024 10:01:10 -0700 Date: Wed, 24 Apr 2024 10:01:10 -0700 From: Elliot Berman To: Srivatsa Vaddagiri CC: Alex Elder , Srinivas Kandagatla , Murali Nalajal , Trilok Soni , Carl van Schaik , Philip Derrin , Prakruthi Deepak Heragu , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Konrad Dybcio , Bjorn Andersson , Dmitry Baryshkov , "Fuad Tabba" , Sean Christopherson , "Andrew Morton" , , , , , , Subject: Re: [PATCH v17 15/35] virt: gunyah: Add proxy-scheduled vCPUs Message-ID: <20240424095405136-0700.eberman@hu-eberman-lv.qualcomm.com> References: <20240222-gunyah-v17-0-1e9da6763d38@quicinc.com> <20240222-gunyah-v17-15-1e9da6763d38@quicinc.com> <20240424093957.GY440762@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240424093957.GY440762@quicinc.com> X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 89qGz_tE3OgnL4axkC5Pm979HLQTQNiv X-Proofpoint-ORIG-GUID: 89qGz_tE3OgnL4axkC5Pm979HLQTQNiv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-24_14,2024-04-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 impostorscore=0 phishscore=0 mlxscore=0 suspectscore=0 clxscore=1011 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404240073 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: ADC6816003C X-Stat-Signature: jnxrcd43u5kqc8s4zayse7ecyjbnug5d X-Rspam-User: X-HE-Tag: 1713978081-993465 X-HE-Meta: U2FsdGVkX1+tHBiXawN8bg8qkXzSMngrW0ytgKR9ZvM0T1NQfrumMGrYylZb+ouJCJv9aopT3mAph4cLuGTkfFe/YWD4w08PUiaHJdvInYAFJm0l1gIrDbFlWHj2utoY9mJsHiAf/SwU60b/fk3FnRrsp2/BdjHs8ptwBWRoByqI1TOkumioBKe6Lc5Cg8b8CHJjKcT03/wOtQnF/fa1dpKzPXlWwEW9PShfNLVYzTeliQXlsmcJ5ZxSserQPjgGrbaXqlutISIO+algc6Q8wJdUAIXC5rc7AclosiyHiiDL7hKePWscI1dq8DRfrSot2Nxb+Lm8wpmCFloyZrrSv6HqoOFBClX+szESe+p5iYBf2xhaEsb8ATOlAPJ9hhDoY2KBeoVd0+tJDQaHKJtdNL38nq2QLLv+AN18iKJS/WhxsCAwJjPS+fUZNFQFgASSeHDqIK8nnDH/l6jO2prWClv/XgHpqsHMbWBW2dRk5vCLFKpTUyvcbzRq200+FwhzqGK+mWQyUJVcKZsvkl77SG4XHaF35xM2hOcDGwGDn2413WIXkkS2+S8aqMhv5FkyPa7qiduZgTJ0VDwqW80Z7A0B7Ff46x7wech3j/ZG5q3cgry4w4aBy78ZaFupN/hol0WmAi0eN338WNvUpo0YkawUoPak3eA2I/CdiVXDQzxdSnyO2EEFgb/X5tgT6sd3G1s+YlQT4xqEdSGaroaPfTKCaaCI4H/Z9J2HxangJxb1KO62dgyUXm9nHBaQDHIc7YpEVupvQOpcprYRFoBqX2ybpKD4Ri9j8/k67xz530BumDXfnXiDgg3IoOdfbr5KzQpFRw2MF/xiKVU4bFYotBxoSe1mqaiIeqe28Wks6wfZP5wK+ZBCFk0cCphqsbeFETAomVtUXxbZdwFqAokyTdDNxpgfrJZWTlB0EqdC3OWQVHIAw4/6Ekzl5n0tuToEpqSFMjcIXT/YWjV8D97 SvAY4cfX 7O+aa7/ZRzsoD0W95Fkzsju6eorxFOX6SmtmAkddeLlbL95Jj2xjyXOLMr8Iwjsyyx1w+gcf9LWzgbhEAjMocljrJ/scOgZRwG3gRHMzvgQ0yOmvYfmKT/avNZyHOComZov1AbMFXGDNJCi5oykaOhj35XK+/i+qRJp9UWpiRuTGRhNUoEQ+LQXUPtEYMKV5SxCYseip+qOxkGxvp6t9o5axPoeWv4lbdxIhbO3A6mKMm2eBDO7qzH0IavB3XHfRVrn3i0sxI86AhTc1amhnSZko6KU3s/TcRrAg69Qg7CqgsLa64F7J3CuayrwY/AG57/jUummwBPK2yNUrgKj5eV4RBRQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 24, 2024 at 03:09:57PM +0530, Srivatsa Vaddagiri wrote: > * Elliot Berman [2024-02-22 15:16:38]: > > > +/** > > + * struct gunyah_vm_exit_info - Reason for VM exit as reported by Gunyah > > + * See Gunyah documentation for values. > > + * @type: Describes how VM exited > > + * @padding: padding bytes > > + * @reason_size: Number of bytes valid for `reason` > > + * @reason: See Gunyah documentation for interpretation. Note: these values are > > + * not interpreted by Linux and need to be converted from little-endian > > + * as applicable. > > + */ > > +struct gunyah_vm_exit_info { > > + __u16 type; > > Pls add an enum to describe the various exit types. > When I was first added the exit_info, I thought a bunch on whether to add the enum. I was thinking that if we add it to the UAPI, kernel need to parse and validate the values from RM. In the current scheme, I can leave it to userspace to interpret the value from RM. I could be convinced to go the other way though. Currently this is less code :) Let me know your thoughts! > > + __u16 padding; > > + __u32 reason_size; > > + __u8 reason[GUNYAH_VM_MAX_EXIT_REASON_SIZE]; If we start interpreting the @type, then maybe we should also start interpreting the @reason, and that will also add debt to the kernel driver. Thanks, Elliot