From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3011C4345F for ; Wed, 24 Apr 2024 01:18:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 152746B01A6; Tue, 23 Apr 2024 21:18:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 103626B01A7; Tue, 23 Apr 2024 21:18:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0C0F6B01A8; Tue, 23 Apr 2024 21:18:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D38356B01A6 for ; Tue, 23 Apr 2024 21:18:58 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 59D7C1A04B3 for ; Wed, 24 Apr 2024 01:18:58 +0000 (UTC) X-FDA: 82042666356.04.7F07065 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf05.hostedemail.com (Postfix) with ESMTP id EC143100007 for ; Wed, 24 Apr 2024 01:18:54 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lhmpshCq; spf=pass (imf05.hostedemail.com: domain of lkp@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713921535; a=rsa-sha256; cv=none; b=zcvPA/9B25VdJ4b0I5MvBPiw1ZHH38asB8Cnhjzwng3q42LGA2rg05FsXBk9iea+U1Y2f2 HzBl2hqmDvNwucIgPRBPGH0aFKLal2PguHleGWTq+hdZLW0cPwsk0/9T7ALhN+PNfR+5XD 69nDW9VVug/95ofI5B2mnyuYUT5jl2U= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lhmpshCq; spf=pass (imf05.hostedemail.com: domain of lkp@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713921535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=8oxFPP6C/o5LDSAwrlaH4HEUdIwNRVu0d7amu1oYPd0=; b=WsD1DZDC83ugrcX7ydq9kxLDMDWFXPUStcTDPImuKqihS/Asd3wUjJx3JhZumMw0FgIa5D 5Va+JpIkTtIJ1wFCXmHun6tRsGd4bCcNYA+t90/lpflFxPyF8GPxpYt04Juh/v5UrwFoA+ NXtWlc0J17xeczjpjxceeQM50IDXdHw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713921535; x=1745457535; h=date:from:to:cc:subject:message-id:mime-version; bh=IvTJ5D1BZfjebKKugZ2HhziZWE9LUQ1pbwpSJGmhLU8=; b=lhmpshCqNZKuqPwr2OPMQXV1u18Zlv5lpjomWFtWag+0UemQnrLTfF6q tu3yueqJtQFi1T36NFPMEz/Z2iiOOoYwJ8HbnKTH3nlB9m27xZhPm/JZk fS+sxmolhcXd05vJ+tDHy0WPk+jDAzzfU5Vurkvx7W8UqXn0fBGzeELDz yJynlxvwmHFNzeX4CdPK7BhxWSOOlXyrz9eSWD0Z/KEHaeqjy/gdypc4C ltuc3oCZi4bO0/8gsKsMZ8OCmZf5cijFRamBY6qmcaI8ryM45GJVuRgB1 Sr0hwHQNXzH7SFli6E3EESTXnTbkfOvo4KK2fuSLYQg2juURufh5kKaj+ g==; X-CSE-ConnectionGUID: 7rW9SWF/TSylNb9nAHqwZg== X-CSE-MsgGUID: 4sm6SbojTv2vvPnz4SUpZw== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="20228674" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="20228674" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 18:18:52 -0700 X-CSE-ConnectionGUID: sB/yoVO0R4+BN/wJLJF8Fw== X-CSE-MsgGUID: r6tW/cASStiQgZJoTQj5tg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="24548317" Received: from lkp-server01.sh.intel.com (HELO e434dd42e5a1) ([10.239.97.150]) by fmviesa009.fm.intel.com with ESMTP; 23 Apr 2024 18:18:50 -0700 Received: from kbuild by e434dd42e5a1 with local (Exim 4.96) (envelope-from ) id 1rzRHc-0000i9-0k; Wed, 24 Apr 2024 01:18:48 +0000 Date: Wed, 24 Apr 2024 09:17:59 +0800 From: kernel test robot To: Lukas Wunner Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Herbert Xu Subject: [linux-next:master 4693/7876] crypto/asymmetric_keys/x509_cert_parser.c:69:9-15: ERROR: allocation function on line 68 returns NULL not ERR_PTR on failure Message-ID: <202404240904.Qi3nM37B-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EC143100007 X-Stat-Signature: r3xmkf1tb3nr6d7d6t5ti48w4f9snmok X-Rspam-User: X-HE-Tag: 1713921534-657522 X-HE-Meta: U2FsdGVkX189hcjmo8kyML+MaGEeryqAKWESUVw1emu1PktYqwZoZf9RWNPJXWTtKW+L5IV6op7/vr0raku+rb7XYY1csVH5DXYxLV5TScUhT+WqqtHg4dqbLEm14tAxa7qcNWxly5RoGu3BVx1RShVL6OHZhjlRpMoyR70Z9Rs7kBHHOIlJHRmJ7EPtnxk6xaIyAdQ9Q4jMfieAHHy484dTXjC8orSjkcA5GbGRBNaE6FzwoFo3ai9dWh4IdxYiO8lZzuwFZH2zxiL+Bs+of/O/fsJpuMavZ7vMMHN70h7VgqPvQ3ScWpLrz5Z9yDs7OGtNbgO9/IqGFxG1KGFqrbPH3EIbPsYLtLNapTYoJRWukAk3pVJCRBJAjVLssDbS8TGS4Ki1YEZaoAWJxzE4tR/0gnyo/QZODFoy8UeeqGrpHpHDwaGB2LYOEC8jM93L4WNEnerIELLuk3MTFLRxsyLuOieBwQVbSNN9hW3D0eNMDQi6JMvDwx2S6drVF+jdWHqn8vI2PZ8x3UeMvOs7dOf3j+9UmvT3rRr/TOIsd0NxNGykpUicbBLsvzZNJEn6lnMYRQbBmKlvPuo+dxWek+/oXtJjVlOLqK9uAG4g03eXkWPXyYV7NghMzwsv4bpGLCIb5S56659+KALOACmMQjC2CC6DE/fMM5oRQibWLc+u6brfxh2blN90LjGdQFc44ZWPVA64UwSRIfzz6zVZfuh4ntvayc6KnXmtAoW1MIMm8aaC/T1DKfznODHpyAm8bBLSSUCg04OYzlmWtHg6u5A/gtMEmAHSKDzzoUbOgs57B3Zzxc936GSHacOfeilZ8oTUYdYhC+fwxoYbWtpPL+CcAlmH1C/Vpw32+1OnWbzV5cZ02I3//FRkAzbSBRb2LKmEPjNXx3mwGJnXQn6o+XA5sXVC6m2Y7cixKl2B2FOG+mcRDu5nSJ3owuY6ps0pLv7QU8lXazinwajXwgp +WfhghgY 9+yTTIKpzaBhS+TKw/Yy8o7R6jhZI51WkPNW71w6DlAYpx83MkmlIWjYJIMAtls2YfozNwgSs6Muzq+B8qIUIST0RS0oLZBzXFW24Bkz0n4g2OHEW0DCBf5t8BPKfoqheyE//8wl6uhCuaWkm3MKyjsZQZH6cnhPutXQNVdPjEyiqpyMfClrEfGK/BKooTC7Rav4cVX2xe+zYR2KjFyTPkeEz3FR2jELbF4ivnnohaYrZbK078Qnrugm8xebEYmJqD5vcqQiz83GERIR3Oa6V5Blw7BTAL4JUDgRjivzzPsjFM9pJddhM+FQ4fzFWgIRhbvsfDvPC6wkY1xZ+HB9kadrSMw/hK328BbkX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: a59668a9397e7245b26e9be85d23f242ff757ae8 commit: 5c6ca9d936654a135b459c846885e08966e5e5bf [4693/7876] X.509: Introduce scope-based x509_certificate allocation config: sparc-randconfig-r061-20240423 (https://download.01.org/0day-ci/archive/20240424/202404240904.Qi3nM37B-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202404240904.Qi3nM37B-lkp@intel.com/ cocci warnings: (new ones prefixed by >>) >> crypto/asymmetric_keys/x509_cert_parser.c:69:9-15: ERROR: allocation function on line 68 returns NULL not ERR_PTR on failure vim +69 crypto/asymmetric_keys/x509_cert_parser.c 57 58 /* 59 * Parse an X.509 certificate 60 */ 61 struct x509_certificate *x509_cert_parse(const void *data, size_t datalen) 62 { 63 struct x509_certificate *cert __free(x509_free_certificate); 64 struct x509_parse_context *ctx __free(kfree) = NULL; 65 struct asymmetric_key_id *kid; 66 long ret; 67 > 68 cert = kzalloc(sizeof(struct x509_certificate), GFP_KERNEL); > 69 assume(!IS_ERR(cert)); /* Avoid gratuitous IS_ERR() check on return */ 70 if (!cert) 71 return ERR_PTR(-ENOMEM); 72 cert->pub = kzalloc(sizeof(struct public_key), GFP_KERNEL); 73 if (!cert->pub) 74 return ERR_PTR(-ENOMEM); 75 cert->sig = kzalloc(sizeof(struct public_key_signature), GFP_KERNEL); 76 if (!cert->sig) 77 return ERR_PTR(-ENOMEM); 78 ctx = kzalloc(sizeof(struct x509_parse_context), GFP_KERNEL); 79 if (!ctx) 80 return ERR_PTR(-ENOMEM); 81 82 ctx->cert = cert; 83 ctx->data = (unsigned long)data; 84 85 /* Attempt to decode the certificate */ 86 ret = asn1_ber_decoder(&x509_decoder, ctx, data, datalen); 87 if (ret < 0) 88 return ERR_PTR(ret); 89 90 /* Decode the AuthorityKeyIdentifier */ 91 if (ctx->raw_akid) { 92 pr_devel("AKID: %u %*phN\n", 93 ctx->raw_akid_size, ctx->raw_akid_size, ctx->raw_akid); 94 ret = asn1_ber_decoder(&x509_akid_decoder, ctx, 95 ctx->raw_akid, ctx->raw_akid_size); 96 if (ret < 0) { 97 pr_warn("Couldn't decode AuthKeyIdentifier\n"); 98 return ERR_PTR(ret); 99 } 100 } 101 102 cert->pub->key = kmemdup(ctx->key, ctx->key_size, GFP_KERNEL); 103 if (!cert->pub->key) 104 return ERR_PTR(-ENOMEM); 105 106 cert->pub->keylen = ctx->key_size; 107 108 cert->pub->params = kmemdup(ctx->params, ctx->params_size, GFP_KERNEL); 109 if (!cert->pub->params) 110 return ERR_PTR(-ENOMEM); 111 112 cert->pub->paramlen = ctx->params_size; 113 cert->pub->algo = ctx->key_algo; 114 115 /* Grab the signature bits */ 116 ret = x509_get_sig_params(cert); 117 if (ret < 0) 118 return ERR_PTR(ret); 119 120 /* Generate cert issuer + serial number key ID */ 121 kid = asymmetric_key_generate_id(cert->raw_serial, 122 cert->raw_serial_size, 123 cert->raw_issuer, 124 cert->raw_issuer_size); 125 if (IS_ERR(kid)) 126 return ERR_CAST(kid); 127 cert->id = kid; 128 129 /* Detect self-signed certificates */ 130 ret = x509_check_for_self_signed(cert); 131 if (ret < 0) 132 return ERR_PTR(ret); 133 134 return_ptr(cert); 135 } 136 EXPORT_SYMBOL_GPL(x509_cert_parse); 137 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki