From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0308C4345F for ; Tue, 23 Apr 2024 23:34:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E6066B01A0; Tue, 23 Apr 2024 19:34:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 296A36B01A1; Tue, 23 Apr 2024 19:34:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 185446B01A2; Tue, 23 Apr 2024 19:34:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EFEB46B01A0 for ; Tue, 23 Apr 2024 19:34:43 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9887212019C for ; Tue, 23 Apr 2024 23:34:43 +0000 (UTC) X-FDA: 82042403646.24.5523401 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 09B0920016 for ; Tue, 23 Apr 2024 23:34:41 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="M/1ENwD6"; spf=pass (imf03.hostedemail.com: domain of ebiggers@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713915282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Mw9qRa/fhAF4JvfrAOSL34BTVFtitL+ibmRJ4b61UY=; b=SJNbx01fmSlsf+A+hhGCK8FNIHKqGD76Shj21QUcstTedP1DYptdYGPAhnrVujB4viJdxi 11U/r/A3K3QHkZJXHq1SRZnRYuYJJdTYHN2T1bDmQ0+gyPw7Hfo4fG2/KXpVz/0mo8l0Q8 li5QrM6TJ0WGhaYkPd1ilRtVafnJM1Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713915282; a=rsa-sha256; cv=none; b=fv1+k5BaXYyfWD15g7zNu6Q/SynDLb6r38uSN+OcUChMtko91EhVJZeSxm5vkb9YjdYp2R 6Zyt/ar+9mpfy0zKaMvayP2U6Mr5P9OjEZhMzELSE9BneILV3LPC1ebywQgnIqvaiZMY6Z i0rMC1Nu1cQcGNYGmOIiBREwWit3kyI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="M/1ENwD6"; spf=pass (imf03.hostedemail.com: domain of ebiggers@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E83C361750; Tue, 23 Apr 2024 23:34:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68753C3277B; Tue, 23 Apr 2024 23:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713915280; bh=LzAcy+XvCVX5N1spjFF+GDeLAm7nYydUoetmvgeGi/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M/1ENwD6whocj16yE+tzly6+1EzemOrzDFOidz4hWg6YPzpZ71V7ES1bnNGqxg9PJ fA+oIyAFE99cmHim7k7KvUsyk+dcmKN0WIRnNEOVG1aUbqEwufskeV3UIi97C3236h /YjiKBCC/GMgnUNPiLCOYKpF9Qmf3QZUEUe6lAmbxCI32pbhhslIvTJC9I8w5daD4Y V6f+XG24TvcgcCwXu3BuVkCKFtYVSyUcePaDWoApXnLfm5cYTMGg+YMRa+PrMkexgn Sdv3fxNpFUqiO4gZxd1KOxNR0hZbsI26O5UblDywQmpVZinlNumBJdt2CqOeZgmfal 2ydpow0owFuHw== Date: Tue, 23 Apr 2024 16:34:38 -0700 From: Eric Biggers To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 1/6] fscrypt: Convert bh_get_inode_and_lblk_num to use a folio Message-ID: <20240423233438.GA32430@sol.localdomain> References: <20240423225552.4113447-1-willy@infradead.org> <20240423225552.4113447-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240423225552.4113447-2-willy@infradead.org> X-Stat-Signature: 3z5od59m3uggxj71ybc1mw8tfoztuirx X-Rspamd-Queue-Id: 09B0920016 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1713915281-951916 X-HE-Meta: U2FsdGVkX1+Z2/cGAfbJlELJUnVBtKJcXe15r6wimwiBjsrpXsWXZFfaOeWzQfnX1HQu4haow+qTNeDfEWYs9nWhD4uIavhMWk+5JCtWp4sOx30ia3zOQ9cYEHBGyOttSM8Lj9o2Ju1TONRbZtk+BTmiYJkclSU0IyhNnwO65ZFGcCizLNYWw55ePt9YuN17jkZO3zCTKQWXzJS0pHMCDdZDEvFng3NgIetLIshVUirF2SBdA2PTnsjLWilibRKiRK0TzJRd1Bj4bdirdN6SzK3P2pFo5WoySPuSWrRh3+1Sbv/kz0H7r9xg5XGg4wDudUeeQNE0rL9ujmB4xxp+0k4wSqh25C1MyGgRBM9ToMXFvsLl6jX/d0spKnkiRuIqx5A6qHQ2eSh9XlM+S/ZTUgbtvKFckHC+8RzU7G50YU7VfIgt035aVSoo24qbZil8gR0uL9cNOqM+1ZtpjmHiJpoo2PjtmMlRiryGSGjetwX7QX9meXKli7xZCGKuAqMfdxUCjGCrcQ3d6Q5Zc6qISVhHMbkWtarIouPcIVX2sAdrQOuB5mUsvcIhbqv3qIuzXDe7obj9jDw0qhPE2snSu6HOLB2dZ5cP2PFTPh4X4eaQqxiOTjNCKqtSKERwVd7fwdkVR8+6uWKGZo34zz4jDl57C+Hp3vkCUuqqH93A5qO4ql9Xw1eXREuBq1ishyUe00DHLhhYrMo3MxoLSpedMkVf76uF5AhQET4SN6gfcbRZeN/ohDXUYb0asyJxgsrVUi6TeP0RdaFyMC6z0O9lLU2EyubXFrPsiwWiIuBY//MqYAzGWd1KbYzX06dy6/CqwHmzRwr7qPy6LCrMdjbXu6KVM50rGJ/3Ic2SmxCqonmfQn2Cu5D4hat8uje1ga9n/cuSeuWL38eMSCSqVjf9yTwyhfyaH/xlzam3URdHkBvh8Wdx9dipqFlpQyzuQl9Uw1ik8vIOhUFHkSk8tj+ eompSBen dE/+3Etd1+FguI4BLMMTvRIQTUbtYThnQI0PGUA0yX8HuHKYFFQlJ3Sl+PxFCrEKbeFfV3sdDu3LyAWpCGwF8giWccsFy2xhrhcjPs2LlrJ+CjtgE1FXhBk1KgRtryagfEIteb5K3fyLaEE1RKOWpIcptypPMAfimQUjclatlYqe+MXuyRMnnS02iBlTy4bk7VmpYuhesxUgwOmDn3CenVCoZISLzGLRN/bxQTpGen9izX5AMjVIzxHrdmpPfWv6uyZ2Yl59URySeMnM3MyCXW4Sz1Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 23, 2024 at 11:55:32PM +0100, Matthew Wilcox (Oracle) wrote: > Remove uses of page->index, page_mapping() and b_page. Saves a call > to compound_head(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > fs/crypto/inline_crypt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/crypto/inline_crypt.c b/fs/crypto/inline_crypt.c > index b4002aea7cdb..40de69860dcf 100644 > --- a/fs/crypto/inline_crypt.c > +++ b/fs/crypto/inline_crypt.c > @@ -284,7 +284,7 @@ static bool bh_get_inode_and_lblk_num(const struct buffer_head *bh, > const struct inode **inode_ret, > u64 *lblk_num_ret) > { > - struct page *page = bh->b_page; > + struct folio *folio = bh->b_folio; > const struct address_space *mapping; > const struct inode *inode; > > @@ -292,13 +292,13 @@ static bool bh_get_inode_and_lblk_num(const struct buffer_head *bh, > * The ext4 journal (jbd2) can submit a buffer_head it directly created > * for a non-pagecache page. fscrypt doesn't care about these. > */ > - mapping = page_mapping(page); > + mapping = folio_mapping(folio); > if (!mapping) > return false; > inode = mapping->host; > > *inode_ret = inode; > - *lblk_num_ret = ((u64)page->index << (PAGE_SHIFT - inode->i_blkbits)) + > + *lblk_num_ret = ((u64)folio->index << (PAGE_SHIFT - inode->i_blkbits)) + > (bh_offset(bh) >> inode->i_blkbits); > return true; > } Reviewed-by: Eric Biggers - Eric