From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10559C4345F for ; Tue, 23 Apr 2024 14:41:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DC4B6B0112; Tue, 23 Apr 2024 10:41:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48C686B0113; Tue, 23 Apr 2024 10:41:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 354906B0114; Tue, 23 Apr 2024 10:41:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0FF886B0112 for ; Tue, 23 Apr 2024 10:41:41 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AFE56A0FFF for ; Tue, 23 Apr 2024 14:41:40 +0000 (UTC) X-FDA: 82041060360.02.F759E06 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by imf01.hostedemail.com (Postfix) with ESMTP id 6519840019 for ; Tue, 23 Apr 2024 14:41:37 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JY3r77A3; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713883298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V2tQ8rp4rjTPQe9UHX14lQ4wUiYvx6hKonm0hvO7XVg=; b=W/zzJQYQupf7rfbAQToGbUGazl56bXWrinhmODadKQH035zTu5wG6tQU31xULDPva4zZeQ q5T+fkVbqTQlgh5AWrTutnrdTUcjMrjl806QnLtGAwv4vCiGOt0lEMZIyuC6zKMUFNx1uB 2ObgKWbyFp2lMwWZR2YuDR0jWlK4kNE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713883298; a=rsa-sha256; cv=none; b=FkIbly8pjd2zk0A0FO1krWRaFe96S41tHhYZQ6HrqOaxsrZ6wCGCFn0arpW9WtKTR3tHEz 3gx9injDX5ntYMJt+t4b+fBAsJLuC58q78S9VhoBhd+xv3L3/78Xl8SNv3df4ONV/sPACJ wXV5zzrd7bZarurOBHmxIZznqWPtHSk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JY3r77A3; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713883298; x=1745419298; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2MFEdQx8PJfmmWmol+/toruOTDUBS8sWIUsI92/p5zU=; b=JY3r77A3LusOWB69Q6ESroRievI6XdrOxO9Oxvyuu0k1P8Pwe8MFvTYB 4ZoZ0f79z2lYh3kaX+CwozQHeg3MUYoubDFuXyaSsnNZ+DPu0QRFegL14 WTsDHxcd7K8ukPotbyS4mB3LKxMYSMDuUeRSWn5xZdHkcDl1i98VNtu4e ICCoMtKn8UzKC4WJznohTOZ2UHkp8jQpVOOAu2OWG2uNpzoenj4eSzyqE QGhpJs10pZqVs3tJoQTKPTe4+us/6yH6uRVYljR/67K+qILpGt+juLF9x c1j3TDzjtcrwwQnkHkKzVFxOo+R1uJCsNaXQ5T14FFwlk2R6VyETEjz0U g==; X-CSE-ConnectionGUID: diXXfMX+T9CudTEzR38XMw== X-CSE-MsgGUID: EEaD7mj+ReyI4t4Cac+5DQ== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="20871601" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="20871601" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 07:41:36 -0700 X-CSE-ConnectionGUID: VcsInWyQT7eIjCZmisbxQQ== X-CSE-MsgGUID: WUAU15WtSuGKJA5MQLX14A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="24363957" Received: from lkp-server01.sh.intel.com (HELO e434dd42e5a1) ([10.239.97.150]) by orviesa009.jf.intel.com with ESMTP; 23 Apr 2024 07:41:33 -0700 Received: from kbuild by e434dd42e5a1 with local (Exim 4.96) (envelope-from ) id 1rzHKs-0000Eu-1Q; Tue, 23 Apr 2024 14:41:30 +0000 Date: Tue, 23 Apr 2024 22:40:38 +0800 From: kernel test robot To: Shakeel Butt , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] memcg: reduce memory for the lruvec and memcg stats Message-ID: <202404232230.94gQwAI2-lkp@intel.com> References: <20240423051826.791934-3-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240423051826.791934-3-shakeel.butt@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6519840019 X-Stat-Signature: rnrrmp8jx8z8cjg4qma34uz48pxmjuiq X-HE-Tag: 1713883297-346242 X-HE-Meta: U2FsdGVkX18TBuEIHCXt0zTUf2Grb6DmrAdXaHUScbiav4AvjgMp3sUpGvz67AGVfVpwrGDJwaovOPaj+PM2ySp8yfS0ms5YgGkqRhSyJZs1FKyQMUWRvnSRGuGoNX7zQzP5AvcYnOo5ww9lCPV8MHyM9IW7CcJ7+AOO/6v3Zlr1oB+ny5E5trejkIMa8+oiRNcfZN4YvjFBzz60v7bvnsXGGZzHkrB4N4gH+dAXXjZEGrT0mqDDyXpjqG9Jbfpx4I3i2gmcuPv45BXAp2JZ6p9TrC4Nsd6SaqCKqiJ7e4JVbi+3hH8tF1CxrBQW/6eo/0s16Il/qFFmr87RWpAa7570VWeydTNews7XmSziiU3XXTQik668NIKGl6fm37kkyhzPgYJIFnDwYi3ffJVH69o1Emzigo10916TDRluMNs4bihAm709esTPXtbW5txiIwJINbIeuSNlZ/kKeze51zkh+k702Z8mI0u4p/jSzQb03kcXsexUxR6XG5/uY/oHgz2frBQe0la17GMdn6GqA6S9euqpzzxpx1LOQmDLxIwUNWECAZPaA0prYObSeeaGDdHopNVUaTOsyCKXC5c5XQ30O/KbO+XbHeCOhh5AQdfLv2kfufZEN7v052knQamnul8wDWuG1SKB/sPKC77nyQNtNOta5oXNgiTVjGCmoY8IAhSU3EqSHTGwDrBxOYmbqFY23JykCpD09nHN2qBHOX7jkyff57hItpOVeBzE5BoDLR8J9UvfYrT3XYlQD/cVvX4O46+bjvZCYqo8tEyE2PYWLHyw2BnsLXeakMbPBiJJgLRvcVrHMGTFBABp1FPltyVahrBgYQKixTViubGNcg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Shakeel, kernel test robot noticed the following build errors: [auto build test ERROR on next-20240422] [cannot apply to akpm-mm/mm-everything linus/master v6.9-rc5 v6.9-rc4 v6.9-rc3 v6.9-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Shakeel-Butt/mm-rearrange-node_stat_item-to-put-memcg-stats-at-start/20240423-132451 base: next-20240422 patch link: https://lore.kernel.org/r/20240423051826.791934-3-shakeel.butt%40linux.dev patch subject: [PATCH 2/4] memcg: reduce memory for the lruvec and memcg stats config: x86_64-buildonly-randconfig-002-20240423 (https://download.01.org/0day-ci/archive/20240423/202404232230.94gQwAI2-lkp@intel.com/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240423/202404232230.94gQwAI2-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202404232230.94gQwAI2-lkp@intel.com/ All errors (new ones prefixed by >>): >> mm/memcontrol.c:1651:2: error: call to '__compiletime_assert_963' declared with 'error' attribute: BUILD_BUG_ON failed: ARRAY_SIZE(memory_stats) != MEMCG_NR_STAT - 1 1651 | BUILD_BUG_ON(ARRAY_SIZE(memory_stats) != MEMCG_NR_STAT - 1); | ^ include/linux/build_bug.h:50:2: note: expanded from macro 'BUILD_BUG_ON' 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) | ^ include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BUG_ON_MSG' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^ include/linux/compiler_types.h:460:2: note: expanded from macro 'compiletime_assert' 460 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:448:2: note: expanded from macro '_compiletime_assert' 448 | __compiletime_assert(condition, msg, prefix, suffix) | ^ include/linux/compiler_types.h:441:4: note: expanded from macro '__compiletime_assert' 441 | prefix ## suffix(); \ | ^ :40:1: note: expanded from here 40 | __compiletime_assert_963 | ^ 1 error generated. vim +1651 mm/memcontrol.c 1645 1646 static void memcg_stat_format(struct mem_cgroup *memcg, struct seq_buf *s) 1647 { 1648 int i; 1649 1650 /* Reduce by 1 for MEMCG_SWAP as that is not exposed in v2. */ > 1651 BUILD_BUG_ON(ARRAY_SIZE(memory_stats) != MEMCG_NR_STAT - 1); 1652 1653 /* 1654 * Provide statistics on the state of the memory subsystem as 1655 * well as cumulative event counters that show past behavior. 1656 * 1657 * This list is ordered following a combination of these gradients: 1658 * 1) generic big picture -> specifics and details 1659 * 2) reflecting userspace activity -> reflecting kernel heuristics 1660 * 1661 * Current memory state: 1662 */ 1663 mem_cgroup_flush_stats(memcg); 1664 1665 for (i = 0; i < ARRAY_SIZE(memory_stats); i++) { 1666 u64 size; 1667 1668 size = memcg_page_state_output(memcg, memory_stats[i].idx); 1669 seq_buf_printf(s, "%s %llu\n", memory_stats[i].name, size); 1670 1671 if (unlikely(memory_stats[i].idx == NR_SLAB_UNRECLAIMABLE_B)) { 1672 size += memcg_page_state_output(memcg, 1673 NR_SLAB_RECLAIMABLE_B); 1674 seq_buf_printf(s, "slab %llu\n", size); 1675 } 1676 } 1677 1678 /* Accumulated memory events */ 1679 seq_buf_printf(s, "pgscan %lu\n", 1680 memcg_events(memcg, PGSCAN_KSWAPD) + 1681 memcg_events(memcg, PGSCAN_DIRECT) + 1682 memcg_events(memcg, PGSCAN_KHUGEPAGED)); 1683 seq_buf_printf(s, "pgsteal %lu\n", 1684 memcg_events(memcg, PGSTEAL_KSWAPD) + 1685 memcg_events(memcg, PGSTEAL_DIRECT) + 1686 memcg_events(memcg, PGSTEAL_KHUGEPAGED)); 1687 1688 for (i = 0; i < ARRAY_SIZE(memcg_vm_event_stat); i++) { 1689 if (memcg_vm_event_stat[i] == PGPGIN || 1690 memcg_vm_event_stat[i] == PGPGOUT) 1691 continue; 1692 1693 seq_buf_printf(s, "%s %lu\n", 1694 vm_event_name(memcg_vm_event_stat[i]), 1695 memcg_events(memcg, memcg_vm_event_stat[i])); 1696 } 1697 1698 /* The above should easily fit into one page */ 1699 WARN_ON_ONCE(seq_buf_has_overflowed(s)); 1700 } 1701 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki