From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52237C4345F for ; Tue, 23 Apr 2024 16:41:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C634A6B013C; Tue, 23 Apr 2024 12:41:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C13976B013D; Tue, 23 Apr 2024 12:41:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB4B76B013E; Tue, 23 Apr 2024 12:41:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 897666B013C for ; Tue, 23 Apr 2024 12:41:27 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2BED31404CB for ; Tue, 23 Apr 2024 16:41:27 +0000 (UTC) X-FDA: 82041362214.18.3323BFD Received: from mailrelay5-1.pub.mailoutpod2-cph3.one.com (mailrelay5-1.pub.mailoutpod2-cph3.one.com [46.30.211.180]) by imf20.hostedemail.com (Postfix) with ESMTP id D45401C0002 for ; Tue, 23 Apr 2024 16:41:24 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=ravnborg.org header.s=rsa1 header.b=Tw8FQkWz; dkim=pass header.d=ravnborg.org header.s=ed1 header.b=MCt7cKSc; spf=none (imf20.hostedemail.com: domain of sam@ravnborg.org has no SPF policy when checking 46.30.211.180) smtp.mailfrom=sam@ravnborg.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713890485; a=rsa-sha256; cv=none; b=NErYj9lEuJmw/t1YttaVxW2Pz+0MIXbz/Kq/npJnt5zTp/RvLgObdZEEsfTV/41sjgvy+b eNARFmj+ynTQEH7VMnhhjS/jUciqRW+WfhQH1LH0v4xAOUQZSmrc3rDA6SgrvdNarBjy4D 9VEExytc7q20lZLQv3t4VyqmKkk2X90= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=ravnborg.org header.s=rsa1 header.b=Tw8FQkWz; dkim=pass header.d=ravnborg.org header.s=ed1 header.b=MCt7cKSc; spf=none (imf20.hostedemail.com: domain of sam@ravnborg.org has no SPF policy when checking 46.30.211.180) smtp.mailfrom=sam@ravnborg.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713890485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ce+ZqFlarA8IAt5zfwbr2hxRLFQAtI7f0O/GFL7QRfQ=; b=iSeK8aLLMp/VXnO9ghI8V5PPuhYIiefjT8XRBQPYlh/q5NtSkgb/tq6CMtTwrimT3ytwMk 9KmTqTHgxZpjGxqLWcI8T45G1Wl/zAwwEjZ4DeuEiJK0gk1uSMzniUr+UhG8rvULdGj2lN gpvQxt6Flzt0aEH9zkHm/W4NVxYfsI8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=ce+ZqFlarA8IAt5zfwbr2hxRLFQAtI7f0O/GFL7QRfQ=; b=Tw8FQkWzueJByde49pf2Etw1JNd+9Cs/a8VSdP4sAjZamDT998lpGJ8OUSXZPgdnq9YK80Ld79By0 E1ZePxzkIVPPM3w68Ti2ki86ZQSTo/Qengh+ox/5EsZdMfGxT/LtyRbZzNkl+eBPCbtoD00qByBVfh QlogVQorbOUCuNhfuDWjsPIOEK757mimusKghDsKCrDlzJS1s6Psw/PaVE8r407gkh53FMLrF7D1dO uDYiPtxot3rmREDV43Zw4JTzOwK/+pqOJcBE6+tKyTzcGurjSzSuf0Roh28MmUDSp64HXkjpWwAEu0 fCub6cvUfUdVz3Rx5TFyQR6t2+r0Tlw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=ce+ZqFlarA8IAt5zfwbr2hxRLFQAtI7f0O/GFL7QRfQ=; b=MCt7cKScu1j54dhTCuf6RoKzDR6Pxv4AhcExl3aouinnY7Cygl2lgVcGjoVORGMB/icOvVzGnLV0S zdG43KuBQ== X-HalOne-ID: 4e317c2c-0190-11ef-8c96-edf132814434 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay5.pub.mailoutpod2-cph3.one.com (Halon) with ESMTPSA id 4e317c2c-0190-11ef-8c96-edf132814434; Tue, 23 Apr 2024 16:41:22 +0000 (UTC) Date: Tue, 23 Apr 2024 18:41:17 +0200 From: Sam Ravnborg To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Peter Zijlstra , Rick Edgecombe , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 04/15] sparc: simplify module_alloc() Message-ID: <20240423164117.GA897977@ravnborg.org> References: <20240422094436.3625171-1-rppt@kernel.org> <20240422094436.3625171-5-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240422094436.3625171-5-rppt@kernel.org> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D45401C0002 X-Stat-Signature: oe3iidicyp4dscro1o6ofe8ndjpdafms X-Rspam-User: X-HE-Tag: 1713890484-259518 X-HE-Meta: U2FsdGVkX1+HQ59uUxUd1yj932DeAi5PbzXENTh2oX662peiJBDT3C6GoeV66JrNafVXXFZdrho7O7TGq2ozXSA/wGfbNXMb616Zz0h0eBWmGAJyLgp2nLgEDQfybNi9ZRUDTMyEuOS7e9F/io6tWF7WhYmqwxIRqCvBVDnCNOEnkKBWMfkQyomdWdBm9iM9a2ZeUhVnTf/9mgjVl8iuuSYSD7+u5Q7FPeaRapw1oTSrgWOHGtJFJd9YCydikWe7grRvrbaX1PipxC3U+wLy88/v2W5MeujqcBJ+eaPHiT9sPI/VrzsJD0Ima3QijYLt40gDt2bxAqPeUKKtVqLL0NMUTn1aUr/qAa//4LZ7lHVPrfBnoW9Y64/Eoh5QS4qSjVkQDw3HllOIP9dWdQrSGzh39XQoHrl9a6JtQqoEg24n37S646hh2cTe9TWUpojTpWMi1leeF2dIIH4XBKFTMgmG3DXGfx38+0/nKPcbLITWyx0TWt/qAvrr8ga7Lw1+60ISoPqWB5WFXO7KgQDL38HJdlIDOp5Yeuqje+TiPwQjMAE2rUJnGd6w7jTQjIAtGQSrI/pbp9Fqpzli48PbibIQ3scY/yA7l/EWuSOXjWedHVpzv3QAc/b0AzXIPBe2UkDh4nXKhjSeuFcTC97HUcFAbDRcgNLXz74TM/8WDxAXwTVYN9EDb7iOnjXjz9ALnQLqpcNkoSM7W0m0+POeF9cuGtZULvwiMtL/QNNr9R6JOU1rLYcguFtlZgwqbucEkpXoaOvK8xaJ6ybW2KPTdRUCznO01fZuoYixzFAUa0iAOW6gQz6Gxq7sPz8CpBzUwyu5RutvhNDg2k3DxwJRsMU5eYXQ6duY/wt9FqRDM999aE1dj1Ms1aikjIcuIdghgMQ1MgGhvVEdgPNyXsSl2V+U6VBbAgxvOiwI5QTHXVKJtMQhmWU7oiCRY/QfXc4Hn3k3hQS6jGvJGY/j10A 5FEM4F42 fzYDgWjz+fXwCMD13Ve5PqatET2K17dIbIJSFuUXIV2ZcwgeYP1jRuyGiwrW1T9k1DwmD5uRqXw+RpvNe9aCwjVOu4ppVVxBgm5dj6xYWg2v1f8ofygL3Hbz3h3b7ZtbtspTcWVZq/+PyQ+P6nWzRBWWHPuUhF2X4FR5KndZN+lCXEWz7Chbi/CMNg5/C8bN/O29FOd8c69rhjpzE/RvQaB/iNwFqqIGPgQWlcyrI6LuKfvb2LtwC5RZlEdv3ThQQUeXe+cf+KiKZGpc3YlLYQgj1uK/QQ5evp5UA+p1uR5dGpOGT6Qnz+QTGgfpo9CbVdT2Lvwy6zvZCm1DBPZJb6InxsYN9sVEESyF6m5osrMu5wfHV6QF7JcQXY2ukj3QvYI0qbSVk6NbCqy+rz4WTbZgI6lebzZPM8szGj8cVuWhovjcSZ59mKMd3EQf0Ky5rrTlrY6qgYw9FFMf3eGGthtM47i4mTcBBin/3zkN3iJefmpzz/tTAaglUcfFxdC6QAjRfOG1WodWrG4s9ZIcQtLNx5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000379, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Mike, On Mon, Apr 22, 2024 at 12:44:25PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Define MODULES_VADDR and MODULES_END as VMALLOC_START and VMALLOC_END > for 32-bit and reduce module_alloc() to > > __vmalloc_node_range(size, 1, MODULES_VADDR, MODULES_END, ...) > > as with the new defines the allocations becames identical for both 32 > and 64 bits. > > While on it, drop unsed include of > > Suggested-by: Sam Ravnborg > Signed-off-by: Mike Rapoport (IBM) Looks good. Reviewed-by: Sam Ravnborg