From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E45C4345F for ; Tue, 23 Apr 2024 13:58:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A3986B010D; Tue, 23 Apr 2024 09:58:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72CFD6B010F; Tue, 23 Apr 2024 09:58:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CD566B0110; Tue, 23 Apr 2024 09:58:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3CBBC6B010D for ; Tue, 23 Apr 2024 09:58:53 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D341A40FF8 for ; Tue, 23 Apr 2024 13:58:52 +0000 (UTC) X-FDA: 82040952504.13.5287D5B Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) by imf05.hostedemail.com (Postfix) with ESMTP id AE7EE100007 for ; Tue, 23 Apr 2024 13:58:50 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=frL5PkLw; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.161.47 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713880731; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WqStfhzOnysXibrgT2E48MrpzZWIctM3Wmz+RM/fc7I=; b=chsv+P2J4A0rMLUccvMWFGelYgjFNyVfQoFX9t1VQMOiazEuO4knrNsD1WXzlPmied7HJf hdpyBs9Xqp9nbkHeYapVIOfc/SCdSP3u7NpZZWQJWDAyVkh9pCNQk+ipZqy6oHuYmi9pEk 5v937drvxhVXFOQ9BdyauS9GUzjxh88= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713880731; a=rsa-sha256; cv=none; b=rK6GfjB6zyuuGaHvK4ZW71++hDMlBmlPElZiHcuLeVm2cKTt/vey/75VH0EQb6z0fDS2zT UDcU+L+1+U9Pr8HjNlylcVBaZLYe4e0MC5Y96vOABFM+JuneIWxUueeLDKI+U7ruLe4jDe SgcUWrFeqNPNWFnINLJmDLb6QNrTeRg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=frL5PkLw; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.161.47 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-5af3cda139fso272358eaf.1 for ; Tue, 23 Apr 2024 06:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1713880729; x=1714485529; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WqStfhzOnysXibrgT2E48MrpzZWIctM3Wmz+RM/fc7I=; b=frL5PkLwg8AwfjSCGrdI2OM3HjpSt2HADsJDJfLAkd8Sszrwd9WhHB/VYbG91qgNCM Yqtzac9E3ac6Wq8sNdh5Xy4JuhURkaL8oQsWvMvGcXAuPMY0Rvs27BFXNMwR5LbYlbCH tuK2f+Y5ZQDxqU5AmM+7KoZLaf7iiUIA//H7YUA7bclyemUOFFmFD2AcOXHXDUCzCrj+ KoOOmmnMn6CMN6ooye+yndaqkgI4gt+c8V8uLl3fjHuZPb6XPb9pXvMojijX+v4jAsdW 0E8WZopUIv8F7D9xfr9yuldbGclQKFL3zllN6HnhebhOxiQku8IPWXh4vJqno99Y0WMt EwQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713880729; x=1714485529; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WqStfhzOnysXibrgT2E48MrpzZWIctM3Wmz+RM/fc7I=; b=nRDHUqcfxYKRJh3glncB+NoqJp7FhT+k8bjXl/fEqEaFvh3jKCokc7Uk1rSXSJ2kig 7n2bhGoxaB6nP95o7oqYwIpSDzqjEDUhh1wQNYqXQ4DPMBCIfToZobcDJmGokPYEI7Cf UJ6D9j9QxE4rvWRiSa1IZLSBZDAxqXBmJ4/q1Wax3C6IA4GaI8w6tFzMWWfGkhgwMah5 zvShPdYTmExPYtuq1bOXSOB28c4qBV5nt0GYyiStM7BAUe3xO/D6ResFhSvJZVQsUY5K psQfxB73IF7lpP5TZr211MYbCsHGQG7F4rXbjJkGkD1F1Rb6dg+STr50iQ2JvhHQQc2W H+LA== X-Forwarded-Encrypted: i=1; AJvYcCWe1CK3CGdu+QhqV2lV4ekwBS8gGNM8RjT7A8YHXasW0kW2ga0VUnJs0EOjLUicfYGaCBAAlpFi59lQzxJ+hjzFwD8= X-Gm-Message-State: AOJu0YzpJPty1xsWLkH9obWVQ0vSwe8lDNcxU7/R0//9Qtw82rB9G4Yb gtOLoWyJZrEP5Zu0OOd3d72mkFyiopT9h6lSNbDNX5QctnMDfE+hQMBZZyTWYy0= X-Google-Smtp-Source: AGHT+IFwG9XJlDFqbvMmAOd4uyTY8SGLMaYeyX3/gPYvOni0T7+MH5srQSPCfT8gzXzv2lH9r8NbMA== X-Received: by 2002:a05:6358:4b02:b0:186:22a0:299d with SMTP id kr2-20020a0563584b0200b0018622a0299dmr17564312rwc.27.1713880729494; Tue, 23 Apr 2024 06:58:49 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id kd11-20020a05622a268b00b00432bb012607sm5202815qtb.47.2024.04.23.06.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 06:58:48 -0700 (PDT) Date: Tue, 23 Apr 2024 09:58:44 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] mm: rearrange node_stat_item to put memcg stats at start Message-ID: <20240423135844.GA21141@cmpxchg.org> References: <20240423051826.791934-1-shakeel.butt@linux.dev> <20240423051826.791934-2-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240423051826.791934-2-shakeel.butt@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AE7EE100007 X-Stat-Signature: 4hgo1w75xdmktbfu4zpt94x41mygkbq3 X-HE-Tag: 1713880730-762416 X-HE-Meta: U2FsdGVkX19GW+4lqY/dFBxOBiaUE+yyCWuOenuyOqooOPk9YSus/dte1SkKobtO9gcomZMCkM2xGADLhGMAATN/cMbDZDnmXzwDVcXxNRyfTbU4f3Kzg8GQCwYZO0hFtm2g4OkgpFsB5S7kDfA+d+/SMIwcaW0sAf+Vw8Y+32J+qS9u2x01mmPSvpW0/VwojntwgsHGjgt0ihS2LSESLil0UTxzBy0Mqyuueod9iYhL9TVk0aL1t2hTz7FFT8yghhxB5Nlnon/LB0cVyD4+8futH4jDvMACtSrrnjH9opmUuaglKq+e74QX+EJHK+O2kWwVrxIfoRWtLgCyPBTOaevd4C6fgdKyXlxdB8dGs0XJcdJb4JO4EJZpamZvQl8hj1bHIWg0Js5oH4YglCBiXunVPnuCPmqSzLalES9WldGvZPH0A8c5Bx8iw+I0RkvsEg+jJrk2rIU3fPGdvVbu77hF1zkk+CFM8yTjDZBI1PYzJX4i5ZvXREqNIBgL1HAiWjaCdWsBrjZXOH06hcC3ELaMzaVk0VATMJVOWJ27GKfiUsIQZjQX6cAbcuuPLcMrz4uPZ8PIujVTgBH0krXz2E27dbNPQ4VWIpV4dcwZhLtwC5nE5TD1PipCmTfMgaDLbgo1sw9SIJiJOROCnG1HQ4vfNJs6ARFuDiTMuG8M78aFIfJg6r4uq1dxyvowGjyxnWO7pbhou7O4V0NK40w/LZbwPN+astn+on4RFCqCahessizZjZImU6x5X89bsandR9SfVrbc0AJT3bG1pAuQI5rzpoZPuJEK6LU0NdWdlqDyELUiFWsiQ/S8PKOClaT2sUpuKTCiyPCyelh+HL7yRcNaO+d/JsEblpCThQckx4b9TM9a31Fe59XerrXaFscaW2YiUVJIq+bbAugJASOZAG+X3tfKvtNASblnSS9GoSs+Xvmmz4p0Dq0UP1aEhBLMNDG3HfXgeeq3yTLk9gR r2w/bged p/BwK2WzuFrU9E5GVFfMUQz67SM8YEK8iw0NDPIaZM3u59tHo9I/ScA5QVKX18bk6/hFZ/oBzxNlqDp7tSvUjkZBc6DmmxfvbPdOLH9oia4nnS7vDioStUMdKRxFiPHbs8WhoGRIAJQqEiKElFVeJu2vuHhLa8fO5eZBaPqwAgn0KAYJ7ZFTw0XoXxBZECqdO7PtZaiKocrHBnSevbXwNSziJNJ01/fz6fbdB7MarOPSoyHMHLlDhNPFdBlMOTFtJ/jvpz3fY1SMZRQvy+Qo+fLe8yPcXhCJC7Q9kPVtQ8p6BJkSHt/XrPzOSkaSghOluI0xim6v+6hDbW0D8Kp2jjOvPRNA13D7pj51B2/8raomaDqwtZdIfeuk3ulh4FiyaOvtej06quW0gJO79t8wFgW4fWL8W55aI0XvQRwpQbXcReB3rqkad6azhW9L4NjzOZjMx9qz/sJJQX+Hrxt6moahLic/FG12qzGT4S92cUtHq3qitFPYjeJjt0MAO+nSKZd8UPOko/dnKbyzPAL2iRM4Qyvrctsx9aQe8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 22, 2024 at 10:18:23PM -0700, Shakeel Butt wrote: > At the moment the memcg stats are sized based on the size of enum > node_stat_item but not all fields in node_stat_item corresponds to memcg > stats. So, rearrage the contents of node_stat_item such that all the > memcg specific stats are at the top and then the later patches will make > sure that the memcg code will not waste space for non-memcg stats. > > Signed-off-by: Shakeel Butt This series is a great idea and the savings speak for themselves. But rearranging and splitting vmstats along the memcg-nomemcg line seems like an undue burden on the non-memcg codebase and interface. - It messes with user-visible /proc/vmstat ordering, and sets things up to do so on an ongoing basis as stats are added to memcg. - It also separates related stats (like the workingset ones) in /proc/vmstat when memcg only accounts a subset. Would it make more sense to have a translation table inside memcg? Like we have with memcg1_events.