From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EBE6C4345F for ; Tue, 23 Apr 2024 13:56:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6E0A6B010C; Tue, 23 Apr 2024 09:56:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1D7A6B010D; Tue, 23 Apr 2024 09:56:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0C866B010E; Tue, 23 Apr 2024 09:56:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A1E1F6B010C for ; Tue, 23 Apr 2024 09:56:45 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 57C31120C6A for ; Tue, 23 Apr 2024 13:56:45 +0000 (UTC) X-FDA: 82040947170.05.FE3C422 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf22.hostedemail.com (Postfix) with ESMTP id 87F9FC0007 for ; Tue, 23 Apr 2024 13:56:43 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dGf5VRvb; spf=pass (imf22.hostedemail.com: domain of ytcoode@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=ytcoode@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713880603; a=rsa-sha256; cv=none; b=e39ScikC9hWettB81xXsCdjiKPZsQ2wvY47OcRtziyb4netNO87XALQl41aLBefV75N+eT TA5395gV/qmGcs6BGtUavPT9xKBx/hv6h173WfVDI84v8Zlxdy7eAqVHNcCmFuWbEaFb4G UqpUJgaX5d10Pgy3XjEEOuOc/M6Xf5k= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dGf5VRvb; spf=pass (imf22.hostedemail.com: domain of ytcoode@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=ytcoode@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713880603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=kQk5FyVP0lAkjPXrseFZ4aW2TL7nmZurojICLrE1sJU=; b=bLAeX8Nqq0dycY5GGeDZqHR5ODrVyE02c0fjdzSTCNwBecw0iw9PacJR7TYP8ux0rVm2pi HALmt0a3cXSyGkNemsMQ1IvFoM5NMEUZS9Er52rZezZKoakFp7jsEzGPsRwi7zE7UUaXGz USnUfqttd6/iDFDXOvsxk4ARitJQ7Fw= Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-5d8b519e438so4432286a12.1 for ; Tue, 23 Apr 2024 06:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713880602; x=1714485402; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kQk5FyVP0lAkjPXrseFZ4aW2TL7nmZurojICLrE1sJU=; b=dGf5VRvbF2vfnW91Q4OvZsLrmzSUWXpDhmTgaxzMwkO0EnBNzd3aDA5FLIKt/TX3ao uGsVqUhxhdvr201gTK5WyvWl4TchT27fu83tObuifHY/1vjfHqofcL5UKvdYw7hNE8XC boHXXfRvYoStYH6MPdQyhGtaIZObaqEJNwfYUYoYPNwJ9gMsF+RORl3kDBTrwakl0OqV 6r34WkT/ojLLdOxLlpbB7WO0Mr/cIJqm4XJiJq0WtYCElgdanPaU9ckAcBB4T1/uAX86 6/Gk7oNmsdS4rk7tNJYpFJ8ufcFU5ffSRiqqv1mYDuLR4SkKTOivMvIer70xXuLEqhyO XQ4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713880602; x=1714485402; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kQk5FyVP0lAkjPXrseFZ4aW2TL7nmZurojICLrE1sJU=; b=g3jhHrq00WMqMpon3804HXGqlFM7fVZYCmAxOTNi0FJqPuXs3gJNLMz3qcQqw9oaf0 2WbxGz0xgWvho2QTJ2CCwvJXaYV9yyrXiDSvOOASfke1g8Vlsnw377nJGHOwcsXjleND sCmG/YQ9oxPjgrX8Fxmlit47VFPv5WKAEQQYlXk5e/NNVDDbBsTxUJy1E0z7gZHug4IV y+2NSAPY6zovm6i6QoHtAskJnYVN5nhLkdBZ+fpUFRLypMUYEZ6dgTPaoGv7OHsYtdTV BdaMv93y1eMqAlGVnxkiMsXGrhtaHJFDVtKRRC2I/D3XruC/iRKFkgyjfPwjbuY7IIeP I48g== X-Forwarded-Encrypted: i=1; AJvYcCWH8v0G9gMutWEB19d6B8Sd9gxg0jlTDMo9lSSefu1eDy868zigRdB2kt4TTbRCVXEOVuW3bNmw5w2pwsvwZeVOmpQ= X-Gm-Message-State: AOJu0Yw6cbsPe5iBXqJo4IPWmo5p3imuW0RlY97SlbZ8UIm+3ypM8Euv PIOVfXOEvWRq61CMsYc5OP1SJsdxhTfGrUBAuTldgQDO8tXVdZL4 X-Google-Smtp-Source: AGHT+IHi14oq6oMq0l+SgcZtnVF+lL+zvoONhe6aIpyGBgnH9ORlQ9qYr2zloIHU1A4q2j4SyGCYhQ== X-Received: by 2002:a05:6a21:9102:b0:1a7:8a55:b070 with SMTP id tn2-20020a056a21910200b001a78a55b070mr17991393pzb.37.1713880602157; Tue, 23 Apr 2024 06:56:42 -0700 (PDT) Received: from code.. ([144.202.108.46]) by smtp.gmail.com with ESMTPSA id fa19-20020a056a002d1300b006e57247f4e5sm9623570pfb.8.2024.04.23.06.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 06:56:22 -0700 (PDT) From: Yuntao Wang To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Dennis Zhou , Tejun Heo , Christoph Lameter , Andrew Morton , Yuntao Wang Subject: [PATCH] percpu: simplify the logic of pcpu_alloc_first_chunk() Date: Tue, 23 Apr 2024 21:55:25 +0800 Message-ID: <20240423135525.36872-1-ytcoode@gmail.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 87F9FC0007 X-Stat-Signature: pqd4887ggtxfxf47nh4dznuhzojufddi X-Rspam-User: X-HE-Tag: 1713880603-672203 X-HE-Meta: U2FsdGVkX1+PEI9OWAmiodhvJ5Lz19s6AOzfZxMAk1LxBupc5CreqBB5v4/scsgQEsbiJzYtflHXrzenxOJUHKgmva3+iDP5K8jyH0LjJABEHf/jpyMEI3Kqswr8GaDpHr3rhnvjZsXd7TXO7osJYT8jBiFbgIfPdit/PSAIZ9Q/tfhh7w50V8RZ6rzCt2snBqTnguCAlTo5vCa9mQjUAHNEMCzWQ+5M934LWStfcAeTs+0EEyVGQWq9xAcW+q2z2dImiroIM24w71VGmOKB2vfsqf4z3ClsgEeyjucOMlWN2Adsz3cMpre67oWNTAfm9V4TI37t69FZP6/109qawLhCX82XIGc4vxYO0yuQpREeTL4Oac5BShWuxRff8nBWDVvcVr9Tx4YnXu4a7dzlbQEup3E3ccWZM2aCcqjN84VNrKZNGvKoXqx/6ocRj0WFm2ofeOOPSaFfJpeyI41yglpxvSi6q973HdeSUqh/Hr3tEWIT6cP6FOsXTPkZLZtbIZ/Wc7LI3ivwgZ6kaxZ4isKuteiWyxQ0U8cT2hyoSL62y4BaOhOt4hpKTjkwUrau3ax5uKXRNk72oJw4pFczZ6/oPFkNfDZTRIFoNS83YHIasQ3Oe5YY+U4ssIJfdTvKfvQJ4+9ZIRdharx+HdQDC/agnIQIHk/WTcA4yDkkBAhWGqi0Zz+7snEB5XrQQKHGmKm9jI1KoLNkJG3O8JOcEpSOWP+pRV2U24vnVFSe1FanvGJ+iRGGr4h4HDDwg7lcdA5IK+m/d8rbDKcS4d45MM/V0A0teArWUNbaMCwKSMQwL8I0Bp9BpJAqS2fktz2UMACTgw41y0Uk6lbiYaf4pFDg8GalQGcc3s8j4Yt57a5iGcpiB4awwSv7dN0qYk9vTSbUsiMVwn8LJ/o2X8+zfaeoqSkfnTPr4w3VY3TLd8FZ4kU7IO8C5yKiuL4L+vsfjuR7/qI9NiIhq1w+Tz5 7F3YX0JF WZ7Y99brJCDVn8KyIPZA+s6S7zt9iBSxL18SguPQS0mdkWg4Bd9BK/tC+TuWKdJT8ZjkeNBi/auCQqheYdSrrkc3G0ZDIUU6qea9Y+LYK9R0zfGXvqu7u0NOLF765LWBQ/QmBW9vBdW4/elSljQwLzQQTSlwvELXG34uVhVfbCBMvdHwcJ7TLFG07wCwE1lXG+SdxLqgfW9p6GaxdtuMIvYgKuz+2ZiM3L8h/bu6PR4rWHh5wBuazabE9YTlQ+mVRTdOfMY1MAIqXMayxwJjnW4/LS3BsDx4ULMuGr6NoxW8n3Z4xF1G/SnooEK4dYIiV9pyzX0z23wbt+Ltja9GLTpKAZBo+Cr3eSdIvgoVmKFFYmqV4jvZ59mboVvQDYFUTQcp9s2G5QsmpcRpK4pDdyQCMLLD9vc/u6v2ZM41rOlHmGLvR+WgUyE8XBQnbGWrBBy0/NDlk688zB9uK8swZPxSjoNVT8h+dnsem+w8NW+zNMU0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001198, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In the logic for hiding the end of the bitmap, there are several places where the same value 'region_bits - offset_bits' is calculated over and over again using different methods. Eliminate these redundant calculations to improve code readability. Signed-off-by: Yuntao Wang --- mm/percpu.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/mm/percpu.c b/mm/percpu.c index 4e11fc1e6def..2a051f00f68d 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -1421,15 +1421,13 @@ static struct pcpu_chunk * __init pcpu_alloc_first_chunk(unsigned long tmp_addr, if (chunk->end_offset) { /* hide the end of the bitmap */ offset_bits = chunk->end_offset / PCPU_MIN_ALLOC_SIZE; - bitmap_set(chunk->alloc_map, - pcpu_chunk_map_bits(chunk) - offset_bits, - offset_bits); - set_bit((start_offset + map_size) / PCPU_MIN_ALLOC_SIZE, - chunk->bound_map); + start_offset = region_bits - offset_bits; + + bitmap_set(chunk->alloc_map, start_offset, offset_bits); + set_bit(start_offset, chunk->bound_map); set_bit(region_bits, chunk->bound_map); - pcpu_block_update_hint_alloc(chunk, pcpu_chunk_map_bits(chunk) - - offset_bits, offset_bits); + pcpu_block_update_hint_alloc(chunk, start_offset, offset_bits); } return chunk; -- 2.44.0