From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAEDAC4345F for ; Tue, 23 Apr 2024 13:52:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B2E96B0109; Tue, 23 Apr 2024 09:52:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6633F6B010B; Tue, 23 Apr 2024 09:52:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5037B6B010C; Tue, 23 Apr 2024 09:52:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 30BC26B0109 for ; Tue, 23 Apr 2024 09:52:32 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DD161A0FBB for ; Tue, 23 Apr 2024 13:52:31 +0000 (UTC) X-FDA: 82040936502.20.2EC7184 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id A2456140016 for ; Tue, 23 Apr 2024 13:52:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=rYatyu05; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="kf/COY7l"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3J4H+zWP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mIJh+WXZ; dmarc=none; spf=pass (imf23.hostedemail.com: domain of pvorel@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=pvorel@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713880349; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S7sUaoldK+ni+3c1FI6B0LC7MkbWSx7hrgafCzLBQh4=; b=Y0aPAN80dyNB2AC1sKEkanZnzezxIjO+DmR2iLrjkGpzGM/q7WO8bpJGO3HGP0mZ+D1148 dBSNeYd9TeRXtcF0KjPJb2SeVl0pIVCEUGq7nnk4682W9v4LQFqtsJg91U9VfWlDWOXIrC inOM10vHhztxYW79eCX3O0D7vxsGTpE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=rYatyu05; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="kf/COY7l"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3J4H+zWP; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mIJh+WXZ; dmarc=none; spf=pass (imf23.hostedemail.com: domain of pvorel@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=pvorel@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713880349; a=rsa-sha256; cv=none; b=ztxJnUrMv1ZC8NCcXcvpMWvXez2S6bpWW3FbjU6wyZD+khhx8Ys9lsnBTcXj057G8fsVAe MpQlF9oQ8jwIU5WLgrOKr+xJVHagg28UbDPRfFOflWxDRmFESmqjd3HBmMwzqxSFRyX9aI ajgCMd4mvOekKSVYKeG5AocmjYaOccA= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B9A0F5FFDE; Tue, 23 Apr 2024 13:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1713880348; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S7sUaoldK+ni+3c1FI6B0LC7MkbWSx7hrgafCzLBQh4=; b=rYatyu05UZ5WqfVfLxuNOAWMy4W+PCssPHr/5n3oIhVfFL64DgPd0Ay5HoUsqmLklmASk0 8OoIuI8PnoWMfndsKm+RSUwVdQepQ49bCZ8MsoVBChreIEihIkL+k7BkuVrC0WLyJcDv/2 PYh1rQcPsG4G/8bH57kDhgo00wpDexw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1713880348; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S7sUaoldK+ni+3c1FI6B0LC7MkbWSx7hrgafCzLBQh4=; b=kf/COY7lXjOGh1SP1uOSoH0J1Gjot3A704KY9ffiUAs2Q9LT1OtQP/LLG8z1DQ/KUbcggf k+kB89sdmk6QyhBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1713880346; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S7sUaoldK+ni+3c1FI6B0LC7MkbWSx7hrgafCzLBQh4=; b=3J4H+zWPsS0SxnmdTAdUwVpRt8QPEJyJ3CMqNJgNI9RTJl+zewqgIwzP0gHnvwZ/Ber77Q DjASXm6+Bth5b2VEPuO60a++OL/FD0xz5gMhozkpx3TvLat9EZZ8GZUzaei6kCoXPaeQbc LeWLXi8D2X69TJy6tz6Rwhn3J4zHpsI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1713880346; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S7sUaoldK+ni+3c1FI6B0LC7MkbWSx7hrgafCzLBQh4=; b=mIJh+WXZjqUkXb04mduTycZiYg5xS5Z83Im/3aErIrKZzpAtF4UHO+ifGdWuor8OvXfQGn sDHMfHO6sAdNH/DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7BF7013929; Tue, 23 Apr 2024 13:52:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1BinHRq9J2aecAAAD6G6ig (envelope-from ); Tue, 23 Apr 2024 13:52:26 +0000 Date: Tue, 23 Apr 2024 15:52:25 +0200 From: Petr Vorel To: Christian Brauner Cc: Cyril Hrubis , lkp@intel.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel test robot , oe-lkp@lists.linux.dev, ltp@lists.linux.it, linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Andrew Morton Subject: Re: [LTP] [linus:master] [pidfd] cb12fd8e0d: ltp.readahead01.fail Message-ID: <20240423135225.GA195737@pevik> Reply-To: Petr Vorel References: <202403151507.5540b773-oliver.sang@intel.com> <20240315-neufahrzeuge-kennt-317f2a903605@brauner> <20240318-fegen-bezaubern-57b0a9c6f78b@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240318-fegen-bezaubern-57b0a9c6f78b@brauner> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A2456140016 X-Stat-Signature: 99pboiy7nrpqbsad6zn18uj4kd4z6m7p X-HE-Tag: 1713880349-423475 X-HE-Meta: U2FsdGVkX1/nuIiZ8nhs+8GpzrmVerrbaTW2uGacyzUXOJ6y8ci0PuBCQ6CyJ/dRJ66XpVpOhOzi1SYLTDCfDmS505c+rcGx2XlvI4I7EtAqZD7kek/sk/6eAp6oEmz+NgxpbvCAlFbvqK438M2oKvxpo6WJI6IMTDpaJnr0mIvWlcIDZpigykeK8MY1/5BPgyQ5RjJHytVK3Stql9cn38UIxrqc9kTvYr6Tl9LcF3kcM6/NRpyluA1CeWCuZAH3pwtbWY6nQfOh/aa0ygDhixjwYy226+HWrFq8LyUwO+0YffJeHZP78+vyS+LlAI5Gtr2QrqEe+5m1nJJnJHVAIroqd3NII0Cw6CR8MGma7uS5Y4TcJaVm3CsISv8qL5ln4IqWKsqBWXAuYuJzsFs6UPYYEO5L8ir8QT6BJni/gpSEMoAQOAoROzScEU5AJj5abAqB2erlTLSq1K4cQU2wVYTXIZdQQxHNw5TkbfuZPp0dJTGT/f/SCW+XqVhAMN/+uoUxQTw3HrXtFX7EO3TfklfjII9/bIIzmFMatFlM3H2zYLlgV/lgY23aZtd3G4kXyCcnO30IXP6OkLB86q2UR21hwfDsEUODdzIkctzo1BhbO3g13YRIMU60Xtu1gtPS/si7OZvyDeyjs0SiAzCDrTwgmzIepwUkWdjITvgza2S+2geURqmv4/i2gDQIgaYta968Gk8hDeidCSsYaf8Hj9PznXbRY/0l/GgLFDb+z5p8nFHKhvj4qWXk6VwtVkYe5EuqWeYDBPu7AVwzSB/2y9wp+rolefC76Ao/Z/u76B+4vP+IkeQy+Yzx+9nT537tywQcAAGT/ejX14zN1oYs/o8T39w4OapzbwlwItd7dCsiLxRJC0kA5K8Wg1J6KfPPV+azqNFCpYNoyQA9lWwmhbm4QsM1zgDBPdZ4cjBimYRlC8qxVe6kFVh84eEIp6cwqB2ZjYNbw/owH+a/fh1 sWftRq7K eBKg2mUc1bFuep15uPgID7k9yEqMJq5/KHAH+uunhIoqI1XLKMxKrlBnHTqolg2dgjaog96Yne2OEtfzdJklYSx5UitQokuXLxDpm+vbJKfWJX5pVCLUEe5LNHPv4cXaHPayO32GrTl8JQE3S8WBWKjylNjkeo5hfSp1qmOJJFJWhO3Hp+hyrzUmcihDTpR9zGFFR0BMaJg5R9hoNXENAkZT2M8Hgb0XXOCwpxWAW1wNflMzp6UZrvhLETJg5sj50vJeBvhjTE8iqRlqOUR5mBSDWm23doNhzgPL/6WQlS2NKiiPeLrIE0aPjZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, > On Fri, Mar 15, 2024 at 03:49:03PM +0100, Cyril Hrubis wrote: > > Hi! > > > So I'd just remove that test. It's meaningless for pseudo fses. > > Wouldn't it make more sense to actually return EINVAL instead of > > ignoring the request if readahead() is not implemented? > It would change the return value for a whole bunch of stuff. I'm not > sure that wouldn't cause regressions but is in any case a question for > the readahead maintainers. For now I'd just remove that test for pidfds > imho. @Matthew, any input on Cyril's question please? Kind regards, Petr