* Re: [LTP] [linus:master] [pidfd] cb12fd8e0d: ltp.readahead01.fail
[not found] ` <20240318-fegen-bezaubern-57b0a9c6f78b@brauner>
@ 2024-04-23 13:52 ` Petr Vorel
0 siblings, 0 replies; only message in thread
From: Petr Vorel @ 2024-04-23 13:52 UTC (permalink / raw)
To: Christian Brauner
Cc: Cyril Hrubis, lkp, linux-kernel, linux-fsdevel,
kernel test robot, oe-lkp, ltp, linux-mm, Matthew Wilcox (Oracle),
Andrew Morton
Hi,
> On Fri, Mar 15, 2024 at 03:49:03PM +0100, Cyril Hrubis wrote:
> > Hi!
> > > So I'd just remove that test. It's meaningless for pseudo fses.
> > Wouldn't it make more sense to actually return EINVAL instead of
> > ignoring the request if readahead() is not implemented?
> It would change the return value for a whole bunch of stuff. I'm not
> sure that wouldn't cause regressions but is in any case a question for
> the readahead maintainers. For now I'd just remove that test for pidfds
> imho.
@Matthew, any input on Cyril's question please?
Kind regards,
Petr
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-23 13:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <202403151507.5540b773-oliver.sang@intel.com>
[not found] ` <20240315-neufahrzeuge-kennt-317f2a903605@brauner>
[not found] ` <ZfRf36u7CH7bIEZ7@yuki>
[not found] ` <20240318-fegen-bezaubern-57b0a9c6f78b@brauner>
2024-04-23 13:52 ` [LTP] [linus:master] [pidfd] cb12fd8e0d: ltp.readahead01.fail Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox