From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A383C4345F for ; Tue, 23 Apr 2024 13:49:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 947E46B0106; Tue, 23 Apr 2024 09:49:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F78F6B0107; Tue, 23 Apr 2024 09:49:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 798526B0108; Tue, 23 Apr 2024 09:49:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5BFCC6B0106 for ; Tue, 23 Apr 2024 09:49:34 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F0755140F87 for ; Tue, 23 Apr 2024 13:49:33 +0000 (UTC) X-FDA: 82040929026.21.63B6ABA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 6F8E4C0009 for ; Tue, 23 Apr 2024 13:49:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uWi7oEC1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="bfeC/poB"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=v7xoW3W8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ecrfcJ4o; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713880172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=54otsI6UoDqq+k+Xp9PPa5eDRRf1d2Mx1uUAtmPc1nE=; b=2zZihnmR8zQ6kX5YKa0VnRZlmdEWSKSHCuErPTbxa9VNYUs+IKch0SQzs+v3f9/KpcPVvE M/Lq6X3qKqPNhkgIfLShdp2rD3/A2BVgOyptvdZpHBQniV6eJmN7phU+M4XpvDH//UXeq7 RuJZ1AsEeUF0OBH9XDeZ7L0VtQVKR14= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uWi7oEC1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="bfeC/poB"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=v7xoW3W8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ecrfcJ4o; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713880172; a=rsa-sha256; cv=none; b=pnh2rcAZJ901B7fPo71qYW86ptm1ptsq5JwjpnXRWyUVkOq0umWLZcP/5YY8w7pnHTwfpO fFCKF5ImdnMIkNTToKVWUdrBApZ2Q4r3wTfIwN4mmE1rSUTIuUfeP/LdeY1lvt62vItctp 7BAGOUMy0zqQiyyc3deGjwFfkWZih2Q= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5ACC25FFCA; Tue, 23 Apr 2024 13:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1713880169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=54otsI6UoDqq+k+Xp9PPa5eDRRf1d2Mx1uUAtmPc1nE=; b=uWi7oEC1LjmnzCwJirxtgcLddCwnd9NotMB8y7eRO9J9kGaDCe+rOmCjEVCVg9h2cjw5Yk msPVQj2z5TreO/tsDdFzjqCDU0iWfxRnmwjUPY9Q/410gWvVz2tuHA0C8JM29HQB5yfgK5 uSCCtyBJxJJbAu29AGHnGnrt9b1zs0c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1713880169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=54otsI6UoDqq+k+Xp9PPa5eDRRf1d2Mx1uUAtmPc1nE=; b=bfeC/poBWxtSr94p6O5hAG6FYErmI0upu0VH1RgrY+qoBJ3dvgUGfZewJKznCz9Pr8tymr TEGg2403KrLE1nDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1713880168; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=54otsI6UoDqq+k+Xp9PPa5eDRRf1d2Mx1uUAtmPc1nE=; b=v7xoW3W8AAYjvlxIVXWQwGqud55udGK5f1upOXiEuBsyvkRJpUn15V4gmfENMwNiMGT8Qh /Nb3uDQNCzaqz4cEcaRi0gxiCTTsFGnxkkj8aK/6SKm1Gu2Yq0qH7s3JZ+0Rs+lro4KD47 nF4SYUQqwVgHQ9w5XnKhGmb2+FcYAVY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1713880168; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=54otsI6UoDqq+k+Xp9PPa5eDRRf1d2Mx1uUAtmPc1nE=; b=ecrfcJ4oxak7KaLj9A+5Cxr6ZMfddeMazoCRfrPaFrX5pqCcxyG7XQUDCghu1zJyaObgRn JFouHs3ce8B7nWCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4161C13929; Tue, 23 Apr 2024 13:49:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id AB2mD2i8J2ahbwAAD6G6ig (envelope-from ); Tue, 23 Apr 2024 13:49:28 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id DF70BA082F; Tue, 23 Apr 2024 15:49:23 +0200 (CEST) Date: Tue, 23 Apr 2024 15:49:23 +0200 From: Jan Kara To: Xiu Jianfeng Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next] cgroup: Introduce css_is_online() helper Message-ID: <20240423134923.osuljlalsd27awz3@quack3> References: <20240420094428.1028477-1-xiujianfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240420094428.1028477-1-xiujianfeng@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 6F8E4C0009 X-Stat-Signature: 1wjkft8fumf6iercen3dmo7wped9wg1a X-HE-Tag: 1713880171-710561 X-HE-Meta: U2FsdGVkX1/jgLA5TT1KW9/rPTljJkTTHz3bTwzJ8vavuVlXoqz/p2/OtFQHshXoDjotRoKm1mXM+9JQIC/nYvK+vINPcIfBOv5NixYyCx6nOrSIqcM9A6M5npFd9Wq9VS4g7teLOJq8/sK/bW5F8wQTDK161+cQyuVaI3c2HRn3L5hBYm//TTvZ1qPp8PPsFpmILZoVRKhRJHvoynZS2BdK18suLEo4hJU1xmFNvyr/YRYX5j5FKrLa8mTSdbY2Ad6M/46UV9D+BqlaYINsE5EMFLrC8StE5+8P3/nVhRRMdeGMRGszdr8NXuuTm7b3iBqMTh0TR7lDmcb+7wck1wc64prN0tt7Ihq/7VPNlbA/8v06il8AaJUY2sRKm7DbZf1sxx7IlYe4kRk9DEMApWbmShigRIfuFXmGuTZFWcxQqwDUl+rXbdhSarc7wEBbaslK4h2BTF0sTvokenUQBH+QIL2vyisBrf2ZCPT0y81rnwkw4ardijlXeWCDqTH2a9xaMjz2206B5pGPw65fZvhwum5trwSJwJIA8RjDp8r487EuRDyBi946GHuAgIxRvCP1Yd6TMD328lsmbq9etamgZRP33t30MByK8vtS59z4dfnJPMqEcd6mObXNT3Sz/W4s53Tw1A8mtgR74PVU40ifJNThTMX1jixk8Fwab5DKh123pYD9DuHKGY7ec6rF0SddLK5MlJYmokejWp9wBYpc/6yiN3p9xECniz4U8O0Oem2O18z4Wfx8q6Ot2K0KLxM3/pp1dEMS/5LcGxllLsMAMzcBGGxurDClUqDSYVtzzuWnlALR45OzsOTLqGOtAwUEabt+8swSk4Ce1Z8hhUaw9/Rq1yVr0R2QIycVb3hXXVK7mbeA1ykM8ANDIhdmT1j9+yfq31wTpByXNTqda8zwb/o1Ci7zdUsEkOz6h+sXw9Xig6Cv2osDF+jEVxpzXAaFTDEKjUipiOReoch DF0KafXL jr1wiFsYkUDZN/9DxwuqVdOECYK2aUM4Ou/q2VCTu0JhGAKe11EsecLpBQQM4W2EMxzSz3lsWCDvJTePZcGCt0PIHefTo2T3nBkzvpKPbzfAfUE8kNQ/ACVSs4Tmh0XhHteB8FNB1uoy6SfnBnCt3H875hUhe49BKggX6KliiapyzzFoCLNwktZVR7+io4ohPirYM+ajGTP1K94u84nxs1iJhNm+JQbwAX59FMz6OtuZNusLsrq7LhSbCJyzo9xCtKvbvMk8vdqFjaEH2kNVAVYPAWVV5a9ElNazdKzIOxyTiUSSvmIwiCT5ntGRshFHDo2fr9nYM1qroyIOKrh8uMeZAeHkRQVceSoqtNrR6kdTCD78Dn2MrxRUfpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat 20-04-24 09:44:28, Xiu Jianfeng wrote: > Introduce css_is_online() helper to test if whether the specified > css is online, avoid testing css.flags with CSS_ONLINE directly > outside of cgroup.c. > > Signed-off-by: Xiu Jianfeng Looks good. Feel free to add: Reviewed-by: Jan Kara One style nit below: > +/* > + * css_is_online - test whether the specified css is online > + * @css: target css > + */ > +static inline bool css_is_online(struct cgroup_subsys_state *css) > +{ > + return !!(css->flags & CSS_ONLINE); > +} Since the return type is 'bool', you don't need the !! magic in the statement above. Honza -- Jan Kara SUSE Labs, CR