From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 211FCC4345F for ; Tue, 23 Apr 2024 18:10:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9732D6B0162; Tue, 23 Apr 2024 14:10:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 922FB6B0163; Tue, 23 Apr 2024 14:10:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EAE66B0164; Tue, 23 Apr 2024 14:10:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 60E4F6B0162 for ; Tue, 23 Apr 2024 14:10:05 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E1F4AA136E for ; Tue, 23 Apr 2024 18:10:04 +0000 (UTC) X-FDA: 82041585528.18.DD0996E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 30D69C0022 for ; Tue, 23 Apr 2024 18:10:02 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="o2/ujoUL"; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713895803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dGsm+ggZOlHU5FtufmukiaBNtRIWnNG+uUCPTczYIiY=; b=7za+fJYAfwL2v8336kLdPB5Z13wLpu8fy2rfz7xCokqF+ckMtwXZavkAuUPFdSFslntaTr XHqidE5rD6sAwsxbmYMag4xI/bE2M4yJZPwiDii+1ryvA1czMX085RCbWs1sVU+ZUqsPmS R1EExSJZf7e2tdCrEZE58DLAZpmbBnQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="o2/ujoUL"; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713895803; a=rsa-sha256; cv=none; b=beDYJaSWMaIrXydTkrNvgDWba4ZTsd3q0WwYiFea5u4ZsmHwc5MsGtcW2iyNY8h/Y8PJMM 1R+MlpTEx/kYsUdsPQ9s+NTig9nkym/jXOP6h6/FqKTuXPlUVHtaGbmSPmC9IlJvNoHq07 eEcJCj5d0BUjJ/jnRnPibj1epTTCZAY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0065861693; Tue, 23 Apr 2024 18:10:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7736BC116B1; Tue, 23 Apr 2024 18:10:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1713895801; bh=yWwuu1e4Hy/gDnhnwnLfWKeZpMIKvT0w/k6BBM66aAA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=o2/ujoULwF6bOMvmsYyRuy1cgJOOfvjqUuYr3RWSGnano4cCpwN1hDcCa7/8PlzFp mnzXeuxkZ9NYm1X5bPcSsytb8gt6l5iNzWmyQs7I7kJxwApRcSAsm70/ejO+d0PbVz IljyuzZNxH1bz9VB3gcotsfAmMtsR36StvR2Sc2U= Date: Tue, 23 Apr 2024 11:10:00 -0700 From: Andrew Morton To: Andy Shevchenko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Rasmus Villemoes , Johannes Weiner Subject: Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function Message-Id: <20240423111000.aaf74252a07d7e7fd56d7e12@linux-foundation.org> In-Reply-To: <20240423161506.2637177-1-andriy.shevchenko@linux.intel.com> References: <20240423161506.2637177-1-andriy.shevchenko@linux.intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 30D69C0022 X-Stat-Signature: pdrmjhcwpkmx4s164c8ubo3bchgaswix X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713895802-220379 X-HE-Meta: U2FsdGVkX193m7P9wDpZ+imeu6vxchriRz4dmRXtV7WGFuCZHZ07xdyrS43jsKZY7NJ+mHDlU5xN+gaLG7CEcLuQ94+kgOJVoZ6Xk9w//i16X9N3s93NPJzBOzLJMykuLcv5YWKoXxsnPAVmwl4Q3kj0n5wgPf5bPX0Zo4EZelOs7J22PF0o3ifHN5DzZ/7NQ7f8zrc9Hw/nNylQd1DZDtl9uzVqxYcHLqbbqtVABwfWM7EYq5wPqpEMlM+sv8YzAfOBXn01T1chqI+tpFy5pLf4P60Fh6jfW99F8Oxuni7SdN9QluOcorXz3MBMPHaPWcXSPvafDJIyQzBq+VEq5GQrW2Se7gSy3XuC1ditHkFg4/17GCOcN6hj7oziRpsZDk4KX4ywt2lfw2lD6Qjm9eHLmHBdta3My2UKH3wpd8pwc8dpyxaZ2qegO2MTvE29zHcGBnxAJiUISCZUtYHk5wN79wOy9dwI+QonSfSCXf41ab3xXUkO2g1sA3MbEZTll+XAnYHT9xypMmQs4rnmikZz0ndcdLStAYNUc3Lw3Cph2PysIYsqp5Epfvd4GeH1Ji0heoZS2BUWs36Vuj+JkSqSQFHd1RS69Z8k3FFW6sf4huzbB0Jgh7bzbDDUz3f2N6JTTexL5cMNM5NWmJnjHtcmQolGgs/K3qj20xWhhYa4ZJLMJd4By9MMKbqK2vPnjYxtVpR6s2fr3WCKbIQQcqFjuuRqI2UxtivdynSTCErtmCpfOKvUYzHdUqzkdHGS3Mz/ElBh+16L8+sPK+7XrLx9ND6vgRK2BGtfEwtzD8aiIrOHY+ckdDcxFq7TTjuKMZrfXDUQS3MKhmDSGbqZg+zA/qqrcVAEjVJmifBb3Rtx+l8yb8p5lkaGm/O7D+A9eJtIVfgMI+nobCPuONnzifivlDPBdapzHtU4V3CbF2gR8HGl1PPMMJ3Wy6Dd16GmRmK5b+iU+PWCIkUxpnN s95PU8xD IttIcNPqEYE6C09pN61a/Mu/7mCKftU61lp8AcuLk7r5oj5ufJUc+F2HjnO31XMIKs1ZZpm7ter608Mevu6Y+fHXv+QLrXSZxSGnVSCrSzqHRhGSy34Hu4YN0zV/FzXx/szksiSptGm4FvbfNOZwS1YGMgHQ5XI672UX3r+n5tyMLr97/Qen2/dzRXXpAqn2QUbfJvm0bNVN1lVh9WjfLbX3/CNzldcHp9XW1oAOhjE73RNmKuBc+KjTD5MlAPzwcg+qGmcSr+MJ6LV+POORPoblDWHeJ3ZYjMaMN6BLod5VA8pI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 23 Apr 2024 19:14:43 +0300 Andy Shevchenko wrote: > In some configurations I got > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function] > Becuase the only user is guarged with a certain ifdeffery, > do the same for add_to_free_list(). > > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -653,14 +653,6 @@ static inline void __add_to_free_list(struct page *page, struct zone *zone, > area->nr_free++; > } > > -static inline void add_to_free_list(struct page *page, struct zone *zone, > - unsigned int order, int migratetype, > - bool tail) > -{ > - __add_to_free_list(page, zone, order, migratetype, tail); > - account_freepages(zone, 1 << order, migratetype); > -} > - > /* > * Used for pages which are on another list. Move the pages to the tail > * of the list - so the moved pages won't immediately be considered for > @@ -6776,6 +6768,14 @@ bool is_free_buddy_page(const struct page *page) > EXPORT_SYMBOL(is_free_buddy_page); > > #ifdef CONFIG_MEMORY_FAILURE > +static inline void add_to_free_list(struct page *page, struct zone *zone, > + unsigned int order, int migratetype, > + bool tail) > +{ > + __add_to_free_list(page, zone, order, migratetype, tail); > + account_freepages(zone, 1 << order, migratetype); > +} > + > /* > * Break down a higher-order page in sub-pages, and keep our target out of > * buddy allocator. Thanks, I'll queue this as a fix against "mm: page_alloc: consolidate free page accounting". Please do tell us the config when fixing these things. That way I can do a little bisect to ensure that I correctly identified the offending patch.