From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB4DC4345F for ; Tue, 23 Apr 2024 09:46:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DA1B6B00EC; Tue, 23 Apr 2024 05:46:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18B2D6B00ED; Tue, 23 Apr 2024 05:46:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0514B6B00EE; Tue, 23 Apr 2024 05:46:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DA8406B00EC for ; Tue, 23 Apr 2024 05:46:22 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 88C6C40D61 for ; Tue, 23 Apr 2024 09:46:22 +0000 (UTC) X-FDA: 82040316204.25.333CA5B Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf28.hostedemail.com (Postfix) with ESMTP id A9BE6C0015 for ; Tue, 23 Apr 2024 09:46:20 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kQoJPqaE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713865580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yVtlhO4s49xZU1ItPoCI7JLpDg0ZBrWqzgWF+JfN10w=; b=dkJoDXxc+AOh2msv5mfpsnlPdo6P7Wkfrot64xIT0y9u/VmRPwdiknhlwVF4/vSGqRWIBz s2HM119gfrGsDtQI5tKr/5n1iU+cRz9kENCIyJZhzvx/4bdtCkAjVDWFlsduTeX87KWsxr ByEziQX4YFN5CU2wqhlicMxgolYvXcg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kQoJPqaE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713865580; a=rsa-sha256; cv=none; b=2bPn6JNPkhB2xwfcO+s4c/iqHmlJOriBMhaqwqKjqJW+Je8zm+MN3RhbytRy/TKyLiQnKy 0ofjfljTCLlTmCoDoDe8HUirxty6k1DvjRDThIkY56+AT7ALr2yGJQ826aNkdogxpnBXai xEuqbD6f3YdDx9jiqdw3EovhCL3neSY= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6ecec796323so5509845b3a.3 for ; Tue, 23 Apr 2024 02:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713865579; x=1714470379; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yVtlhO4s49xZU1ItPoCI7JLpDg0ZBrWqzgWF+JfN10w=; b=kQoJPqaEmFBDNYnLqifaAFxTJWu9RM4vdcWVLK0VD9q3k3asoPNGI49Ym0bwqGDeMY xIt5fsQbK2JDl01Xidb8kLxAdrk76M4MnR9S4U4eFQTd5nwwjjgctlG33uqTwjQ/ZlOr A6saTlJEwuIL6YVKnmmJuC5vUaSVqGpN90hC9W5cwmq9M32LRir3Y0XcgUWU7BQeNJ2u 4MozoOt8KFv7G3BbL7UmVFYaogoFyo6BFtnPpmczBd/UnQ9OjpqsZUSCH0OkmgY0oXcL TM5hWqc2FfCiSrGwD6J7xrmOEFp69jzEt+FOYqc+W/pgDpAyswfjX72n2pSWUV64TbGX NgEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713865579; x=1714470379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yVtlhO4s49xZU1ItPoCI7JLpDg0ZBrWqzgWF+JfN10w=; b=Vye4qdtArJlk/ABkgR5ySVQxxXseKvIxAkpcPpWAKbiI6zQ2JfYETIdmsrQlT8dsDJ 8T9xHmAmZVs0Cra+6JLG2mAMpScKn3yIpBd766amAlwkACKoXldoTNhJrce20vTne+6x BXDusBPB7jNEC5C+qz2cQyO3wHTlysw4tPhqbAaNixg4W9wu/q6H1DbAJfK4OmZcTgjz LUKs4RAxxpl+RiioG3xRKbq2Yx0KTY2U3TfT6gmr5HdGG5g9aQn1Bpjf6i/pD7+giWBj 6hX5ZmLEcrI4khkeoUXz1w10fWnv9dXDqf2yl/mMfysQrih7wYrMG4UmF4sWS8JWh4A0 eMvQ== X-Forwarded-Encrypted: i=1; AJvYcCVIaB0MIDpfde2myFPwa0Ouy2Y0BcIOdfzHG1zQJK9wy9x4gkaMlzByShi9k2V2cSrQNATlEB7+5yZI/3df5lZKPeo= X-Gm-Message-State: AOJu0Yx7x8qrOSfVUGbIcB9BcwaalXymUiAHmZnJ4bVu4EzaQkgfmS/Z W+j5jt98HtihOpTE+hS78r+bUQdGO1vjXVar3Z4XJCR0PIRkZK8C X-Google-Smtp-Source: AGHT+IEf8WRPrYdPf3as1sxPJI+z/s1TRXy5Vez+91vpeFVQd8HzW9/Uy4tUN6IGCeOvsjGo61E3Ig== X-Received: by 2002:a05:6a20:7484:b0:1a7:3b4a:3e8 with SMTP id p4-20020a056a20748400b001a73b4a03e8mr16826796pzd.7.1713865579527; Tue, 23 Apr 2024 02:46:19 -0700 (PDT) Received: from LancedeMBP.lan ([112.10.240.252]) by smtp.gmail.com with ESMTPSA id fa19-20020a056a002d1300b006e57247f4e5sm9214399pfb.8.2024.04.23.02.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 02:46:19 -0700 (PDT) From: Lance Yang To: baolin.wang@linux.alibaba.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, david@redhat.com, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, shy828301@gmail.com, wangkefeng.wang@huawei.com, willy@infradead.org, ying.huang@intel.com, ziy@nvidia.com Subject: Re: [RFC PATCH 5/5] mm: shmem: add anonymous share mTHP counters Date: Tue, 23 Apr 2024 17:45:02 +0800 Message-Id: <20240423094502.4080-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A9BE6C0015 X-Rspam-User: X-Stat-Signature: 6rfee1ftyskphck7tyqgdyihcoy8nmzq X-HE-Tag: 1713865580-702561 X-HE-Meta: U2FsdGVkX180RMVdqpus4JabWq9UMzs1ARJnZaR2k10czu/Wac6lItK4h5k3gxw+u9nwV3mLgj3QTiuFEL4YCDzYz5Hw9vV7muTbwG3xo5bmv9TC8Tj4kLy/gyC0qtYFsTiq5DjhZTWJ7utayURMMB6MwlLr5tTeObTbN5pBLHzwZNyrlsyHFh7Dhmc/m7xs47Xm1Z4dGW6qKYU8XCoUig2z/hFEPjGl3bQpnSEHWA5QNWurslHqo/LiWwhxkplhdnvMW+yF3EN84ySpQTGXl7SQOLyyODp8UXZOkCqlyBJ/bF+H2GJGBB1u0ssPEAiAwFCrUa8v1bkh9M6oMxj2y1lW5cqHOhoKI+CQc+yk4l7r/2cfL4QUvVYI5mZ90o4BOMlrESAeOc3ADTdNDA9H7rKokkM7W2dhppWBDo1bHXLasg2j0SAO/Ojx12N8/6LNG1bIREsYMcJwsJIgPpBDPKbSuWRRSfug12yDKuIsDEdKPEfctHGcWjbrjl7Qs1lg9J0QpYu7S2aT7tt5D6BO3qyFljdgU3xYy0uEJfW8BzrY4R+FH9HucR80rmtRV4f/Wxh3YxyYzME/hfOmsydBy26muYV0gffMz64YFoGqNoKczK/8wrd9LHiknMk+TFvCgDyhzHvLbKhIU6xLqPh+2XML5ub8VGPxGtEQkPFX6eMWdRQOvvwMrvJ60fdbA0StuZ/tBAPttt/YXJG/+7N0477RFC/NTOnTS9uSIOIaEzyVY+OdNeHk+yz8LTDvVG7xB9fxRYocNMmYVxGDAzT5ofxwOo5hR/wuXW1NTf3z3oQODOg6FeYBds0K7OKKGLfew66XP/+oTBskYt8IlwdG/C+wG6W6qt0g4Gijc8Zh9Zb+K1OH1cycFSK+kYWPz1qVq9OWLadxqS7o4wVtxJ6TmTxOABYp+lt8QeUG9FFySx+jcDOAD8/zNoooPGHfjSNKf8i1dxecEFry7gS0VOr Kj1Cx/Y9 KVpsIJTHLlCI6QcqY03BATx/sOUChcqiJYU3WQRFWN0reMciCp/VwrG9CZy68SYc1patWLg647Rhj/xci9ZnP0xalIDo6QVNHfTs8n1T8CX5ApqKhnemyzwfOLNZvexuQrazw8LboACC2a5Whe1eslZtG/e1uhjKabMRXuQK/QN2eBYj/+cyJJQoHeOW0i4BULjf2kEIwllwZc+/zFiiJ8XTikMOx8uoVYNa2axKO4rOfRw4z9crpAY4eiWL6eM4CwTp1Ps941yfskGgNwtZvpIpFwsdxZdBrlX7pz0a6v5fE0MfZPU31ftM+txpqtzRrHE585bzIk7Z/TSN63D+wXYRw/k3TmZIrYHaY61HWCjOCXKrBm9YeJxFbtx/tJQtFE91pzy7JKPuARyfss+8w10dGj+fhkkYk5SzBsznuKI5S3yU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/23 09:17, Barry Song wrote: [...] >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >> index 26b6fa98d8ac..67b9c1acad31 100644 >> --- a/include/linux/huge_mm.h >> +++ b/include/linux/huge_mm.h >> @@ -270,6 +270,8 @@ enum mthp_stat_item { >> MTHP_STAT_ANON_SWPOUT, >> MTHP_STAT_ANON_SWPOUT_FALLBACK, >> MTHP_STAT_ANON_SWPIN_REFAULT, >> + MTHP_STAT_SHMEM_ANON_ALLOC, >> + MTHP_STAT_SHMEM_ANON_ALLOC_FALLBACK, > > not quite sure about this. for 2MB pmd-mapped THP shmem, we count them > as FILE_THP. > here we are counting as SHMEM_ANON. To me, SHMEM_ANON is more correct but > it doesn't align with pmd-mapped THP. David, Ryan, what do you think? +1 IMO, shmem isn't actually file-backed, but it has file-backed-like characteristics :) FWIW, perhaps MTHP_STAT_FILE_ALLOC and MTHP_STAT_FILE_ALLOC_FALLBACK would better align with PMD/PTE-mapped THP. Thanks, Lance