From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D44C4345F for ; Tue, 23 Apr 2024 08:40:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 159F36B00E2; Tue, 23 Apr 2024 04:40:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10ADF6B00E3; Tue, 23 Apr 2024 04:40:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F13C36B00E4; Tue, 23 Apr 2024 04:40:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D14F16B00E2 for ; Tue, 23 Apr 2024 04:40:01 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 733D61C1315 for ; Tue, 23 Apr 2024 08:40:01 +0000 (UTC) X-FDA: 82040149002.07.16281DF Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf30.hostedemail.com (Postfix) with ESMTP id 9F49C80016 for ; Tue, 23 Apr 2024 08:39:59 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lveLztr3; spf=pass (imf30.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713861599; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5ihD3jb/Us/Z6Kem6hQCYxCXpK+hNZKDWnNmjR4ycrQ=; b=PbqN4e6zj9Pi/r8uJ75FY0oUv4UBbhrioejwtE9zC5lLWvUGNYhoo7b3GYuD7j6hq72ovB TbqTXmD9p663gy3BzYbtBZjoRAvOVf7JD7TRhASVDzxXFrCrUAmXQBoVSQjTVwfqhgjNAD VASJgB9hEu70g72K/kJmLqIqCLl9/z8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713861599; a=rsa-sha256; cv=none; b=L54MtVYlRySDnro6X6RZELFX6SvSrm+3Hsn7cVAcSC3zBYVQ8nXmgDCH1J6XtK5LgBFXfx ouo9W8SgX2/K9Nw2Kwn1GwV/YziU3R+nS1Mf49f/eYKB3DlAAt01qc8eXoRrNEDaZJ/6wv IGZ5GcmBnR0UZsnVmAMCDKAz3arnsq8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lveLztr3; spf=pass (imf30.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6ed112c64beso4603158b3a.1 for ; Tue, 23 Apr 2024 01:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713861598; x=1714466398; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5ihD3jb/Us/Z6Kem6hQCYxCXpK+hNZKDWnNmjR4ycrQ=; b=lveLztr3Jq/zDh7w8vxhJDQ4aAQnteRC1kTGHcvFiR+3l1kTh8i4UFRVqU+8yLm+4t jaqfjahk7nts3zaTtLc++iR5CaGwuRT4J6A+VTKr+Cb97nqzoqiRTeIQYPk4WA78DUoN ZBoq03010t0OgPGQtaxyecikJ45Ojx9PGxn8tl+vI16O+LoDgVbUxnZ7GB2KIFArKdzA uvPbYvVqLtQgNEPP9hWRLk0LubZlNLmizru5Vu3TLiElIYQJtaTdd2uoLFXfUmb9TBbM +69EBoT0ww594dX79aWoluYI0Wy7infx9HXM54S6r4jAYia8K3LQzuTCS7Rjycv8HprL T7Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713861598; x=1714466398; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5ihD3jb/Us/Z6Kem6hQCYxCXpK+hNZKDWnNmjR4ycrQ=; b=VeIFgcAInCsOjarI4n5zRARTpXttMq48j+W0PzKU+rF+jPd8U4XuYTZJLf7Tzf/eib H5hu862/Haf0vTXL4YNEUz+U6SGEyiJZvPtZFjK/Pf4PNa/h16KYgAUIyGp8+IXbyuOw 1+pU730vO09WHVPBFAfMk7Usp+1xRORfjyecKDaBwDLSg8L7/kne6xrcbenQdv/nmw9w 6AnzLe8DqlY1gX1rFMefMpo1p0IvfhU65ceuwMdNj/pQ+xynMnxI2R1+aeW7xZTqmL2S IksQWqvbuigXgSjmCg5DbS1dIU6L4Dnpepkib2KBA5XCHLkhZ2AxJ/6jrzn91My6IRke YWIA== X-Forwarded-Encrypted: i=1; AJvYcCWBI+xliRU/lMuan8z9+A7crTMiUaXzVHICwwXIhG5/Xr9q4pCuJbao4LDRxz5xzUzOAybKYs4M+XiV1nsVWipZffQ= X-Gm-Message-State: AOJu0YyZUnTTv4m+Q1jz3Q6RJMuYNqnmFuoLtfejF7fwBW3z1K/0uypl Oh6hqjxc6LRtFgXMrBRskXMdaIOAVpH5x1vH9cU9vO/LpbF+40yE X-Google-Smtp-Source: AGHT+IEthgN1iS58ClxkD1qG3g2hjq8TWRx3fBXvqLxwb+i8a3emvKfEUAX+vdn1KvxNMCNoV3w66w== X-Received: by 2002:a05:6a20:9708:b0:1ad:3d93:b71e with SMTP id hr8-20020a056a20970800b001ad3d93b71emr3743979pzc.59.1713861598439; Tue, 23 Apr 2024 01:39:58 -0700 (PDT) Received: from LancedeMBP.lan ([112.10.240.252]) by smtp.gmail.com with ESMTPSA id v7-20020aa78087000000b006f0b820022dsm7565155pff.75.2024.04.23.01.39.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 01:39:58 -0700 (PDT) From: Lance Yang To: baolin.wang@linux.alibaba.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, david@redhat.com, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, shy828301@gmail.com, wangkefeng.wang@huawei.com, willy@infradead.org, ying.huang@intel.com, ziy@nvidia.com Subject: Re: [RFC PATCH 1/5] mm: memory: extend finish_fault() to support large folio Date: Tue, 23 Apr 2024 16:39:51 +0800 Message-Id: <20240423083951.1380-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <358aefb1858b63164894d7d8504f3dae0b495366.1713755580.git.baolin.wang@linux.alibaba.com> References: <358aefb1858b63164894d7d8504f3dae0b495366.1713755580.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9F49C80016 X-Stat-Signature: 1tah639q7tmd31j6yarbb3oeofndzfwq X-HE-Tag: 1713861599-379545 X-HE-Meta: U2FsdGVkX18ZtHxkVHYVfPu/l0jnSSipFzC4VdbP0ahOvJO8Z2bINHhaGxu77WMUIKPCecoJlZCs9C58hsUDan+WwSGzjiwGFqAQgwbLvD28F2DKeottYh46LecWlCfXtZRGfEHudh3dFdf8XoT09xL85cZyu9A35mxlyYvJDerqLlNiZpTX8/E91k/xubpvMejdSEHxB7gQ70diel1KdVdBR13UhqsZK2sHuA7/+FEyGQCr6M4j9uR6BCJ5hr8jwbDY1n8oms/cZJfNTpvQYIDCw8e3aqZSD6u6RsfruOqhkDdGNYFJ/NtZsW/fDr8+cPweA/TTbGRpoG5jkyikYElxNu2cCZqN7lWRiULz8RK0vGzzzJaHu1uSuy264dWXeNmFYv2C8Aq2bxqTQYH0qjEQOC/TJl1ftn2MVNfpA71EvzpeeUjba/m5cLFkx0fygvKdfRDYxV+rEoYs1NN03rmfa4xxUc/bLVqZjxHBTG2U0pJCVhRxYUh3inxv955AJghSRd1QbLyM8p/V+yjfD/aG4S+bGRK02wN0WuvUnmRmC8ZZUVJdx9DTv9J1PjroSKitq1s68C7E7UAQlOtt9hP3teF5fZ1o1+mYRC/HtnNLhxpSV7rQlTYxmxxbqrmd+ea86aUeaxuk3sMICTYXwHiMIOLsavpy7fwLKPzNmwD2zwx3dz2G+sJIcBAK/PFsEkiZsnOWFNuFlxc/GocY+eN1fTbN4/enO/uqRHbALCPYdALOH27ReTUG3o/A4OlAyL9v2+1AaxD6DmdIrVnD9PyGWZ0qJWDiEkoaRc6HKOFaDpIle2fFqp2HFQiAIP7YUvYMRM96ZZFty4j6wY58Qv0p+3amhy8WA5Tfi8i6935kd2k5Ygk5kpXgPFhL/1WZ5RM4zWMBHYJEJRdXxjQTUuhnpuJHuWunOBlAhl8ArURN7x3K4v3Cv6MNBt8nF1soD54TBAkKuJ7ytEGxFD2 VNmTzKCo Xr5oj85OIgXrKYPdrh4FxLnaLM5wNvFDPlTIHwNQ412iAa1HwtWivt91KuCF3D5X0LU/RaXqrEF+Fbiqyi8xfzEhBnhacb/slLtL4mbljMBhtn2SB7qoqfinAX/2TJ7DQej2OsVonxyvwAsqjBDrNBU7P1oNfV6zq1p9SJzPg7dSmtCImBy0QUyuvM//n4ODueCMoRMAnLHxOGGmmg8zD2vRkwbII+7moCVA5aZjSszeKfjC0aa3enDUspmJ7QuDgG8R60+cLsy4jhSRkfDFdQXyTl+yByiDgksO6Fz5jEdqlmk98Sso+7l1ekf/J7sAlTfP7e5Zx5swYbfluJAHNu/uDe+bzcn1ANh8/jmJ/6eEJgNeQdRSYKmksRp/hGpY/OHblaFQSO8rr82FeOjxRllQSW4jJfQsc1mqkkFzGPSd86RRsua9Hh3On6m7UCMFTb+hfxAVYWhz4oTb+wj1Ipqs3Oe6i/c5YOoXh0SbE2q3IlDDaIODgQUvt0RJgqEJ0wMncfCOYvsSkG3Az7TzVOwDpVAeDKcl4k4Ia7b5EDZ71N00= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Baolin, [...] @@ -4727,9 +4725,11 @@ vm_fault_t finish_fault(struct vm_fault *vmf) [...] The mm counters have been moved from updating out of set_pte_range(), so we we may need to rebase against Kefeng's patch[1]. + int type = is_cow ? MM_ANONPAGES : mm_counter_file(folio); set_pte_range(vmf, folio, &folio->page, nr_pages, addr); + add_mm_counter(vma->vm_mm, type, nr_pages); [...] [1] https://lore.kernel.org/all/20240412064751.119015-1-wangkefeng.wang@huawei.com/T/#me2827c26ff453c0fa86f2af9f68f245978b08774 Thanks, Lance