linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Lance Yang <ioworker0@gmail.com>
To: baolin.wang@linux.alibaba.com
Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, david@redhat.com,
	hughd@google.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, ryan.roberts@arm.com, shy828301@gmail.com,
	wangkefeng.wang@huawei.com, willy@infradead.org,
	ying.huang@intel.com, ziy@nvidia.com
Subject: Re: [RFC PATCH 1/5] mm: memory: extend finish_fault() to support large folio
Date: Tue, 23 Apr 2024 16:39:51 +0800	[thread overview]
Message-ID: <20240423083951.1380-1-ioworker0@gmail.com> (raw)
In-Reply-To: <358aefb1858b63164894d7d8504f3dae0b495366.1713755580.git.baolin.wang@linux.alibaba.com>

Hey Baolin,

[...]
@@ -4727,9 +4725,11 @@ vm_fault_t finish_fault(struct vm_fault *vmf)
[...]

The mm counters have been moved from updating out of set_pte_range(), so we
we may need to rebase against Kefeng's patch[1].

+	int type = is_cow ? MM_ANONPAGES : mm_counter_file(folio);
	set_pte_range(vmf, folio, &folio->page, nr_pages, addr);
+	add_mm_counter(vma->vm_mm, type, nr_pages);
[...]

[1] https://lore.kernel.org/all/20240412064751.119015-1-wangkefeng.wang@huawei.com/T/#me2827c26ff453c0fa86f2af9f68f245978b08774

Thanks,
Lance


  reply	other threads:[~2024-04-23  8:40 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22  7:02 [RFC PATCH 0/5] add mTHP support for anonymous share pages Baolin Wang
2024-04-22  7:02 ` [RFC PATCH 1/5] mm: memory: extend finish_fault() to support large folio Baolin Wang
2024-04-23  8:39   ` Lance Yang [this message]
2024-04-25  7:04     ` Baolin Wang
2024-04-23 11:03   ` Ryan Roberts
2024-04-24  3:23     ` Baolin Wang
2024-04-24  8:07       ` Ryan Roberts
2024-04-24  9:26         ` Baolin Wang
2024-04-24  9:57           ` Ryan Roberts
2024-04-22  7:02 ` [RFC PATCH 2/5] mm: shmem: add an 'order' parameter for shmem_alloc_hugefolio() Baolin Wang
2024-04-24  6:28   ` Kefeng Wang
2024-04-24  6:55     ` Baolin Wang
2024-04-22  7:02 ` [RFC PATCH 3/5] mm: shmem: add THP validation for PMD-mapped THP related statistics Baolin Wang
2024-04-23  1:13   ` Barry Song
2024-04-22  7:02 ` [RFC PATCH 4/5] mm: shmem: add mTHP support for anonymous share pages Baolin Wang
2024-04-22  7:02 ` [RFC PATCH 5/5] mm: shmem: add anonymous share mTHP counters Baolin Wang
2024-04-23  1:17   ` Barry Song
2024-04-23  1:46     ` Baolin Wang
2024-04-23 11:39       ` Ryan Roberts
2024-04-24  3:48         ` Baolin Wang
2024-04-23  9:45     ` Lance Yang
2024-04-23 11:22       ` Lance Yang
2024-04-24  3:49         ` Baolin Wang
2024-04-23 11:37     ` David Hildenbrand
2024-04-24  6:10       ` Baolin Wang
2024-04-24  7:11         ` David Hildenbrand
2024-04-24  8:15           ` Ryan Roberts
2024-04-24  9:31             ` Baolin Wang
2024-04-23 10:41 ` [RFC PATCH 0/5] add mTHP support for anonymous share pages Ryan Roberts
2024-04-23 11:05   ` David Hildenbrand
2024-04-24  6:55   ` Baolin Wang
2024-04-24  8:26     ` Ryan Roberts
2024-04-24  9:55       ` Baolin Wang
2024-04-24 10:01         ` Ryan Roberts
2024-04-24 13:49           ` Baolin Wang
2024-04-24 14:20             ` Ryan Roberts
2024-04-25  6:20               ` Baolin Wang
2024-04-25  8:17                 ` Ryan Roberts
2024-04-25  8:26                   ` David Hildenbrand
2024-04-25  8:46                     ` Ryan Roberts
2024-04-25  8:57                       ` David Hildenbrand
2024-04-25  9:05                         ` Baolin Wang
2024-04-25  9:20                           ` David Hildenbrand
2024-04-25  9:50                             ` Baolin Wang
2024-04-25 10:17                               ` Ryan Roberts
2024-04-25 10:19                                 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240423083951.1380-1-ioworker0@gmail.com \
    --to=ioworker0@gmail.com \
    --cc=21cnbao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ryan.roberts@arm.com \
    --cc=shy828301@gmail.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=willy@infradead.org \
    --cc=ying.huang@intel.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox