From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AB21C04FFE for ; Tue, 23 Apr 2024 04:56:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D4E96B00AF; Tue, 23 Apr 2024 00:56:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 286BE6B00B1; Tue, 23 Apr 2024 00:56:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C3BE6B00B4; Tue, 23 Apr 2024 00:56:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E28E86B00AF for ; Tue, 23 Apr 2024 00:56:02 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 831721601DB for ; Tue, 23 Apr 2024 04:56:02 +0000 (UTC) X-FDA: 82039584564.13.054D90E Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf15.hostedemail.com (Postfix) with ESMTP id 7AF79A0016 for ; Tue, 23 Apr 2024 04:56:00 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=W+hY2obX; dmarc=pass (policy=quarantine) header.from=oracle.com; spf=pass (imf15.hostedemail.com: domain of jianfeng.w.wang@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jianfeng.w.wang@oracle.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713848160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TYmvjtB6eucNM5NnkM79EVOBCeXRCqEp5LsJY9gl/ns=; b=gQBZPiwg9jRWc+X8MIG1/f14E902YBheUyQ9HmKub/WbIGoJWD4+gK+mN/FnJDcElA5mPu 3bs6k8xCOJJrzcCH6P3eTXKFV+dCNuCZLQjQyQFTxk208VqDMbXDAnwXj/SgE3TvEDBDY2 H8OAzuc2DKZc9V8ToC2fzLXYkUlObcY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=W+hY2obX; dmarc=pass (policy=quarantine) header.from=oracle.com; spf=pass (imf15.hostedemail.com: domain of jianfeng.w.wang@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jianfeng.w.wang@oracle.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713848160; a=rsa-sha256; cv=none; b=x0+kD+rM4uBpcOjySnbrCkJvYooYp1TGgkWyPUeDDGaNKlhX/qnx/deYnpjszVorqmlBPv YCJjatUuZM6enVmY6QKHq7e0oGP7rymXs/PST8RF8DdO+efR2FCuJI/XscIHTQvCEROGVh xqTl/yKbbiPGSDpcAfyEXaARjqL2Ges= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43N4f5Ac014582; Tue, 23 Apr 2024 04:55:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2023-11-20; bh=TYmvjtB6eucNM5NnkM79EVOBCeXRCqEp5LsJY9gl/ns=; b=W+hY2obXjpHBzJ5uxpOUQGIm/dEuBjxNEG9MnitmtsD1etikTwCNAQiHirUxTVHVYkjV BThFc759JL6qnahETFmEEqdwIFZNiPHDXG+DjPYoGTWQ6c3ZDMitIYzUCnN5Bswna0gV AvGzdUJG1DK1X7BQ1rHDOpFMUVMXaio1kDdHjx797emB5Dgfb+D7zoZUZa4gfXV5DHd+ hNggvjAcNobvgYAqFQqb240i2wv4yLXaesPyGbUg1IiGo48PjqrBDzumQS89E7lN/G7w HCtjcpf3ftT2aAAeV7y0qEcjtbi7PFS7IAIWHeBMNo6zlJI6W55tMoExSqk1xN3vs5q+ yg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xm68vcbad-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Apr 2024 04:55:58 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43N4LNos034390; Tue, 23 Apr 2024 04:55:57 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xm456n1cm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Apr 2024 04:55:57 +0000 Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43N4tt9I007016; Tue, 23 Apr 2024 04:55:56 GMT Received: from jfwang-mac.us.oracle.com (dhcp-10-65-141-153.vpn.oracle.com [10.65.141.153]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3xm456n1ar-3; Tue, 23 Apr 2024 04:55:56 +0000 From: Jianfeng Wang To: linux-mm@kvack.org Cc: vbabka@suse.cz, cl@linux.com, rientjes@google.com, akpm@linux-foundation.org, jianfeng.w.wang@oracle.com Subject: [PATCH v4 2/2] slub: use count_partial_free_approx() in slab_out_of_memory() Date: Mon, 22 Apr 2024 21:55:54 -0700 Message-ID: <20240423045554.15045-3-jianfeng.w.wang@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240423045554.15045-1-jianfeng.w.wang@oracle.com> References: <20240423045554.15045-1-jianfeng.w.wang@oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-23_02,2024-04-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404230013 X-Proofpoint-GUID: Fk9-8NlnmSmyya_0vFJXTo5m0hs8oQxj X-Proofpoint-ORIG-GUID: Fk9-8NlnmSmyya_0vFJXTo5m0hs8oQxj X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7AF79A0016 X-Stat-Signature: eizotjb366n3k6jaq3iq75uj5hf73cke X-HE-Tag: 1713848160-20488 X-HE-Meta: U2FsdGVkX18zZjQjz+iASudsK543EmjgbFITajWWRv0Tf4BeKL2Zuxwfx3YLAPaf889aZAlGLWryMCy69O1cUMIjZ/Rag1dHdv2GRSXnxuvCTNNbnpULZGB/xvSLzloKaxeljVvedkwBUeHl5L2uOsGNo7n23v+uqbQLYvCcI3yl/sto5wIovPrzJLw92dkChWhqoDdrrE+rVLHvgmyU1oSJsOVUJDygG5UA7R72W4WWglCvUktl5DUO8xBilNeFr5zS2xu/3RDoH434smufVywauGh0lmHkTyMNW9m2LBSuPatHoL7Fl9frE20ud0ROV9T/IC1X5q/xxxJFZGw7I0l98GPGSb2QmD5QlXZjtjM6v091XlVSOoMxSRXtM8AFYhdI01v821FJ4t5Z0AZMX3vwg6NxMJQs3qZg0KnVC1ip672tZwtTWSN6TPBBpJm3CCjU6bLvh4UvoMtzIl702Mu3X7IcLmsTDPw5OygFuYtq6B/dfEXaRr9HrltLIsrjL65wxhb7O5XBuPKcK58xHaZeZwlmcVgEIx2DTMTBbdsDyLFHamcJYNHpc5CFHe9bweObKR+zCqgzaoPGZFVrHf9ND+z0Qe5p8bQ8zKpd4MmD84wIOQMBPZKlOnAuKM+H3UvBiNWIxB9M5L0CaINVoS50rsd6r9mxAEoT1dXFZl2aX4KbiDq87WUevF2SiyPv1qIkcUcnu0QZkXIw46Etd0F7f0I/E4cETY3CMBsowoFi8uoiVgJGcLQS9ll1niFZvMkP0szreUBrO2J6u8A2pgUc8C0hW7ptanKp2/DOZjQBSvDSMSxD8AllgyJI/ACxEh2w3qo15ng8D4wxU9JWCDlEWV/62fTqsh36yk6MKmS9ImC9cO4g+mrhTM3NxrfrxheLcePpVA/3grAY8h3V7zQr2Hp2ZlTX1PVO9maEscbxqqxQ6TeZK0TN9HO71wullDLR5y9De0wCbIfqs4n N/nOqPuj YG6UCIa9ZnekMaKNgtjh9rf6PBDbCibK8Ubxv1Z8NMPZtsgOiDxoaUBS6FY2TOCioZtY5ls6x08aw5tljKU1M2eYqw20ZnmIf+IQcNjK9yoDPlQiVoXqYRJDMBYu2aWjFRlQy6mNnBCHSwtDykhDAq3PYidDT300Edo46F5Ws9hCpsZt+CPAmONkgrcDn1ItWevs2jz+avDnLwDG0sbemPx2ynRKshB3t07EVYLiKXUGwO/J9gNSdSTeBFWq++LhV8asjOnBauRU8zEdu54rWilfs8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: slab_out_of_memory() uses count_partial() to get the exact count of free objects for each node. As it may get called in the slab allocation path, count_partial_free_approx() can be used to avoid the risk and overhead of traversing a long partial slab list. At the same time, show_slab_objects() still uses count_partial(). Thus, slub users can still have the option to access the exact count of objects via sysfs if the overhead is acceptable to them. Signed-off-by: Jianfeng Wang Acked-by: David Rientjes --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 6d8ecad07daf..5c112817160b 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -3292,7 +3292,7 @@ slab_out_of_memory(struct kmem_cache *s, gfp_t gfpflags, int nid) unsigned long nr_objs; unsigned long nr_free; - nr_free = count_partial(n, count_free); + nr_free = count_partial_free_approx(n); nr_slabs = node_nr_slabs(n); nr_objs = node_nr_objs(n); -- 2.42.1