From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B74C6C4345F for ; Tue, 23 Apr 2024 03:41:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A4236B0093; Mon, 22 Apr 2024 23:41:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02A8E6B0095; Mon, 22 Apr 2024 23:41:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D72DC6B0096; Mon, 22 Apr 2024 23:41:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AF57E6B0093 for ; Mon, 22 Apr 2024 23:41:33 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6FEE6A0C06 for ; Tue, 23 Apr 2024 03:41:33 +0000 (UTC) X-FDA: 82039396866.25.B7C0B46 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf16.hostedemail.com (Postfix) with ESMTP id 9409A18000E for ; Tue, 23 Apr 2024 03:41:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=VwS5b+qW; spf=pass (imf16.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713843691; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P0uuoQxJ0kINjaQgEP7wqVGQ+5rr3s87tkW4G+81Ziw=; b=K2CtcF1JTGQGoLaMgPc1bes6UConNPw/wujrbn5Ln/i/gaGANlXuiZ+5/kTiVPOZ1QWZNM UjCSRbG8QzKsUy8G/vsa6es4+r/w5ona8IkvkWOBdnSyFjv+oRGoa+vbhCsX9A0x9JIuYz OeSqXNcUssqPV77YWQGM6V2vcGBpNVQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=VwS5b+qW; spf=pass (imf16.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713843691; a=rsa-sha256; cv=none; b=lPDkljXkHW0CcxWFCJry0dFHNdm4AjN4ZMdKRFXXvJ9/CWVqcjMXWe23I3FlCC3xVGxqaX s5zNLSYDBYl1vDxE+BmqivmY3ptHl1pC2nSBMyPRg6qm5nmx7l1kDGuJ6FyqJgRCFYBEmz mIuRA4aP+QMKwC8D2C2E8RDSPM1rR7g= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6ee0642f718so4301843b3a.0 for ; Mon, 22 Apr 2024 20:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1713843690; x=1714448490; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P0uuoQxJ0kINjaQgEP7wqVGQ+5rr3s87tkW4G+81Ziw=; b=VwS5b+qW+gb5cERq64RzuvjIrRL+ElmmO6Tz9sEKTfdnrwYo3IqWeg4AHTgXU49XXd JXlamDrD1PaneY4UyUBKjnV5JcxWiUz59C5LefbhLPjeODtvdPIDKTVSAxSKHlqLtSAr v/XMNxPVbiuH6JoxzwyE+Qj3WfrP04h5g5047GxSyojNOq9vKScBBQONux2dZypoPJkU 1P5ydcYYfzRHF3cuh/GfuFhn5JdEpjFM1LLt6gU44lESF1htYjXGDkJ9Yhs1hGaZtZuG CtksX310BDLYF8xw+edcuebFCs9ZhkG+gJnZYS3GyIBbH2YBpA/hbuo+G1e8U9dljSeb vN1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713843690; x=1714448490; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P0uuoQxJ0kINjaQgEP7wqVGQ+5rr3s87tkW4G+81Ziw=; b=gdKqwFsMJYEp5tOVPDnR8n29Gc+vpgdROzEkR3BadRvhFs50Vhq2PniEoytR7+iNHS Vbpt/EQJej5MthwGSicwSJnatEC/ela3cmiy/vpmSn7PjHFPYeWdjCEhTIXSHtzxWax4 055u/47fcVB5tI9QLlX5AEp4vuXYf4it3QbSBlcz1zXZsYNP+h9yqOqG0QFx2DO+9lV0 yQpF+61wAHjt0Pil8/fdsvqnw/35g7CCCFeHyz+HHYcd7W3yK3di0IgLqYaU5l113xfI LP8vL+UmuXA37mbutdYtVyxFTRGMg0Oj7uCMPusMYkzqGvqkd0/vLtI59FdIx+x9WU2V daPw== X-Forwarded-Encrypted: i=1; AJvYcCWyi4WT14Rh24TB2NO7LIZengmi7qRCkmPf9xXOSPcigraqpNy5ZuDpWjdvY/OFB4AASVyhVfvloCx3u7KLoQWKwRA= X-Gm-Message-State: AOJu0YyYKaRkJr15Bib5bCgMBE/WH0ITqxqloSFFXB00gT00zqgWOwQD ZQFGYeHGeJvAGOPfPDGewra/Ke1nfeRT1tQqj0RMfkBnnSMcvKc1si5keXWbn7U= X-Google-Smtp-Source: AGHT+IH3OpN2sFYi3GvJfqyxhabzuW3WUwrv+oQUG4aXzn7ZEeGp3bOQixCyYcifZfO95/rYrfTxJA== X-Received: by 2002:a05:6a20:841b:b0:1a9:54fe:b9b7 with SMTP id c27-20020a056a20841b00b001a954feb9b7mr2176395pzd.21.1713843690300; Mon, 22 Apr 2024 20:41:30 -0700 (PDT) Received: from libai.bytedance.net ([61.213.176.11]) by smtp.gmail.com with ESMTPSA id b16-20020a63d810000000b005e438fe702dsm8266980pgh.65.2024.04.22.20.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 20:41:30 -0700 (PDT) From: zhenwei pi To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev Cc: mst@redhat.com, david@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, akpm@linux-foundation.org, zhenwei pi Subject: [PATCH v3 4/4] virtio_balloon: introduce memory scan/reclaim info Date: Tue, 23 Apr 2024 11:41:09 +0800 Message-Id: <20240423034109.1552866-5-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240423034109.1552866-1-pizhenwei@bytedance.com> References: <20240423034109.1552866-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: d5wiioc6oifgw669pdkbe16kdhrmtxg5 X-Rspamd-Queue-Id: 9409A18000E X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713843691-255086 X-HE-Meta: U2FsdGVkX1+FcQRo9YqicvD55MsXl+DWeDwefxl1LdcDokgT5ojNHC315dbGrH93/VgNE4HgD9VzeTBk2WJEq/nraj45LAU4WcA0RJmv44t73D7UpY9vPxneTRQ3WtLuYzshB9eYzM8UcA3nsHEvXHzMrlvqCO+hkKpK5imQCN8nC56H4W9VAhe6I+v/6hkRVXFBY/1DWZZwjUFrjTxOzmEDKLXwmTLi+MXbq9OcunkFWILJixoAjbbvRndvfoQiCHaAz7lrW9dCFHJwPECfumxZw4QYoqfauVb94nQeVhrl/cA92uX70PVcLVxOmmSqtGT4y26jEdq0BMSMdNFGVSMBVJKr9JjbmRF6cjfvP5gWzWUHeoXKO/O74vo7DH/MPc6TNWp4yrqb2S1LUsEUskygEk5URk+FtnjzpdcJ7IvBYMKYWk0zA8h4x5obmAoNcwlS9Bh4rLe07rB5Gzx/vDic3Jr6UlWXqKwqUcULEN14WkL0zZkkJWi7ULXTCRXHdgTmt1Zb3uNr2pkcEhZJ1swJ8WyBpKHM8EffzisRNTqaJecBUQPPQVmcSWNgRo/q9wEyb3u8Z6VQjc6a4m8yM6PIYffasTNxEIuN3Xj41V9SYrNQu8rddkUHAJkJpo+ZhJA37xJnqDur7KlTyrvVR5XKnRuyQkY01HszdURsesGa+tZ9yQqlq8+4PD1IFdw5SgstP3QYuSqmvtBIVMUOxUHeAK9TGflU/7Hcg4aZ2spR8qLtYRfYtDF8KxX3pXOozlq++Og6+Bdx4FRsgSitAMaX1aNi5WPWOEm68HezAGF5Rmyu11w1iIPjWeQphMXdtHCkFDBR6RU/tFxK3/6oXbloCFx8dEidHIZ0qTzrA6b8a+/3QBEAQ4kNLsuSiSgX+IObRCokaAQ6Vdr785lrgPP34wOqn9S7HDBNcvl8UknGescx3MioCJHwFuYyu662/zSiSDXl255NZdhRMon dQLMDNki I+JGcwr1hyk8rITalQHuurLpx8AFPFbR317ZfDnPjv0UoVErAvQDU054xot1pSKkmtm0TooyXg3LwdycAAaXTY6l5EsfXeP+7Im0HdYMsLtD3TplGqTs/wJPY6x/iT8GwWQh9fEjRH+NsiQVMolLHobaCE1tHJml2N6PmU9dXRe2Rsw8q27lySXSKkuQJmHbDMiOljn309mc+Yh+o9yM4ZyMM0XAG2cxgSd4/HrWNaLlntrIkqnmiiq1ENfhIMSHFgD4thAb1F8uYxkOTqO9Haoo7TDJrOLejwKrvg9EElHWwequTOlFq6RuqHCvx6WhcFPR8wxw2qk39t1hySD0XQNdlH1po0NgrR/ytrinDIZ5jv8W2hmaWH1OyDAGjRSaYHmqU5bAmtdfbpb2j3pggh+YidRj1zXSq4Y77tYr3QDJuNt/GOvBFXBEVqxEy3A+Db5/1IbqB9lMUwf599hUsp98DrrMeadB4fWzmWNu4eKNgJQY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Expose memory scan/reclaim information to the host side via virtio balloon device. Now we have a metric to analyze the memory performance: y: counter increases n: counter does not changes h: the rate of counter change is high l: the rate of counter change is low OOM: VIRTIO_BALLOON_S_OOM_KILL STALL: VIRTIO_BALLOON_S_ALLOC_STALL ASCAN: VIRTIO_BALLOON_S_SCAN_ASYNC DSCAN: VIRTIO_BALLOON_S_SCAN_DIRECT ARCLM: VIRTIO_BALLOON_S_RECLAIM_ASYNC DRCLM: VIRTIO_BALLOON_S_RECLAIM_DIRECT - OOM[y], STALL[*], ASCAN[*], DSCAN[*], ARCLM[*], DRCLM[*]: the guest runs under really critial memory pressure - OOM[n], STALL[h], ASCAN[*], DSCAN[l], ARCLM[*], DRCLM[l]: the memory allocation stalls due to cgroup, not the global memory pressure. - OOM[n], STALL[h], ASCAN[*], DSCAN[h], ARCLM[*], DRCLM[h]: the memory allocation stalls due to global memory pressure. The performance gets hurt a lot. A high ratio between DRCLM/DSCAN shows quite effective memory reclaiming. - OOM[n], STALL[h], ASCAN[*], DSCAN[h], ARCLM[*], DRCLM[l]: the memory allocation stalls due to global memory pressure. the ratio between DRCLM/DSCAN gets low, the guest OS is thrashing heavily, the serious case leads poor performance and difficult trouble shooting. Ex, sshd may block on memory allocation when accepting new connections, a user can't login a VM by ssh command. - OOM[n], STALL[n], ASCAN[h], DSCAN[n], ARCLM[l], DRCLM[n]: the low ratio between ARCLM/ASCAN shows that the guest tries to reclaim more memory, but it can't. Once more memory is required in future, it will struggle to reclaim memory. Acked-by: David Hildenbrand Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 9 +++++++++ include/uapi/linux/virtio_balloon.h | 12 ++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index e6229e548832..225662358221 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -340,6 +340,15 @@ static inline unsigned int update_balloon_vm_stats(struct virtio_balloon *vb) update_stat(vb, idx++, VIRTIO_BALLOON_S_ALLOC_STALL, stall); + update_stat(vb, idx++, VIRTIO_BALLOON_S_ASYNC_SCAN, + pages_to_bytes(events[PGSCAN_KSWAPD])); + update_stat(vb, idx++, VIRTIO_BALLOON_S_DIRECT_SCAN, + pages_to_bytes(events[PGSCAN_DIRECT])); + update_stat(vb, idx++, VIRTIO_BALLOON_S_ASYNC_RECLAIM, + pages_to_bytes(events[PGSTEAL_KSWAPD])); + update_stat(vb, idx++, VIRTIO_BALLOON_S_DIRECT_RECLAIM, + pages_to_bytes(events[PGSTEAL_DIRECT])); + #ifdef CONFIG_HUGETLB_PAGE update_stat(vb, idx++, VIRTIO_BALLOON_S_HTLB_PGALLOC, events[HTLB_BUDDY_PGALLOC]); diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h index 487b893a160e..ee35a372805d 100644 --- a/include/uapi/linux/virtio_balloon.h +++ b/include/uapi/linux/virtio_balloon.h @@ -73,7 +73,11 @@ struct virtio_balloon_config { #define VIRTIO_BALLOON_S_HTLB_PGFAIL 9 /* Hugetlb page allocation failures */ #define VIRTIO_BALLOON_S_OOM_KILL 10 /* OOM killer invocations */ #define VIRTIO_BALLOON_S_ALLOC_STALL 11 /* Stall count of memory allocatoin */ -#define VIRTIO_BALLOON_S_NR 12 +#define VIRTIO_BALLOON_S_ASYNC_SCAN 12 /* Amount of memory scanned asynchronously */ +#define VIRTIO_BALLOON_S_DIRECT_SCAN 13 /* Amount of memory scanned directly */ +#define VIRTIO_BALLOON_S_ASYNC_RECLAIM 14 /* Amount of memory reclaimed asynchronously */ +#define VIRTIO_BALLOON_S_DIRECT_RECLAIM 15 /* Amount of memory reclaimed directly */ +#define VIRTIO_BALLOON_S_NR 16 #define VIRTIO_BALLOON_S_NAMES_WITH_PREFIX(VIRTIO_BALLOON_S_NAMES_prefix) { \ VIRTIO_BALLOON_S_NAMES_prefix "swap-in", \ @@ -87,7 +91,11 @@ struct virtio_balloon_config { VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-allocations", \ VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-failures", \ VIRTIO_BALLOON_S_NAMES_prefix "oom-kills", \ - VIRTIO_BALLOON_S_NAMES_prefix "alloc-stalls" \ + VIRTIO_BALLOON_S_NAMES_prefix "alloc-stalls", \ + VIRTIO_BALLOON_S_NAMES_prefix "async-scans", \ + VIRTIO_BALLOON_S_NAMES_prefix "direct-scans", \ + VIRTIO_BALLOON_S_NAMES_prefix "async-reclaims", \ + VIRTIO_BALLOON_S_NAMES_prefix "direct-reclaims" \ } #define VIRTIO_BALLOON_S_NAMES VIRTIO_BALLOON_S_NAMES_WITH_PREFIX("") -- 2.34.1