From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AF37C4345F for ; Mon, 22 Apr 2024 21:21:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57B8C6B0089; Mon, 22 Apr 2024 17:21:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50CC56B008A; Mon, 22 Apr 2024 17:21:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A3C96B008C; Mon, 22 Apr 2024 17:21:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1C8F36B0089 for ; Mon, 22 Apr 2024 17:21:20 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B3B7A120D83 for ; Mon, 22 Apr 2024 21:21:19 +0000 (UTC) X-FDA: 82038438678.08.86FC051 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 073E68001A for ; Mon, 22 Apr 2024 21:21:17 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NKxMXaW1; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713820878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H0ZYpuVO9wf1wEPoKTrybUEjME3KjVYBau8IWyyJPvU=; b=8dgOrIyQZJ7ADRrhuHWrRzIDDWzO/V3S6K7qhnsvMYh2/TsQRqZ/XVmrT1wKJsSzoKFCoB hfT8aAWRnxo7u7UpsU582LWlZPNo+AgjjUaLljxITZn7vwGZaXYq3g4rEPrgG2VNYtnJex PWH140z9FhmnnaYioWIvToAL7bnG2ps= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NKxMXaW1; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713820878; a=rsa-sha256; cv=none; b=RMa1Ff+6d1msghVyiHSWVQrfByEK0wS4eq07o40WW7SbDoWkopiPpqe0I4Kq9GAbCdQUSo ev2UDGBUSd1ouJNjef+i3OfaXHQ0ZnXUiN63+kG3pRjhkE/QFmw0hCt5AAFSmXNa+kbaO0 xGE4rNNG9V7LY4n0w7wPaAXz8BVNZPE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 125716116C; Mon, 22 Apr 2024 21:21:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F855C2BD11; Mon, 22 Apr 2024 21:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1713820876; bh=imYM67ihv3Fe1HHi/ujfhBDgevfHRJsH7J8djTH66mg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NKxMXaW1BISKZ+xx18wb/+SrPLRRgxkZ93rWsukcaMxXXr89+EbPpBE7TXnPdQCjL fd5+yT0eBb/fzeAejTinfokN9Bjv2yAN3UpZqI75q/XmE3/jXwmsS339Fw/N1PSOt2 IMFYkK3CTuBdBQc3Ua2nwp43SDPBU3WI/y9wAnXk= Date: Mon, 22 Apr 2024 14:21:15 -0700 From: Andrew Morton To: Miaohe Lin Cc: , , , , Subject: Re: [PATCH v2] mm/hugetlb: fix DEBUG_LOCKS_WARN_ON(1) when dissolve_free_hugetlb_folio() Message-Id: <20240422142115.25582386f7f02df817eab8ae@linux-foundation.org> In-Reply-To: <000d75f3-6e16-6b91-7657-afb954773381@huawei.com> References: <20240419085819.1901645-1-linmiaohe@huawei.com> <20240419141134.464ea3a1ef3d0e93c6711c93@linux-foundation.org> <000d75f3-6e16-6b91-7657-afb954773381@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 073E68001A X-Stat-Signature: ybbidxnme4dph6zfsz7reireywifyhpu X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713820877-436780 X-HE-Meta: U2FsdGVkX18l9GGaDTXRXboNCe/XtIBAT/dVlVvIh1xCq3dG9jBYMrNFOh7WQLLXmkkNn9KH1wQec/j4y5md3T8oo4yTd7b7LdF9p0SrlSapN2xX035j4wkHK+irqvxbyghyTALvZsP3BZkpPVFGanneb6gl/Kwvb8LdHST9FNefCEZnhs9mrtpjSOozES9Kz1m6ADQ5Kon3Arcvt65yR4eem4k/oeGVmpJEJqFcVvMrjbtGs3TKopjv2XuPuGNNhDHFxLrlJyqvMpF4Wa/b/x0nYAhtovFzloj+5BfiICnwg4xJVAvwECUXLCsz/fts/cYLvlWBBfZ9QlqulwrhQKiPQGPu2JGuA4SeQfEZCVxxEPba2xqlWjQHy/NSVsM9yOXxQbr1GFykzfnUkPUGpPsQbL8yIYqbpBSbxEPblwCA1rEbnoA7KkGRFcVnaSeo+44wu9tJ4UxWyQUid5xBMmAJY/extLRLZrnKikWc2qy10s7in4qgHRM5f8ND4IBnJU5FgnT7Fvyzgwhm+XPin96M8rgqI3Quocz223UbobvPLc8l1pRG0lTlL/B1NppFV008kE2c2J0hXFA8nx+YA6bxXWhq+wtU4o0L8beEoZgVW4xkVZEzjCzYmywyVPPSInBkXh+Nt6FKypUfCNQUherTCgJ/EXhx0kPEGbmlEmGUP5+TV0k5qi6MF0hf/Jtj5G2V6To7XBOg8XBxTuN6brjgcPZXYRzMqyYarzzT81LxmYcmJjdJnxUQFOj1jhccO31RuKNo+dqKqSQu3MTfnJalyXKOpM8SNOUimIKnamhSTyYKxgMA25UF2LBEDINf9xuzpUZ5aHIfzi/2EIef/b72yU/hog8XRYmITZLauWja+gDXP/9ySIJiudKUx0fdXLdb5XBIbQYE/tPMWycA5XYMALL/N8NMQ71jjBgK7BTB8SQm6mGg2SadoS4QSA5Jxd7girhyEJPKrmRAJ+h ayElGjaI iPFyVsqn2IFdYDlOd9TkEPcgbLpIR593lLGGTLjj7wQgciGIgoRi7Nk11JgGa0N2YMWRyWdpAfoE5+ZK43JxVASHP0i5Yrasr85UkqBHSjGLdwmJdMHv718SPffJLJ24rgihl/LlzY33jvNty6T8rfPM3Ip9nfy/dNwGlupe/bVJ/Ull6Y2ChF8k//kN4CCNQsN6FGR6RcnHn/dBkuVdREvxGxoWYkXoyOiHcZqGPXXleEirg6xsYRSYKldDRS2MB79UdZYk+OSYU/HNfPQ3k3bZc6VMaVH+svpVhwViIsDLQIog= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 20 Apr 2024 10:13:06 +0800 Miaohe Lin wrote: > On 2024/4/20 5:11, Andrew Morton wrote: > > On Fri, 19 Apr 2024 16:58:19 +0800 Miaohe Lin wrote: > > > >> When I did memory failure tests recently, below warning occurs: > >> > >> DEBUG_LOCKS_WARN_ON(1) > >> WARNING: CPU: 8 PID: 1011 at kernel/locking/lockdep.c:232 __lock_acquire+0xccb/0x1ca0 > >> Modules linked in: mce_inject hwpoison_inject > >> CPU: 8 PID: 1011 Comm: bash Kdump: loaded Not tainted 6.9.0-rc3-next-20240410-00012-gdb69f219f4be #3 > >> > >> ... > >> > >> --- a/mm/hugetlb.c > >> +++ b/mm/hugetlb.c > >> @@ -1773,7 +1773,7 @@ static void __update_and_free_hugetlb_folio(struct hstate *h, > >> * If vmemmap pages were allocated above, then we need to clear the > >> * hugetlb flag under the hugetlb lock. > >> */ > >> - if (clear_flag) { > >> + if (folio_test_hugetlb(folio)) { > >> spin_lock_irq(&hugetlb_lock); > >> __folio_clear_hugetlb(folio); > >> spin_unlock_irq(&hugetlb_lock); > > > > Please let's prepare backportable fixes against current mainline, not > > mm-unstable. Because fixes against current -rcX and earlier will be > > upstreamed ahead of the mm-unstable and mm-stable material. > > Do you mean I need to send one fixup patch against mm-unstable and another > one against current mainline? Against mainline should suffice. I normally fix up the subsequent merge/build fallout. If that gets too risky I'll ask for help or I'll outright drop mm-unstable patches and shall ask for a redo of those. This is rare.