From: Nam Cao <namcao@linutronix.de>
To: Mike Rapoport <rppt@kernel.org>
Cc: "kernel test robot" <oliver.sang@intel.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
"Linux Memory Management List" <linux-mm@kvack.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Björn Töpel" <bjorn@kernel.org>,
"Andreas Dilger" <adilger@dilger.ca>,
"Arnd Bergmann" <arnd@arndb.de>,
"Changbin Du" <changbin.du@huawei.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Ingo Molnar" <mingo@kernel.org>,
"Krister Johansen" <kjlx@templeofstupid.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Tejun Heo" <tj@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [linux-next:master] [init] b8de39bd1b: BUG:kernel_failed_in_early-boot_stage,last_printk:early_console_in_setup_code
Date: Mon, 22 Apr 2024 12:18:06 +0200 [thread overview]
Message-ID: <20240422101806.NkNd2Ksz@linutronix.de> (raw)
In-Reply-To: <ZiYrdnbw5z1ajeRw@kernel.org>
On Mon, Apr 22, 2024 at 12:18:46PM +0300, Mike Rapoport wrote:
> The kernel config here has CONFIG_DEBUG_VIRTUAL=y, so __pa translates to
> __phys_addr() in arch/x86/mm/physaddr.c and __pa(-PAGE_SIZE) triggers
>
> VIRTUAL_BUG_ON(y >= KERNEL_IMAGE_SIZE);
RISCV also has a similar thing when CONFIG_DEBUG_VIRTUAL=y
>
> x86 has __pa_nodebug() that does not do bounds check, but it cannot be used
> in generic code because no other arch except s390 define it.
>
> For now I don't have ideas how to make this work in the general case, so
> probably we should only fix riscv for now.
Agree, let's just fix riscv for now. This time I will cook up something
safer, no more __pa() on a potentially invalid address.
Best regards,
Nam
prev parent reply other threads:[~2024-04-22 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202404221524.4954a009-oliver.sang@intel.com>
2024-04-22 8:29 ` Nam Cao
2024-04-22 9:18 ` Mike Rapoport
2024-04-22 10:18 ` Nam Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422101806.NkNd2Ksz@linutronix.de \
--to=namcao@linutronix.de \
--cc=adilger@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bjorn@kernel.org \
--cc=changbin.du@huawei.com \
--cc=christophe.leroy@csgroup.eu \
--cc=geert+renesas@glider.be \
--cc=kjlx@templeofstupid.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mcgrof@kernel.org \
--cc=mingo@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=rppt@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox