From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97BCEC4345F for ; Mon, 22 Apr 2024 07:43:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29C026B0095; Mon, 22 Apr 2024 03:43:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FAC36B0098; Mon, 22 Apr 2024 03:43:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 075636B0099; Mon, 22 Apr 2024 03:43:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DBB946B0095 for ; Mon, 22 Apr 2024 03:43:18 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 86D2CA18A4 for ; Mon, 22 Apr 2024 07:43:18 +0000 (UTC) X-FDA: 82036377276.21.9670FFA Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf26.hostedemail.com (Postfix) with ESMTP id BB0A214000B for ; Mon, 22 Apr 2024 07:43:16 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=PbZycXbB; spf=pass (imf26.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713771796; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bBFXolLQYa78XCdQIXx8hSsPDNH1h31ohatbB+q7SSA=; b=p3atDmANSB+zQ7p6kMqlQJwgmId+DrQaaSeI9cnirdd/H8wr4BH2sTSb/EPlw1dIO6cp8X 7CcBGeBZd3ZdqOgScyfBvEVKG8Yzdt50jeBSeaM7qMo6X1TkFSEzT+e9fvDI9ZCGVKWbkt ubmeg5T/RyNwGx/DL5tlpaf8rOfG6oQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=PbZycXbB; spf=pass (imf26.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713771796; a=rsa-sha256; cv=none; b=GrC4pCJ3gYC2Qadu62MC6Wdsmy2FGpsb4JExRwzrLa2O4geVwMm72J7inHE71rY3HrIPI2 PJSr5wvs0HLZ40/o3RbI+n11LfvndC7xs3wHKvunzkOM5Stn8gYUq01Uv611KI8PaZ8YsA uEHytSx84iRYClcb8nj7CzM40gK8yxY= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1e9451d8b71so11142805ad.0 for ; Mon, 22 Apr 2024 00:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1713771795; x=1714376595; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bBFXolLQYa78XCdQIXx8hSsPDNH1h31ohatbB+q7SSA=; b=PbZycXbBzPhdLVifCq9xyW6JOroJVJCS6ZZTEpbUk08bBHkhq3sewLQ4fnIuB1Frmx Q/yxTOB7K29dAtBLUuh2KH2tGbqNJgipVfrBBA2MuYhdWY73fDtcTb9zmqBGOqnr1Vuf KihXq8lFqmzUDcQJ3WFpZQkL/GXSUdNl9vbPWLJy4fPCiKUzA2AxRUXj5VbSU8YoyGhD XmR3aILGK/gPVzd0R7POjJwykcovTzaEKlFzlo1o0DTwy6V3+rQ74qOhZErnoecHYz5b BWNC3iwmFSDTTZwyD+OKgzuPTm+zKSoPugyurZAiOpuZvMseSSymWB6un8Og8/Su/gcD mUgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713771795; x=1714376595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bBFXolLQYa78XCdQIXx8hSsPDNH1h31ohatbB+q7SSA=; b=kquoL9vhPJ0sN/S7eYR2EoX2Ek3qQVQB/252yfw7Sg5fxeySBSvrssFTq8PbBYebr8 JBhZQqf83VUaJL55n6Pe9DlPafq99dMuMbv68Nov9OXFwlF37XHYn7naQp6ZdXhjasUe 2bR2JZ6zgaHfZP0WTuLk/faRQk4oB6OwuRQYA0iWEidV7JKs4cy0PqEJO/YQmhZbDX8u /k1WoQzmpWWvByacQU/TgBPt8K6FvEnoHvL2gcanDMfYKRy2coSmNPXv2HdwiXSpmwjx IPZoSHwKQJaR31oVQiFEj0ev9V0gOVao+6LlcxXacUk9M67TWOw87UmLquUsMPDRabxL NJmA== X-Forwarded-Encrypted: i=1; AJvYcCVBf2enMsq3dPVHtFe8F9w7tXcRJketfF9ft/Y+YW9WZSozfExZzrIfTSUrGTMydtVchudRZlGx8KUbf+6WPsRAhbM= X-Gm-Message-State: AOJu0Yx5zxKYEjQZFnKzSqcuRx0ov/T7rk8UNC+JA/z/mEbzM2g+2R21 XgEsXcuvCj97dSanfw0b9YbFsm7zWUPG/y5PoRfAeLW02HARYaO1q14d5e75YHY= X-Google-Smtp-Source: AGHT+IEvHT3XYAnqbJeBRBtYXwHjzJuRWUr3q0IHkM4UWpx7JR4+gVdQqRx7dbo9nSIw0pAVB8jXbw== X-Received: by 2002:a17:902:784f:b0:1e4:d548:818f with SMTP id e15-20020a170902784f00b001e4d548818fmr9126943pln.58.1713771795591; Mon, 22 Apr 2024 00:43:15 -0700 (PDT) Received: from libai.bytedance.net ([61.213.176.11]) by smtp.gmail.com with ESMTPSA id e11-20020a170902784b00b001e0bae4490fsm7595634pln.154.2024.04.22.00.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 00:43:15 -0700 (PDT) From: zhenwei pi To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev Cc: mst@redhat.com, david@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, akpm@linux-foundation.org, zhenwei pi Subject: [PATCH v2 4/4] virtio_balloon: introduce memory scan/reclaim info Date: Mon, 22 Apr 2024 15:42:54 +0800 Message-Id: <20240422074254.1440457-5-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240422074254.1440457-1-pizhenwei@bytedance.com> References: <20240422074254.1440457-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: BB0A214000B X-Stat-Signature: 1oadizbqfwpowjw6c774i4poa69mgazr X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713771796-272314 X-HE-Meta: U2FsdGVkX1/5RqkDoOvLtdgtvy/ATky30c9oLNRnAOK6oH76XZ/B+aSQTOwdGNsK++Myzlo3QSwbIfz8IGXs/iSqZJ2AOx017roiHOJGwgo+dUQCgexHnfEs29BFurdRNjnnGgzBciAWhqRWNWPUXNauv7ziu0Q6j3E07//5cU6vzHoDIUfMKHujXHqd9f/OeMekGTWR5kNxO9LR/SJ2YDkXPMMeux/9WN/D+pLOWwyfPLqZ14SbjE7iM/xc2/gMMj4BBcANtjALWl0qVNGO9svqC9mva+nVwKvCECbyyeQ/sA/d/7mGE7ipk6J2Kk0x9SAogwov1va+t5dUj4R5DjcV+nDyvj8SgctD6KrSNN+qVNiYEQn0lU/r4oqVm/+adnT3gWyhPWIa/ePERXXDUwc63BQUeflH3XF+Shqk7/wg6nVBIMa6tMBXBprbtNvZjbbHqgJl2tzifaQuAI0Or5rAKkE4sE4tE7bsSBFFoRZRq8GAwtywRwXbYnF6yMig9yAFLVFTHG73RM1Lm2nJYnArHd/HwiMuy3BXrvxUGQMsVx/NdMVi+q4j1l73BS8ul7Rr+xQvu4hAVA8K/3wb9a3Dj9mivGeU/vqAcchql36pzkKIhU5VMvqhBKdotY2IU0RNxOQQQ2EMTox6ZWhvqoDK8/M/bHHIwpq/uDEWmEVhPABXC+pA2WVgGPW0NL2Yk0l/3tG+voYCGvRQJd3BjKWzRA4uvvpbkBLU8D+ES2IU8Ehtl4bUzT31FLprLXHXS1REg8rWvQyx8ODmTex9Eg/oYUMo+F0JOeLb8UOoaS1oWKipRx3E8yt4xwDYzobT1kaydbo+rjc/XzNlovgJgyKhsXRGZ2dJ/RYC/KizmPPi471Pf/0e+aIAT6/BCKX7g+uW/GLDem/0RIckLgoI8aLNoqQbVlhM617SAc+kuMWNAf1ykSHu4mYxeZ7hK5pHIMUomg+wurf80S5YTiV /59cGqvD Almt0pM8vERezvgtkkx5h52+DYUavf8tYMSfIuYsdZDCbkJ7TjSHSKWaLWdZdzq0dribimxOEVUVmQcyrS0oYvceMGQmwsdeQ7zJtmTsC34ojDl5Y1pHv12jCamwRGqb0EYdMJ4yLmu55flAxPiKdv/Hykxc3es3Gw6jwTjnsVPUI2IEcLYEmbPjhOGYsMu9niahJOtQqqRQbTSw9nkKXoTXOCHja6qZQrF1MHwPDQFI+PZgyIN6NMj+P9KUaoIos0vbdPdmsO5gEdTr/Ohq9THHAe9qHZ8JhIQc/983Zxlnyuw1dyBetjy87sqbp1ijVgTUSL+GcGcJ7wkKa59xR+Jk8REdE8YVG8paXLaKa2l4XOMFXqg0BkAdeJye27CZwL0JiZFPnZiRYx46l2fUYf084Ix7o8gSOHi+78xRXmumjbk9zfTjju1ByL1z8v/7Nzfryt1c/Vcn8gsq0WazFW+2xSxIkrTlcEfB+bISJLaxao6Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Expose memory scan/reclaim information to the host side via virtio balloon device. Now we have a metric to analyze the memory performance: y: counter increases n: counter does not changes h: the rate of counter change is high l: the rate of counter change is low OOM: VIRTIO_BALLOON_S_OOM_KILL STALL: VIRTIO_BALLOON_S_ALLOC_STALL ASCAN: VIRTIO_BALLOON_S_SCAN_ASYNC DSCAN: VIRTIO_BALLOON_S_SCAN_DIRECT ARCLM: VIRTIO_BALLOON_S_RECLAIM_ASYNC DRCLM: VIRTIO_BALLOON_S_RECLAIM_DIRECT - OOM[y], STALL[*], ASCAN[*], DSCAN[*], ARCLM[*], DRCLM[*]: the guest runs under really critial memory pressure - OOM[n], STALL[h], ASCAN[*], DSCAN[l], ARCLM[*], DRCLM[l]: the memory allocation stalls due to cgroup, not the global memory pressure. - OOM[n], STALL[h], ASCAN[*], DSCAN[h], ARCLM[*], DRCLM[h]: the memory allocation stalls due to global memory pressure. The performance gets hurt a lot. A high ratio between DRCLM/DSCAN shows quite effective memory reclaiming. - OOM[n], STALL[h], ASCAN[*], DSCAN[h], ARCLM[*], DRCLM[l]: the memory allocation stalls due to global memory pressure. the ratio between DRCLM/DSCAN gets low, the guest OS is thrashing heavily, the serious case leads poor performance and difficult trouble shooting. Ex, sshd may block on memory allocation when accepting new connections, a user can't login a VM by ssh command. - OOM[n], STALL[n], ASCAN[h], DSCAN[n], ARCLM[l], DRCLM[n]: the low ratio between ARCLM/ASCAN shows that the guest tries to reclaim more memory, but it can't. Once more memory is required in future, it will struggle to reclaim memory. Acked-by: David Hildenbrand Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 9 +++++++++ include/uapi/linux/virtio_balloon.h | 12 ++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index ab039e83bc6f..e45146fde164 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -341,6 +341,15 @@ static inline unsigned int update_balloon_vm_stats(struct virtio_balloon *vb, update_stat(vb, idx++, VIRTIO_BALLOON_S_ALLOC_STALL, stall); + update_stat(vb, idx++, VIRTIO_BALLOON_S_ASYNC_SCAN, + pages_to_bytes(events[PGSCAN_KSWAPD])); + update_stat(vb, idx++, VIRTIO_BALLOON_S_DIRECT_SCAN, + pages_to_bytes(events[PGSCAN_DIRECT])); + update_stat(vb, idx++, VIRTIO_BALLOON_S_ASYNC_RECLAIM, + pages_to_bytes(events[PGSTEAL_KSWAPD])); + update_stat(vb, idx++, VIRTIO_BALLOON_S_DIRECT_RECLAIM, + pages_to_bytes(events[PGSTEAL_DIRECT])); + #ifdef CONFIG_HUGETLB_PAGE update_stat(vb, idx++, VIRTIO_BALLOON_S_HTLB_PGALLOC, events[HTLB_BUDDY_PGALLOC]); diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h index 487b893a160e..ee35a372805d 100644 --- a/include/uapi/linux/virtio_balloon.h +++ b/include/uapi/linux/virtio_balloon.h @@ -73,7 +73,11 @@ struct virtio_balloon_config { #define VIRTIO_BALLOON_S_HTLB_PGFAIL 9 /* Hugetlb page allocation failures */ #define VIRTIO_BALLOON_S_OOM_KILL 10 /* OOM killer invocations */ #define VIRTIO_BALLOON_S_ALLOC_STALL 11 /* Stall count of memory allocatoin */ -#define VIRTIO_BALLOON_S_NR 12 +#define VIRTIO_BALLOON_S_ASYNC_SCAN 12 /* Amount of memory scanned asynchronously */ +#define VIRTIO_BALLOON_S_DIRECT_SCAN 13 /* Amount of memory scanned directly */ +#define VIRTIO_BALLOON_S_ASYNC_RECLAIM 14 /* Amount of memory reclaimed asynchronously */ +#define VIRTIO_BALLOON_S_DIRECT_RECLAIM 15 /* Amount of memory reclaimed directly */ +#define VIRTIO_BALLOON_S_NR 16 #define VIRTIO_BALLOON_S_NAMES_WITH_PREFIX(VIRTIO_BALLOON_S_NAMES_prefix) { \ VIRTIO_BALLOON_S_NAMES_prefix "swap-in", \ @@ -87,7 +91,11 @@ struct virtio_balloon_config { VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-allocations", \ VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-failures", \ VIRTIO_BALLOON_S_NAMES_prefix "oom-kills", \ - VIRTIO_BALLOON_S_NAMES_prefix "alloc-stalls" \ + VIRTIO_BALLOON_S_NAMES_prefix "alloc-stalls", \ + VIRTIO_BALLOON_S_NAMES_prefix "async-scans", \ + VIRTIO_BALLOON_S_NAMES_prefix "direct-scans", \ + VIRTIO_BALLOON_S_NAMES_prefix "async-reclaims", \ + VIRTIO_BALLOON_S_NAMES_prefix "direct-reclaims" \ } #define VIRTIO_BALLOON_S_NAMES VIRTIO_BALLOON_S_NAMES_WITH_PREFIX("") -- 2.34.1