From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6986C07E8F for ; Mon, 22 Apr 2024 07:43:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72DC56B0093; Mon, 22 Apr 2024 03:43:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DDF16B0095; Mon, 22 Apr 2024 03:43:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 557C06B0096; Mon, 22 Apr 2024 03:43:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 334006B0093 for ; Mon, 22 Apr 2024 03:43:15 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E5D671C0AB9 for ; Mon, 22 Apr 2024 07:43:14 +0000 (UTC) X-FDA: 82036377108.30.0843750 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf23.hostedemail.com (Postfix) with ESMTP id 1766A140011 for ; Mon, 22 Apr 2024 07:43:12 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=JloEebNZ; spf=pass (imf23.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713771793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zrl4akKhVgEJxLJYwq5+gLRsb/mo5Xi0vTQ5EYuojH0=; b=3KQNIJE8XwMGpkX8vthWz+JvXl28JR0y1dSG+0YOhXZdk2d4Uai30peHNboMzV7vsJFCOf LBPtd1GKvcSKTktuz6oMEYmxQrzERpnw3FK9LdGh8AnfqEXAoH94qk0bLxFZEVTwVkkD+R 3o1DJ7TEgntK/P1TU/ex3keRE6xHyY4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713771793; a=rsa-sha256; cv=none; b=2peXcnx7C8NoKgcU6FGgeBqHmFwwWpzLYQ3jLVifE3m5ZDWzzm5oW79nB8TdyOlVHKzwhB tOStOOvqU5u1nzxKNgmiH3DbnONGOF3COnTXxfHrKV0zyJLZyr9/PrLZJ8hDizo1jO1kqu GWkRpLHmQOv6HmIAH3q/bnTUOGRWl8Y= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=JloEebNZ; spf=pass (imf23.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1e3c3aa8938so27537995ad.1 for ; Mon, 22 Apr 2024 00:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1713771792; x=1714376592; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zrl4akKhVgEJxLJYwq5+gLRsb/mo5Xi0vTQ5EYuojH0=; b=JloEebNZTaLWg/SBl3UGoao4RgogC/3Smhg7KtEieelbPAe5/vsOfxyY0DmkQlVlYi AwlNxn6bHjl/yJfc3e08+xWqUQjgZEQjHIj5RPWTphxZ1LNKCS25yaW6ih6HX+gUNlQ/ WBIUGbPfd7dog6+EP3DiG6Fa39wA79rI9zZ1Eh9dneSRQFT3LcG0Eo20XsVd3eBwykgz mSU8twCE5uETecutKPO3e4DazNGYyDzI4JvuLgXPRgBPxh4QhCcNOyeyKcGydvJlebcA vp6XNkn3HNpTQ20BSFD11SjFqKP0p3ia1RbMwixVb9+8zGHXkG/CXhNL0Y7/GHWMlUY4 57rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713771792; x=1714376592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zrl4akKhVgEJxLJYwq5+gLRsb/mo5Xi0vTQ5EYuojH0=; b=KxRVBn2ophqk6jcXf2A/0HiF6TmPY7HxE+84RghYOVNksPFnQ2fDk5qqK0O5KHhIth oKJbg19T1Fe3UhZuSmyEh0WvMKBRgxH6pC1OoiAsXvPo4WnM/gAEOQjciKZS5sOjv1Kr d3CJOef/DGQFOhygPUJlMOiqH1OXjJvLaZ6l7iwfXxnIuGDXAPb0pKqkA6w2RyhPD98x La1RiGwV9Z0IISoPwFbqY9IVi5z5lvqf5Txj4IRiSPVW+gzeRPA3feXFq0oPSrp7Twi2 oerKxyVDgxlbseven1LE3/RlKdxTNQcOGRk0cb+G7p7AgqCJAhKDm5kfrg4VRSO1pBRs tlOA== X-Forwarded-Encrypted: i=1; AJvYcCUF/VXTSIopBmeAzfVou5NdZl8QwBVtNH8eq4l1xQOOOG/LYXwqhIGaqnH1RvsH3bWpFHTGK1xUBfzYi9W9puogA3Q= X-Gm-Message-State: AOJu0Yy9+yKL8JtBSTTRrFGQRbgVNj1VX/v1lQDcePIhDkezzPJWzbWX kOMf92foXO+932hDVd02raoMHS845JiOQLiFHbMKzG5JO3t0JZfSyfsb2Rgk7wo= X-Google-Smtp-Source: AGHT+IEc9oEJpvxbLzrOG8tkIAbOFSv29i67Gv0xrVCixugzuwunQk9IqJOdyb3sAb6X7Uc5rZD22A== X-Received: by 2002:a17:902:db07:b0:1e4:bd90:f1d4 with SMTP id m7-20020a170902db0700b001e4bd90f1d4mr11064583plx.40.1713771792141; Mon, 22 Apr 2024 00:43:12 -0700 (PDT) Received: from libai.bytedance.net ([61.213.176.11]) by smtp.gmail.com with ESMTPSA id e11-20020a170902784b00b001e0bae4490fsm7595634pln.154.2024.04.22.00.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 00:43:11 -0700 (PDT) From: zhenwei pi To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev Cc: mst@redhat.com, david@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, akpm@linux-foundation.org, zhenwei pi Subject: [PATCH v2 3/4] virtio_balloon: introduce memory allocation stall counter Date: Mon, 22 Apr 2024 15:42:53 +0800 Message-Id: <20240422074254.1440457-4-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240422074254.1440457-1-pizhenwei@bytedance.com> References: <20240422074254.1440457-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1766A140011 X-Stat-Signature: 9yf8ysbbzfoqt38amwiqi5hebb544jpc X-Rspam-User: X-HE-Tag: 1713771792-977845 X-HE-Meta: U2FsdGVkX1+9ng7STet9O0D3k4r4I0Ag9drz89cOXI2/rvMpVH4rQZ5IMuKx94MyZOrzxTXXtE4pLW0jU4boFdcUW2c+9hYKKMxp6VYLU46HO6w8E5BMEjmgaZuPWc3xUn/BlpeSsOoKueR6xilYrqpTBXdDbPjGCS/iKDIT6BineHyaNOCU3wzQEFcohJ3zQzHnm6ETLjkkQXh75FIK5LVRStnUdqXVBBj2DwXMLy/f5dwTYxbl5srA6QSYIvCgLx4/k2xnNkjiqghKbinguYXXSFSM2wZy2LkBK6pE8N6qRdNAU7aY9I3tUXSd95DVUWuzkpXz5AlkeJwuSyzkHZwJM+flpKuufxIM0rzxRlYCpBEcaNR65qfZbAP3ruf5BydesRA8cW9kKUM6qO63I+NUo4EpyuIw9FoUNyUxV+YJNphlVlW7MJXAJJKL5fjpVtGMyxAylVcmxPvCBJ9Cuhar4SdztKUBFgN0kpJxVFi8sh7Ns98qGEm0ikrw04FtHkia7m9eRMcT3xzJbS3nGCevt2AxvhVCIIvymdWztgXt+fwT0jD60SVRcmIX1qJXQZS3CdA3zodvefEZllFh0TGu1LoGt+ZcqZb1PBOXt6xNREaT8xhI2QaYaX9LBY/229CEdDjpYLkcNV47mq4su4cAz2clWeWtOlGBVceIXFGOTz4yHPDomwVQpZQ7JpBkTtParATTCNcCyo35p7iTRzRF4vLVEY7W4BTUDby7qh3qAnqUuppYyCmMUly2m3use7unX+iyYa6i/MeFRoiG+kWskm49UYjYdDM16eNcW0TUg2qxCc+JRiqbCTOKczS2uYYu5UG85+PxkVOwuVi8N0gn8ezEo8jJ0lbLVRrCWjPFTFU80BembZA+T0JnnCJ1HoWzybUPZjy0QVcuMTwoklVQvgcCWibcslJWmBVNi8jsg4fwfmqAJnw0APqpziuYDHG9laJH+tQ/DLV3gXv EnZd0yR1 jZRvKb3FDQjPCy5wJwJU7vrem5f06H4G0lA/LsofNTDU5S5lx89ipEoHMaptLYviYXsS12dccE0hSwXyMPMMW4dvm8sMR5osbcrLSRJSZIFx3lz920BRXNMyQqyN8kDiRhveibngcZ8e9fQJ8NVtHAZuSYaf2rnWTltHLngd8BQ1QMvJh7qsohMURrMFXG4+rlaXJAmr2F3zHP4zKl5fNc6CoaJHbIuUKohzxxHnqpu7drJrDKKZpDSAsHDeHpXRnxVHseyEoOaeuIjKax+cGeBBpsZym9Bm9Qwn06/pr49QTWy6f89jMkV6iCjHCCBHzdhoa0NHr8qaCSJJZ+pUS5DtA6d/qg/Y53bg3e/xag95s+crKoKU67Rty6HFcUaqcN515PXrmsPJ25hogrUg04rX0nXWcd0w5z8S6O2+BgzBv7KEZPHhKhXoLQkWr16iIxBnAQAKUqy0WKTE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Memory allocation stall counter represents the performance/latency of memory allocation, expose this counter to the host side by virtio balloon device via out-of-bound way. Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 8 ++++++++ include/uapi/linux/virtio_balloon.h | 6 ++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 87a1d6fa77fb..ab039e83bc6f 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -323,6 +323,8 @@ static inline unsigned int update_balloon_vm_stats(struct virtio_balloon *vb, #ifdef CONFIG_VM_EVENT_COUNTERS unsigned long events[NR_VM_EVENT_ITEMS]; unsigned int idx = start; + unsigned int zid; + unsigned long stall = 0; all_vm_events(events); update_stat(vb, idx++, VIRTIO_BALLOON_S_SWAP_IN, @@ -333,6 +335,12 @@ static inline unsigned int update_balloon_vm_stats(struct virtio_balloon *vb, update_stat(vb, idx++, VIRTIO_BALLOON_S_MINFLT, events[PGFAULT]); update_stat(vb, idx++, VIRTIO_BALLOON_S_OOM_KILL, events[OOM_KILL]); + /* sum all the stall events */ + for (zid = 0; zid < MAX_NR_ZONES; zid++) + stall += events[ALLOCSTALL_NORMAL - ZONE_NORMAL + zid]; + + update_stat(vb, idx++, VIRTIO_BALLOON_S_ALLOC_STALL, stall); + #ifdef CONFIG_HUGETLB_PAGE update_stat(vb, idx++, VIRTIO_BALLOON_S_HTLB_PGALLOC, events[HTLB_BUDDY_PGALLOC]); diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h index b17bbe033697..487b893a160e 100644 --- a/include/uapi/linux/virtio_balloon.h +++ b/include/uapi/linux/virtio_balloon.h @@ -72,7 +72,8 @@ struct virtio_balloon_config { #define VIRTIO_BALLOON_S_HTLB_PGALLOC 8 /* Hugetlb page allocations */ #define VIRTIO_BALLOON_S_HTLB_PGFAIL 9 /* Hugetlb page allocation failures */ #define VIRTIO_BALLOON_S_OOM_KILL 10 /* OOM killer invocations */ -#define VIRTIO_BALLOON_S_NR 11 +#define VIRTIO_BALLOON_S_ALLOC_STALL 11 /* Stall count of memory allocatoin */ +#define VIRTIO_BALLOON_S_NR 12 #define VIRTIO_BALLOON_S_NAMES_WITH_PREFIX(VIRTIO_BALLOON_S_NAMES_prefix) { \ VIRTIO_BALLOON_S_NAMES_prefix "swap-in", \ @@ -85,7 +86,8 @@ struct virtio_balloon_config { VIRTIO_BALLOON_S_NAMES_prefix "disk-caches", \ VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-allocations", \ VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-failures", \ - VIRTIO_BALLOON_S_NAMES_prefix "oom-kills" \ + VIRTIO_BALLOON_S_NAMES_prefix "oom-kills", \ + VIRTIO_BALLOON_S_NAMES_prefix "alloc-stalls" \ } #define VIRTIO_BALLOON_S_NAMES VIRTIO_BALLOON_S_NAMES_WITH_PREFIX("") -- 2.34.1