From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB50C4345F for ; Mon, 22 Apr 2024 06:17:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 897636B007B; Mon, 22 Apr 2024 02:17:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 847926B0082; Mon, 22 Apr 2024 02:17:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F3DE6B0083; Mon, 22 Apr 2024 02:17:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5138E6B007B for ; Mon, 22 Apr 2024 02:17:37 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CB537C0A24 for ; Mon, 22 Apr 2024 06:17:36 +0000 (UTC) X-FDA: 82036161312.29.D81ECDE Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf09.hostedemail.com (Postfix) with ESMTP id E7DD914000C for ; Mon, 22 Apr 2024 06:17:34 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PjXQhf/e"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713766655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G1b+z/goVjx9YkRKhoEzKM+xLmhhl6Fzo8qCm3eFOPU=; b=ydC2kBBz97AIoMPWNrZwPHR2zBqn+bBgSqx3SVQB8pQrAo8Xwv6IZARY3BQtxkGd4HJwAT LzqPyagwo01qt+Gof/DGMOhzdKGKsFGUA73r9Za56vh7gFwl7wDhahRcR+30lBbxM6xYtz AW/fgDvnQPxaqwFJTZOrk1F3mnRuVOQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PjXQhf/e"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=ioworker0@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713766655; a=rsa-sha256; cv=none; b=PF1N5tA5Iy/Vaupsh1qUD5yeCrx9opH8mfslA5ckKpsochWBVGVkQ5DGoRoVKI5ZdejAf2 Jjg91fqIx3xTisjZh8VxnRJaSCRCekHy7qMZTo0fE2AFgcy0/SmlIJLPOI6lOznVZu+EQZ OsjZGn43GScpCJdH5wrIBhLQgdMccwQ= Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2ad8919ba0cso753156a91.0 for ; Sun, 21 Apr 2024 23:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713766654; x=1714371454; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G1b+z/goVjx9YkRKhoEzKM+xLmhhl6Fzo8qCm3eFOPU=; b=PjXQhf/e57iZRNk/EtcevBRus2CWXXce8IQn93NRggDE1WkHWNYJcPHv9k52v1DUls JEk2fx7AQiMeRrcfeC5pY1mE8JrV4R1FK3boC0x0lFgzAEB/fZ3dv7+C9Wri6d3o6dWv i3YlMdhkbHek2l2GjeoyQtwubU3l6EonzyUH8Xbj7iPFh/YCrNNUPpDyEGrf+9BoB0xy HKyoOyqLXqrCW+NkVgeA4OH4jBkf62SOFACTO95aHnXCdx6m3ej4fRZ+XkZbxQY/Sevh EonS30uYDE0o05UyxeCuKKCc0jsIsxIc1iEnR2QrNrXRlRqK9RC708B64Ha+QxOncbUT 8K9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713766654; x=1714371454; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G1b+z/goVjx9YkRKhoEzKM+xLmhhl6Fzo8qCm3eFOPU=; b=wFszHS9jrYaf+in0Sr/c4Bdl3g2UfSG/5mYegKgn5+v1QHjfcz3nhjzqIRa2dOwcmt wDiv8JxTvCmCUcw2+L3S6NaaATAotR5sSuULURjj4kLH0pdBrzKjqQBmJ1QdfX2MLL7p bnZgdGYFXqRcnNhUs4BqFSeYc0vtHnHfVSXGKNhANUqhRubr5dIw/p3q+Y8AMZ6XkYnd Gt9JNLyS+BLet5okD49Ed3R73gQb6usw5h5xvXtrgnbL+vPLGKXPNKIMXWqiIq0M1Vxz D96B5DPMJoSyTZeCNN0jIOxbVAhc/v3FtvS6Rp2rdq/gFR71/WPgZ+HMFgYGTpp1D/Iz KEZA== X-Forwarded-Encrypted: i=1; AJvYcCUW9IDQRZlwEWI4SvPSrqmFIM3NwWJPsAgzQiqDkU/GO9WBz9Idmv2i34AiQtoDCvs0Sh7vXqRl0WeTv/JNAvzpMos= X-Gm-Message-State: AOJu0YzfJxSyIKKZjhLSsWgnsdU3J/WwDZPitM2W7BDMeX8co6y5iLw6 5HErMwoutBpLMgCqv3iuazsdLWpkGRTr2mrg3+oNaTpXCHvQH+P0 X-Google-Smtp-Source: AGHT+IEf6w3kycs5FuY4nHyDOASb8CcoZfA5ks13u+jzfHMWAF5DwtIYKhLPRQb4OlJkNGWYLoRcTQ== X-Received: by 2002:a17:90a:5b0d:b0:2a2:bd4b:764f with SMTP id o13-20020a17090a5b0d00b002a2bd4b764fmr7750171pji.3.1713766653545; Sun, 21 Apr 2024 23:17:33 -0700 (PDT) Received: from LancedeMBP.lan ([112.10.225.217]) by smtp.gmail.com with ESMTPSA id t12-20020a17090a5d8c00b002a474e2d7d8sm8626944pji.15.2024.04.21.23.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 23:17:33 -0700 (PDT) From: Lance Yang To: baolin.wang@linux.alibaba.com Cc: david@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Lance Yang Subject: Re: [PATCH] mm: huge_memory: add the missing folio_test_pmd_mappable() for THP split statistics Date: Mon, 22 Apr 2024 14:17:20 +0800 Message-Id: <20240422061720.61697-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E7DD914000C X-Stat-Signature: s5u5izq4ums1t9rhgyk6639b1duueuck X-HE-Tag: 1713766654-543080 X-HE-Meta: U2FsdGVkX1/f2BsRjGzP9obg5U4HRoxGQj2wP2Vkuck/R3QRXhAzbSp9H7rK/t3c2/HA1ZHnx60mpiLQ9iBZUnRW+aLLmtjwU95zdU3IqxbcUpYBzeD8v3wx4rxBnAu8uG1NNfe+hNcPA9EVYnpm9+wRYYHbvU1mW6Nqz94dghf34ytBZLEGeY/KD4e/BGfb7K7vhCgQZCso/yIiM0qNUQMVYexwMCVFRXl/qdcfZyLqP/ofi93IeKVg+QzoU0BmDlmH5vGWmj1hOSVUpRErisVJYbU5ENZZrFEvZM53yyX66EKTf3a6rV+UybBe1JUqBERL/bxi4FLTsOH1TbcauAywMFvmC80pDek9FCmpp0Sa8FRwvp1xITDPJM73YhPcEdgI8qVoA/034h5XdOTUwrwukyKOiQgBf+WdlT+Wqd9ubqTTKtcjp7Z2Jftw9XnbrxoeJkGX2s8JrcGlh4uVv4DKdnJPnczCpqAt+oOgeFFaYV5uAd5weIQXWK7zHYOc1QtC6mNjMtvuZDGXb//jiRZsGtb4km6GJTSlvzwYz9Gn8b9r5//UWQiimQVNw0CRdD5At5fC9xRA7nRNKA83dVZuFfoFR+y/YHv+EpJlbHzdjcyE33sSJX5csM23QbF3T5wW3T4BWwGIhDa5gfwN8YOka/3WRJyr+/JyOxoe1edNOERc3rL4q/nv4naFbQqS/ZFbXUhT4ok9zovPC+QJE/cbINWiHjSq2IQbF28GwDzp5ZpysuCeWrnc/O/bnRx7lmzx/g46uAvWAySRY6+Qokn51Uv5WyVbWYjXRTrA0yOkyC4Xh96xuZaX7Y9m2qOoMPWGjtSmnK08dMuZTsZ+sLtLR7Bg/1TAtX/O7iJLGNGqcGtl32CQfVKq/Yjtj7gvSm0Al+EU6Ob5GKOHxw9AMy7sSjCaJfnlTviggi0Zm7KGmSSDEx8ldRRbfxaUkYjQZ7QO+JTe19tWz6kwZRa x0fIz1Dq QYSIaT+d13USszHyS/8O4isS5HLIooPnGLOvGTY0fdX9bO+xCiC2HSb/QIIXvob4rlOHel94GSzq1W9IMQroUJwMTWh4t60uK4E8AN+dbm20QEeFx409+2umXmk/gcs+i1UkQmpPMoafF2fyLnghAiouXWkL5mfI4SM/fEXesDYi/Nq0OC3ZZWYDBD+2JwD81jbHNk+fBPJTKzF+ks+lyzEVkptWdPe+pz18bvtHNJeIPUwGgm77bqpGhQ0/yZmPDNBgSeRUD0bxCDXelMoPOtNsDOhVWDmPmBxTehOfGoBtaVLZ1TIOIhBuxXhAAGP0md5w1WGa3U0523JYgeLgXBt2Mzw5ENPgziVHwhaFGQ6n7sijftX+snaK6+p21nM0JvhhH5Z2hbSXWnqAOrrnerWO7t4NivkHB7AN+MGi0ywh+FO4ynY9442yrpdLCl8UKDc2cdreYtUPaDvhr5p4goQc9nd7P/K61+jMMJElEnEdxN880U4ly7DTnwQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000163, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Baolin, Maybe I spotted a bug and made a change to this patch as follows. diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 824eff9211db..f3c4e08c6d30 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2994,6 +2994,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, XA_STATE_ORDER(xas, &folio->mapping->i_pages, folio->index, new_order); struct anon_vma *anon_vma = NULL; struct address_space *mapping = NULL; + int order = folio_order(folio); int extra_pins, ret; pgoff_t end; bool is_hzp; @@ -3172,7 +3173,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, i_mmap_unlock_read(mapping); out: xas_destroy(&xas); - if (folio_test_pmd_mappable(folio)) IIUC, if we split the folio successfully, it won’t be large here. + if (order >= HPAGE_PMD_ORDER) count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED); return ret; } Thanks, Lance