From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E528C4345F for ; Sat, 20 Apr 2024 13:23:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 601396B007B; Sat, 20 Apr 2024 09:23:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58AE76B0083; Sat, 20 Apr 2024 09:23:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42B0E6B0085; Sat, 20 Apr 2024 09:23:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 255B36B007B for ; Sat, 20 Apr 2024 09:23:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8DDC0C058E for ; Sat, 20 Apr 2024 13:23:33 +0000 (UTC) X-FDA: 82029977106.19.F796F00 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf19.hostedemail.com (Postfix) with ESMTP id 71F5B1A0005 for ; Sat, 20 Apr 2024 13:23:31 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="z87NQOM/"; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.128.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713619411; a=rsa-sha256; cv=none; b=1NTVPHLVkU35PdtZHsd7ln5NkNrgsN81wWcWB0HM2s+ccpLaajCOchN9pedPdUevSuKNq0 abxKASzn8F6KSBuXPH+3X06r/zAvTZykcHD9d5EEanL7p5qyuvi0lGlA7xf9mI77lCMlmQ Yz4NUs91oxJvf2jYBB4n1fSJyoRSNRc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="z87NQOM/"; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.128.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713619411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7E/gU/HnTfpLL2KPHG4Owb2FHQL2jemmH65c7TQSroM=; b=T5r8/qPRVKSoRMSXiQMqencjgN5hsFzyRaOG9J4paNhSwfgU5Ye++Trl/4lc1vi1/f+i+E hSo6xnM6dqDvkHHGw9ARMvn+O6+QeF8Y2KnvESUAqJvwonq44d4hWAkq4IQSJpcECUtKlM BEiiJ1cH8/QYC4pP8pAiSSN4xllkIfw= Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-61acfd3fd3fso32368017b3.1 for ; Sat, 20 Apr 2024 06:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1713619410; x=1714224210; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7E/gU/HnTfpLL2KPHG4Owb2FHQL2jemmH65c7TQSroM=; b=z87NQOM/DzFggM2Vy83rMMrZz3Pq88U1moh1vOvDfoJaJpnZ6C0nHtQq9bYfDLhh96 95nwBFJDvmkyisD6MeHhDtHj9KHoH/C0j4Rp8/m6Ep0F7IAKclXYqNEodz57qoLKTZZF J/MM0KNzrzSASYFjMFV2ZqnXQeDgtJ3qbdNM0qjHiEPf+bml66RswHUG160/cVemiVLS iBjSoYnf/R61lbDdn8MnKYEVMbSrb4+d/jHACXIL+dQdBEynpTAgCpy0Ie8XGfkNwTOx ps6P8zMKvWxoajUssEPyMWx3WdIIO553tgwxiJV6w3F+Th6e66QwKKZu4wQ+iagm9s9e VysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713619410; x=1714224210; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7E/gU/HnTfpLL2KPHG4Owb2FHQL2jemmH65c7TQSroM=; b=smiF6jw/0tXGgFuufgWM8hCBBpQ2iKMXhSkQDgis0aYp/b1gQrSGPTfwDL0ucOb6bC kcuGKFHrv+nkTutNmBbHIC/Xwl3mTSFxEihQCkUrf689rqtPJmtXfITmqveQ9By9Qgjj IMakVSMXuxXF7SZKqmB3u56vTQIBR/duFxTimUr6Tt82chjQtq87Ui+7Zrv+N8kKA2// iDmBwnTV9wKLs8xJTQr2XddvvojYl9U08/NhlnivJay2kvidPle8WFGMSCR0c3PZHgaS d8snBYkUnS3BfH2o7Yn+PHCXBVLNOWCAAdjJqKjPbOgdIUrkx3pFc6MzSCR7GZRLeptA VqyA== X-Forwarded-Encrypted: i=1; AJvYcCVGSaOJ9zIepV5qDcVz8wG48iqzniNwjXKJjgzNky5xlCzlXT/uV1WfhdaD0h7Gorz0jxwJ/uxW+vtmO+etxTcHJ0o= X-Gm-Message-State: AOJu0Yxedd1s7KQOofSMsmPgNvbyIDPkSzNF2YsCeUnqawN26Xjsh7Fs jwJ0qPmP552OdW89ZR/N6pGogjV2Ev9VwB4fhud/PsLhE4oXNJdw1UR/cSv3g2U= X-Google-Smtp-Source: AGHT+IFF7WdFGx06lubZjnZEDsS7NHLyRc7J6rqOKjkDjjAr8x9U13jv0WnJ7Lmv1HVdrelM9tkBpw== X-Received: by 2002:a05:690c:6a10:b0:61a:b7c8:ea05 with SMTP id ih16-20020a05690c6a1000b0061ab7c8ea05mr5479226ywb.35.1713619410429; Sat, 20 Apr 2024 06:23:30 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:9d5c]) by smtp.gmail.com with ESMTPSA id o2-20020a0c8c42000000b006a06f044a34sm653868qvb.23.2024.04.20.06.23.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Apr 2024 06:23:28 -0700 (PDT) Date: Sat, 20 Apr 2024 09:23:26 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Andrew Morton , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: simple cleanup of stats update functions Message-ID: <20240420132326.GE1055428@cmpxchg.org> References: <20240419233949.2326100-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240419233949.2326100-1-shakeel.butt@linux.dev> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 71F5B1A0005 X-Stat-Signature: jawgju6j4rsjzm4bhhste5ykjq4bch8y X-Rspam-User: X-HE-Tag: 1713619411-436650 X-HE-Meta: U2FsdGVkX18EksSC/dPscLlX6gRxD1NTNCKkszrRs5JX+pnZ/6ZFbiVt6XRfDaEIxQnkNdrE9Yqvg23sNQWBNSp6rf8+/tbXIdNmrIyXq5hP1bMEjvrr34Mx8SkeemmONAuXNC2DQTr3P/+Dcv7P9QiE1T7Ub6FNaAAcro6CJkWozFNcoYsSfs1vsTYMiJO7tnmtOJf8+/TJmJJckCqjvImU5b8C20ZxmFXX7izzIUENk0Lxgw5jP682agfXB8lZ0XsC2+3+wlQIxT9e232/1nH7kYOJlyX7oMnPyeq3i/rZUmN1qEVM8q3I76VbfOZrlrQ6vBJMMHh2PvKLdqwE/vAALVMy9GLLrn1Adr7gFoYn4OihhL99h0jXCPv7mge7O/UD1DPXtMmywkpq4PlbrIcbxb0j6sTypsjpzC7WQkMsbzH+8MZpbmU2zYJQpu5SX1LNw37J+TkjiSqhrBzltBjJ1oCZA4kRMayjenVwIAI3XqoeaDE1qWezaSH2d49m0sFZzKT50ahStW9tq555Mza6iPsj9Ixr5v5SzdcstbnLoVEQ+o5dysU7WU0e/LElBZqlROaTPMKFEOQ520fbdHP5E2V8W6lWS+WWzTRIY+8a/a4mQlGtHGaq9NgVchoC4El2pvIYH3pAMz806Ru2aUEUIwnjMFHtfvPIVFdVfk79gKUoz9r0D+XlNqetmp6ZmWfnQ0ONNiq+OBEg9lxGji9YGvnzfH9mm13whNfLJ2vS77r49CNC7EcWwHksz8Aa7ylWQB/9cqtLtkD9sY31L964FY7QhSz4aSVZNPnLYfmBnOcOBYY2BLUul5MIp7C5idsYRCTqp8johd+2mJw2pDqVGUcshZJAcAZ5WePcraGf6A19AazNJw2T5uvj4GNXxYudGc9HKZ8AzIEPw/lq3nxBpJ56GebFOmBn6YeJ1wdYSA1QKqz2Zo42EJ7ELe3WoOlBLXzSkNDVGebf/Il YA4DsTY1 u4+hUWMQDueiLtrsHzLxjzIutjXmOgBWEdcqrXBZxDuzNqhmcVD6xbK2Dy05U7l3nBO3UwP3UuaV2VHul2Z1BEHZ4BUP9Qy9mmqZ3SMWSaneAXP6xRUclqCu1vQG+J+eI5SCczW7KyPNu+Ww= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000133, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Shakeel, On Fri, Apr 19, 2024 at 04:39:49PM -0700, Shakeel Butt wrote: > @@ -2983,10 +2984,6 @@ void mem_cgroup_commit_charge(struct folio *folio, struct mem_cgroup *memcg) > > #ifdef CONFIG_MEMCG_KMEM > > -/* > - * mod_objcg_mlstate() may be called with irq enabled, so > - * mod_memcg_lruvec_state() should be used. > - */ > static inline void mod_objcg_mlstate(struct obj_cgroup *objcg, > struct pglist_data *pgdat, > enum node_stat_item idx, int nr) > @@ -2994,10 +2991,12 @@ static inline void mod_objcg_mlstate(struct obj_cgroup *objcg, > struct mem_cgroup *memcg; > struct lruvec *lruvec; > > + lockdep_assert_irqs_disabled(); > + > rcu_read_lock(); > memcg = obj_cgroup_memcg(objcg); > lruvec = mem_cgroup_lruvec(memcg, pgdat); > - mod_memcg_lruvec_state(lruvec, idx, nr); > + __mod_memcg_lruvec_state(lruvec, idx, nr); > rcu_read_unlock(); > } Best to rename it to __mod_objcg_mlstate() as well to follow the naming pattern for whether caller or callee handles IRQ toggling? Otherwise, looks great to me! Acked-by: Johannes Weiner