From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57FCC071FD for ; Fri, 19 Apr 2024 16:47:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D6316B0093; Fri, 19 Apr 2024 12:47:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 655626B009B; Fri, 19 Apr 2024 12:47:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 480266B009D; Fri, 19 Apr 2024 12:47:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DDAB56B0095 for ; Fri, 19 Apr 2024 12:47:49 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8DCB8A1DB8 for ; Fri, 19 Apr 2024 16:47:49 +0000 (UTC) X-FDA: 82026863058.22.EDF22BB Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf02.hostedemail.com (Postfix) with ESMTP id 9ACEC80002 for ; Fri, 19 Apr 2024 16:47:47 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713545267; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o28GBocDpoTP3ijVgDy9HzG4ps/UPFTAJx8rfg0PCII=; b=QWrBo188CAzetzDeHQk5fqpXUtKs1Vuac0gu9k3vlLjl7pVOepTf9py0uXdHxPEd3UwI8e pHVhxDQAuzt52f1U9fQW2m7JlZYVi51fyvabE/bN8IlWxB83o3SjOMgLmmEG1unr8H5EDW PleN6itYHzC3wBN9U6z1fLvmVix5nuI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713545267; a=rsa-sha256; cv=none; b=3zvbf2V+iQty75KQuUFrpcAUVtGWrX6x2v06jhrA27UvEB/BsbfeigTSmE323CMyakywJH y/6WZTkKnPfTzVdY2rQmsSI+ODnGE+GLPGtuez7LMTsV8GMJrwyzJHZI9pXDA1jYcJ2I/I +vnFrQLBxw5LynQdcA9YDgR8VmRGEKM= Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VLgW536scz6K62B; Sat, 20 Apr 2024 00:45:37 +0800 (CST) Received: from lhrpeml500006.china.huawei.com (unknown [7.191.161.198]) by mail.maildlp.com (Postfix) with ESMTPS id 54086140AB8; Sat, 20 Apr 2024 00:47:44 +0800 (CST) Received: from SecurePC30232.china.huawei.com (10.122.247.234) by lhrpeml500006.china.huawei.com (7.191.161.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 19 Apr 2024 17:47:43 +0100 From: To: , , , , , , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [RFC PATCH v8 03/10] cxl/mbox: Add GET_FEATURE mailbox command Date: Sat, 20 Apr 2024 00:47:12 +0800 Message-ID: <20240419164720.1765-4-shiju.jose@huawei.com> X-Mailer: git-send-email 2.35.1.windows.2 In-Reply-To: <20240419164720.1765-1-shiju.jose@huawei.com> References: <20240419164720.1765-1-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.122.247.234] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500006.china.huawei.com (7.191.161.198) X-Rspamd-Queue-Id: 9ACEC80002 X-Stat-Signature: j4qofrwof3a1gba3bak8jntm6zgticep X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713545267-163353 X-HE-Meta: U2FsdGVkX1+KIqK1kFZLWgztI4WhJkna6lhwPjY2k+wZybG0amhusezdowW5/T4nC5FQBW2VZIGP4YASb4dhwCDZ6CZ/sXiIG4XBsltNqEyeZaGTHb3iCqogVp4gRlEODwkYv1gRlpBlw/vzXOVve2P/3L1paW7Px4TWkDR8WK+YukrzL/5E0A6UomnMG4g/1v21pVQie/nhLNVSVaBf7j8H7v36pzL+3gRMLqjXC96VNVG6+biu1ttfHGn6GIkKTQXn7joCF2sFhUDz45x7NNvPUareD5rnE/wkAI1BF18n1l7NtkZXqeagsP4JjnZ16ABrMEP95cjs9DblNDl+e8usxRmJmjNf7m7N/3FpxklV6m3fSDvKzsBy8Lnn7mhnPqq+VbJb5aMnyGbGlv7Det1RokzuHrvUOm9fPTS++UFllNE46nZtC5OK8XtRvTSA7wUb165J9WbnFtcWE1sRRJ3+ElyKZ6pVbCXR2kWadbuEFC5AFefUmnimWUqJSKSlaNI845nvKVlZzr+3Ce1/Jb0ZJflfWVkuVzwGDjSbN3VWoR3C6/K5bVeuYm8dFE1y2RLLBOnAsDnGIBUVeVzagfKyoe+AaDcwxZ7SDUSRC0SQIOkZqIrICI+5ctQgh/hf46VotSFTPgcDJu7grk1/q98/wR+KhgWjA+r7CgoCuXLbtpSWxgaOiSyQvYrIEGeeCoYBy8YaAMP+YR3/To1PB+R+yAB0hfrG4h8tG5DofxqLEjkIihLvuRIuPQxzsnroZtvso74O/zJLqGBhNrGZrIpgtVB3CaD/VaWb4/UoAm57oZgFqDBFBM3OjdLZWpDg9lhR1hBostjprf5ka3MoUJtemrhwLoPP/es/6L6aX0jFjkHZizR6KSjpBJPDk0Eu0Zl3TDLI4LapAt3XCVcQIOOJRXOR/hxlKX1RJMzpoy6preVhMTRZ69OhCTb4LObSTLNmuXUVljni9tDE6JF QS1O4qI1 nDWGCjIlGs9u8HWIwUVCaHZVsKuYqPwc1/Za0mpONV0T7xiRui0OeWEsQvbIb0KWz5a+nte3kQbthUQ85QtI3o3OqVXky+g3n2J6LoqlWGKxgROcBHTve+EnbBVhIuQ+NBg2G/LBfX3prdN6/vl9gjoxwlPvPa6vyBQxW9BxUu0Qr9yAKTNrUjtIaO6MhyoyOOU4vTJ5y1SjIp4G+hYRVpqqAW+NX/sFe/KONyLCkIxM47WZ6rN0cnLbA02JWq3cwFbt26hdw8OmU7e0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Shiju Jose Add support for GET_FEATURE mailbox command. CXL spec 3.1 section 8.2.9.6 describes optional device specific features. The settings of a feature can be retrieved using Get Feature command. Signed-off-by: Shiju Jose --- drivers/cxl/core/mbox.c | 53 +++++++++++++++++++++++++++++++++++++++++ drivers/cxl/cxlmem.h | 28 ++++++++++++++++++++++ 2 files changed, 81 insertions(+) diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index 82e279b821e2..999965871048 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -1318,6 +1318,59 @@ int cxl_get_supported_features(struct cxl_memdev_state *mds, } EXPORT_SYMBOL_NS_GPL(cxl_get_supported_features, CXL); +size_t cxl_get_feature(struct cxl_memdev_state *mds, + const uuid_t feat_uuid, void *feat_out, + size_t feat_out_size, + size_t feat_out_min_size, + enum cxl_get_feat_selection selection) +{ + struct cxl_dev_state *cxlds = &mds->cxlds; + struct cxl_mbox_get_feat_in pi; + struct cxl_mbox_cmd mbox_cmd; + size_t data_rcvd_size = 0; + size_t data_to_rd_size, size_out; + int rc; + + if (feat_out_size < feat_out_min_size) { + dev_err(cxlds->dev, + "%s: feature out buffer size(%lu) is not big enough\n", + __func__, feat_out_size); + return 0; + } + + if (feat_out_size <= mds->payload_size) + size_out = feat_out_size; + else + size_out = mds->payload_size; + pi.uuid = feat_uuid; + pi.selection = selection; + do { + if ((feat_out_min_size - data_rcvd_size) <= mds->payload_size) + data_to_rd_size = feat_out_min_size - data_rcvd_size; + else + data_to_rd_size = mds->payload_size; + + pi.offset = cpu_to_le16(data_rcvd_size); + pi.count = cpu_to_le16(data_to_rd_size); + + mbox_cmd = (struct cxl_mbox_cmd) { + .opcode = CXL_MBOX_OP_GET_FEATURE, + .size_in = sizeof(pi), + .payload_in = &pi, + .size_out = size_out, + .payload_out = feat_out + data_rcvd_size, + .min_out = data_to_rd_size, + }; + rc = cxl_internal_send_cmd(mds, &mbox_cmd); + if (rc < 0 || mbox_cmd.size_out == 0) + return 0; + data_rcvd_size += mbox_cmd.size_out; + } while (data_rcvd_size < feat_out_min_size); + + return data_rcvd_size; +} +EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); + int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr) { diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index 06231e63373e..c822eb30e6d1 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -528,6 +528,7 @@ enum cxl_opcode { CXL_MBOX_OP_GET_SUPPORTED_LOGS = 0x0400, CXL_MBOX_OP_GET_LOG = 0x0401, CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, + CXL_MBOX_OP_GET_FEATURE = 0x0501, CXL_MBOX_OP_IDENTIFY = 0x4000, CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, @@ -754,6 +755,28 @@ struct cxl_mbox_get_supp_feats_out { struct cxl_mbox_supp_feat_entry feat_entries[]; } __packed; +/* + * Get Feature CXL 3.1 Spec 8.2.9.6.2 + */ + +/* + * Get Feature input payload + * CXL rev 3.1 section 8.2.9.6.2 Table 8-99 + */ +enum cxl_get_feat_selection { + CXL_GET_FEAT_SEL_CURRENT_VALUE, + CXL_GET_FEAT_SEL_DEFAULT_VALUE, + CXL_GET_FEAT_SEL_SAVED_VALUE, + CXL_GET_FEAT_SEL_MAX +}; + +struct cxl_mbox_get_feat_in { + uuid_t uuid; + __le16 offset; + __le16 count; + u8 selection; +} __packed; + /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ struct cxl_mbox_poison_in { __le64 offset; @@ -888,6 +911,11 @@ int cxl_set_timestamp(struct cxl_memdev_state *mds); int cxl_get_supported_features(struct cxl_memdev_state *mds, u32 count, u16 start_index, struct cxl_mbox_get_supp_feats_out *feats_out); +size_t cxl_get_feature(struct cxl_memdev_state *mds, + const uuid_t feat_uuid, void *feat_out, + size_t feat_out_size, + size_t feat_out_min_size, + enum cxl_get_feat_selection selection); int cxl_poison_state_init(struct cxl_memdev_state *mds); int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, struct cxl_region *cxlr); -- 2.34.1