From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36169C4345F for ; Fri, 19 Apr 2024 15:11:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AECBF6B0087; Fri, 19 Apr 2024 11:11:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9CF86B0089; Fri, 19 Apr 2024 11:11:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93D2E6B008A; Fri, 19 Apr 2024 11:11:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 76A9C6B0087 for ; Fri, 19 Apr 2024 11:11:20 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1A11580D94 for ; Fri, 19 Apr 2024 15:11:20 +0000 (UTC) X-FDA: 82026619920.25.57C75CF Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2047.outbound.protection.outlook.com [40.107.93.47]) by imf10.hostedemail.com (Postfix) with ESMTP id 251CCC0002 for ; Fri, 19 Apr 2024 15:11:15 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=Lwy9C1xR; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf10.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.93.47 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713539476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3qSeQz0enh3nAACey1JKcfgjxc5ZS1pjRYCYrOLMTs4=; b=TZ8Rk0StU0ERNCmjhAx65RY6STFMdJMp1EkUSI7J4o/GQ6mr3x4gWuytLQhhSGyqN1HwdK ND7/1oj/UuNh7nPF6E2vRrN+4A1hfN2tlm6nTompDeRCch0LKazILMPS2xSJ2pWyYdqjRI A2ctKX1KMX5mu32zDYSwomSqz69cizw= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=Lwy9C1xR; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf10.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.93.47 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1713539476; a=rsa-sha256; cv=pass; b=2F1bjiYhgc403IKBSbVmH4+jokuKx/CwNBMBzPeEWVPUjKzCFpw6MF0btVAfJDNU8ofvQ/ MJFytFlAcdrqPaNuvXL3OHriMznfSGmjiry0riXXSw8H+Yl0aHmYfKtpahGCDhtUJw+imO 2TqDfWy7KTstmKr1l74n8jMdfwkrsd0= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iGglFsMezYIvPja6laEvVLvSTpYRXcOQZOYjSCRFE2AOzHUu04vz4/hvPNLqvUuK/f0i2vL6wt8q1wx7l2VgexiXWF9b552cCJX7yapSbBmmiCmVKajtViUQveLDfsi17bUGObPJaVJkpR2hoYAzHcpTaxmdt2ellWs8MvKx7/k+xnH+enTUDBAEEJCX3r7vrU9YEI3vudWUDzkMyGnr6shMg4zqgN0+bA6z1HifTZxwj/C2CmKOWCCCX6Zc30p8TWyc3drURexESAoeJi35qWDvh1LZtKnmV+KKpRQbxxt5QNH0QZqNb+UBtmtOyJIs8cYwMfuj6nEHa5ddjFVv2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3qSeQz0enh3nAACey1JKcfgjxc5ZS1pjRYCYrOLMTs4=; b=gmnxAfuw71cwuJQIaUmunjmR29KdQiW4tVzSfRsMGQuNd4hNJYIm+QgsGnMseYfmTSJBv7yKVTpnP/yzcPdaujpzg2O6aMj0ExQCSOd6hF6+eL7IjsgyYrn2LkOyYUDmVD6vz4WZZ6jHHTE+AlG96+TWpr5tAcu1egvo7RWsb0pubNyPOh9AhRRZBctCyq3oI4hkd6CLG8kcfR21EfIEVesnjHxhkxdv5+8LH1JNMO+d94XbnYpFB+3IIikazgWsOelmt8Ega/OFTqTDN2FXHB+xkW4Xrgmc5DJFxApXfZ1sHLS6vRujDDgf6rV16CN/2TqhVrO505MiR6G3LHyGYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3qSeQz0enh3nAACey1JKcfgjxc5ZS1pjRYCYrOLMTs4=; b=Lwy9C1xRLLYn38lSawithV5dB0Yb5+GmGWmbBq8bAcBq1nmBJ8ZvU2xOazICg0cN8KiEm6873XgOpZn2gDETGcaFoK3Uro71xKXkbGi5gw3UFlLDwfRNfA4+GcxbSO9MQw8sI7iFci8bgq6AYYRmB+KvaZrTE6dWtEQhsxJXcog= Received: from DS7PR06CA0038.namprd06.prod.outlook.com (2603:10b6:8:54::19) by SJ2PR12MB9139.namprd12.prod.outlook.com (2603:10b6:a03:564::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Fri, 19 Apr 2024 15:11:09 +0000 Received: from CY4PEPF0000EE32.namprd05.prod.outlook.com (2603:10b6:8:54:cafe::eb) by DS7PR06CA0038.outlook.office365.com (2603:10b6:8:54::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.33 via Frontend Transport; Fri, 19 Apr 2024 15:11:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE32.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 19 Apr 2024 15:11:09 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 19 Apr 2024 10:11:07 -0500 Date: Fri, 19 Apr 2024 10:11:09 -0500 From: Michael Roth To: David Hildenbrand CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v13 04/26] KVM: guest_memfd: Fix PTR_ERR() handling in __kvm_gmem_get_pfn() Message-ID: <20240419151109.bo6kz4s24jgrmaj4@amd.com> References: <20240418194133.1452059-1-michael.roth@amd.com> <20240418194133.1452059-5-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE32:EE_|SJ2PR12MB9139:EE_ X-MS-Office365-Filtering-Correlation-Id: f21d702e-2189-412d-a4ec-08dc6082f18d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iunGVMZpDu9mmJf9+rNqettYlXiVIlnxFFBNycGuCOBsltobTMrWMJkFNMcmeGL27PuOg9ToDLyrJJWNOxLeuo0Wb43m7KnJpPsR9uVIIARMEBoDOnw+tLOTlNF2t+0jLhBD7ZKduQYR992RTyasB3OI4f/z6qcxIlk++by+mjedc90GRwRyHwtiWqdm92qLWTi+Rjr6THEWQHe9C78+1DYuV2VLQETWFVE07wSzuYVAwd8QHs5JsV8w3eiwntXSfn1PDrThFKzXt026Vp/PbQt51/OjuZ3f/Be7HoW1CcOpbys1ZFfZb1rTj6ISppynBGA9wgfp9ms5y2qX643eWarbQmCj0mRv/u9HtLeAQjtNc+oVFxhEmgdY/QjlpsXBCpC+NgncZR9ytlLAa0UdBR0ZgS4+61o9pTGlB426wyjVaXbdv3qLPrn6XZLwNaEpOyXFGMZWSlFfye3nYXR0DnglixQEqS2ubob7AWu5SHOzLvrTTdPf2hv4LFh/04fsWsBMKVOUtLFSs3VNBrUO0y0FrKKXldEoi3MT1sCDzuF8eMw6KFSGB4nxmSe4tmqBOjRMwB/1Dh3ZKEWSMCo1ePPeFYm5uLsy5wxXtE1cvRKksZVQFYqVaZ6F/NrT900WiPI/PbvY6riEKdodD7oBUqsHNGoPu/grhLrCA98bkIYBBBI9YMRcLv3u/QaLR/chu9QruKaPTG2HTVfZfmuu0coWAVaYs7jM21lm6xRhzoo9LHzZ5T/Q9EpFlnyoZMgm X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(7416005)(376005)(82310400014)(1800799015)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 15:11:09.2923 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f21d702e-2189-412d-a4ec-08dc6082f18d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE32.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9139 X-Stat-Signature: dp9beeauihcmwmm3s1xtgerff8bidk68 X-Rspamd-Queue-Id: 251CCC0002 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713539475-129290 X-HE-Meta: U2FsdGVkX1+JjS6uI6W2i86WuzPjVK7fzNR5aYzHCNaaLh6X7RxRPsNE3ePIfOKlz57anxnCvaSLqRaqx47YbTWMqBWgAltS43oNy0jHNRKxKX+XlPVTCMiL295RYgC0l+CYf/8LlWbz6i8VV4u80fi0sw3znpB1xk6I9Ia/5AWrv3dvvImnXFKLscPU4wmqCbDWSisErwMNhJkQRa+ROO1leMIgPnmOd2aLWexQlXi2oDOtSgmgHYlq0+cZvYVAzr9VevhqdsnuxmkH/MvLfHFlbQvqPuNF49zQcGgKGxVLlb5RQdXdu1GpdSsGLxj0l2kuqTzoUev+4iEgPLbnEq1rmXgIdTWDoxnpH72snPZ7gO4Z0GyXjU5NN3xyx5C+aCczeuaSSB0q8+upcYsUV/KbWEe86o58NkHv6MDrDoUPFFaWvbmVo5LaqPxjZZZnyggZfpfeiUlBw9mP0BgmVIfrgxtXS1jwLQsA63kDilxAmVmu45HASDrDwNHMAeQCqFm/aWae0X/5U1IrsaySyPNP73LOVy81I9bbIuFjSKeZCF8dzcLzwhvnE9Wkf5LfZzYbrQs/CDvsDxkrXuAK+BuOaV0uL1OAfpT4Bw9mc6t4ZIXGo+s/II9+KLXOzIC9wO+vWvrwJFukJg/kaoCe60vQ93xOcfdwzqBl+eyVOUdhBmOZr5qXOxJKKopAGav10WgYJVxYeo8J+J9EKS4F81mnvFbqCImTo4wMFnedzJ6BbPqL/wCUIb6CvQyWtFpv0oGbq8kBxDYlp88MLfe460y3AQjDTpFpYd9kBxT1yZunxiVORw27koVYz19LGomGIxQav3Flgv6nTVcjeN9JJ9Km95OCUwX6oW5dkPtvHk4d3PfWtvKa1VQ6EZwpGneJViOXmgrpwpWeO3Ry7RCBQK5pjdZr2qRVGmduaUepjlAugcfUmqw7eIRqGevwfbupVEXgFxFCG2VO7BDv6ZE p9smXBAs IKT1i4yaGAjVVZpw+8cEKdATxWD0w9A9f0qZwhhtNTGiAxI8prfK3GAt6XhY/pRQL7PtOUqwQbXYqJVRYEO0PNn1APtbINqlRSBhmtD1kamSREjBNzyRNqsqNR7sXekD3Ipi5MAH0tEki/WeT3HrzfqQVGReq/PsGN9OQ7eemg+lES7JrNadwukHvjo+7722JMM/wlZFa+Pedn4yPQ/1vdT+rgLWvPUQTToz4EB3XcLMwhkkDCRncacySB/0zvB6u4Yt+mR4mKTq18eT/Uf4F/+cd2glMW8kDvlDzdspLUz6D0gOJDfpK3ka0Sd5mI/RGIUB0tiuwrFQwE30F13UDQAuzndJ/DMLkickaqyfAcGLBvQNLg+NItQ9xGm0o5ixXiJ3xQ2IzKPJEEZU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 19, 2024 at 02:58:43PM +0200, David Hildenbrand wrote: > On 18.04.24 21:41, Michael Roth wrote: > > kvm_gmem_get_folio() may return a PTR_ERR() rather than just NULL. In > > particular, for cases where EEXISTS is returned when FGP_CREAT_ONLY > > flag is used. Handle this properly in __kvm_gmem_get_pfn(). > > > > Signed-off-by: Michael Roth > > --- > > virt/kvm/guest_memfd.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c > > index ccf22e44f387..9d7c6a70c547 100644 > > --- a/virt/kvm/guest_memfd.c > > +++ b/virt/kvm/guest_memfd.c > > @@ -580,8 +580,8 @@ static int __kvm_gmem_get_pfn(struct file *file, struct kvm_memory_slot *slot, > > } > > folio = kvm_gmem_get_folio(file_inode(file), index, prepare); > > - if (!folio) > > - return -ENOMEM; > > + if (IS_ERR_OR_NULL(folio)) > > + return folio ? PTR_ERR(folio) : -ENOMEM; > > Will it even return NULL? Staring at other filemap_grab_folio() users, they > all check for IS_ERR(). Looks like the NULL case is handled with PTR_ERR(-ENOENT), so IS_ERR() would be sufficient. I think in the past kvm_gmem_get_folio() itself would return NULL in some cases, but as of commit 2b01b7e994e95 that's no longer the case. I'll fix this up to expect only PTR_ERR() when I re-spin v14, and also address the other kvm_gmem_get_folio() / __filemap_get_folio() call sites. > > > if (folio_test_hwpoison(folio)) { > > r = -EHWPOISON; > > Do we have a Fixes: tag? Fixes: 2b01b7e994e95 ("KVM: guest_memfd: pass error up from filemap_grab_folio") Will add that in the re-spin as well. Thanks! -Mike > > -- > Cheers, > > David / dhildenb >