From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 383B7C4345F for ; Fri, 19 Apr 2024 10:17:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B02F56B0087; Fri, 19 Apr 2024 06:17:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB3296B0088; Fri, 19 Apr 2024 06:17:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 953786B0089; Fri, 19 Apr 2024 06:17:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 770E16B0087 for ; Fri, 19 Apr 2024 06:17:11 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 139CF81142 for ; Fri, 19 Apr 2024 10:17:11 +0000 (UTC) X-FDA: 82025878662.16.1153A8C Received: from SINPR02CU002.outbound.protection.outlook.com (mail-southeastasiaazon11011005.outbound.protection.outlook.com [52.101.133.5]) by imf28.hostedemail.com (Postfix) with ESMTP id D4E2AC0015 for ; Fri, 19 Apr 2024 10:17:07 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b="Y/oX8hXO"; spf=pass (imf28.hostedemail.com: domain of hailong.liu@oppo.com designates 52.101.133.5 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; dmarc=pass (policy=quarantine) header.from=oppo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1713521828; a=rsa-sha256; cv=pass; b=B6AvBr0OqkaLgGcXWz7Y8n+QAqdIw7Wp9qfT7996Ou1ERYj7cB1xfRxlcCEvBG3UrJc2+0 ONi65z2lek+M63MfcsD8hcd/h8xXqcBLJuT8jYSQI8DgJfmg5AhI2f6Fy7lfxsy5k7zuHq z5iwa0eJ4HjPVyd45JHpYs+TH7BWWOU= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=oppo.com header.s=selector1 header.b="Y/oX8hXO"; spf=pass (imf28.hostedemail.com: domain of hailong.liu@oppo.com designates 52.101.133.5 as permitted sender) smtp.mailfrom=hailong.liu@oppo.com; dmarc=pass (policy=quarantine) header.from=oppo.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713521828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=D9UxydkTj6zi7CrpC/MsY1FMJqTiZr603AVf+x5Q29Q=; b=cmSKi2kL4Ybdry3DeJaL+7rzDRSi8d/UGFPeuYbkF8hyMK4D9TQnl5Vc8Yk3SVg62JAGh6 lC7t9kr0SW4K9H5y7xdwp8gtsFIeKZA7MiU1d1WCNzuyS0TIqa9tW8bsoeZpXPpQ1PRLkV xOdJdHEa0NJMBV0TAcvLMefsJ91bkjI= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AOACkC3902hvNtW9/SGo1MRborF9fdZhpHWdaRirmi/liAcPr9xPd+OwEpUh6oj5jpxHJBwJ2W2Hrt2orwl5BnBprhazZd9f6aFnsd7DR77ukjm9QsbN9VS1xIa/WGftzKMPFEKpAyAmHS8POTCm9QZiTnFrXGcGPqBkP7pqWKk10awA2NPBXUf6BIbzJgKh9/N4G8lj3PKZgBkBptY050UI6Zpa/WKBXRxmt1F4qwGZhHxhkqaNcTFyvJ3y6DVwZJUpX8smTDCS4lrMEZWHuBBrnHpdeJ8+E1o8T0+Mjf0LXr7BCT6m+NCOOGy05a45NYBz5aFWtY0ETXy7CRVi6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D9UxydkTj6zi7CrpC/MsY1FMJqTiZr603AVf+x5Q29Q=; b=OWeFG3ombaKdGw+iOWv6KgjLo09DOsP6FTqufmGdMrxwGkV07zxsL2MV5SfEy7PiUnFBxlgnKAS36ARaoDNPNn6k1KxC65yfD2LQHpUnv6E6cAZlZuyWmujkDeneDZ2nXOgcW/sxilsO7rtXZHll1tu57sHsrOuM1WQhivBPfaBH6Zx6ZK2cMk/9QX/MyN1V1tTEm9Fj6MzUAbFNbPwt+msJcQbXgKiMr06E+TlpbKxkWo6VCyFzxpgUOO0qfx1bblvwto9KpXXDeY6hAMv1zwaXv3VWBVffeWwwy2FJ7hEzJUKIbZ1svql+jEFiSWapAhMmZ3dw2GAcKS1/G4yDoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 58.252.5.68) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=oppo.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=oppo.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D9UxydkTj6zi7CrpC/MsY1FMJqTiZr603AVf+x5Q29Q=; b=Y/oX8hXOUK1mnodRb94zGZt/V39s94LUd1YvsQ+7jkTgoaFo/kFDWJWHV0HFKnoXlvMUMfaEQfojxZTQS2XjzzhYrNs/ZRtqnxipP7gi3dNMmGyuwEZ9747C2zOkR55kfch3Sucy9YXmOA7/WRFQvcTW7lCCZdsktMyDq/LmNvE= Received: from SGXP274CA0002.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::14) by TY0PR02MB5573.apcprd02.prod.outlook.com (2603:1096:400:1bb::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.39; Fri, 19 Apr 2024 10:17:00 +0000 Received: from SG2PEPF000B66D0.apcprd03.prod.outlook.com (2603:1096:4:b8:cafe::a) by SGXP274CA0002.outlook.office365.com (2603:1096:4:b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.29 via Frontend Transport; Fri, 19 Apr 2024 10:16:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 58.252.5.68) smtp.mailfrom=oppo.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=oppo.com; Received-SPF: Pass (protection.outlook.com: domain of oppo.com designates 58.252.5.68 as permitted sender) receiver=protection.outlook.com; client-ip=58.252.5.68; helo=mail.oppo.com; pr=C Received: from mail.oppo.com (58.252.5.68) by SG2PEPF000B66D0.mail.protection.outlook.com (10.167.240.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 19 Apr 2024 10:16:59 +0000 Received: from PH80250894.adc.com (172.16.40.118) by mailappw31.adc.com (172.16.56.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 19 Apr 2024 18:16:58 +0800 From: To: CC: , , , <21cnbao@gmail.com>, , , Hailong.Liu Subject: [RFC PATCH v2] mm/vmalloc: fix return value of vb_alloc if size is 0. Date: Fri, 19 Apr 2024 18:16:43 +0800 Message-ID: <20240419101643.11534-1-hailong.liu@oppo.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [172.16.40.118] X-ClientProxiedBy: mailappw31.adc.com (172.16.56.198) To mailappw31.adc.com (172.16.56.198) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SG2PEPF000B66D0:EE_|TY0PR02MB5573:EE_ X-MS-Office365-Filtering-Correlation-Id: 86e89d7d-bab6-4983-eca3-08dc6059d96e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zEFA+XK84OHm0ksvS1Oa8/5b0xjGncVptXwhoGyHw7pMvrBooR+tJ9ghOB2rrbpadBOmRQOLZS/qtLAWQ0ea3BjmvetQwAzTTyacJic1cmvHMLRAWK5pnFaHFnEjPtjtz78H/d7VY0UYyj04h7WXPy65GYOh7UkiVBa/vEb1uern8u5QS0AhMlTtf8jnzi9jDd2vuZQdfhmbY+7++Z+AD8OEuu/PhPYE+YU7MaRcn/CoCCCzAYH1G0oslXU5YPmsrg+AGlgIzpPr8Q70/MSmnufVTrhwqxM7vjhqTJvgSPlnI5HPP4KLRQN5v3vt/17uWEkleSXoXqMuFdGTdsx7TwmIZwut5Pkc4/c1aJHEX792+0ZgdaDkjzFqCc1xtnszBLPnmea9R88TXeBtSJSoIKwoHi5whv42pZdk1I/7xNMtIFOE32PX1to5k5kcRhXJF10LrTfMB6X0bqrlNEbiB3HjY9E+JcSfvCmbE227I2rQduUksOpUNSP0dr2qjKKR25S2EzHzUI643ZLJYhNXT1oqpTRuZb+splqCf8qfrDBBU+hAsXRI0dBzd4gt5+zwXF1tFvLj6CmZBG8q2U/0nt8YN8cGqHsZRNBQCpZqo4BBd2UyTm4XUuhAfzTPK0G2j1sNYALbH/yRaNbZ0CuK9x0A6y8EG3rJrlpRdKfpAUk2Jxke1expeiskcQVMmfYiF9r+1IJ2FmuA307tJaLRRyOKMS7X+ufXdTSq88pwRSmW/wBqy77o4D7NW9gknESC X-Forefront-Antispam-Report: CIP:58.252.5.68;CTRY:CN;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.oppo.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(82310400014)(36860700004)(376005)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 10:16:59.4955 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86e89d7d-bab6-4983-eca3-08dc6059d96e X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f1905eb1-c353-41c5-9516-62b4a54b5ee6;Ip=[58.252.5.68];Helo=[mail.oppo.com] X-MS-Exchange-CrossTenant-AuthSource: SG2PEPF000B66D0.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR02MB5573 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D4E2AC0015 X-Stat-Signature: 47z58chun3p5wdmer3tywsgaipruoc7m X-Rspam-User: X-HE-Tag: 1713521827-258160 X-HE-Meta: U2FsdGVkX1/brF62Alv4ACIV3r53jenncd6YeS7qeJ4OovYl1m2bVXd3LIQecu2Vz2bf29Kj3g2LlA5hQXxNaQXH8wMCKJWxR8eQP/9aqtzXpXdHsl11/S3CKnZma+hkMtGc1fGSNT4mOVCsZ5mB7CWBVy4rzL45gZtDTl5AG1tDnDlpwLNW6xY+oH45wrQ3yQs7CuAg9bAAVSo8cxM5QDsth7ffATY0s7geIAeKllFfoRrfLiTFD6O3IZygiZRidTcNucn2Rxh7rRpQH5hbkR+b/UnRTskeAG5/uAQgimMN6+dSsUKC9RBs4dzlkpoUiCNt43msXgNGA4YY7yQOWJS5ZPY/b9JL8/hoqQmG1W9+SDW1ypEMuOoUxhNofz+wW/AUXhKZb3854OLc/6QnwvVaIQyfsO1AMOh4lUEzycL16Mc+va3+fgpf0S51pl8Z5eAPqUP94R8OZG4tnMe6MrhzExAuS7OJYsFbyWpqVb+ZQ8WBBeB2B3jbbfFegO3UmfxreZdps/mcTeZKscVC28jRpnD2+P53k7PESZOmyZaFVVpgs8tQMdbwc93Kv8wWnxdIhqqLBequZJcd5qA1E9ekWFwVeorVXItt2lFVSaGOcehYsI2Hl1g8ryeYkxQcix17Qo71vTC5rOYSD5PdRmgz490V5m2JNpjTjIJ+YzKPv7+hLkHQFfwJpi3vi5vVoW0Y22I/MlKbA+DYE1E9kZglu8bFFwjxsHNVk7AKIUyEjmKzz0DKd60kdRcyYxCllBqD5TH3cnqoh4cTGGVzV/OPIVrKzmmB0UfC6MuaSYGuXAPf7YdfQATjbyAsIzH7RA9X3TJrVEs9l6fXqzN+bXH4leTAA2cLv5qsLLjhwJ7Wa6fHGJ0o6LQUoeWMyTbLP5wEydyQydJnMjKuE/1p+VydStKihHD591lYIbnihNE5Zw8c8mp1v9piNHv9WTnypnLoDv1NQY73xH2ELov lC2PhhNP t75Un1yoUZaeAYz7eqZEVC20zxyuRZgxJWvhQgSHa8BP7Fn8ppkIN2zIt17iK5WVLRaLXk20VGK2z+MdWYyavbe6AUZDZCGAU3Lj+E0u50CN8FIMvDbyuBCAWJ/8M3eEsJ+iHYnupTsrEqVTeL59X4lWaleo6R2z35Q8AtgRthKcSkF2d96v67kyBbvord/7s24NoI1DdJCBB52Z7SJcmovEgLJPFwdMmQXUfYep21z/Rbw1ICKquxF/FFDyMS6WubeOs5yVHEFOKaOa/Qyd4JrcCn6uP4SBnwNsIAgT7tKb1k4LfmmJ4aTL0y5DWgYbefyDtBmT+hGOTe3gtLTdzAlLmce0Aidn1K/bIUnuNh9uGdEJFShpIyQF5ew25IiCPgfBSdTGf7vX4JICwGgEpne5H2ubfTSx+D3dp2cK82u5o2HwAHT3dinfoEkMiKGC0bF8X3qAMsS3qferI66A47Kfe9BUxVQbdtcUQa0Izg6PiLqwHDQOX7CPKxUFsKOVY0xkn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: "Hailong.Liu" vm_map_ram check return value of vb_alloc by IS_ERR. if vm_map_ram(page, 0, 0) , vb_alloc(0, GFP_KERNEL) would return NULL which cause kernel panic by vmap_pages_range_noflush。fix this by return ERR_PTR(-EINVAL) if size is 0. Signed-off-by: Hailong.Liu --- Changes since v1 [1]: - Return ERR_PTR(-EINVAL) or not check IS_ERR_OR_NULL BTW, Barry suggests me that if count is 0, return directly, in my opinion, change return value is more resonable. [1] https://lore.kernel.org/all/84d7cd03-1cf8-401a-8edf-2524db0bd6d5@oppo.com/ mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index a3fedb3ee0db..c430a999805b 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2173,7 +2173,7 @@ static void *vb_alloc(unsigned long size, gfp_t gfp_mask) * get_order(0) returns funny result. Just warn and terminate * early. */ - return NULL; + return ERR_PTR(-EINVAL); } order = get_order(size); -- 2.34.1