From: kernel test robot <lkp@intel.com>
To: Christian Brauner <brauner@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Baokun Li <libaokun1@huawei.com>
Subject: [linux-next:master 5767/6937] fs/erofs/super.c:775:2-7: WARNING: NULL check before some freeing functions is not needed.
Date: Fri, 19 Apr 2024 07:15:32 +0800 [thread overview]
Message-ID: <202404190747.REAcTK1e-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 7b4f2bc91c15fdcf948bb2d9741a9d7d54303f8d
commit: e4f586a41748b6edc05aca36d49b7b39e55def81 [5767/6937] erofs: reliably distinguish block based and fscache mode
config: i386-randconfig-052-20240419 (https://download.01.org/0day-ci/archive/20240419/202404190747.REAcTK1e-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404190747.REAcTK1e-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> fs/erofs/super.c:775:2-7: WARNING: NULL check before some freeing functions is not needed.
vim +775 fs/erofs/super.c
763
764 static void erofs_fc_free(struct fs_context *fc)
765 {
766 struct erofs_fs_context *ctx = fc->fs_private;
767 struct erofs_sb_info *sbi = fc->s_fs_info;
768
769 erofs_free_dev_context(ctx->devs);
770 kfree(ctx->fsid);
771 kfree(ctx->domain_id);
772 kfree(ctx);
773
774 if (sbi)
> 775 kfree(sbi);
776 }
777
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-04-18 23:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202404190747.REAcTK1e-lkp@intel.com \
--to=lkp@intel.com \
--cc=brauner@kernel.org \
--cc=libaokun1@huawei.com \
--cc=linux-mm@kvack.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox