From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D60C4345F for ; Fri, 19 Apr 2024 04:44:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4E226B007B; Fri, 19 Apr 2024 00:44:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFED66B0082; Fri, 19 Apr 2024 00:44:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A77766B0083; Fri, 19 Apr 2024 00:44:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8AC4B6B007B for ; Fri, 19 Apr 2024 00:44:25 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C5E0AA02E0 for ; Fri, 19 Apr 2024 04:44:24 +0000 (UTC) X-FDA: 82025040048.05.08E5701 Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by imf26.hostedemail.com (Postfix) with ESMTP id B2FD014000B for ; Fri, 19 Apr 2024 04:44:20 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=rFUtTOkv; spf=pass (imf26.hostedemail.com: domain of hariom1.p@samsung.com designates 203.254.224.25 as permitted sender) smtp.mailfrom=hariom1.p@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713501861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=Z25o43JCrYV9Z2WyXrctJEsjpL5tpjd53IPnfYhtPd4=; b=nn64klQt33zT1YkT1g40RmxrjF+e4RauC5R0rhBPrMqpdq4g79YD9j9pKz0YXmshJejBl9 elfh/36ri8NhWmF+OBSExHg3H+/3ZwuChRWv1CxsakS94/E4jR4is6wQes5VCgfbCtR4D0 TlFvjf6a6IzsqS8RQWFS2qio1ltKd8Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713501861; a=rsa-sha256; cv=none; b=qtJXTkLzCRhMfm/9JVx99lGgDeUTvzBwP0MEoyB4fNMsU+8gyZ8MJu321erDCE3HHkDP/0 /ffmDmfftj2Jz8Wi5N2zF+p7AWg5gZLDxSo4lqKhrpVFlxogbRPyHTx4xCSEwgaa1L7yIh awq8Xs04GcZa6LbsWKM+flOcOvFaDI8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=rFUtTOkv; spf=pass (imf26.hostedemail.com: domain of hariom1.p@samsung.com designates 203.254.224.25 as permitted sender) smtp.mailfrom=hariom1.p@samsung.com; dmarc=pass (policy=none) header.from=samsung.com Received: from epcas5p2.samsung.com (unknown [182.195.41.40]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20240419044417epoutp02b2a7f868653bc34338ec103af97732e2~HlNxSV74q0917609176epoutp02f for ; Fri, 19 Apr 2024 04:44:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20240419044417epoutp02b2a7f868653bc34338ec103af97732e2~HlNxSV74q0917609176epoutp02f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1713501857; bh=Z25o43JCrYV9Z2WyXrctJEsjpL5tpjd53IPnfYhtPd4=; h=From:To:Cc:Subject:Date:References:From; b=rFUtTOkvh/Jn/WHDg9UKXcYd5lP7AlugfwBcKaZeljx6YojRkzOM9tVF/ZXyjwOwf 1XfoJ5CIRX9DtWbs71dFGAtJZ5xZcAhetncbIt0qXlnX0YqPur0nGVRgB9K6aZY/n/ li6jAXbxx94kXSVHZhbxGjAuPqBCILsu7Nfl1JXY= Received: from epsmgec5p1-new.samsung.com (unknown [182.195.42.80]) by epcas5p1.samsung.com (KnoxPortal) with ESMTP id 20240419044416epcas5p1b4c56dce2b87c4cae8c007c810ceb3e9~HlNxAuWQ92300223002epcas5p1d; Fri, 19 Apr 2024 04:44:16 +0000 (GMT) Received: from epcas5p2.samsung.com ( [182.195.41.40]) by epsmgec5p1-new.samsung.com (Symantec Messaging Gateway) with SMTP id E5.40.19431.0A6F1266; Fri, 19 Apr 2024 13:44:16 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas5p4.samsung.com (KnoxPortal) with ESMTPA id 20240419044047epcas5p4a90ca734d73bc9a87cd1670beaa24d8e~HlKtmeK4u2796527965epcas5p4y; Fri, 19 Apr 2024 04:40:47 +0000 (GMT) Received: from epsmgms1p2new.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240419044047epsmtrp2dfc97ad5f34c96fc1e9a44799cebc91c~HlKtkkO7O1545515455epsmtrp2a; Fri, 19 Apr 2024 04:40:47 +0000 (GMT) X-AuditID: b6c32a50-ccbff70000004be7-71-6621f6a0e120 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2new.samsung.com (Symantec Messaging Gateway) with SMTP id 37.A1.08390.EC5F1266; Fri, 19 Apr 2024 13:40:46 +0900 (KST) Received: from localhost.localdomain (unknown [107.109.224.44]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20240419044044epsmtip1e89b19a67f09edbf58542b6956d1862d~HlKrhqEca0959809598epsmtip1h; Fri, 19 Apr 2024 04:40:44 +0000 (GMT) From: Hariom Panthi To: akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, maninder1.s@samsung.com, r.thapliyal@samsung.com, Hariom Panthi Subject: [PATCH 1/1] mm: vmalloc: dump page owner info if page is already mapped Date: Fri, 19 Apr 2024 10:09:10 +0530 Message-Id: <20240419043910.2156379-1-hariom1.p@samsung.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsWy7bCmhu6Cb4ppBo23TCzmrF/DZvGk7RCL xekJi5gsLu+aw2Zxb81/Vos73+axWxye38ZisfFetsXqiywOnB47Z91l99i8Qstj06dJ7B4n Zvxm8ejbsorR4/MmuQC2KC6blNSczLLUIn27BK6MthnTmQqOC1UsnKvWwDiHv4uRk0NCwESi /89m1i5GLg4hgT2MEt+O9rJAOJ8YJfrb5rCBVAkJfGOUWNhqC9Nxdc9aRoj4XkaJxh+xEA1f GCV2f/vM3MXIwcEmoC1x/JMVSI2IQITExD0XmUBqmAUmMkr8bd/CDpIQFgiSeLJ9GtgCFgFV iRtrTrKA2LwCNhInX55lglgmLzHz0nd2iLigxMmZT8BqmIHizVtnM0PUPGKXmPXEG8J2kVi/ +h4rhC0s8eo4xC4JASmJz+/2skHY5RLdC7qhahoYJeYu94Gw7SWeXFzICnI/s4CmxPpd+hBh WYmpp9YxQazlk+j9/QTqNF6JHfNgbGWJuUc2sUDYkhI75ndA2R4Sf+9OhYZVrMS/X32sExjl ZyH5ZhaSb2YhbF7AyLyKUSq1oDg3PTXZtMBQNy+1XK84Mbe4NC9dLzk/dxMjONloBexgXL3h r94hRiYOxkOMEhzMSiK8ZhyKaUK8KYmVValF+fFFpTmpxYcYpTlYlMR5X7fOTRESSE8sSc1O TS1ILYLJMnFwSjUweWdxXTqYss5gbcynncv8DsftVvE79SNpfmxAdrHcUWehiuuCdyuu9IYw bNXJ71PaVfF/ntvD1lUy5ltz7BhYD+gt5u3307m6x+ERd7fo9lOOftkb1qd9VPv7soF9ggyL xXr9dx8+1Hommm5Pc1+VdT6HxanO1bhA4mYbs5Ypt8/i6n08b3IXLn16bEb1zUDpjjuPPC96 G7K2u3Md9a7fwvjk4717AgKCB+4vmj3vxHW1667d2343SZ6ckvNCRiNC4MH66KhHt3ZUSIWV TvvMxtfiWRY985Jt6a9q89nWd6z+zd+RoSk55br9rvWmMi2twS5nb02psVQNiw0353f6G9v+ p129weuuyL0n6ZxKLMUZiYZazEXFiQBa09PIpQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJLMWRmVeSWpSXmKPExsWy7bCSnO65r4ppBlfWWFnMWb+GzeJJ2yEW i9MTFjFZXN41h83i3pr/rBZ3vs1jtzg8v43FYuO9bIvVF1kcOD12zrrL7rF5hZbHpk+T2D1O zPjN4tG3ZRWjx+dNcgFsUVw2Kak5mWWpRfp2CVwZbTOmMxUcF6pYOFetgXEOfxcjJ4eEgInE 1T1rGbsYuTiEBHYzSvz/fZQVIiEpsW7+F2YIW1hi5b/n7BBFnxgl3r49BZTg4GAT0JY4/skK pEZEIEbixZwfbCA2s8BURokX8xxAbGGBQInW3Z1gM1kEVCVurDnJAmLzCthInHx5lglivrzE zEvf2SHighInZz5hgZgjL9G8dTbzBEa+WUhSs5CkFjAyrWKUTC0ozk3PLTYsMMpLLdcrTswt Ls1L10vOz93ECA5dLa0djHtWfdA7xMjEwXiIUYKDWUmE14xDMU2INyWxsiq1KD++qDQntfgQ ozQHi5I477fXvSlCAumJJanZqakFqUUwWSYOTqkGprWPbta8W+/l/f7Bo67F+loB6vHRM9KN Dlxe+P7m44nRfXtub49Ujd08L9rXaM/+Y1s8DeRz03lNVgg3T/L2edFx4M4GZasjwlcm/V2s p3N9WtuplQrrjGJ8bkmf1Ahd0ZzfWxx+++ri3gab+b5Pfh6aZlyUwDSP/03QrZXZq32Wbpl3 u+musOPEAvU6vo1ZCe9l9j8KylGLPHm2dUlzpM7dplmHHjsuq1nW9mzZl72PzjDNLjzitzZU 0e5u6tO1D5bEPI6M2q8R/OrJ390RfA2/ZWVuy927XxIQvzd4cnnfhHen84MNZ+Z1NrHlbS/i v7e/ubTu9/aQLdeFVH6E6k1a736OQfFm3oZr0gfK274psRRnJBpqMRcVJwIAhluRV8wCAAA= X-CMS-MailID: 20240419044047epcas5p4a90ca734d73bc9a87cd1670beaa24d8e X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: REQ_APPROVE CMS-TYPE: 105P X-CMS-RootMailID: 20240419044047epcas5p4a90ca734d73bc9a87cd1670beaa24d8e References: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B2FD014000B X-Stat-Signature: ionwr7wwz7871fz5n46qdcc1g1dsktbq X-Rspam-User: X-HE-Tag: 1713501860-319158 X-HE-Meta: U2FsdGVkX18dh/NQVZAdkGXta68oGBthxk1rkQG6RYxV96igv3YGIyoATh+qdA/qha+dz97WrrdvwYC/243Ehc6/c/iMFCKuJT8ETSOyWT+1HGHL6h+n3/duo9ENT5CtMlqhe2FrXtvRchClHXQu8NCnHAoU6ai2LFKid79bkBj7e8CJBlAGKoQbb4gRji1/QV+EztNbeBBrpLgpuw2I/dMZlXIKjyFbGjsb6RHj73QZb5ea1M9ALbvlt2RjGIe7Abn9JUsKRcQ6CY9cDVsO1iU8qWlX0bkeOdvZfX09JYS6fWAIEpHdIRF1f+DFps12yhEbGQ6O/PrmIb4GElQP+2agTjukEtD/Eq2bR3QubFPGEKoptcgYE0C2tZgYTssUkNfRcFRYiJMNGfZ6T0r+BE80D1o9T4ZLSIxpDxYSzGcykBXu2uSYpk2t65rAV8/QjXBF0+w5x/WgdpqNfcUjlDKCweYCRqYtiC5MEvZUgWqFP219RDaWhc0uz7WZzGsIhSQd+r0QyNSJbgC+sHLU0gm/6//nJFTFFwudPY8Sz/0J4EgAVPyUKQPtdt8oNhsuk7G8RLwtT30XLLdL27aw67IBKaAt2M2/ZCkmgusv/mRXI8gc/nP8r5WSaFuk9h3AR7yEEwZBUBC/Pr3H+RByRCbeEAv6FKFfrOyxkIqUze7e1m3XTtQ9pIHuFC3o3ouQvLRmbqL72N6hNHcFP/s7NGlnCK3XKOIolB1oiRooYLEFeg1GWr1WcoIzgcky8gd31J48GkmccAuOsaQn91uB63P1tg6hBiKgXJrLcNwxhxVVY2CN4wxRbN4FbnFFh42yrv0q+LRUnM5VPZS/gPAag8QNiXYpQhJePolKTIEzyRRK/h7y4vYX7ZfvTF7hf950G9YNJ37NN0hgomdW3ExulpduUosmnBhJW4SEjpVZTxpb2Rq2/wdFAJjewi38KTjKI1E+q66V3UPSIDMm9yb A3l+9oMU M4goSNQz9g9/prZI5uWFZp//l9clQa2mn0hffVgELhW0lSmmnmHpbnN5LPJadeY9q7DtQeS7kpU6sbfeZGX68SO5FIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In vmap_pte_range, BUG_ON is called when page is already mapped, It doesn't give enough information to debug further. Dumping page owner information alongwith BUG_ON will be more useful in case of multiple page mapping. Example: [ 18.258806] page_owner tracks the page as allocated [ 18.258970] page last allocated via order 0, migratetype Unmovable, gfp_mask 0xcc0(GFP_KERNEL), pid 81, tgid 81 (insmod), ts 18257811008, free_ts 0 [ 18.259327] prep_new_page+0xa8/0x10c [ 18.259455] get_page_from_freelist+0x7f8/0x1248 [ 18.259591] __alloc_pages+0x164/0x2b4 [ 18.259703] alloc_pages_mpol+0x88/0x230 [ 18.259821] alloc_pages+0x4c/0x7c [ 18.259923] load_module+0x74/0x1af4 [ 18.260031] __do_sys_init_module+0x190/0x1fc [ 18.260154] __arm64_sys_init_module+0x1c/0x28 [ 18.260280] invoke_syscall+0x44/0x108 [ 18.260394] el0_svc_common.constprop.0+0x40/0xe0 [ 18.260530] do_el0_svc_compat+0x1c/0x34 [ 18.260647] el0_svc_compat+0x2c/0x80 [ 18.260761] el0t_32_sync_handler+0x90/0x140 [ 18.260887] el0t_32_sync+0x194/0x198 [ 18.260996] page_owner free stack trace missing [ 18.261143] ------------[ cut here ]------------ [ 18.261272] kernel BUG at mm/vmalloc.c:113! Signed-off-by: Hariom Panthi --- mm/vmalloc.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 68fa001648cc..9c91091887de 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -42,6 +42,7 @@ #include #include #include +#include #define CREATE_TRACE_POINTS #include @@ -96,6 +97,7 @@ static int vmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, { pte_t *pte; u64 pfn; + struct page *page; unsigned long size = PAGE_SIZE; pfn = phys_addr >> PAGE_SHIFT; @@ -103,7 +105,13 @@ static int vmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, if (!pte) return -ENOMEM; do { - BUG_ON(!pte_none(ptep_get(pte))); + if (!pte_none(ptep_get(pte))) { + if (pfn_valid(pfn)) { + page = pfn_to_page(pfn); + dump_page_owner(page); + } + BUG(); + } #ifdef CONFIG_HUGETLB_PAGE size = arch_vmap_pte_range_map_size(addr, end, pfn, max_page_shift); -- 2.25.1