From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA22FC4345F for ; Thu, 18 Apr 2024 14:50:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 527A16B0085; Thu, 18 Apr 2024 10:50:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D76F6B0087; Thu, 18 Apr 2024 10:50:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39EC66B0088; Thu, 18 Apr 2024 10:50:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 196CC6B0085 for ; Thu, 18 Apr 2024 10:50:25 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B97618139A for ; Thu, 18 Apr 2024 14:50:24 +0000 (UTC) X-FDA: 82022938368.24.A5D14FE Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf22.hostedemail.com (Postfix) with ESMTP id D7317C0014 for ; Thu, 18 Apr 2024 14:50:22 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mwU7zx5+; spf=pass (imf22.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713451822; a=rsa-sha256; cv=none; b=vnko07DyUz3IW80beFovSK2L/xnnt4qcMfCWmHYPFG0iItSU+XqeHNBosc1MTMoU2/Ye8H mORLcHsBc4nXVmuybLGyckLUm1BN1E5wjMtTcW4m41y7fqyhY8QF3fswRjRd468FFxuwDw 0J3n8rHIupGaQO3ke8KAq9EQYFujpNA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mwU7zx5+; spf=pass (imf22.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713451822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6p+8w8Hh04Jmf8oGwjxpLa/UzKTop1h7DhMYms+7Tq8=; b=1AbheOwjEQ16u5VVlpd58Fl1KzgORzk8Llv0V1VJ4iHCk5vzTRFG8oSfaHVneszz+6ZyRj VaR9KSPviVSSaDFc2E48ZWjy5eybVdgEqBm8tiDAvCNmcXzrU6T2bClsE3OsnAIpGCqhAk vIg+Aej6AJImdlltMv4IoofJiUPamZE= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6e46dcd8feaso512895b3a.2 for ; Thu, 18 Apr 2024 07:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713451821; x=1714056621; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6p+8w8Hh04Jmf8oGwjxpLa/UzKTop1h7DhMYms+7Tq8=; b=mwU7zx5+akQVWkCUt1Bh3lk/JWowmK/V313wsOjK90rchh0qwNeRVUlMZ92yr8Urwb /EvJfaAo4Za8/aH0ancbDozYRHiGAEK/WkLKJXVDNVtgb/7SDkMYnJLWa0ILu/JgncpJ 23qdxJS6l0E0M8HUTKoiIFAQ2BlsaUI3i2rNGMAT0AKzz9pGrW7CLX6RERtWdxXkQuv7 WZpxmplkhnjXQ/crxzJ7RKOMtnJWjO17ptUsTkTY3xxkq9jkd9Ng4i2it4myjs7VwfzH dyL97oFwgZWlcUn1wY/U94AgUw80jxhVk3oxVvml3MMfxbyJpAKd6iPjHdCXiUzPqLmo UciQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713451821; x=1714056621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6p+8w8Hh04Jmf8oGwjxpLa/UzKTop1h7DhMYms+7Tq8=; b=G2lQ5Y5/Up4RLNN5Pd4OcS+4Z6K6lWHaUOuD+fZ899sHJXMRdi+7cAZdO3IG6A2ewK iAoEdXKs47I9ezuwfLY7jxv4dun4XQU1YHYPjz2qEXC/FY2mKr6Zk7OEfU8apy0ITH66 uap4vsVw7ovQRdsrjwA3ba/Aql6wgUdFa/nqQkk+jE4DcBQu3n7JA1fCQZALvoraFUkQ pSqCRL+Ydsu6ir4d56xPKFiOgvKg6NzZDz2y5CqM864OSQKlxNgq6iCi/n4cpmNU3G0S PvS//aAuvauuLAWwgOS9sY/phnNy0PDvF57pvRsL5Jys/9K4GaqgUjKA98xOyqT2RY8H rLww== X-Forwarded-Encrypted: i=1; AJvYcCV/Ey8AcVq5L+Pnn7CEti5G1z7fQpVYEfb/EIcSkzTv8ukQh12nVlAYkQAFbU9z2q000rzkQmgHaUZrXGGpwSSyfrI= X-Gm-Message-State: AOJu0YzSjL8PgMqt1yoBQjzIf6WMdQJZ+kRoikMByBwNlSaJkEdq6qbx vOKdJ5QYHuaLCVt+kdUmzGgVz0XsfuOvDh0cUnG0gQZzUJSEqZGH X-Google-Smtp-Source: AGHT+IEy3w5ti8d/aRlYULSHP6kn4xClYK6aejX5I6/4QNKJ+uBQwqqDM8a4ftyXRx5jRuNQIVC1bQ== X-Received: by 2002:a05:6a00:3d0c:b0:6ed:332:ffbc with SMTP id lo12-20020a056a003d0c00b006ed0332ffbcmr3858066pfb.20.1713451821509; Thu, 18 Apr 2024 07:50:21 -0700 (PDT) Received: from LancedeMBP.lan ([112.10.225.217]) by smtp.gmail.com with ESMTPSA id fv3-20020a056a00618300b006eb3c3db4afsm1552999pfb.186.2024.04.18.07.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 07:50:21 -0700 (PDT) From: Lance Yang To: david@redhat.com Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org, chris@zankel.net, corbet@lwn.net, dalias@libc.org, fengwei.yin@intel.com, glaubitz@physik.fu-berlin.de, hughd@google.com, jcmvbkbc@gmail.com, linmiaohe@huawei.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-trace-kernel@vger.kernel.org, muchun.song@linux.dev, naoya.horiguchi@nec.com, peterx@redhat.com, richardycc@google.com, ryan.roberts@arm.com, shy828301@gmail.com, willy@infradead.org, ysato@users.sourceforge.jp, ziy@nvidia.com Subject: Re: [PATCH v1 04/18] mm: track mapcount of large folios in single value Date: Thu, 18 Apr 2024 22:50:03 +0800 Message-Id: <20240418145003.8780-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20240409192301.907377-5-david@redhat.com> References: <20240409192301.907377-5-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D7317C0014 X-Stat-Signature: n8kjw3mdsrw7hyy63fcseftxcsequx34 X-Rspam-User: X-HE-Tag: 1713451822-633441 X-HE-Meta: U2FsdGVkX1/Z5JIKTek6ejxD/NvfJrhBaoUvumjBtsjUwTFvWhkmZrFTpJz8nLcXFYHSS3nBD/lvb980WEfnL9+wEusZJATgsrp7GOuGsRDY/TvHyMd2/HluWzNKOYYmPgQwcvV60OvGjR9oDwd9MhSB50jrGn9mBP1MNTsbSzwi2lFoe7NYI7Zy3RFI6Cu7Tr34UT67Zngc4kvigOpzXX44MQLA9uGOxESMB3TxC/vJAJI5N/tKbT8r4/PYE5XX0L479LzL63LsxMZXGq5ykbHgR252eK7taWppHW382J3S7mFaG5W4Z8jyz5rn+EnDb9V7CrIjnTlB6V9EGrOQsI+k1CIxm3HWTzev8yjTPUHmzUzss8VyqF+9JVEOKL86/z0VzbPFY3RZTGpcyFJzBVSJSi/yeCJUapzjJsJwqUMJ3D7+cWE6O0crmtSv3RH6Rek4jbb8x0lO+13asPEqqSXMDiRGfFLN0U1DB1asf7M12ltM1YDgz1FHLvyX/RGbftwCyq3Z+BuuuDDZ77UWeQSD263qT/xriLcTmQPQO4yN6nrISTfKsFM0VnA/q/BNPBz7dJ1rWyWl+WmMIliIMGY3qtjTLG83HDsX+1ot7oqfjGVQL+IyyxvgtVBDb8RZ8k5eNPe13ijaFR2xVwGO5KjzLvkLECJa7Of1TmCm2v7HgyfyDW2jJCGaThGfAoV3jhjsywAWBHjm5azjaV180apaoo8EVBNuFOzu8aPG64k0FfCM4Icw1T4N1mSp7PKC7+IOujB9Po8iI/G2KF8jD4UGdC8b1suZLGLe+VTrNd2H81I3RU7igMsY0nlVTg3PbG2Tlj3ZV6qNQ66kU02tKkwTBNCwM0dx6dddGcffmIR4kdZSspoKahV6lkhkCiSE1WFtHWizSBXiM8db1Hypo+8sy+4+NafwwL+uhPWujba4z9bhdfYp5DCyHgj/EdWUGNvx2a3uwD4PjwFndol 5kuxKhGR tvOVlNFOVc+24QCEZoekcCad76Sffdty0NOv7lSfHeAlvG5L+iyhw4+SuQEMPmSwtPxtbvEiLq2/2htPWV+TmboLgP9ibf7TE5QJm8HwIUSf3dGhJpygT/b95o5ILdEQYTh1GX/yLFWx6nKhHH0oKzdKtXylNxMEhpVJcfWv3f0CyzEkVrY+m4IA55aN/74GZ5YND8Ao00hAjTEwclTqy7tvMsiCj2vwk8OST4PhoCKMkIfC6//DRHrCFKxM8kJfJUrM+tZP1s3FONqKFpswlRpDn5e/0vkzOKED1ZX7xY4oOFQBUQ/u29soegkeRgJyXxQmNMtuHbdGCXrX1mNqTjlM+iBakyOkUTLy+lty/dj3GL5DOGo0Y9PYrc3SFqXPukfsZY8FMA21IOPH8ZbWWFabXJT2EuiKx/Uz3xCauSrqUz+M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey David, FWIW, just a nit below. diff --git a/mm/rmap.c b/mm/rmap.c index 2608c40dffad..08bb6834cf72 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1143,7 +1143,6 @@ static __always_inline unsigned int __folio_add_rmap(struct folio *folio, int *nr_pmdmapped) { atomic_t *mapped = &folio->_nr_pages_mapped; - const int orig_nr_pages = nr_pages; int first, nr = 0; __folio_rmap_sanity_checks(folio, page, nr_pages, level); @@ -1155,6 +1154,7 @@ static __always_inline unsigned int __folio_add_rmap(struct folio *folio, break; } + atomic_add(nr_pages, &folio->_large_mapcount); do { first = atomic_inc_and_test(&page->_mapcount); if (first) { @@ -1163,7 +1163,6 @@ static __always_inline unsigned int __folio_add_rmap(struct folio *folio, nr++; } } while (page++, --nr_pages > 0); - atomic_add(orig_nr_pages, &folio->_large_mapcount); break; case RMAP_LEVEL_PMD: first = atomic_inc_and_test(&folio->_entire_mapcount); Thanks, Lance