From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 850EEC4345F for ; Thu, 18 Apr 2024 20:38:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A702F6B00BA; Thu, 18 Apr 2024 16:38:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1F656B00C2; Thu, 18 Apr 2024 16:38:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90E2C6B00C4; Thu, 18 Apr 2024 16:38:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7415B6B00BA for ; Thu, 18 Apr 2024 16:38:25 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 25DBB140113 for ; Thu, 18 Apr 2024 20:38:25 +0000 (UTC) X-FDA: 82023815370.23.F4A83E7 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id 0667AA0012 for ; Thu, 18 Apr 2024 20:38:22 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=HE17W2pX; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713472703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kMovb/Ih/EI9+xtX6d+G9C0oNEZ3/3pIEDK/vSbSizM=; b=kf83JzepD+kXNqJ6UyudjxJLGRIWljbLELD8ljRMZERmY0EETP2Bo6rmt3w/8LIjnL3fKx but4DfrvT7eWBfpB523mU7XTllBc5HQ9tiTLQ+DinjcWwf/OT7kAqa/pdRANVnTZ1dqrJj tgAtmAI+PdSxXc5eU/b3H0M8xrf8NlE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=HE17W2pX; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713472703; a=rsa-sha256; cv=none; b=KQWzi0TPCiFEEbA7qhfBMAGXwTQ0VpbFRzah9avQNYOw0fwyXrK42dZkn+WRuz9yfaF3iD zrStQ5kxAryMX0YH7ZbY6eIJxawpYkd4KsGEwCvRyZ7gPl2d5eiPhNAA+xf/xKoVYbfgbh pnEmUOQqVcgxMajt0fKWK8Qq7oNITNI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1B4B3CE183C; Thu, 18 Apr 2024 20:38:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 161D2C113CC; Thu, 18 Apr 2024 20:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1713472698; bh=w5RGyzVBvoGAtMUsTnU34Y0CJu5FBsbDHlJjmWZiX9w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HE17W2pXfryr1qP1csdJB5HMM6g/LCw0KRag6Rbrltd2xCWWYPBEjPp9b0p5aMxMO 6oP2ODaoNH3oXamowSKFFW5G+RFn+/+SA7bbm7KGWyNYHgx42d/6H4q9hm+OKWgRTc 67MKC0gHKcvMwEMXEjosllHUn9GWgZ9uOtKiEQmo= Date: Thu, 18 Apr 2024 13:38:17 -0700 From: Andrew Morton To: Miaohe Lin Cc: , , , , , Subject: Re: [PATCH 2/2] mm/hugetlb: fix unable to handle page fault for address dead000000000108 Message-Id: <20240418133817.afb65c8dcd11cfea7c686d25@linux-foundation.org> In-Reply-To: <20240418022000.3524229-3-linmiaohe@huawei.com> References: <20240418022000.3524229-1-linmiaohe@huawei.com> <20240418022000.3524229-3-linmiaohe@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0667AA0012 X-Stat-Signature: wm66e3nq8dmfkw91qofcr8uwjr8yu1yo X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713472702-468956 X-HE-Meta: U2FsdGVkX198casP54kEiavvql3A0afPAYMiFMwSD8joLTWWiA8CiGErgrSt4Y33+xi5WTivFsQsUdOzWXrMXg1JKB1NWj/hFitJqgWRRbl1yjuSwGZD6F/qaggpLPJWW5kbwXhYV4u+2CwY/raRF4EpGyYRnD+c3HZFEwpyU3AElZQurKRLbGtcNpBlMRp2jSfdcGTNDub9jLq+QXNDS8dqdjL+TFtq5vDiLhlewdIT/O0DRQtwHc0hCNyw82AhpvXVl/rpou8ytYsC/HAA8YqEGCmn5VT5GcP74Y9e09kFc7vHdmZaFhaitaZHfkPHT1jH/uoMZTwpvRdd6Dfyn+4p7B4XEhFjuhd4mihRZbDoG/7uTPrHt209ABAE7v/in8sPQas8X00c07XC+v43fRT8TGt2Penw1L0pBWxp8uUQouQi+oLFWvkZ14fiEVfJV+BXJDye985aDfHztcIDLOC9btyXYZG99H0a7r59w85NabclUfjrEHikdFL7zWJQGVxjSGAHtcrfyFC7ZpwbXPm38wZ27PVjMHk74dmVNoZZX6+77kElNdB7Z3Ww16znU+estNPFIeMsqol1m4EvHPKYtAEAGcx1/0659aWGTSO5KsJ4s66vadH6T4hmdjSDmHOGqPCgUQN7lQGPOaT7Ham+lYnF17sD0axTZAstbnHpVRct7dufNKwyz+HqsOR2OzZZIWY6r++Xra5MYBuj2vmXSuLpHQrgfz2rbsE7NOoKDvWpmzzo/PNQOknczDNnbXE57HJwTbKYnRpFEgj5Xw+GW5uGWp6bS274NORFmmdfmQNi9AOcJwyHQuwQQbXApJwbVtSlRJEKToqnJzjFzS3Tqapsinbrt9zeg/Kagkh3nuy2mSyWlueg7+QRf5W0//P7ygPKysPtp5ZYXkXfRezQVkAHsWWfTso8MsaKbVv0DftPBuZQwPj+aYJPBQTXM+CY2fBQKzcCvJcA8Dh NbTwo/iR wQclQDBIT9y32lDipiVz/vch3VOlCitzP+spti2VvDAJC5vEmmu1yUoZijJ0vYr5jcBNIzeCf3+IDUh0hFAZrQ7a3fyky0JnALYJslzNdHqc9CP3Dh3tI4lAyJVllzF2vbJDFO7XRz79ATKCyVvosE9PSy8Mmp528JXYKqLk2tHuFygZZfNdnBGExPoqnH3XiRFwjN5kNRCXPca/8jvFAiGkmsrnmr1yUwQDhlpzA8pWJoxVx+pFiE/JJNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 18 Apr 2024 10:20:00 +0800 Miaohe Lin wrote: > Below panic occurs when I did memory failure test: > > BUG: unable to handle page fault for address: dead000000000108 > > ... > > The root cause is that list_del() is used to remove folio from list when > dissolve_free_hugetlb_folio(). But list_move() might be used to reenqueue > hugetlb folio when free_huge_folio() leading to above panic. Fix this > issue by using list_del_init() to remove folio. > > ... > > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1642,7 +1642,7 @@ static void __remove_hugetlb_folio(struct hstate *h, struct folio *folio, > if (hstate_is_gigantic(h) && !gigantic_page_runtime_supported()) > return; > > - list_del(&folio->lru); > + list_del_init(&folio->lru); > > if (folio_test_hugetlb_freed(folio)) { > h->free_huge_pages--; We should cc:stable and find a Fixes:. This appears to predate 6eb4e88a6d27022ea8aff424d47a0a5dfc9fcb34, after which I got lost.