From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E6BC4345F for ; Thu, 18 Apr 2024 20:18:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88A056B0095; Thu, 18 Apr 2024 16:18:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83AAC6B00C9; Thu, 18 Apr 2024 16:18:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 728AC6B00CA; Thu, 18 Apr 2024 16:18:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 54E5F6B00C9 for ; Thu, 18 Apr 2024 16:18:08 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E71771C15F5 for ; Thu, 18 Apr 2024 20:18:07 +0000 (UTC) X-FDA: 82023764214.16.D8CBD59 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf05.hostedemail.com (Postfix) with ESMTP id C7BB210001A for ; Thu, 18 Apr 2024 20:18:04 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NraMZAa9; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713471485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UxBCb6vS5bjA5dA5tbjIxtykXTv9+5pzmAznnoeeJSQ=; b=MJk06vNzpHp/CmJdz7hNJdAgN6pQqH/ESHgUFl1JYqvXN9LgrBjFFZskMUttPUzhg3eW5K xejruWCU7YwpJgiUdlspTFdg4fxSk7zyKmXqQPAeMOhYEZtHPEF7FGuPWIqWmCHklWwaZq /x5GaBHQV4R0inmnxxhyHVy0Wv+5NPY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NraMZAa9; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713471485; a=rsa-sha256; cv=none; b=gtoy0VvSDfgvuCWwfwzr+F43zBDqLzcFB/L0OsJxyam7/+lrFC8n3YW4TqnQeg4SzQD94x uhuP+7xIgQ4DAkHujGKoIc78IJbHMO5oSMbkDolLya7OwKOsobE6M0UHaE9L9sRzsXMBjF ndvh6aCEwTAgHX39DSsj5rsjibDC59k= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E931ACE1854; Thu, 18 Apr 2024 20:17:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88D87C113CC; Thu, 18 Apr 2024 20:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1713471479; bh=2+Iu6rboHTU4pX23XKc3js0Lcx0WQKJI0I/FuIkKTMI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NraMZAa9mMPDgVOfAPJlJzcl/uoR8Q3StueDMKYV9BNc+RLuv/17p36JUBkEnyN3e 6YcvzIiVUnL5IaKZkGA7Cmf9W+wD80jOi2lJctETtTfuSIHS0H/hY+k8vEoUbeiveR EiqtHO3PM82Zw8VXCcU+tYG3t4us67xEkEgw3F8s= Date: Thu, 18 Apr 2024 13:17:57 -0700 From: Andrew Morton To: Byungchul Park Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, ying.huang@intel.com, vernhao@tencent.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, rjgolo@gmail.com Subject: Re: [PATCH v9 rebase on mm-unstable 0/8] Reduce tlb and interrupt numbers over 90% by improving folio migration Message-Id: <20240418131757.cd05a8e7c7e66b3e90508c11@linux-foundation.org> In-Reply-To: <20240418061536.11645-1-byungchul@sk.com> References: <20240418061536.11645-1-byungchul@sk.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C7BB210001A X-Stat-Signature: unohsptyhb4rtntn6qtpxds5rguk1xur X-HE-Tag: 1713471484-219922 X-HE-Meta: U2FsdGVkX1/yMkp7qLXHfkisLeirfaksJST0Ca7jriNVtRzqydtP7lVz52kY+qJ8Smi0JP105uv6PSGgImPamjXzafuF8NxvgM47i+wP+LP3NtYtnByPf3/4Ka4OUjb12x9b3zrdlDLuWlnSMNrNAXhQ4kmcWsc57XQBD3MwHJGS9bZwj5RAfiYl5SskR+Feqf2wYoxThUvVR5XRwAGUH/mNLnSUXufbtJ+6lJV4NxT4YzjEo3lzLv8SUHKdlITlLHXo/o+qJ0wkTI6OkzmIL1r9vG623qO8xgtdbwFN7zC6/R7bGNS5A3JhiT+m5LCIct91iEhyVboXLv5ImiWt//3y+AooxmAJbsJ67e88nYxb1yjoicHvkjyouuw3mYpRQH7HStN3lh3nq1dPd7qaakUSYDFz2A8n7gDk3JGfYWNaxUZRqAQ+vEhsAXCy3psfNQ3M+dMF30N4PhFVZsa2dfrZZXdcYPlpsqI7e8mpjCuyxzuqu52N2E9S+HHpSjUJXTkJInePwF12el7CyxkReMFQ+1FDf/2ggP523uHcCCLpb6qf3Td4NsxxDjA0yJWSsJ9JeqHVW+JXC3Ea2xoLOu5tzI7G2PEmPTle/rIT2VW8TcXKfhnGAMNYmi//BlHtUFYhOfm1wKrfXJgqyRo21Rw+MHoK6QOo80bUXEMowgIwd08ZsI4vxP9TJqyPjE+lrNVAQB/Z7mgA7ia0lNpq/OWOLq3SEA0hPtKQj5m2sKul0XttnEXBKpGH7Vh+EsjXzOr62OFmOW7aVYDiEewfYAbbXvoDPPA5zBqgx8Ylhj70oyYvJwvT7G0a34VrskUj08G1p5Kh2wyj353B6Toyb0wSH6mkswkCf/QB5hFUsQC+rQ83tP+986YyieEgv9E7avIRuKZYJZN3t7sLag2779JleHF1jhh8jP/B9UZt/MMLahakoMb0kRxZi05NzrIxFv4IqlM6mNQjzNe8NCx 7HFFD1x2 /Xt+9JzexAKOniEzijD4fnD7bdbDYktA02IHUw4IBzObYyEOlZ8staU2pXDgzIDdxu2lQ/x2MqGQbXi/X4PpL6wqnVQuFrmnuJNb118bnt158Z8uTT/WC46AbkY+SQbwFmsIaJIVMc8rjsmvvWG40QPEC2LxC6ID/5+ex5gKiLINh7kWnddm7w0TDialYcYnHz0gyCnCS/Rus8b01KOjayHcC6vc+Sj4uReoCA0pOpiAX3fpeIlpqFuKENA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 18 Apr 2024 15:15:28 +0900 Byungchul Park wrote: > $ time XSBench -t 16 -p 50000000 > > BEFORE > ------ > Threads: 16 > Runtime: 968.783 seconds > Lookups: 1,700,000,000 > Lookups/s: 1,754,778 > > 15208.91s user 141.44s system 1564% cpu 16:20.98 total > > AFTER > ----- > Threads: 16 > Runtime: 913.210 seconds > Lookups: 1,700,000,000 > Lookups/s: 1,861,565 > > 14351.69s user 138.23s system 1565% cpu 15:25.47 total Well that's nice. What exactly is XSBench doing in this situation? What sort of improvements can we expect to see in useful workloads? I see it no longer consumes an additional page flag, good. The patches show no evidence of review activity and I'm not seeing much on the mailing list (patchset title was changed. Previous title "Reduce TLB flushes under some specific conditions"). Perhaps a better description of the overall benefit to our users would help to motivate reviewers.