From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A67EC4345F for ; Thu, 18 Apr 2024 06:26:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11C4A6B0087; Thu, 18 Apr 2024 02:26:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CAB46B0088; Thu, 18 Apr 2024 02:26:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED4646B0089; Thu, 18 Apr 2024 02:26:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CD26B6B0087 for ; Thu, 18 Apr 2024 02:26:19 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 81AE7160FE2 for ; Thu, 18 Apr 2024 06:26:19 +0000 (UTC) X-FDA: 82021668078.14.C2F4CD1 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf22.hostedemail.com (Postfix) with ESMTP id AA10FC0006 for ; Thu, 18 Apr 2024 06:26:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=HHtzmipQ; spf=pass (imf22.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713421577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qLD61XepBARAsgwAEEryGhLKo22WgyhNR7D0Io1kaZU=; b=JYqE9JdyxehTAnRnQdeisuXJRFqqqRmei4DzwWXhAzjWaxxX4oMXhzKPHcoa/2RYkX3tdF oqVlpR6Wfw7TzQbF4hssbYLIrMeMvFwFv+GoAsqEcp0SH3qQtcLGUn5HRNQIdEtm3XwKZu AkH03QKsC+iOF7JgFPvtCy9kH7BRucU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=HHtzmipQ; spf=pass (imf22.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713421577; a=rsa-sha256; cv=none; b=Huw1lrHhMpwusw3YpW13jHCe0VABHotCZk1gaq7uzqcgobk768/Gnv3XkN/rp5OJbTt+7/ 7wcCKVDqAuLEreZawQRFgXr9PpUCrLEZtaf0x4NPZaELR6/gvW0jjcIAIG0h7odVHKvPxr Lg6t91zBT/ptQ4BFYD5CySQBPNxpFFw= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6eddff25e4eso454643b3a.3 for ; Wed, 17 Apr 2024 23:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1713421576; x=1714026376; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qLD61XepBARAsgwAEEryGhLKo22WgyhNR7D0Io1kaZU=; b=HHtzmipQhbUHMvaniP62Q/uhAKI3ACdNuipCit3hoiccwkNLeXXVkC1DNV4aOx3idz Txy9/I2NCMJTB52BbOrYwdt98fBIqsTsPA/83SOnrMT/Uwrn2JEY4KPORWiAN4KzMsw/ MwK7KEOLAOxfPgiaTNN3Udy33+HxYSu/H1vxY65jiAQoTvBEdMRcEC1Hbx9oJMM7b4JW ENtwNMywbOpQ9GwdWfa7IXdxak/AnfNr7IJUug40F8sZXODq1NEjVjqIboVIiUEV2Zb0 HktPGYWSWe8yn+VaVbQa5p1/lNcXR5L4AJe0DkcM6POG9Ej1NUzYLXX6INZ2btouxUg7 lQ+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713421576; x=1714026376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qLD61XepBARAsgwAEEryGhLKo22WgyhNR7D0Io1kaZU=; b=OT2Q0StPK4MG+5SLCR1YnRVZgxZ3d2iUMg/2671kWXUTH2kiN5GdQphxN7oivurw+d 4aelIXtw1Qma4mfqKsxHyleeqxQuvCglououawN1l0ocOiFsRk5xt3Jz4up75G1rAUlx IVFcvTV98FV+u8Zjf4w5oMriSyVysrwqjvDbM9gJUSK1dl2EAvoHMNRreMhT9tEkXDgR o7R7P9FzokmwEvDWPrUItcz1cL1YQQ1l7u/0oXylgX40ujJVwYQVBWBt/AxJPcTrskQy z5LUMDhTMd0DgMBEQcAXdPMOgiUftQwBC09ovu4yNCG3i3sVgfX32pZpkia3OXY+InG5 GJoQ== X-Forwarded-Encrypted: i=1; AJvYcCWIlpa6zMn0Ke4pRd5fLPy7UjGFea9Rs/L97WVpUCFhT36juBLn7BXCtQTjceFsb2sjhfHwuUnh/V4qTB5uCsIzSfU= X-Gm-Message-State: AOJu0Ywnz0LY6bVMlDzqv741mckY1ZU0g92Gby1hBOJxnKSDu4xga4gV nUW83bzBA9BepN/JR5nD/cpjneWjHlxJRnrJq6q66m2MLzUxbjrEUTGLZCttzhU= X-Google-Smtp-Source: AGHT+IExq7y1kqyqGXewPq6tqKPgeINzrgW8X9DzhXoz5Wq5smACLbcQzHv5/LkcKr/osJEn2qOGzg== X-Received: by 2002:a05:6a20:9717:b0:1a9:dcd9:9756 with SMTP id hr23-20020a056a20971700b001a9dcd99756mr2120694pzc.16.1713421576513; Wed, 17 Apr 2024 23:26:16 -0700 (PDT) Received: from libai.bytedance.net ([61.213.176.11]) by smtp.gmail.com with ESMTPSA id s21-20020a632155000000b005cd8044c6fesm666392pgm.23.2024.04.17.23.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 23:26:16 -0700 (PDT) From: zhenwei pi To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev Cc: mst@redhat.com, david@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, akpm@linux-foundation.org, zhenwei pi Subject: [PATCH 2/3] virtio_balloon: introduce memory allocation stall counter Date: Thu, 18 Apr 2024 14:26:01 +0800 Message-Id: <20240418062602.1291391-3-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240418062602.1291391-1-pizhenwei@bytedance.com> References: <20240418062602.1291391-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: AA10FC0006 X-Stat-Signature: bd1yntrfdwtw198whymmkokthwhrg9ms X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713421577-463546 X-HE-Meta: U2FsdGVkX1/f0/r7qcYOTq9mOufUcP9Fd/iRVUbRbsKWYBLVhAzXRMMoPUjYj4JgAUHrhmfkkR9IY5DlYURZg5N514cpJTUXlsQA2Vyy4C8YxrdfOB/APinYcheYtZn62jfIcJ+RCPvlDxu8y93qimRkGNVaZzXN4gFBwEX7h23znuxmhqqWGYI43pMQSnZZHsbHu7z6Ss0ZPfRI/S3O9Jq40aSXrziGtv9BmWThySudy2qg35xq3du+y4q+Obit2/DLRuC3Dwv6uAoCDPSl6i0d5YouG3WVh21rxuEhYn5xrSnN9aTUJZ4e2KpR9OOu6ZmFRwZqafcOaIC1bl9yx6p3aEwhXvEHCN2ITa0hrbWmDnJGOtQEMeIf0RqlaWdBfwzZbfSHBsm/ONIcBllZ/BUoocOf+zFZBCe3jK3W6i5mFl0IbofaAKXa7sbtz8ZJJkWVxy/rTyeOVw0HZrN2PZsWw5BwqL80abD8yS//IcpwOFMA9QcL5mhhYeAH1IXl9GS4pvfdlAf8B1PuWZDDsWAWO7rElMWQDuMyMgJGEQ47ePE/ajV55NKFemaeYTW3pNCt8+phf+FS/bnckJknxuEOlNzJHqWYp3RWoYpbbzlmf/dsS71SxZaqzhfCUy4LUjMHjOFEAuzimKpaWoNOgNk4QQ44Qf3DB/IzbOlxTMUXzTlzXalaJAsHo/u1zBwWRkIopgbyIQ4hVZGfqYGpZbuyn/yM9WeTt2FAAj6Bg7MdV+1Xp/uckM+u4/TXRVt/m+thRSLuQE4l++3qiNrU1B/WKme0pd1q0MFaHNP5NmZpgpl+gfT9MN1D4RciBU6gTpzr5gpAfeg4inIMGp1HEBdHTNYpBvAA3Br5pfvmK5bLBk+++b1nyGmkhLrS0UG1iierq4OogdKc8FGy+Ghh3qPD/J4qkSKY84d7vIlARIc/005vak8FuWXVu1qjR+u34kM2S79m7OvS+yrpPsi ktAnRMpF SFNRPdbeMSDGePIrNf/rXHzlsjygXIH1Bxy/dRj9OK7TanzCXqpfPpDi5XcXq9GUChMw975M7OcJ93+yA1RmBMFhF809lGYbiJ3kr/AmzXXrY7sCGNrJv/7zGQDK0qj01u8K0rUpBBlOwIP+8TZvta8a0V8PENHuFWjiMU4iWiLt9oQsO5h3dD6ik6XEgk9pZ+Mn//6Je4c84nxVWfr3KTSns0OswTPnNvXB8QzrN9Zdzi4MJ1wgrSfs5m+vja460IgN0qI3MC7ET7r5gIAMWhb1StxVTQBgIvxeDiahfVoZmMt9r3wb/z/7UeKLG4VbJJMeGvTcX/+JPqEyTO/NkNoeOOLTOo4IytPr41r69N2XgaDPS4619Mf1n3c389U2o0VO4zmCPJPZWcT5BjdZU00ztKnFIZRVdWKPEmReaUzfgVx5BIH0QK2EUswdBR31zG1v/5r+e1Be6ypI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Memory allocation stall counter represents the performance/latency of memory allocation, expose this counter to the host side by virtio balloon device via out-of-bound way. Signed-off-by: zhenwei pi --- drivers/virtio/virtio_balloon.c | 20 +++++++++++++++++++- include/uapi/linux/virtio_balloon.h | 6 ++++-- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index fd19934a847f..e88e6573afa5 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -321,7 +321,7 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb) unsigned long events[NR_VM_EVENT_ITEMS]; struct sysinfo i; unsigned int idx = 0; - long available; + long available, stall = 0; unsigned long caches; all_vm_events(events); @@ -338,6 +338,24 @@ static unsigned int update_balloon_stats(struct virtio_balloon *vb) update_stat(vb, idx++, VIRTIO_BALLOON_S_MAJFLT, events[PGMAJFAULT]); update_stat(vb, idx++, VIRTIO_BALLOON_S_MINFLT, events[PGFAULT]); update_stat(vb, idx++, VIRTIO_BALLOON_S_OOM_KILL, events[OOM_KILL]); + + /* sum all the stall events */ +#ifdef CONFIG_ZONE_DMA + stall += events[ALLOCSTALL_DMA]; +#endif +#ifdef CONFIG_ZONE_DMA32 + stall += events[ALLOCSTALL_DMA32]; +#endif +#ifdef CONFIG_HIGHMEM + stall += events[ALLOCSTALL_HIGH]; +#endif +#ifdef CONFIG_ZONE_DEVICE + stall += events[ALLOCSTALL_DEVICE]; +#endif + stall += events[ALLOCSTALL_NORMAL]; + stall += events[ALLOCSTALL_MOVABLE]; + update_stat(vb, idx++, VIRTIO_BALLOON_S_ALLOC_STALL, stall); + #ifdef CONFIG_HUGETLB_PAGE update_stat(vb, idx++, VIRTIO_BALLOON_S_HTLB_PGALLOC, events[HTLB_BUDDY_PGALLOC]); diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h index b17bbe033697..487b893a160e 100644 --- a/include/uapi/linux/virtio_balloon.h +++ b/include/uapi/linux/virtio_balloon.h @@ -72,7 +72,8 @@ struct virtio_balloon_config { #define VIRTIO_BALLOON_S_HTLB_PGALLOC 8 /* Hugetlb page allocations */ #define VIRTIO_BALLOON_S_HTLB_PGFAIL 9 /* Hugetlb page allocation failures */ #define VIRTIO_BALLOON_S_OOM_KILL 10 /* OOM killer invocations */ -#define VIRTIO_BALLOON_S_NR 11 +#define VIRTIO_BALLOON_S_ALLOC_STALL 11 /* Stall count of memory allocatoin */ +#define VIRTIO_BALLOON_S_NR 12 #define VIRTIO_BALLOON_S_NAMES_WITH_PREFIX(VIRTIO_BALLOON_S_NAMES_prefix) { \ VIRTIO_BALLOON_S_NAMES_prefix "swap-in", \ @@ -85,7 +86,8 @@ struct virtio_balloon_config { VIRTIO_BALLOON_S_NAMES_prefix "disk-caches", \ VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-allocations", \ VIRTIO_BALLOON_S_NAMES_prefix "hugetlb-failures", \ - VIRTIO_BALLOON_S_NAMES_prefix "oom-kills" \ + VIRTIO_BALLOON_S_NAMES_prefix "oom-kills", \ + VIRTIO_BALLOON_S_NAMES_prefix "alloc-stalls" \ } #define VIRTIO_BALLOON_S_NAMES VIRTIO_BALLOON_S_NAMES_WITH_PREFIX("") -- 2.34.1