From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9668BC4345F for ; Wed, 17 Apr 2024 05:04:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3B376B0087; Wed, 17 Apr 2024 01:04:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEA016B0088; Wed, 17 Apr 2024 01:04:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB1986B0089; Wed, 17 Apr 2024 01:04:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C44086B0087 for ; Wed, 17 Apr 2024 01:04:37 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 799A6140BB3 for ; Wed, 17 Apr 2024 05:04:37 +0000 (UTC) X-FDA: 82017833394.21.A6A02CA Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf01.hostedemail.com (Postfix) with ESMTP id C4CC240004 for ; Wed, 17 Apr 2024 05:04:35 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="DHbw/T4D"; spf=pass (imf01.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713330275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A8cE2GY5Lwaxvgym50OvlfdzVbTihI4gujlM0wTOT/s=; b=4KeG2SnrOlNB57WI39JKukZuVvcczJL/X+mrWULE/F68iyTWYB0fs2quXVwFhZsYk0LW08 40FGuwCywXTiwZezb4VxfFJs6SkplZhXZYdrhHEOXvx0BCHk6vS6jX0rDAfIYz/5X0w7XY 2WGDDLRD5Yw0Bwq3JV4m5qtWp5tfwNw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713330275; a=rsa-sha256; cv=none; b=4MLpm1riMHdAtWRrNk2stTbPVTU+Mh8VlOne5bnqy94REvUFOlYRY1LuuNZJnrbIOzQ6pN u/AgIU+AINj2uNQvU4P2S92wAvHgpYjR15SCz9tNqIsg99cXapsvT3fjwDTurRKxdRuC7g a9PpBsCXG32BXz1s/YUqFfTkgCuxPQQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="DHbw/T4D"; spf=pass (imf01.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5d8b887bb0cso3880273a12.2 for ; Tue, 16 Apr 2024 22:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713330274; x=1713935074; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A8cE2GY5Lwaxvgym50OvlfdzVbTihI4gujlM0wTOT/s=; b=DHbw/T4Dgmr65t8v/YFZMdma4/dToovXLYt9Ejzn5w6m0Veg61WtzR+jzin97+z1za 6Qgu4j0bsgG4jRE2UkpDSc+IfFv4igUv5BABJAXQ7jRqE3kZiX32jFB56/yWCmUgsF/D Ts+hlXKUEFTgoYmH2mcN8Z/9uAGSGlhnxssLMdSOpixYXEsl2tjKiJLEAg+V083x7Abd rcudm/a3NWHJQyyjgWqh7SEqAFgS2Bk3X0zlOTcVDyFz7Gq4gErhXts6oqLCZTQCP6Gd LUTgAFB4oRMLOBO2j2JYSy8kyvqA6XdTovO2cCv0TCrmYid3gQCk/nEQ+Jy4P9mLcXSR 7bqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713330274; x=1713935074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A8cE2GY5Lwaxvgym50OvlfdzVbTihI4gujlM0wTOT/s=; b=OEKHbi+rIUDfK0JqtLIliFLcrV+Tfcyg/RQbLhLPjv7281XkVT1mh8WTLETXiyXmB9 cBJeKqLsDvyq2qY8lnbxkQBXQeaw1v3zCshPBB+epddJT9HdVLXWorAPSqvMHdVFD1WW Djhk+sIoYNuKIRMCSEzDM7spw4t83FuxTpZtd/zbp++RRlZP0viY7XI0smsGSDSHwnWh 24wjJ2s3yg2OtaBVnS6V3nr8wHqI6zEm0lAJBeJUb0DQ9tcs+e94BYcxoOLiH5vmevH1 xuTA10hzFDEVir3xTJuUoSwV9H5QihV6ArX8kuV7EGxOZ/cjYkWrHPf/UKkZUPZm0SHI KfXw== X-Forwarded-Encrypted: i=1; AJvYcCXuiUOn/huT9OpR/XF4tH+EsWngbRzTKqDFHpB+8RUggMF9pKqczGsmQw4xH/yjXA5NQBTe/4jcGtPFZ6mTmZqpD8o= X-Gm-Message-State: AOJu0YzIcUxBIEYhcRmuD09G7Vz4Hnqbgs85seeSRoazLKoD0S7SQfYB 0iR3AxEcOJAEefNuOCNExgYELLsX3HfJxoFxdi8oYqXTIgIF00Gl X-Google-Smtp-Source: AGHT+IEblF7vy2XSGTFmF24m/8tK5t0Ox3i9yE6fmQYAZ7wmKEsaYpKSL1iBeaHI10GdgAecyBosVQ== X-Received: by 2002:a05:6a20:c101:b0:1a7:3d2a:7383 with SMTP id bh1-20020a056a20c10100b001a73d2a7383mr15516623pzb.18.1713330274448; Tue, 16 Apr 2024 22:04:34 -0700 (PDT) Received: from LancedeMBP.lan ([112.10.225.217]) by smtp.gmail.com with ESMTPSA id hg19-20020a17090b301300b0029c472ec962sm484417pjb.47.2024.04.16.22.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 22:04:34 -0700 (PDT) From: Lance Yang To: ioworker0@gmail.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, david@redhat.com, fengwei.yin@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com, songmuchun@bytedance.com, wangkefeng.wang@huawei.com, xiehuan09@gmail.com, zokeefe@google.com Subject: Re: [PATCH v7 1/3] mm/madvise: introduce clear_young_dirty_ptes() batch helper Date: Wed, 17 Apr 2024 13:04:26 +0800 Message-Id: <20240417050426.66194-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C4CC240004 X-Stat-Signature: rrxi7wxnxbthapzh89radwcunsyzxa7x X-Rspam-User: X-HE-Tag: 1713330275-351983 X-HE-Meta: U2FsdGVkX1/6eAI1ROdLAQErSBKDGjVAMegOe0IWotwC/6zYIYdy79cR1Yat0F9bRU/QiZxmLgLE+LRuHRUz3hqLXlRHt0SCGjyTd3LdnPBq20EeppIiuFde6MMQwKV0BGG2a/d9sYT22s+l29zgeYSYzGzALlHIFMR019y5MNRSXqrW9AsmCbnW/QbGhX9JTTMOES6ps/QZHdCv6mHv9NRV3pLAjuhwelMT7zN9w0Jf+FlALgguRPkbaVTzfYFFORxvS+/25tEdZoXY7amte2zxKGaq2lDKT0ySHAIA/gsrIeWBt+Uu2GNtFm6AYqLgK9b/Rq7tMIFRSH/xBDlq778id4HVjzUsWKtBIkS0jcELPocp2EupJZz7HfsuVu6Y8ef6fHZKGhrrzFnp2a+RKD7pYQ10OO9UUiQLa/XxamtDK1oJV0dyG6ZFZZCSOSmrDKgZt1idQkc7aarvZm/altPv/sXXCrM9P/pn05knHMQ2vkM6/x806ZnOGCGjBmIitFabugi15XgiOuRhkelYajb7HLqYHBuBEzeAjr6IJma3vlcJ8NZOZJPvPg8H6IMsEVAzgsfFOCwGJAqa5UMjfibg/AjN1gNjqCYjMif+6eMa4kY+O4L71TacUGoZeGb0apJBrwJVTtNBGeBoqC9Di+iok/3IOnu/gMAjocgffYvI8gsPsOscRHui7mlHCJFkMasXyIHTjzjRW9FhX276Nci+d0wHZl6ymZILuCHXCBiERhGttraXPKveNJ7UYpujaJVEy28z9jOaK2lnH/pxx2wATI+A42tY7qNu8IDmvWTMiIaFO4m3nBgCpXGqDRpfYxlrFghQOXyvmb9adLCFInFIIDZz7KKEFwKA6gaXZixnfIkqH+4072TWo2F2JssWVRCNYx0jBCO2SXhcHdP24iBNl3vodX+TcpsBCQigo1voG8e9/nkfKXpRmicaEtq48kxoDHpzUhmpiEt3MSf a8vQbPzY +nunAcTe3c/stqVeBv9fUZlHMeFv9UlD2WIAVYiEU8kJW3KRvYHWe5QaOH45IBQ9zNuTt/bt4VJ7WjrDUfjO7fnxDlq5bc3Za5J31rPD3Wkvy9VYh3M2MRwckSd/jvcTw5RFo+jVOqn5SE8yttTYCFytbMctNGAXgMYaz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000030, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey David, Ryan, How about this change? static inline void clear_young_dirty_ptes(struct vm_area_struct *vma, unsigned long addr, pte_t *ptep, unsigned int nr, cydp_t flags) { if (flags == CYDP_CLEAR_YOUNG) { for (;;) { ptep_test_and_clear_young(vma, addr, ptep); if (--nr == 0) break; ptep++; addr += PAGE_SIZE; } return; } pte_t pte; for (;;) { pte = ptep_get_and_clear(vma->vm_mm, addr, ptep); if (flags & CYDP_CLEAR_YOUNG) pte = pte_mkold(pte); if (flags & CYDP_CLEAR_DIRTY) pte = pte_mkclean(pte); if (--nr == 0) break; ptep++; addr += PAGE_SIZE; } } Thanks, Lance