From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79296C4345F for ; Wed, 17 Apr 2024 02:31:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DF286B0087; Tue, 16 Apr 2024 22:31:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08FB96B0088; Tue, 16 Apr 2024 22:31:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E98A36B0089; Tue, 16 Apr 2024 22:31:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CBBBE6B0087 for ; Tue, 16 Apr 2024 22:31:53 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5F0C81A0AC2 for ; Wed, 17 Apr 2024 02:31:53 +0000 (UTC) X-FDA: 82017448506.08.A0A850B Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf14.hostedemail.com (Postfix) with ESMTP id 698CD10000D for ; Wed, 17 Apr 2024 02:31:51 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=erCGXZ2F; spf=pass (imf14.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713321111; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sLxzFgXT3MHB159K1sbDGa/EUJR7X/HFjnuDr4sEUno=; b=wItfDlsVVSNl4y+MyhAvPhQSOrtuXMDq2Z36Hyr1F6O2s24wrXMRFyVOGhNAgf8nv5Xcpu VJwfAQInxa0fNhj/8+KxfaC9isvXFkOhpdlfifnoZaOVQPz2WV0ZSoXd604n+kAy0urDn3 wNRfTw8HAaL8Pnxs+V2j8neyrTlJjIA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713321111; a=rsa-sha256; cv=none; b=H2ehwkIkx0UsNUejY8eyieSWfIK4ciQ5AlXPi1ZIqTwbHf+Y/cJRhAK47ib2TsRKO8aZHe OepDGpMs7IrSb6JLOAi4ktjrNhsr+CQB1bmrnO4ai46ghALLaWIQXlyO+HWBqNulCiJ5lK 4IHwAYom2p1bkw07cOWmi+ObR6Wkc38= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=erCGXZ2F; spf=pass (imf14.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-570175e8e6fso4640627a12.3 for ; Tue, 16 Apr 2024 19:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713321110; x=1713925910; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=sLxzFgXT3MHB159K1sbDGa/EUJR7X/HFjnuDr4sEUno=; b=erCGXZ2FuBSImeyMerM/LdHIMrwr7DlDX/K+LLTrlBLLdvRhAysH4Pk4wGSG9U+xRe MSB9Xx25cKnTiUH/K4CDZkFENvkObZiDQcmWY0W/avix0XDvfBF8DHNYMHeoJstfxurI xMc/i+Frd3DTlD+y560aK6sjNy2kOdjhDtEAkyYFLUL9flqHOkAhklAsnLPiGlZU3B0J Ti6O1dIvaeHG0xpVfmhro7o7oRK+KBG+XzeNINBNWZSYBF+B6jMxJhOy19ZojaE0jToK 93gKGp3R8j+fxSmG0w4T5yZFM7hxK6a9I5g09BcIyEgKIqEfpy/FaSG5CCjD3Vs/6zWT 9Eyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713321110; x=1713925910; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sLxzFgXT3MHB159K1sbDGa/EUJR7X/HFjnuDr4sEUno=; b=e+OjlwccNxecvpnryC0jfq7g5p/Vz75fJ4hTtcp5t7eTYLkBNh+/sL0SrMK+M7PdWB wOl6JjLCnEmWhucyWkh//AJ9BMYdvRIvfhi8kfUBf7LK+Q9TgFkeRmzjuOlqahXFw3KJ IJP6T2vv0E+jJOammD1ETHvfpVIDUhXx1whT4Ak2yYv2ktpH73eu2nGVF3SA+15jSAOp GqcNj+UOKdHNVwQbJlOzrL511SOx4+9xU3j1URi5hJY7aXA4q0uy+KiE6qZqJUhhGP5u rZIAQjjto/H9l/XJU0b4jhpFSTjQqrAuoFRePmydWBmcvNmj4gmwfLBR80Kz8f5eiWg3 Dzvg== X-Forwarded-Encrypted: i=1; AJvYcCU1IEjLCLVEKRSSJYR/uTe8vuCS8f7OofUHY7d3m5lEqtDq++VUcjT9WOD6xoTsfwNJubfH2MUO8P8AujNvt4ivVj8= X-Gm-Message-State: AOJu0YxgXet8Ry4SqZrkWTSgc1M2SB2CBIj+jtLeBDA3nBw/AxrdsEeU HsNwCcbMz3J/3qQrz4/P0EwOfq87FwJXj0Px8ZbTvSWE8w9XR0MT X-Google-Smtp-Source: AGHT+IG1ofJ/hLCDgOPDzSCQq51uNaCKrfcQLvF5/n8mz4DFU14PSiIxYZGV04kc10i/EV/WUsy98Q== X-Received: by 2002:a50:c302:0:b0:570:7e4:8e9e with SMTP id a2-20020a50c302000000b0057007e48e9emr7402448edb.15.1713321109214; Tue, 16 Apr 2024 19:31:49 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id cn22-20020a0564020cb600b0056e34297cbasm6686274edb.80.2024.04.16.19.31.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2024 19:31:48 -0700 (PDT) Date: Wed, 17 Apr 2024 02:31:47 +0000 From: Wei Yang To: Mike Rapoport Cc: skseofh@gmail.com, robh@kernel.org, saravanak@google.com, akpm@linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daero Lee Subject: Re: [PATCH] memblock: add no-map alloc functions Message-ID: <20240417023147.ybefdy6fn5drvq5w@master> Reply-To: Wei Yang References: <20240415142448.333271-1-skseofh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 698CD10000D X-Rspam-User: X-Stat-Signature: decr7qhdtadtci6skurakodr7wtuh1hy X-HE-Tag: 1713321111-904679 X-HE-Meta: U2FsdGVkX19NRiojfS0djp1VvWlgob6IVtCCVWgxv/vHpPV6WCRRvpzfvcTrUoAe10BDSEj0Emruuf+KuhjRudgJ6EqfhKtw2ioZ2bqjX4S5Eh78xXLaQEJGJQR0m0ENfkJXqererTCCSWbLxCRp9WwrLej7z6nq5pIoi71pcA0cSzZPJ4kEQoSda9XFn8u7ERqD1E9PKZ8sHRxoEMl2FyRtpV3n2C8BWURZBFXJiH7v4H/KRnMW9cYas/Nd1w7V6T0Vd1BG/bE56QWFixVZes6EQBUPFftohwneundJubYqpGCqXb88tg+U/mPvwtTaO9AvlfsGVSw1jIimEnPMMKrVg4ByexESIhu8e2Z/UkGBswyM7M5mi1k1fMQfUXrqpEtKyPRHz7fcVg67ijMLcLgSGc5L8r2r1/ty2hFGN36iIZbWT0kXS3eIgMs0eclK62lqauFOTKuEgWWFB7PbltN8bcUWaOGjsXASUIidWBSIpUyPOZ2pi+N3YlzriIV8e27irtqchaJwKoui7CVBvGDim6QC4bj1DDR+97fzFnICHhTb0v3ai2Jo6Tzq5IRjxDvmdHxP+g0/HuX7uEiuzF1/rtRHpq16wJRz9W3OvyeaAsu8z4cn9/c8SzUiP9jiChOG7KzPpA4GMLjFyaRxzDq4FyEsx/DqGgrXDLkRfh8LLcOofKh76rnTWKKsES/RJpAv9ZBiJD0//zivwJ2oSeXlyeBh/F21hCkHzcr1XvB4sR5ao5uFYPDt7Vk7sszqWOfHFfXGZzPa2cc0griM2qkHi/Et0lEswqzeCSID9E6L2XFRdPcHekElbFscX3lS79SP/82t4LjOwGxWveriR+jeFeTk5R9Rr0/ZnAQTowbkSWr2/JmfAc8i6JJ3Y2pt0BjNUOCI5qzItJKcNVhQfDZDi/U0ZULnUCO9MMpZC7cSnQAXSpOO2ANumgLvJvc/ITkV9K2e7jYk8Vc2PJY eyJNBnK2 s8jYpQSf9OjnI2t/RysVheaIKt8DYaXOKerlo58RvSxFxcrjm+I8ZfRqUdoC84rGOcnXqREGylMX4GA08OThhQOwOQCo48tjzj9inA3rHyWbS3qM+HK5NGmAg3+cdsAXn591M6c5NFka5TWMoTxR3Ozs7ge5MG9Hfe8vOuy8DgjNt20Wp7Rdl1f//Dha6S3cM/WsfeNwzQBrNPAr96Sx73XnROHnGKF0+bbx96A4MAVDdWXMCYfp7F7dUO7ivntnlK3k1EoCdVLgo3W9/NtrdC83Tudj+XXQPYu+tzQYosd/kAgegiCrSc+2Cf7jL3vZEGQyieF4wXV7BO43jCldzCt9cXKXg0E3KsoOTeKZnz96tsmB53qQReuNjMxDyaxUPs1Yw/CrLt4mg8RYccbZ+xYJ9HLlJ8GhzSGFFl2e3rRQQK1ZGrRE2EisKhv0lAp26HmkwnbbChwH6mi5xIe1JbspPUyNBFusU7pRg77VhSbG29+mrBhhJAp2QT9+Xz1OzOZXMhXP5Xz9TqyCO/ts3Fgetza+yC4RKx5UmhntOY0Bg8S/OvV/K/KxsOFXCYVA+9bvpOfB3n//Loo+LHRhuzvyYOqhaJIcos/ivAdE2eTXH6mply1UU3PoReA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.010401, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 15, 2024 at 06:26:55PM +0300, Mike Rapoport wrote: [...] >> + > >This changes behaviour of internal function, what effect will it have on >the users? > >> if (!base) >> return -ENOMEM; >> >> *res_base = base; >> if (nomap) { >> err = memblock_mark_nomap(base, size); Mike One question may not directly relevant to this thread. NOMAP doesn't apply to all arch? I took a look into the direct mapping function on x86, memory_map_top_down(). It seems iterate all available pfn instead of skipping NOMAP range. >> - if (err) >> - memblock_phys_free(base, size); >> } >> >> kmemleak_ignore_phys(base); > >-- >Sincerely yours, >Mike. -- Wei Yang Help you, Help me