From: Wei Yang <richard.weiyang@gmail.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: skseofh@gmail.com, robh@kernel.org, saravanak@google.com,
akpm@linux-foundation.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Daero Lee <daero_le.lee@samsung.com>
Subject: Re: [PATCH] memblock: add no-map alloc functions
Date: Wed, 17 Apr 2024 02:31:47 +0000 [thread overview]
Message-ID: <20240417023147.ybefdy6fn5drvq5w@master> (raw)
In-Reply-To: <Zh1HP8IWWjexAUKN@kernel.org>
On Mon, Apr 15, 2024 at 06:26:55PM +0300, Mike Rapoport wrote:
[...]
>> +
>
>This changes behaviour of internal function, what effect will it have on
>the users?
>
>> if (!base)
>> return -ENOMEM;
>>
>> *res_base = base;
>> if (nomap) {
>> err = memblock_mark_nomap(base, size);
Mike
One question may not directly relevant to this thread.
NOMAP doesn't apply to all arch? I took a look into the direct mapping
function on x86, memory_map_top_down(). It seems iterate all available pfn
instead of skipping NOMAP range.
>> - if (err)
>> - memblock_phys_free(base, size);
>> }
>>
>> kmemleak_ignore_phys(base);
>
>--
>Sincerely yours,
>Mike.
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2024-04-17 2:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 14:24 skseofh
2024-04-15 15:26 ` Mike Rapoport
2024-04-17 2:31 ` Wei Yang [this message]
2024-04-17 5:54 ` Mike Rapoport
2024-04-16 13:41 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417023147.ybefdy6fn5drvq5w@master \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=daero_le.lee@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=robh@kernel.org \
--cc=rppt@kernel.org \
--cc=saravanak@google.com \
--cc=skseofh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox