From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C5EAC4345F for ; Wed, 17 Apr 2024 02:24:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54AF96B0085; Tue, 16 Apr 2024 22:24:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F9436B0087; Tue, 16 Apr 2024 22:24:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E86D6B0088; Tue, 16 Apr 2024 22:24:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1C2A26B0085 for ; Tue, 16 Apr 2024 22:24:03 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CFE6CA098A for ; Wed, 17 Apr 2024 02:24:02 +0000 (UTC) X-FDA: 82017428724.17.90C93D4 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf15.hostedemail.com (Postfix) with ESMTP id DBF69A0006 for ; Wed, 17 Apr 2024 02:24:00 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HHq6NKM1; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713320641; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=epo1oT+++2cLMYZiFx2DX+JGf1s/GKSnrk05wKVL2aI=; b=Ly1hRN0Q/g/EItadvEAM/dQCD9QNbklbxT7HzV2Bdc8FtJcCVt/yq05W2+5mq7pYYmxU9K z6O87GufMYkQT2Z5z0AzChKVDUZAlv1gsjwHsZDIMNRJ7QkuG8JSTuffjUG1+hkhKlGjxU skdJkH3vautb5kKkIuAE0EbGvckJMyw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713320641; a=rsa-sha256; cv=none; b=r+azmrS7SiwgYoJT5HHfwqy8R2dfXSIdMa4i6F9O4bYn5att0oe5HM8SPfKlDa94zMHLy8 t8Za2077wVGulFQPMHWt9iOk5OP850SkPfZ3emd3dr0/831KR6z/QTMk5nK8fIQTx7ICSZ BXsQ+o5WLHJw8OZjSbWY0zJRL6vYl98= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HHq6NKM1; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a54176639ecso311567366b.0 for ; Tue, 16 Apr 2024 19:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713320639; x=1713925439; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=epo1oT+++2cLMYZiFx2DX+JGf1s/GKSnrk05wKVL2aI=; b=HHq6NKM1BUsMnCngI9pGYtDzBsqELquRFqlNJfqpPAbXF7LTfht6Gs8SmrGjgXyvDQ yVmfSQRZUTwr5ptKQLMqIOlSPxz0bXIMO4uuGd3Zybcc0HbXp/5LQg+zVtsutNCgiaBr s6vQLJ/7ujtYEn/wefeVdaNbb+j+VzTTylz48if1RJYxzl3+IA93oQ1owWBTfFWQwW6o pbl7GaRBXaJgHrOl40fnnyDf047glynETtZXV6hUlslxwr9kUH/kV7dV9kolKt1sRMVN o56EIH45OiRJAC2X8UGeW0VPGUofbTxuBdN3XoxwgKSdD/JYt6bCmw9Pm0aBg+pOxC7r rKTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713320639; x=1713925439; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=epo1oT+++2cLMYZiFx2DX+JGf1s/GKSnrk05wKVL2aI=; b=xFzn/ms5bMq9JVRkfLa6GYsfSHiCmXa3oWkfMEtjIDk2+2e/JSdcFcEjYYp/6/8Hnt r272JDdk5eMzqIZpwPxrLxjNpqyp7CmjhAHm4CQEUWmW+wR+n42/3DWYtmCfjMmLgUrb X0LujH19gK2Mm7J5tQP63U32C6Fb6TpOtYgKhAXJoYXs1C3BhNuVFel96MiioFmf06QW aBIpv04Vh9C29RKghuG7Th8eh3+k5M0L+n2101NNmZgfrvBind7V7JG1N9n1VOA14OWt h2KlL1e1CE31yZCEjiAog7iEu+Hm/geIxGC+bdmyEOHGh3/C1mVtsz6r4QgS/SyI4q5V vypg== X-Forwarded-Encrypted: i=1; AJvYcCXWsYwf3V7t33wMNq8Z4NJgPH1+0PQ+c0229gslLgrmvYHpV9Q74Lt5oNTSY88CLU4tPN/KmfKd2r94Q9imCeuKiL8= X-Gm-Message-State: AOJu0Yxf9wt/mKl7EpSpnpo7nTw6zZlVXIcDppVaAHx8nhFfmiqYPAGf 3OeoQPRx+aDbpjPlWkmDUOBIYJaQyFpRxjFhXDHaZO2eCU1od5EMPmLK7jRR X-Google-Smtp-Source: AGHT+IEsEJ3oBX93oBSYOsmqLbKNJndsPIfuYLiWRnL0KyICPE0J7d/MnMYKik5hM5k+CpGN7fz/rw== X-Received: by 2002:a17:906:3bc4:b0:a52:5d89:5f27 with SMTP id v4-20020a1709063bc400b00a525d895f27mr5324754ejf.14.1713320639180; Tue, 16 Apr 2024 19:23:59 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id ga31-20020a1709070c1f00b00a4e24d259edsm7451411ejc.167.2024.04.16.19.23.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2024 19:23:58 -0700 (PDT) Date: Wed, 17 Apr 2024 02:23:57 +0000 From: Wei Yang To: skseofh@gmail.com Cc: robh@kernel.org, saravanak@google.com, rppt@kernel.org, akpm@linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daero Lee Subject: Re: [PATCH v2] memblock: add no-map alloc functions Message-ID: <20240417022357.glrgkb5cg6ajxnqd@master> Reply-To: Wei Yang References: <20240416120635.361838-1-skseofh@gmail.com> <20240416120635.361838-2-skseofh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240416120635.361838-2-skseofh@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: 69hcgpse8aijizjsyex3htxw1zaf96gs X-Rspamd-Queue-Id: DBF69A0006 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1713320640-767738 X-HE-Meta: U2FsdGVkX18mSA5zv0aeqjKVNIvlnfu94JAOdROAsonTkcck9X681nCGWwjdHIZ78fbWzEwA2c/ySxOtSQOh9nQrLo8mHWWmbtQTtdsFTi/Gqcmj6ND3G1bqfDo26VuCdbY7NrUZvz7/u2Uh7Ez2rFhcA7ZNmrPBpFHQn5gTESmH+lyG+XmXgWhZREZH7Sevqt9wP3aD617Ug65qwVgS3mqmlmPrVFX8isf+qXO1ccE4jf/n6E50XsHMNLKA1sZoaWt+rZLIsZcgZk1ktT6k7IOXGWufQhdSYvV6wMQvjM2G++b13gnLJrThVvmTGaxM6wA4Y8SacmhFfu+ZKT7O3SuWuMPZ2XvBhx/ni7+dkCCgqELwk+/Nbi1K/D1ccFsUuplvE+/bzOcayZEduFhaOyzbEN4Uw0462w8VCU0AbgYU8SRyt7zb6qr4xasYUNM0ya8SCGii1mfJNn+/oC96IXFklZV3W4IBZW5SKo2tAMId4ahaQUXS3sNsnkkKApwAy6C/pIDwmYouGu1vG+1dFNPCTvGl4RBFjX7JV9kOX2pRgtoiWJZnAX2y6fWZXHT5IKluIoCZbH4Mc4J7fAXaAsGyQz+giPg/AYrBi8vFZk9nSUHZ+64Tnp5HWUZz8wTFAUCXo8i/JdTtnwi1ybCaYqUSPshPtg2BRwLQh54f1ZKYHeGKYqhBUmdb+4eashCGxgUocT4TuBvVTQt/1ocguEqnuh2TCFxajXX93nb9YvRo1zSPShuU+VXKCqZqVgVY2scuDGRXELBovbph/oA0HEmCcbRVEYE6EZWUfcpKN/MkAeUlgPijMoLQeNVqSPdpzGWUg/GNEvl4vOcN+S/MpuAOez2TbbgqNCtfZgkUWbfOnfbC72obTS64EJbzghqvBaioVRio4g+FOSs92p1Zam8uF8CMXhc+yTE4ejpA/rjZt/rfEhOCFiDO2DWU/avmdTawwWs1As3PL9Ycspw +TO52ABB gzDLXOarnhrO6556NCKhWrXO7+otEf9HUi/CC5UIXQbPVLJqr3xlgDzpC0N7FQFReqG9+faEEgskDXNvOdb6mJCfYrw22aovw53u/lXZxexoexkV/WCp+MHjyCMGTvkjkgkgqHqP5qfu+Wj5KUBPehH5rig+xfHTvmDTfy6YIDJlcHw/KlhhEPDcKz5fWCGbehHJbvcYLAldogDzwk/3BEEWchkaIPVOqYdGXBWeQkF8dXWgQRd+hdmTTy5/QHx89v5ptfvB2qPi2cz+0YcDZ3T28NJJyJdVJ6FWg6L5J4QyzUpdJvQyEtq89GeGtxZCBGnrPnqcwl/cSj2GcaNxBMf1Mbs4/W0iCZOVt8uxQRzCLoeBK0hmD7bCYMrfnbeu5SJncrKbCKjqTlrX9u7NbH6EESCI0SaPpQtGfghl2tuICUpnR177X2tQqK98L5K/PD/7+5Hanu8gPxNH2OiDgYUpZF/n2xFS+2OaAYku2iYhpC1/mCuJcdDGm4mmF3TpPHbkbkV3mXISIWJEYRaDzIlAO8FTJ97+u7RJTqIMswamy+wYxgKnhLqlg+dIioKAMMqvSAQHXGdkgNAnWMHnNGdkAAoBQvR5yikIiOjPSgscm7G1A2AD6v+FBf/iuDRJinQpg4Rto4WpKsdzf3M8xaFsfABApGzvayuE1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 09:06:35PM +0900, skseofh@gmail.com wrote: >From: Daero Lee > >Like reserved-memory with the 'no-map' property and only 'size' property >(w/o 'reg' property), there are memory regions need to be allocated in >memblock.memory marked with the MEMBLOCK_NOMAP flag, but should not be >allocated in memblock.reserved. We don't "allocate" memory from memblock.memory directly. We present memory in memblock.memory and "allocate" a memory by marking it in memblock.reserved. > >example : arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi > reserved-memory { > #address-cells = <2>; > #size-cells = <2>; > ranges; > > bman_fbpr: bman-fbpr { > compatible = "shared-dma-pool"; > size = <0 0x1000000>; > alignment = <0 0x1000000>; > no-map; > }; > > qman_fqd: qman-fqd { > compatible = "shared-dma-pool"; > size = <0 0x400000>; > alignment = <0 0x400000>; > no-map; > }; > > qman_pfdr: qman-pfdr { > compatible = "shared-dma-pool"; > size = <0 0x2000000>; > alignment = <0 0x2000000>; > no-map; > }; > }; > >So, functions were added that find the required memory area in >memblock.memory, but do not allocate it to memblock.reserved. > >In previous patch(a7259df), early_init_dt_alloc_reserved_memory was You want to say this patch introduced a regression? >modified to use memblock_phys_alloc_range allocating memory in >memblock.reserved, instead of memblock_find_in_range that just find the >available region. But if there is a 'no-map' property, memory region >should not be allocated to memblock.reserved. If my understanding is correct, memblock_phys_free() is called if 'no-map' property is set. This would release the "allocation" in memblock.reserved. > >So, the early_init_dt_alloc_reserved_memory_arch function was modified >using the no-map alloc function. > >Signed-off-by: Daero Lee >--- > drivers/of/of_reserved_mem.c | 9 +++-- > mm/memblock.c | 78 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 84 insertions(+), 3 deletions(-) > >diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c >index 8236ecae2953..504f2f60689c 100644 >--- a/drivers/of/of_reserved_mem.c >+++ b/drivers/of/of_reserved_mem.c >@@ -40,15 +40,18 @@ static int __init early_init_dt_alloc_reserved_memory_arch(phys_addr_t size, > > end = !end ? MEMBLOCK_ALLOC_ANYWHERE : end; > align = !align ? SMP_CACHE_BYTES : align; >- base = memblock_phys_alloc_range(size, align, start, end); >+ if (nomap) { >+ base = memblock_phys_alloc_range_nomap(size, align, start, end); >+ } else { >+ base = memblock_phys_alloc_range(size, align, start, end); >+ } >+ > if (!base) > return -ENOMEM; > > *res_base = base; > if (nomap) { > err = memblock_mark_nomap(base, size); >- if (err) >- memblock_phys_free(base, size); I see you removed it here, seems does the same as before. > } > > kmemleak_ignore_phys(base); >diff --git a/mm/memblock.c b/mm/memblock.c >index d09136e040d3..f103f1ecbfad 100644 >--- a/mm/memblock.c >+++ b/mm/memblock.c >@@ -1506,6 +1506,72 @@ phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > return found; > } > >+phys_addr_t __init memblock_alloc_range_nid_nomap(phys_addr_t size, >+ phys_addr_t align, phys_addr_t start, >+ phys_addr_t end, int nid, >+ bool exact_nid) >+{ >+ enum memblock_flags flags = choose_memblock_flags(); >+ phys_addr_t found; >+ >+ if (WARN_ONCE(nid == MAX_NUMNODES, "Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead\n")) >+ nid = NUMA_NO_NODE; >+ >+ if (!align) { >+ /* Can't use WARNs this early in boot on powerpc */ >+ dump_stack(); >+ align = SMP_CACHE_BYTES; >+ } >+ >+again: >+ found = memblock_find_in_range_node(size, align, start, end, nid, >+ flags); >+ if (found) >+ goto done; >+ >+ if (nid != NUMA_NO_NODE && !exact_nid) { >+ found = memblock_find_in_range_node(size, align, start, >+ end, NUMA_NO_NODE, >+ flags); >+ if (found) >+ goto done; >+ } >+ >+ if (flags & MEMBLOCK_MIRROR) { >+ flags &= ~MEMBLOCK_MIRROR; >+ pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n", >+ &size); >+ goto again; >+ } >+ >+ return 0; >+ >+done: >+ /* >+ * Skip kmemleak for those places like kasan_init() and >+ * early_pgtable_alloc() due to high volume. >+ */ >+ if (end != MEMBLOCK_ALLOC_NOLEAKTRACE) >+ /* >+ * Memblock allocated blocks are never reported as >+ * leaks. This is because many of these blocks are >+ * only referred via the physical address which is >+ * not looked up by kmemleak. >+ */ >+ kmemleak_alloc_phys(found, size, 0); >+ >+ /* >+ * Some Virtual Machine platforms, such as Intel TDX or AMD SEV-SNP, >+ * require memory to be accepted before it can be used by the >+ * guest. >+ * >+ * Accept the memory of the allocated buffer. >+ */ >+ accept_memory(found, found + size); >+ >+ return found; >+} >+ > /** > * memblock_phys_alloc_range - allocate a memory block inside specified range > * @size: size of memory block to be allocated in bytes >@@ -1530,6 +1596,18 @@ phys_addr_t __init memblock_phys_alloc_range(phys_addr_t size, > false); > } > >+phys_addr_t __init memblock_phys_alloc_range_nomap(phys_addr_t size, >+ phys_addr_t align, >+ phys_addr_t start, >+ phys_addr_t end) >+{ >+ memblock_dbg("%s: %llu bytes align=0x%llx from=%pa max_addr=%pa %pS\n", >+ __func__, (u64)size, (u64)align, &start, &end, >+ (void *)_RET_IP_); >+ return memblock_alloc_range_nid_nomap(size, align, start, end, >+ NUMA_NO_NODE, false); >+} >+ > /** > * memblock_phys_alloc_try_nid - allocate a memory block from specified NUMA node > * @size: size of memory block to be allocated in bytes >-- >2.25.1 > -- Wei Yang Help you, Help me