From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F20C6C4345F for ; Tue, 16 Apr 2024 13:41:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B82F6B0085; Tue, 16 Apr 2024 09:41:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 866C46B0088; Tue, 16 Apr 2024 09:41:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72ED46B0089; Tue, 16 Apr 2024 09:41:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 55D7C6B0085 for ; Tue, 16 Apr 2024 09:41:46 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DDEA31C0F58 for ; Tue, 16 Apr 2024 13:41:45 +0000 (UTC) X-FDA: 82015507770.28.0165194 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf19.hostedemail.com (Postfix) with ESMTP id BFF7E1A000B for ; Tue, 16 Apr 2024 13:41:43 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mgSH7CCq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713274903; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2wMSwIbSW3/LmnCJZAsPzybV/yi2Pk1y2NoQeMM1hTA=; b=o/mZVItOHOFcagS0+y5ez3wqYGOj1lh0GTlz02OGPiVOkjKCEXRYowrk/C1UhXW2gITeeZ yTEVCirb4zH0bekhRp/wFfw/IcM6EMsvQVb68sv5p/+KxbOizBbWsrlIH/z8iBx9ptxcXY jRecK3RXjGGH6vu0eGkc2TZROW56yIU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mgSH7CCq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713274903; a=rsa-sha256; cv=none; b=DSXgSKEkYvQeyj4clzWCLxrKw7g53KRPpXgt9lAXDiu4ybWIm+79RN7vzitzD0dA8K1yn3 0hUrWYAaIGX992GbcGvQkX8TgWE5K5uOd+ljlUy8VLlaKTj1mwkfq+FQ5YBpE9Qtf+9Bwr rNzELqLcuHy5o4JbSyrxgMHq+JqXnns= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-570175e8e6fso3702348a12.3 for ; Tue, 16 Apr 2024 06:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713274902; x=1713879702; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=2wMSwIbSW3/LmnCJZAsPzybV/yi2Pk1y2NoQeMM1hTA=; b=mgSH7CCqbyAMt7XlaScicC9j6PkgU4q//bfO6/PcW4qIl1boqlXelwD5XWhzoAg4av u23fSM+U9z/qQd/8oMC6kI1YAEjQBGaYIIYFQt4b3zl2tR1kIu0HNTtppv+rxC/iyAEm FsljDLBm36Pu7kosQ3VPg3efb96jHfdUvRIvQxpjAyOlIhb1I/kXEHUWO2KmK7EUWXhI eu8Db9JIv2reeDIzJ/bbpb6WReOsI3mf9qQSoWt0KoNhcRqN/x481ad4T/lVGMNJovza 4FSCbyOwApu560rgUJ+5GNz4/Od8CcLm80JO9iUNIfYUdywNECJqH5BvZViCPbBILBMo 97DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713274902; x=1713879702; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2wMSwIbSW3/LmnCJZAsPzybV/yi2Pk1y2NoQeMM1hTA=; b=hq0zUsMTnYGPAOKQ1vNBrI6k2Q8B0Qadb2e2VYCPmd2uelO6XfsI7eb52x1IEx6ojN /vEbAc2O2u3KXJANH/zRMNPl+eEMqXZdldgTGLWzAo5BMOnX0G7P4VzEIbaj5ZVObXz8 J4NPBvbk3fZrXBe9dk9afXWITenfy2VpgrUw/EdJlYqBbHy8YGltHGAj6GPsb+Mz0xKf Qsguncz780BEBhJwjO1sS1OLltJPL000mLwHyecxe+66pkySLUp9shE3+8FM/RvBE7gV aBZukez/y2JG69d6mDep64Nn4Rb4nWv0zwkmHRSruy8XEVq6k3j32Xbsbu7VxAG/LFhb 4s3A== X-Forwarded-Encrypted: i=1; AJvYcCXqes2OU01LZAVd7hZ0Pg0nXRXaLqswyuq0s4Z1gFhI7eg3gcehyKrn9bQ6mZKkBGrffXkEhMXfyB3Ullljt0eXQ9I= X-Gm-Message-State: AOJu0YzZR1N9zmvGzOJehjvMZwQEHM8v4FiMvKsv9AQyWoxAgf3gefS7 FNyc/HDOR6LP5v6BczE5lIzAof1P6E6Ze7sKYwG0s6zuAp8eNFCaGB9X6JMs X-Google-Smtp-Source: AGHT+IH55Cj6jpywIj2+Z8nl0guBr3BgBcMbTvEldRSOojc2nQ/kvumL0NhllI05uFLNwb2pnN57DQ== X-Received: by 2002:a50:9544:0:b0:566:777:af4f with SMTP id v4-20020a509544000000b005660777af4fmr8670914eda.1.1713274901962; Tue, 16 Apr 2024 06:41:41 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id k20-20020aa7c054000000b0056ff82e54a0sm5421225edo.31.2024.04.16.06.41.41 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2024 06:41:41 -0700 (PDT) Date: Tue, 16 Apr 2024 13:41:41 +0000 From: Wei Yang To: skseofh@gmail.com Cc: robh@kernel.org, saravanak@google.com, rppt@kernel.org, akpm@linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daero Lee Subject: Re: [PATCH] memblock: add no-map alloc functions Message-ID: <20240416134141.gnkjj223qlxk6dhr@master> Reply-To: Wei Yang References: <20240415142448.333271-1-skseofh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415142448.333271-1-skseofh@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: BFF7E1A000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: yeeexhtqz87n8oybthtf4fhy4drz3bq9 X-HE-Tag: 1713274903-714526 X-HE-Meta: U2FsdGVkX1/vAaX6nta7MYsD+aNyWGfKsEmXUI6heek3K86Lt4zc/BrPxWkvX3s44pQq38A30LxKq+aeL53VI6+h7PkEVCxz0V/V8wfH6ZWTEf+AZMeGDYFlx8vQo2a5dfPMk4Brob56la4YFMy39VHwSYhUM9LWjYSrcNHDUyzFxkLPhZSufklvdXXIZzf+ByQsHSdViweGMFb2PXV2nQpSeUoSW0BQNmDSTDh60p8RmZ25obTbeAx4OZlYwfyLJ6YfkbyY04EX7HePPeFZOXZzU3QkhUW30diyN/q04trE+6+1M7ZT2dTQT3ZpYO+w1YqOUfbf0YovD8OdF9a3/0P10uBzBducM1YzPJCoUhjnR8fsdgDvoWlkkNpOvXJqI7MW4O8SsrCylRaN//FwOg8GI9xpAKME2ntE2UP37Kdi5mgea+0mcCa1iqcaLbPd/67bQ1gMrOz+oK/mLL5+z+urnCDx/JvJ9LYwFDovAnz9hL98SEqbWs4y4fJ/qnSBEJraBM/kDhoIwvcvatdRToS7GTvodJJTN/nuxx1FlM9goarc5kljq8WrU0fuCRRvaeQycotskExuySJw0DVC0r6s4H1xvuoVKCWhk9A2F2FfnkIx1KqBlB3s6T3/6W9BBvPkUH3gCyvujvpU7WizVa3OmzELkfuV/OxwRySRts2TecHrp0mXgo9W6p/Unh0Kk/VPwGMS3Fnr/dnOhc55CEyinpRJTyijTLIdax09PsLx6yywqRAAWpzbdoV3GSpuTdJgg0EMguLSgc/alJW0liwHdkDqTxkZMwZtLv5TBwmz35FZ7jCqq29xjrZhpS4y0BACXySBevOdNYSOOcJjPL2s8s3OnPkQ7ET/xq/CZkwDKxvNSW/YicE+MiTwLQAu+hAY/4xdvgx8h0C+IaxvQMtyj3V7zizkdaOm1GcaTgZYmm6yTiWr/XytbsiudcNm1JJp/PcqtHL99g0zgzD JRYahGaX Frrp5vQTAdn0Tb2uAMHnmdrUtF5aX6+uLnw88NFIcMHX1vKjzGmXiDK+wWwQoPLIXtyJtw4qI1BEHIoPfZZimmzVAUAsvFN6bzrRDOUSq4F3S03uheFNtl48Iyj/s8JjxV1uv8HPjKdOxGZLloGcz0SDm1rDBaRDAXnumv7hW6CyKbEZp40VeKI5IUs0H7tOzuLgopWwH8zET20zkf/7DKbOgaNzhWg967F8LmG6aQxUfniLWHnOkwrHzzpb+MI8olgW8rGbsseaPF+CizVOvbEr9xWwPQEJ9andHJViBBRvovTZPNeUU3qM8KM11PMvUvZfdYXLPOdgGBIbMveX4J+vWz4wfDI636lQ0n7qDYAS/etiCY/LjQIVsAvdBfRpoqtPVzNgqoRZadwHxq2HEdWMrC4ey5MFJYkeRYa6ZnGc85+vDe4ssDN4wsGPSyd5+qgeVBTjO3HJ2YoUYNT2GxU5NFS0l6s1/KXSq1L7FZ79WQzlvpRaQHcxfG+74EnLbOSLxmwCY397OLLLzMIB2Gz00FmK+4UeBwvhbsu6iPu7EPOZZMcd0149zRz1I8O0978weB1ED8ZyEJBNlAxbU9traAe2HgRleELiY1o9ZABSQQ+tpCfSClqNVlPZEl6GqYcS5h4jmQCJZrXM9FWpGFGxLJj7dBEn76ntx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 15, 2024 at 11:24:48PM +0900, skseofh@gmail.com wrote: >From: Daero Lee > >Like reserved-memory with the no-map property, there are memory regions >need to be allocated in memblock.memory marked with the >MEMBLOCK_NOMAP flag, but sholud not be allocated in memblock.reserved. > >So, functions were added that find the required memory area in >memblock.memory, but do not allocate it to memblock.reserved. > >The early_init_dt_alloc_reserved_memory_arch function was modified >using the no-map alloc function. > >Signed-off-by: Daero Lee >--- > drivers/of/of_reserved_mem.c | 9 +++-- > mm/memblock.c | 78 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 84 insertions(+), 3 deletions(-) > >diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c >index 8236ecae2953..504f2f60689c 100644 >--- a/drivers/of/of_reserved_mem.c >+++ b/drivers/of/of_reserved_mem.c >@@ -40,15 +40,18 @@ static int __init early_init_dt_alloc_reserved_memory_arch(phys_addr_t size, > > end = !end ? MEMBLOCK_ALLOC_ANYWHERE : end; > align = !align ? SMP_CACHE_BYTES : align; >- base = memblock_phys_alloc_range(size, align, start, end); >+ if (nomap) { >+ base = memblock_phys_alloc_range_nomap(size, align, start, end); >+ } else { >+ base = memblock_phys_alloc_range(size, align, start, end); >+ } >+ > if (!base) > return -ENOMEM; > > *res_base = base; > if (nomap) { > err = memblock_mark_nomap(base, size); >- if (err) >- memblock_phys_free(base, size); > } > > kmemleak_ignore_phys(base); >diff --git a/mm/memblock.c b/mm/memblock.c >index d09136e040d3..f103f1ecbfad 100644 >--- a/mm/memblock.c >+++ b/mm/memblock.c >@@ -1506,6 +1506,72 @@ phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size, > return found; > } > >+phys_addr_t __init memblock_alloc_range_nid_nomap(phys_addr_t size, >+ phys_addr_t align, phys_addr_t start, >+ phys_addr_t end, int nid, >+ bool exact_nid) >+{ >+ enum memblock_flags flags = choose_memblock_flags(); >+ phys_addr_t found; >+ >+ if (WARN_ONCE(nid == MAX_NUMNODES, "Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead\n")) >+ nid = NUMA_NO_NODE; >+ >+ if (!align) { >+ /* Can't use WARNs this early in boot on powerpc */ >+ dump_stack(); >+ align = SMP_CACHE_BYTES; >+ } >+ >+again: >+ found = memblock_find_in_range_node(size, align, start, end, nid, >+ flags); >+ if (found) >+ goto done; Only find without reserve has no effect on memblock meta data. It seems run but nothing happens. What you want to achieve for this function? -- Wei Yang Help you, Help me