From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1B7AC4345F for ; Tue, 16 Apr 2024 20:11:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43A6D6B0095; Tue, 16 Apr 2024 16:11:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E9E16B0096; Tue, 16 Apr 2024 16:11:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B12E6B0099; Tue, 16 Apr 2024 16:11:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0ED2C6B0095 for ; Tue, 16 Apr 2024 16:11:31 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BEA19C0B87 for ; Tue, 16 Apr 2024 20:11:30 +0000 (UTC) X-FDA: 82016489940.13.3A74402 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf05.hostedemail.com (Postfix) with ESMTP id 9DA8710001C for ; Tue, 16 Apr 2024 20:11:27 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=cjZZt45z; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713298288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dzgDEmRceOFDzNCXUsX+I9UG7YSyd6aygwj+yG5BbfQ=; b=zvTqUgBZqBddz7FO/yb9m/zA3lTILfTn6QwLxHrvKFJgWp443mjFFWSzAOVk2Mw3+aR82p utPkX9P7FhDHpfROvlN0TNCfSvbddCniKqfdviPA3yLWdyvRXhb1Wf2ztEDkKJjMrgqSxO yYBSHUhbvEaYO3twK+423iCf8F5Cz58= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=cjZZt45z; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713298288; a=rsa-sha256; cv=none; b=7T1GrqpTIdzZkJA2lxAArWPusGbDW/7KkA7Njq2+jnWGd1VG5aPx9knnZ5TJobPMKpd6/c zoRIYShibW5Gopvh2Zy2sXy0mwt35fFxqoyq6gmsmlra0ayot4lNCERsbaghHBTam15tGZ pIsziFawnlwnyuDe97ox0nhzjLkZpqQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7AFA2CE113D; Tue, 16 Apr 2024 20:11:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 947A5C3277B; Tue, 16 Apr 2024 20:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1713298281; bh=vH93qz9QypmdrxTbfPnlMTMImwmxiAcyrlntd9a+0o0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cjZZt45zzFNVvRVLLkIaQ69+5t4zoCNBaDZANtTYyKIzGiPWX0wB/I6nLAB1CxgDP LyDiexeqmuMVOpNvYwYTEYfDw/QqbKIpHEnEylNsfU0Nr6S5UXmnG60k+iAegOG4s6 wUvuXfyB5LNQoRUHmF5B7VHXvfaARZL14SvNsgdE= Date: Tue, 16 Apr 2024 13:11:20 -0700 From: Andrew Morton To: Maxwell Bland Cc: linux-mm@kvack.org, Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Ard Biesheuvel , Mark Rutland , Alexandre Ghiti , Yu Chien Peter Lin , Song Shuai , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 5/5] ptdump: add state parameter for non-leaf callback Message-Id: <20240416131120.a801ff03a6d0bbec0e9151c8@linux-foundation.org> In-Reply-To: <20240416122254.868007168-6-mbland@motorola.com> References: <20240416122254.868007168-1-mbland@motorola.com> <20240416122254.868007168-6-mbland@motorola.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: ikkefmwmkgcx4wpf5bk8ytym1ugh6dqr X-Rspamd-Queue-Id: 9DA8710001C X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1713298287-385089 X-HE-Meta: U2FsdGVkX1/6hol3nfCirw+sljjecrinA/qaswx/Rgt9vuILr4wcRoIL13uNSabZkowVQT0d5AOW2NAGwGq18/dkcAViV12RCVdLECqarKS6jlTLf7J8xlFhFAsgMvqNUadVBSZ6pNOaCogOYWdX7yOuK+zq1V1XK79JJoJAVyuXtjBIPRz5P2ziY36ycNJu7LbZ2CkhGo6OfC6Piz581QX4wCvfmtm2lEvUQ/IqcrXHuTDP25H39Js+bBa1Qco/WZkUjUEVcxb7CdZ38/PFeKZrqIlZjJAmpV7Bc552/vf9CcTpGzZPV0n28guGd1yvGGIZjGL2lRMyExwVD1ti+MdFcbgnRBP3ReiRQKfTcufTabKgdTg3+o/zFfS7Hek6uzriYKr4jO9677u5FkpnYZTEyWEecXFbAl2RxeesRW0I/xPu8O4AJlJfX4xUn8RXIPC+WXd4db/RWJ/9EjUwDarTjr2zacDKHqpzhncWoWi5NPMPQKEO7E56Kjkx/Y1+mw0LZQzoR+xe+0QTY5WYmmwWSoyHm3r3+dfb64sKX3fTvA/9wAqwn8uSW2XOL9gI3kMBLNkgfFZ2b9cYHWb2paCPHQeKrtVfJ5Bp4KA/OVPKA+kVWazOYrM6OI0KVmcSMmOJMBwR703l10uO2hf7tuRtHS/Lz38e1zeUBgNMzXJYvPnG38z5GAV0bKU98oMlLg1aYCp9PYRMD098TB59gcwKM3cdq2TNZCRJazghfbhkQdiBfsgNX43ak7CHLLdPoOeCoJpvsUS1vTEER7NDHfaVVVmzeE+Yda1Dp8F4FmFWh+CEOtO4abGZM+RtacAcfqqMaqTKob99Xj6Du8cF1f8R0RTOzyUlsvFDTc6gdNDxgowfUsMhjN+y2csS8zoFAJLBZkJVHO6hCw/1boATL9YIrMPcDjV5hrk90CBzvQA6MV6E7SrHpH0JYr/Gr5BqtXmoyPb0LCnrftbfSmt qHFXaVse t7e8+HSv++TwhrA52Rfl3BfckzA8e1VylklWX29fglTJDKHUY30ci9z4lOvNN4Odx3cGdd6LS6YC+bv413NrsOJFEqRSJduaYBZtV6rKvz/nft9GDEYXg0qeplUtK+K56IP2bVPdjp1v/tZjoddzzBrBJO2PMIcRoyM+QmKFgidJNIQqjpXazb0CGhaXXAVs4TXnGzgxu814FIEPCld+J0vEPIUUQ1Es+0WX6ZU+z3zg072qrCl3lT+b7UgXYEt+PBSR9BR9nwLph3069aZJEIb8Fx8421oRQttJf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 15 Apr 2024 14:51:32 -0500 Maxwell Bland wrote: > ptdump can now note non-leaf descriptor entries, a useful addition for > debugging table descriptor permissions when working on related code > > Signed-off-by: Maxwell Bland > --- > arch/arm64/mm/ptdump.c | 6 ++++-- > arch/powerpc/mm/ptdump/ptdump.c | 2 ++ > arch/riscv/mm/ptdump.c | 6 ++++-- > arch/s390/mm/dump_pagetables.c | 6 ++++-- > arch/x86/mm/dump_pagetables.c | 3 ++- > include/linux/ptdump.h | 1 + > mm/ptdump.c | 13 +++++++++++++ > 7 files changed, 30 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/mm/ptdump.c b/arch/arm64/mm/ptdump.c > index 796231a4fd63..1a6f4a3513e5 100644 > --- a/arch/arm64/mm/ptdump.c > +++ b/arch/arm64/mm/ptdump.c > @@ -299,7 +299,8 @@ void ptdump_walk(struct seq_file *s, struct ptdump_info *info) > .range = (struct ptdump_range[]){ > {info->base_addr, end}, > {0, 0} > - } > + }, > + .note_non_leaf = false > } It would be acceptable to omit all of these and rely upon the runtime zeroing which the compiler will emit. Documentation/arch/arm64/ptdump.rst might need updating. Please include sample output in the changelog so we can better understand the user's view of this change.