From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 545CEC4345F for ; Tue, 16 Apr 2024 18:44:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D66ED6B008A; Tue, 16 Apr 2024 14:44:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D16EC6B0092; Tue, 16 Apr 2024 14:44:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE7FA6B008A; Tue, 16 Apr 2024 14:44:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A07606B008A for ; Tue, 16 Apr 2024 14:44:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3B8C4160C8C for ; Tue, 16 Apr 2024 18:44:47 +0000 (UTC) X-FDA: 82016271414.28.8794CC8 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf26.hostedemail.com (Postfix) with ESMTP id 01370140003 for ; Tue, 16 Apr 2024 18:44:44 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zuU2FIVF; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713293085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BQddM4HnFA8jf5hCiXWTQzVkny1CWgtZP7MLRHS4e6c=; b=XtYmi7exSqxIP/rJZJSDFog0unjjwsBPnPqnUMr7gXPA8/so01nEoySQSe9cN1GUNB8Uh2 O0YjS0ATfKsMb8t6m6wLlqOMELD73Gti6w5YC4Jjx4LTs/mJDludjTImiM7uMv2FEnaXli FhDVa6V0fe4NpwpWTmiT04Af2uR4Qrw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713293085; a=rsa-sha256; cv=none; b=RFzIR0oagh/K4aihBHv2OMLmQYH/ulg7Jr603GcPUR1yFdDRqX1M6Kpe+pQlbtRlFtEhS3 yQ1LzRBqD7o1yyeGnTCev+L8/jTVBcGIG/WHgfmN1PW9PYOa/zf4bpQtAKb0/kZH7mYCFb XvgdA9+wo50I7y2UNyWDLighh5Ig/pQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zuU2FIVF; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4D50ACE1153; Tue, 16 Apr 2024 18:44:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D32AC113CE; Tue, 16 Apr 2024 18:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1713293080; bh=PfVSCPLedtUiAlqhfWLQnECZx0MQcYJs85YdER9mbtQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zuU2FIVFHSjHsUiTAdIzo8HgZPDKr3Mnh5prwnAv5vMaRzQxJWSPV+J4GrMU+dwS1 NQQEyGYYsGkJrNM1QRzdslhvdWiV3p2+F8RYZirM76Xs3qVbozpO2mwnZQVfeC+h6i D5eBijVqLO9S7+Riuj7ynQwaaeygognYhKyW9H8o= Date: Tue, 16 Apr 2024 11:44:39 -0700 From: Andrew Morton To: kernel test robot Cc: Edward Liaw , , Linux Memory Management List Subject: Re: [linux-next:master 5507/6266] ../kselftest_harness.h:1167:9: warning: ignoring return value of 'asprintf' declared with attribute 'warn_unused_result' Message-Id: <20240416114439.038054b9c33986a13f4757c7@linux-foundation.org> In-Reply-To: <202404161023.K0EsnDmF-lkp@intel.com> References: <202404161023.K0EsnDmF-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 01370140003 X-Rspam-User: X-Stat-Signature: ibh7tjci31co7uhr8g37q357mxp7ph18 X-HE-Tag: 1713293084-882977 X-HE-Meta: U2FsdGVkX1/aqflhxm6upGo7mO4Fg6iRVS9zS/yWWOUczP+O1XltEH+GtilV3WhljwGZaU4nRHZiGRG8HsNYpoSF+u/9tzRmk8VDxtq91i8ZKUf7Nm5xgQ1NYYxbMugCMwD9i12QXJQbrOqd0ZWJuDpJwX9sXJINyCjieMXxKX1LbId3EPjf9o+V9rZHW2QhS3cwJd57Vqi2gCF5fuIe+7FTorVGexKFRmmdZgYULunSOU3ClL+dprjfn/jPCsE/aSq4ry5s23Bx2zPubNjqBhCaRDQo3ooqLYVlWd6uCEwiJNmJWoYZpbwE1M+tSrwDY/Jc/BMdwLajUmzlRG0IPACzLjZHJYmR6ypH/vVSbgYO2cCrSTfrnzybKDYAy5FrnWYxU/f90GUAUBCSz4Va08MS3zzHzdwmGYH+92r4aGWhG3IO1iXXR0Fg/eS4/lvQl1irTzLwbtNMMzJ/K+9QpylqzT0UPPTdFh17TOOvaMqX5lYcSZeZakwnnmJyuUAoU2DI4mPzdq1jG+7y+wqTmhcue5KrZJrOd3vp0FP9uuxV5vk1Fd5MNk/TUnD2WYqPEiKI2Sf69e08HLWbMaGYnZ3UnI8UQwn4k3VQyNO6WBmQ+6zQT4Xm2Q/kRODgDm3bYcEMCOAKrMMtI4iWXupx+X/NA4tZQxNNuBBUGJdJ/42+WDd9zLSJLxqt4Ls8Z/MpzRgXsOjJ0hRZDwOdYZJXVsbWDbEzQDw1jeTVaflVPpXqhAySjWnzmkPLvAV1gUswcQpsjU7vf3pN+bzqvXdaw+Q/yk4rtQWDgjnMOt/wgn48J4v8vf+QUi8OELUpm2YPhHnJm1QmPCd9zG0jIPoYqDsMQJb/tkmBbiQ8L+FfQBgU8BahYi/XiLLKJ1nK+LxwEaYFEUYY5sdKQgiZVFCLQBeq8rWo4nUzupwUOz+gTN4hf7UU8qmP6c7MEwjOdQ/cAUvwYkK+/7Lf9yo4NYg ADdxcWIn AH1MpV5YjLMC14B7Qw+W9wtdDoE8CxNSTdPibo+0njyBI1d8V7Lgh3QJDcwmQxkyWul7x7/ygEjYeLstGTfNrKnVxMCn6CN8zJEuVwptbmpgdDmnZ/OBOTcHHagxat7ZPiX/TqfdmF8lF313hUGpHsxyHUXC7wfc1cvrA5+Sqh+woj5r/0n5EDiTwChM69EBSgsltPlRRITni8dbNuVYJrY4Dg+oCqiFZ9GrDyLIQ6KYyNyK6Z0Brek0Kj2k3YZhV5bUwxHE13qRMGYbcLVLSeUEnPtE2OHV7MeLVW0CMiMMQv63920m2/LbElmp0cnDj7nnLUOfJUkrRbFsRIPcjKE2FBmrMue9Nv4B4245lwU3VijlzuTXRGBOtGbR2xVFzEbk3xRtjYGQuhWXjFFpIRpn9jyn/0hDPCmEx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 16 Apr 2024 14:35:18 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 6bd343537461b57f3efe5dfc5fc193a232dfef1e > commit: c19377e23d4cb45f69c5d226ae3436f7fa818c8f [5507/6266] selftests/harness: remove use of LINE_MAX > compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240416/202404161023.K0EsnDmF-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/r/202404161023.K0EsnDmF-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > In file included from tls.c:24: > ../kselftest_harness.h: In function '__run_test': > >> ../kselftest_harness.h:1167:9: warning: ignoring return value of 'asprintf' declared with attribute 'warn_unused_result' [-Wunused-result] > 1167 | asprintf(&test_name, "%s%s%s.%s", f->name, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1168 | variant->name[0] ? "." : "", variant->name, t->name); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Thanks. How does this look? --- a/tools/testing/selftests/kselftest_harness.h~selftests-harness-remove-use-of-line_max-fix-fix +++ a/tools/testing/selftests/kselftest_harness.h @@ -1163,8 +1163,12 @@ void __run_test(struct __fixture_metadat t->trigger = 0; memset(t->results->reason, 0, sizeof(t->results->reason)); - asprintf(&test_name, "%s%s%s.%s", f->name, - variant->name[0] ? "." : "", variant->name, t->name); + if (asprintf(&test_name, "%s%s%s.%s", f->name, + variant->name[0] ? "." : "", variant->name, t->name) == -1) { + ksft_print_msg("ERROR ALLOCATING MEMORY\n"); + t->exit_code = KSFT_FAIL; + _exit(t->exit_code); + } ksft_print_msg(" RUN %s ...\n", test_name); _