From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F389FC4345F for ; Tue, 16 Apr 2024 17:28:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8014F6B009A; Tue, 16 Apr 2024 13:28:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B1246B009B; Tue, 16 Apr 2024 13:28:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 677FA6B009C; Tue, 16 Apr 2024 13:28:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4AA8F6B009A for ; Tue, 16 Apr 2024 13:28:08 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1299680C5C for ; Tue, 16 Apr 2024 17:28:08 +0000 (UTC) X-FDA: 82016078256.30.D6B5BD4 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf22.hostedemail.com (Postfix) with ESMTP id 324E2C0007 for ; Tue, 16 Apr 2024 17:28:04 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="RhAJk4/a"; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.170 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713288485; a=rsa-sha256; cv=none; b=06U8GwIdGoetY+hG3XBSlKwp8eRx9yJhUSTqhywlW6s7or3wItQJTPKIKviNqIaVnmGQ+T WuSFBOsXzXQhSDEkJBWbKiumZHdTDp+36e0ZmmYLw8Qo8IGurMXc7XQLlC33d25jwNWiY7 YMS75R04w7vX0t+S0DzYVtIpJbiDQFg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="RhAJk4/a"; spf=pass (imf22.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.170 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713288485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CbYixWM2CqQRL1wOMDrzHbCtgA+kuvvqBpiFHzx5mPI=; b=H9CK3YmDZLQM2cZjZBlcHlvFX6SM50hZNPGFR47DGOYuFfeghZC0y/MfaYkUeCxbkX7+/s 6k7yceSZGckQHHnGiD75KsGh2wrUm/SG3Jot0xwvh6or3pjFsMN5CM/OgW2CjUk4W+Fxo+ QxjIB9qvK6D6kq2/OSFXy8UeJySXy0Q= Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5cddfe0cb64so2677529a12.0 for ; Tue, 16 Apr 2024 10:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713288484; x=1713893284; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CbYixWM2CqQRL1wOMDrzHbCtgA+kuvvqBpiFHzx5mPI=; b=RhAJk4/aeqWFbQ5IbdAwO4N3s++Vml4t0QuriY12kWT6FjnDmSFMVyCh7Nbs+SoXOm 3IgVPy73z7FfgMCMDHy8vhI4yh4dwVCj7WNo5RGTkRZLqHOPgQ37IqHJGvv2DmAW5eUt spu6KRG3RIZo8UoUUTZmtw+MJjJH25EyX/TTE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713288484; x=1713893284; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CbYixWM2CqQRL1wOMDrzHbCtgA+kuvvqBpiFHzx5mPI=; b=mEKfedbZYzCB71XLkKpHtZlEKCLm2p40lQ16mFkUUmOPVsgC0EPcCXFU+tQEvmmqjb VsPJgSmWM5jhwRWEbFLx/XRgMr9qvhPQwcrrj1V6z3d+Oj6c+pPj7s4Zzmx7iBx7q0xC 0gJccl0KNa9Aixk8z6LpqXldWftXM15i/yU7Byfs4ixPRjG66CdKvdQE3LeF8GGTm561 gtVWah4lf7lRV/pdrCWbPs5bXKuU8helyMQmFlAopQqS1ygFAiEkNxb9FQ7Ir4i+S/+i j/k7+mDPpNc2JeeE2WFoDFhHCgAMcX8ECdaxQ7W9mHjYfExXHk741M9S5i0YjDkAP7Sg gung== X-Forwarded-Encrypted: i=1; AJvYcCV+75QvR3NBvXPVolpg3OmbM9U242PrIlRjoxK1ik+B0i/Xt+IwaRbE2Uo+pjsDOySBEPuOMtZ+F1UmfuCmkOfHKVA= X-Gm-Message-State: AOJu0Yw36E4IZyN6mTgOIZ7qL8AFgedRiqCon9nMmp15RC3T/gJsv7nA PT4F7jq7augTFSaMtlgFBqzNjxVZG1mcGlk/09NO8yxjIKzvcB1yfzW3YS3O9Q== X-Google-Smtp-Source: AGHT+IHbN76rCh1Qe3W01Nc2eeKTGXKJ8Gpa83X/WpafmSVHalfqd6xohNVPAcA7T0vL3gX2KQ5VZA== X-Received: by 2002:a17:90b:3bc7:b0:2a2:672f:ef6d with SMTP id ph7-20020a17090b3bc700b002a2672fef6dmr10647646pjb.49.1713288483774; Tue, 16 Apr 2024 10:28:03 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id h16-20020a17090a051000b002a2e4b593cdsm11862530pjh.51.2024.04.16.10.28.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 10:28:03 -0700 (PDT) Date: Tue, 16 Apr 2024 10:28:02 -0700 From: Kees Cook To: Muhammad Usama Anjum Cc: Eric Biederman , Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Andrew Morton , Yang Yingliang , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v2] selftests: exec: make binaries position independent Message-ID: <202404161027.63F4D4FDEB@keescook> References: <20240416152831.3199999-1-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240416152831.3199999-1-usama.anjum@collabora.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 324E2C0007 X-Stat-Signature: 6fhq13eosmrbcz73e89bwpnxica9z4ow X-Rspam-User: X-HE-Tag: 1713288484-425584 X-HE-Meta: U2FsdGVkX18s04cMsbx05xIxaFmTBSKp88vWrXQLv1Dc3PN2zWENnIUvKt+tg60I0/nzHS2at8BMeQ8cA9gX7JxD5xr3eCvWFFlTytqZEW3xJAJuIdcxZaWg5CRvhvV/9pCWc/fNvBO/NBxt3g3YGUDrqrMS3ReOnQrNA/03OZo0W2E8IeSpMwYK0yGYepUjxDc4uysO3ml0C/6Jjb2fNbSfaxf5YDMvWjI565qzVAz0TgAhSM30mJhK493Bq+p4PC0w4Oh3JdkWqC3JZnA10NkzZcLr4kMVFAOWPqs8/0I+q6froFtYDd19HTBPGfo/DfS6Z/wFsICPFNmaqgI4gXd+8wHK6aAFU3tGaihCN7r+K4DkW1RIaRZaAZFJkZ+sex23PhPathQdqKtE6kGXA9SfWWecNhF+3aoVVU6Y8uIqUNMSWyVAjusJ0JdzhsJlttHUNJnEDIqszxvFr3p9PYXXpPnyyrhPgR8HkUQGR2vD0/FRSwk7Qus/ePfLuutZvUJ5Dy5iZRFHDhfhBiefTMbgAoo5lQHBnPlf2Hq37PD6MWhoTeAxF7SUsPgMwO4ZMm1kB0oLZbobxWgkf73Aa+3G7YFiIuq29MS+0ZE6/NMC+yhM6d5jXWfnxsE6r7oZb3BGkxrqHzTgST1k1e+Ln0D+HHKMMJh0qbX861EcCAWpQnZznO/vNWbtJM3YWb74JUf66ZO8mjPOm/BGKduRkDe2WluYL8P3jTgqTiAcC3bG9Jj9LiKIBi6EKM1L1BS73bNVE4LmT8UgtyttE+sm2wSF5fdNrn4A3cXu85BdUuvZ2C+x9HwzQ73NjxKibuVAy1oLZYlIGODzMlBvMHEVn/cwQnvwLvZ9UGGne6qraxydmykovVCvNbraQ2NQXjbOUsjP0sMSZoApW4dbsIbGjVz/XvyrCay7xN/o2Abm26A3eAFX2ZjMvRC4/O+ff5kf2IGVHEnp/slAHTtfZ/5 KFRwh6o0 rqXczra4dJh7VvBIqT3I3rxKaJDIp97WPckYoQqhtSzozdvokOuuMpxmE/OgLTWmeDOXuT2Oze7N5Ax1KdGgp2tLn6WonFxtYJDNhR9+pH22XTx5/zbe7ol/TPJ99XmPDinMld78yhYRuz3HOvUNc4vst2hutnMtpIe0xRnAPSc7pjLn7IUMzRQnq6fEA1OQ9UtGCNSP0At9RFLqYCRHmP6ptlhnbecuzH++0vdApoZ9sPLdrmFnr6I/E7g+2gOHiJI2qLIBuyRB8NxnstWBNCplfppMrcI5c2tVg2oCogSc6NlllMLAo93EvAYbjcMmKhVlrQxbIGzgMd8JoqxXoXTHTMHPZ2mDVy06VDFFrtodt7FXx84PHBN4bq/nUYGnWqH7JWBa/uoinHX/YW+C/aGxS2He7yvK6z1/4LwyzS6t256ki0LO2yHqFa5T9e84Sf6Vbm/isZA5V6jeH9QDz4qdvF9dKYWWlWsj4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 08:28:29PM +0500, Muhammad Usama Anjum wrote: > The -static overrides the -pie and binaries aren't position independent > anymore. Use -static-pie instead which would produce a static and > position independent binary. This has been caught by clang's warnings: > > clang: warning: argument unused during compilation: '-pie' > [-Wunused-command-line-argument] > > Tested with both gcc and clang after this change. > > Fixes: 4d1cd3b2c5c1 ("tools/testing/selftests/exec: fix link error") > Signed-off-by: Muhammad Usama Anjum Thanks for this! Reviewed-by: Kees Cook -- Kees Cook