From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C815C4345F for ; Tue, 16 Apr 2024 00:34:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE75C6B0089; Mon, 15 Apr 2024 20:34:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B97D86B008A; Mon, 15 Apr 2024 20:34:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5FB46B008C; Mon, 15 Apr 2024 20:34:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 898BC6B0089 for ; Mon, 15 Apr 2024 20:34:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2186D1407EC for ; Tue, 16 Apr 2024 00:34:40 +0000 (UTC) X-FDA: 82013524320.20.4BF1122 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf19.hostedemail.com (Postfix) with ESMTP id 3744A1A000B for ; Tue, 16 Apr 2024 00:34:38 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gPzKnyNq; spf=pass (imf19.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.170 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713227678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tECMZdHIf57W8gG8gWlbX6tFu4h7YfeqS1rrPxFzlBU=; b=Dn3YE58FWUbma0b5ry50dd9yzZ7ufIm20N7UDQQUhYSxbRNY26HXMns6JJPG4fd3UnuVg1 AqbrYICPVVDrTmWQjEjEpDrrnQLImsaykJuLpPpSRXazG4Ly1Eg5CrCwsmQ8i8E7Wa/Y97 UNHjJs72pMYPIajkcrxqZhgyrKQ4ZM0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713227678; a=rsa-sha256; cv=none; b=EyvuvlT5Qa4B02UfAxAAwZr48BjRLhgOtXCAkDcq8fknVM5wW8BHmUdwQHtFYx/tFq3e90 BXpHJfEdRgLSk/pz8FI4j0k9UI+DmSLF/n9VkXKetPwoMu/siej5jeIBV0TB4XzKBPVfOv 9QnjRtWL9tgH84fU1jVHtd7p1n3vULU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gPzKnyNq; spf=pass (imf19.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.170 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6ed0e9ccca1so3516852b3a.0 for ; Mon, 15 Apr 2024 17:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713227677; x=1713832477; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=tECMZdHIf57W8gG8gWlbX6tFu4h7YfeqS1rrPxFzlBU=; b=gPzKnyNq5BpIq8S7M7HFZFlQHeO4V5sSr5R1IunU+/eUBKREE4jyhImW4jmAYqVNbP ZRRRROwRYKqFchTpCTxY4QH2JsK6A6kxAxAtdC1MmrTWbC3KLLYamffjO0WBpB/iypIv xtTm18fPIuDRTQXINqFqCtZZ1ZiJfuSihMW7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713227677; x=1713832477; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tECMZdHIf57W8gG8gWlbX6tFu4h7YfeqS1rrPxFzlBU=; b=n2GhYp+7xQw4L1E3xeS2lmzZFunVC9Razo+jLRyR6fewX7Nw43Dp0XJ5xOmJXg4KpL 75IefvTfTxH3jGjjXKYTxkRopDn069S303BaklkNvESGPGTBzzJD8VAzNpGMEazOFaWP oHLdMpzsUCkirlWoHhlmA0Yq8kQAXkOyP/p/c85cLnBehPDxmnhCMicTg5mc25v36gT0 nNfm6pI4EjKV5WjKPHTuWrNqCAHJOmAtAApWdDRhszdBJG+qry6RIzpbeL7UlEuUWHfn o9RykVr4sw3Jd7Lb9MG3/iw6vtZi4KODPWLO5EWwcFZud39+YXhgOCryf/ICx99w/Rkw H/pA== X-Forwarded-Encrypted: i=1; AJvYcCVl0uyQiZDy8m9mblV3SbYJDiQt+r/nXJXdVeS0dPS7IzqLsAZo5TUSquSgm7GVJTfI68fnBG4BLvLfT/fHfJ1iUpo= X-Gm-Message-State: AOJu0YzjpizldE44SLHzX/4BXuih9yLRHLoVdgradVOcdQDxJ2zljF4Q He5Rq73kr55aSSSvoUoEUBYouVhT/90sSNMkz9reP01/42aUkZZLeQUu2wFQIg== X-Google-Smtp-Source: AGHT+IHBTYQNm0G/5iTIWcqtCpBMx8eO+Lcv57FnkpUl7K+iOvZATxbmc2iNNHMdthR59l4Mz4CqSQ== X-Received: by 2002:a05:6a21:4987:b0:1a6:b689:8c29 with SMTP id ax7-20020a056a21498700b001a6b6898c29mr10500341pzc.61.1713227676987; Mon, 15 Apr 2024 17:34:36 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id k3-20020a170902694300b001e24988b99asm8503932plt.250.2024.04.15.17.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 17:34:36 -0700 (PDT) Date: Mon, 15 Apr 2024 17:34:35 -0700 From: Kees Cook To: Jeff Xu Cc: Muhammad Usama Anjum , akpm@linux-foundation.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, corbet@lwn.net, Liam.Howlett@oracle.com, surenb@google.com, merimus@google.com, rdunlap@infradead.org, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Subject: Re: [PATCH v10 3/5] selftest mm/mseal memory sealing Message-ID: <202404151733.59C3EF3@keescook> References: <20240415163527.626541-1-jeffxu@chromium.org> <20240415163527.626541-4-jeffxu@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 3744A1A000B X-Rspam-User: X-Stat-Signature: cfq98hwgatgu6tr98ybq1q98owkbhyjf X-Rspamd-Server: rspam03 X-HE-Tag: 1713227678-175073 X-HE-Meta: U2FsdGVkX18jo+/dZcJNFr1sOm8wfNrCHEn6VYr51F2hSrmYfvpFhkIBWK4cTC57KsqUtTMCWGlzI1IkSl/xgIcodQmX4bpEhjkyls/JQODiJgWLS+xVe8s7WiUXXY11ADdHlc57nPZCyMvY31ZIR9K8QzZgioXH7AyF3U2jCIGFKrCGIougIhznLWqMD+eL2Sh1H/LcJT8RTSr6zzWVbGb0FNJyd3mNHeo4/9V4zHBI1ythZOjVYuReC5FKdbNR0Poq7y2EntQ0LQuhlvvRfAQpRFbgzXBICniv0+l+1XaiaN6xksu1vp6ILBQ9Fqs+DC20odhLHlYj7taxgRf+hDhqfa6Ptm2QSjLcD7JSxeky+mrR39H5pgbLQbqk7cB7/F5a8lmQTSCZ4DZVoSPOErxzdoB/vxOnhyTg/5PPMdxfM1IxzTbutBTPabltoyVYKNKhMVgicek/pr23/ZvuXZPZ0C5wF9jh3vagMCQNAK9J5caII5L2AD7NNvnKlbQvcQjkXDelRbgkcctNQoSsOBa3luOsqcTjfphu1J3goCu2AYmg47zqn1KzdMKipyAwT0h5QpcZHTqnQXqV23RorYVEbOFEBxhpNtwYbWtOQZKwC+BoJQ1XY8ncFYM0d3Ls0LTEF9DoRHMIxxWZcdzAdf51gON2fqeTWYMOA7Rkun8dY5Lq74xh1NmV8+zl0CoGqtlvqBKAx8VeybtzpdeTSS0U4ayzwZgUGWUvOTSEOhArpOozNA/X+ODYZdFZfBZfyhL2Mc7CExIErr49OY8Y+fInyzMRXC/QXbwaTuMxhYsyrApcCIIwjnW5ZcX9AF9kiBUhJwDCoPLfC6Fj475H6xqU8sY93J76fMnIKFAhYKtfTh8E81kvqKzLMv8qHnh/1UXkAeMems9kfxOpHqdBom0lpkUd1BzLHr44gVahvi9D4koGKEQ7V18JmBrCynZ2xzf3UrBH7x1KSXaYosH ZKh6w7lJ +vEV2BXnAFRoANXNZJRZgQYrH3qaRFbLXByKao+obg6wmAfWVPVGDfMQND0nX+RlOywKVQx/nDbEVth9YxVe5pnpZIA+78VM3SDfbFO2d+zen+hKIeH8Ajt3s3qylizFaENWQylWAMj9pnlp6e1MF55ewVZQebDirEXmNJKw4LXlFjQ0uwA8b3cs+zuKvz0z0cfA0LGmurtBpg8mNm8NbZaJxinJEeL1MAody5tHYJjjAIrCSoUjM5O1QizZaXe0d11X8bC7jAJMcKjuFyMgdhbesuES1ihmX1xABfc8bTYrGHkm6dB2F7eHOSxE/EAAehFnz2JCfFuBjIC9MfIfzkuTSs5GbjdwRk73oX45n2aqihV32IxngBTVBo5nqrqzKMlSOolDRGGxjAIPehHqZKQe8FFZepKJI3daooLuOLUHHV7Fj98rAah6dGK174eEyLQVqvFr7XEqCdKWRumfrVe/bjmObLf7tVgXm99ODtyH9PPrjEXYo+VmR5H5qvibAVbOj X-Bogosity: Ham, tests=bogofilter, spamicity=0.041977, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 15, 2024 at 01:27:32PM -0700, Jeff Xu wrote: > On Mon, Apr 15, 2024 at 11:32 AM Muhammad Usama Anjum > wrote: > > > > Please fix following for this and fifth patch as well: > > > > --> checkpatch.pl --codespell tools/testing/selftests/mm/mseal_test.c > > > > WARNING: Macros with flow control statements should be avoided > > #42: FILE: tools/testing/selftests/mm/mseal_test.c:42: > > +#define FAIL_TEST_IF_FALSE(c) do {\ > > + if (!(c)) {\ > > + ksft_test_result_fail("%s, line:%d\n", __func__, > > __LINE__);\ > > + goto test_end;\ > > + } \ > > + } \ > > + while (0) > > > > WARNING: Macros with flow control statements should be avoided > > #50: FILE: tools/testing/selftests/mm/mseal_test.c:50: > > +#define SKIP_TEST_IF_FALSE(c) do {\ > > + if (!(c)) {\ > > + ksft_test_result_skip("%s, line:%d\n", __func__, > > __LINE__);\ > > + goto test_end;\ > > + } \ > > + } \ > > + while (0) > > > > WARNING: Macros with flow control statements should be avoided > > #59: FILE: tools/testing/selftests/mm/mseal_test.c:59: > > +#define TEST_END_CHECK() {\ > > + ksft_test_result_pass("%s\n", __func__);\ > > + return;\ > > +test_end:\ > > + return;\ > > +} > > > I tried to fix those warnings of checkpatch in the past, but no good > solution. If I put the condition check in the test, the code will have > too many "if" and decrease readability. If there is a better > solution, I'm happy to do that, suggestions are welcome. Yeah, these are more "conventions" from checkpatch. I think it's fine to ignore this warning, especially for selftests. -- Kees Cook