From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B25FDC4345F for ; Mon, 15 Apr 2024 08:03:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 332246B0085; Mon, 15 Apr 2024 04:03:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BA0B6B0088; Mon, 15 Apr 2024 04:03:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 138396B0089; Mon, 15 Apr 2024 04:03:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E99936B0085 for ; Mon, 15 Apr 2024 04:03:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A0D68A159D for ; Mon, 15 Apr 2024 08:03:52 +0000 (UTC) X-FDA: 82011027504.17.FB5329F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 6EC95180010 for ; Mon, 15 Apr 2024 08:03:50 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hKFfLh3Z; dmarc=none; spf=none (imf16.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713168231; a=rsa-sha256; cv=none; b=7lN37SofnB4bwMCqx2abnZheuOKcYp7SMJ6NkZzsIhRMaA6ITtYTME9mhdx9JwO8f9nVsZ f+dRQyzyl0LwKEy99eBohJg17ZIWmhZrofN9fWYuFcfOSyZNaD7h2C0PmOeflYBPk5ig4d bNkuXyHCF3ToS5SGti0Wklly2fUepMg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hKFfLh3Z; dmarc=none; spf=none (imf16.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713168231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SnC5QhRh3mlXbiY7BQLXM/Gh385CPpYbuU5jeG1ji44=; b=kx7mR76ahFV+uTghA32BwC5VBDxsBDI5gywkNjZ8ziI5Uym0mThUP3sVYHKpcWq9Ko/ahK FBwwlBPzmhDnnbffq/c9Sy+eCTbBtoANuRVOoNhsHOajOWep/ZDYxBBNzfUywT39fTniPv jglcLkGM9woYE7JYyUxUtvdHUZt6GSA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SnC5QhRh3mlXbiY7BQLXM/Gh385CPpYbuU5jeG1ji44=; b=hKFfLh3ZzFSzJGPDsRiopYa0ZT efNxCJqPzVqpITxLJsqCQRDO/uvf69qkc9BXqmWr7IXteAQce+itGNJYH8NcZtrv9mowEIaYK6OnE zu1E4zjHKlTRzhIC1ZV1QOADiXZdrVLff1qYNP1JR24KuBKOy5EmbA81XuxsDuKJyy+iJ89PdOUI/ efJhNT73J6k+ohWLAe+NOaJ0tLI7iHDK5KHmXtq9go12IpYLvh58Vu6qfltj09NU88Ez/5/ao6M2e ksvVbHfa9e2PLeJq7LlMBgltQx/i+r0JGyYLxMjQF0iD8WvUaOibeLqFhJKeJcs34Gs9iz6tlyZPZ lKITRWCQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwHJC-0000000FFhi-3aDy; Mon, 15 Apr 2024 08:03:22 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 12C5730040C; Mon, 15 Apr 2024 10:03:22 +0200 (CEST) Date: Mon, 15 Apr 2024 10:03:21 +0200 From: Peter Zijlstra To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Song Liu , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 06/15] mm/execmem, arch: convert simple overrides of module_alloc to execmem Message-ID: <20240415080321.GG40213@noisy.programming.kicks-ass.net> References: <20240411160051.2093261-1-rppt@kernel.org> <20240411160051.2093261-7-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240411160051.2093261-7-rppt@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6EC95180010 X-Stat-Signature: 6jmpynts4os9zaqwp36xrrtzxuut8yrp X-HE-Tag: 1713168230-914947 X-HE-Meta: U2FsdGVkX18BXBQ7wkJ0F/QJDUZTGxoLUgL0/opJza6AdI/lDO7LAmIF3K1mAWNQUw3DTYq36I0fUnch15lUX/zaoFo17sIFiHbk0Vo2hDJK+4L/4nxpYAjmH6U0l7XpgMXnOYAxbIxJm9VkV6htkvk3t6RRa8G1vUWJ8ZYb+mT53QAa7QeEncJhrVp+NWikm9jzsXBz+jOaTqdL7CZwjskkSpMKkUhLn8eO8TxIQwwFCqZto3RMlpf62EvuddNKEq2sbq3oAGYmjepkVHrKgPBcz6cG98PeT2OO6xYaJHKqVbOMjrKRq5Cynd8xRF8fDqTp7FMUg6P9LnwYebhDFnAu39M8O4nXFxTrOfvJXtOxPS5d5kW623wDnATGhjemtV8/JvU7pcPInqjpojqnEfXY/xigWk2xVHkoT34YNi37Kbsit0Kl29TS534jpjFECmIEL+6GzXM2bezuyqRwSjyReFMMn6hKEtvySI7I2CzcU+gInck9YVQtgsTESMtZOCBXBPYnTXnRk7Yt7n/rUzDO4xoIrpvfL+9K4Df2PYb2MHCRgriMkwZMPjNZWffJu8zZKaBiy6lw6gb638BdO/fBSCPB+rV808afcP5Mr6gvo2eM/qyDBisfmHcilWvmbMQdHzFnz4vxwCnRjh1AWg8ZPN9RSFfKh5ofZHj2Xg7F16bd6RTRgpjKTf9k8c6/pXtl4wo+0+7UYXeE4MUmqD8wb/DHSuz7E2JBVKISxe8WnHX/PxOHMw6URSxMCPU4s97bmGs+bH8QxYm08x3EeMxl0sCyjrP8iKOTHpuv4rXvkjXK4zvfoXu4OgSOR5c9bFZc5RhVMjfq/Uhk1QRWyv6S8lRmGv8i1dEdCtHjDhF+3qal7fkyxG8uepGuPrCJ7QJE8Wr9RDxMv2KKBe5tHPVARVzCbaV1BM0FVFOrGCyVOP/248cdp82DaLEW5nF5BK0hxovaUjbCR98O75N WCGe3V8Y PuuqMmWkxz/UZ9KXG/HVUji2/Cb5aBtLjnUCSHooyQxWdEbuYxZ3QqrpkBUqAMqqrRaXxj6nOTZ7sBIJEI/3s4oWt74MjbToE69PgctNZVijKRJeZB0ycpZVA7cj/RvtVgab4kJ4+OLrG0FAJljxQyfPhoQ7F1Wh5pBKM9pcLemAyWpK3lAYgeSjOwRfHiFk0et4SkVMvC8tdc0bi59+/WWQlMXFaVbpOrvyfez0t/fAQ8bMjsSlwhh/JoLTAeOZ1B5PG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 11, 2024 at 07:00:42PM +0300, Mike Rapoport wrote: > +static struct execmem_info execmem_info __ro_after_init = { > + .ranges = { > + [EXECMEM_DEFAULT] = { > + .start = MODULES_VADDR, > + .end = MODULES_END, > + .alignment = 1, > + }, > + }, > +}; > + > +struct execmem_info __init *execmem_arch_setup(void) > { > + execmem_info.ranges[EXECMEM_DEFAULT].pgprot = PAGE_KERNEL; > + > + return &execmem_info; > } > +static struct execmem_info execmem_info __ro_after_init = { > + .ranges = { > + [EXECMEM_DEFAULT] = { > + .start = MODULES_VADDR, > + .end = MODULES_END, > + .pgprot = PAGE_KERNEL_EXEC, > + .alignment = 1, > + }, > + }, > +}; > + > +struct execmem_info __init *execmem_arch_setup(void) > { > + return &execmem_info; > } > +static struct execmem_info execmem_info __ro_after_init = { > + .ranges = { > + [EXECMEM_DEFAULT] = { > + .pgprot = PAGE_KERNEL_RWX, > + .alignment = 1, > + }, > + }, > +}; > + > +struct execmem_info __init *execmem_arch_setup(void) > { > + execmem_info.ranges[EXECMEM_DEFAULT].start = VMALLOC_START; > + execmem_info.ranges[EXECMEM_DEFAULT].end = VMALLOC_END; > + > + return &execmem_info; > } > +static struct execmem_info execmem_info __ro_after_init = { > + .ranges = { > + [EXECMEM_DEFAULT] = { > + .pgprot = PAGE_KERNEL, > + .alignment = 1, > + }, > + }, > +}; > + > +struct execmem_info __init *execmem_arch_setup(void) > { > + execmem_info.ranges[EXECMEM_DEFAULT].start = MODULES_VADDR; > + execmem_info.ranges[EXECMEM_DEFAULT].end = MODULES_END; > + > + return &execmem_info; > } > +static struct execmem_info execmem_info __ro_after_init = { > + .ranges = { > + [EXECMEM_DEFAULT] = { > #ifdef CONFIG_SPARC64 > + .start = MODULES_VADDR, > + .end = MODULES_END, > #else > + .start = VMALLOC_START, > + .end = VMALLOC_END, > +#endif > + .alignment = 1, > + }, > + }, > +}; > + > +struct execmem_info __init *execmem_arch_setup(void) > { > + execmem_info.ranges[EXECMEM_DEFAULT].pgprot = PAGE_KERNEL; > > + return &execmem_info; > } I'm amazed by the weird and inconsistent breakup of initializations. What exactly is wrong with something like: static struct execmem_info execmem_info __ro_after_init; struct execmem_info __init *execmem_arch_setup(void) { execmem_info = (struct execmem_info){ .ranges = { [EXECMEM_DEFAULT] = { .start = MODULES_VADDR, .end = MODULES_END, .pgprot = PAGE_KERNEL, .alignment = 1, }, }, }; return &execmem_info; }