From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E10C4345F for ; Sat, 13 Apr 2024 15:56:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06E186B007B; Sat, 13 Apr 2024 11:56:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01D916B0082; Sat, 13 Apr 2024 11:56:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E27086B0083; Sat, 13 Apr 2024 11:56:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C53AA6B007B for ; Sat, 13 Apr 2024 11:56:51 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 656CD1C1368 for ; Sat, 13 Apr 2024 15:56:51 +0000 (UTC) X-FDA: 82004961822.05.F5A409C Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf03.hostedemail.com (Postfix) with ESMTP id BC7DB20006 for ; Sat, 13 Apr 2024 15:56:48 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=ZQSoo5nd; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf03.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713023808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=SlcR41hse8ytw2MXnYpZ97rYSoxohH+lL9OGt7SRLNU=; b=SAaKdD7pO6KI6SOogMMGnxRn77qKbLiTZKfsOqk8+QNNkaoVUinUFyIt2188ffhJWDv9oQ vl3L1rHhMvQhBvXDeT251nh4z7Clr1JWsj93t+zpvZzEDmiSEkTYc07124dnSpp4H6BCQZ R7165Nbap4jslWotjYVzGBMo/Ixq4FA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=ZQSoo5nd; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf03.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713023808; a=rsa-sha256; cv=none; b=Nz+LgefKRnVsjIKTxwy16/ddgaegb+wXxF6Q4CD2XozOd/Q5c8btvZ5aSsEAiX/KivYHGr Uo9Zk9fzgy4REoEiEqMtpzirQUVfdEC+/u17dZYl0j9o9CrWDTzNUDR4E5k18e1LD7VorW cEOw7U/WNpmsSPj2HE3RC7NGA41nQIE= Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2a52c544077so1349585a91.1 for ; Sat, 13 Apr 2024 08:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1713023807; x=1713628607; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SlcR41hse8ytw2MXnYpZ97rYSoxohH+lL9OGt7SRLNU=; b=ZQSoo5ndoWByexjd/0RBBLFCDNp1rKE841jZoZVc5F6XVcR2ehGkht+Gb74VP4SJSI lHzr0rZivNlebpVBROym1xZVEcUTjA2F2P0Z27pqKa2wScCXFl5n9/cnr3rwOunVHUKf 22rk6X6iibkw45nA6S+DtQTXYYO6FthyNEVzmyqxXMNz32CZiM3aMHqa5d+1HKHN7ohy SCLkPIcK/Z9GWNavMrHws87FT2yrGVZpjmJf82BAbSJrfSjMeXGajALOAelxYOSPlj7Z d3Puz0NbPiupVIwxHG1NLu4tdS+ZXnjPzG0CeddNxqrG/mP+foL4Mqy3rUQpcUR4WHdG ENpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713023807; x=1713628607; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SlcR41hse8ytw2MXnYpZ97rYSoxohH+lL9OGt7SRLNU=; b=fWUxwSEFz4Ezurw28uB7SMEw2X93PHOKukV26SM8QM6NoUG0ZI9P7J5eMXBLzH2IGl k0t2UOXjGQ9LtFeLdMwFOXOMnIZ7QBbVcHbZSHDSWK3j/UaRnq23xNm/8zVsoVYS6x/U djjE++aqpRZ7456w3wL9jtKK3KUcPpumOdY5XnPeEzr0mU/DfqpNIqyQ7lr8T/o5Tabm QLchz0Uau9OUUFnC95gENKmC95eYLbCcIHnS3oPp97Fcu32C/mMQtweQtfxFeRYAmGud DjyapZVXB7+tB8b+ztrJ2ubuFWF4hq6u//rT4hxlgpJkDU+U/IwMrp2pL63+SuU68G0G LwOw== X-Forwarded-Encrypted: i=1; AJvYcCWvN3WaqpRj/N4Dk6P8QqIZvPQVTLUnZuowUhU4IHYGQe5LybY3OGK6z6FpU9vThKtxtjexJPwotctbsqtMW8CVG+M= X-Gm-Message-State: AOJu0YwFhLTwZN3tiKFogwBgCzFI/YWar4tgHnPpCc7JUpUKxBJ5LziV 6Hblnwj61XGzZ88yXmIORALVW9uxhgBwIodKrbyMAcHWaV5UfF1A+cdsnf8D0GU= X-Google-Smtp-Source: AGHT+IFieKNdVVSuLwqWGtv5VUNM4ouN23R6EytmrRddQajutjkn+wP1sPm30eKCbNzX3DUh9RWAAw== X-Received: by 2002:a17:90a:49c7:b0:2a5:379a:e2c with SMTP id l7-20020a17090a49c700b002a5379a0e2cmr4500879pjm.7.1713023807460; Sat, 13 Apr 2024 08:56:47 -0700 (PDT) Received: from localhost.localdomain ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id a18-20020a17090acb9200b002a5e1b215ccsm4443636pju.21.2024.04.13.08.56.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Apr 2024 08:56:47 -0700 (PDT) From: Haifeng Xu To: cl@linux.com, vbabka@suse.cz, willy@infradead.org Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu Subject: [PATCH] slub: Set __GFP_COMP in kmem_cache by default Date: Sat, 13 Apr 2024 15:56:03 +0000 Message-Id: <20240413155603.617554-1-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: BC7DB20006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: iga5q9mng65r8kpy7jfccar779rthbxk X-HE-Tag: 1713023808-994464 X-HE-Meta: U2FsdGVkX1/rv9Lbk4MRee8rdyHznD7nvu8yMhEH6zANGvclC1D+HxYsNpKB3iM7rtP4LP9up8kSQuMINCAhKFap8NvR/W7/znWQDy0iexLkXddZWpu5Ok7OIuxvrC+cZQe4WzSwaLqdFrCUYcy9rQQ5/J1e0Fm7rMrW4HY4DoeBd3hdlEY7POuU20Foi7XdeF8XvK3zzxGmRylsNJz9Q7xbI+b3NrLe+WSKLVgsXnPE3/xBTWvfOvB4y5+zkL98IW0mA3Zhrewe+wZrFcglSpZ1j9PivkJBrW+6smv6kTITreeMk4iJmbiS/llfUeTqu9b/gA3+7PsGE5J98ldf7JPVmvo2Oz8uhdOUd67ztJf7USE/2qeIg9gLxGpg4Q9jDtRcMYqPnBMAFmkswm30K3wCAsGcUK/XFRBwYG8ZGw6MgHlJoWdHO44qV3I6U1GZIqt1uw9btbiwTJhrEjOJLUuLciibAM9US3AF/GP98VHlTx7AEiQ0s9quv9oks4GAiWFgbsPZxTE9HjyN9RVEAE9yBXmP0v4PTE7f/nJ700VuyR64rUT0MzroJcSJv6BWC40virk0COEN44ablAQq5muWP71dBepkxaDBzBRwYEiSs4d4a3YXNh0MyqPRmGLwEotlQ3WUYYQDXMnjKdVipMJrsuOIzW8zthLwizs3qNokDLY8L4y0+s2mmsQU+1W/sFcqfVXxUjv4Pe3Xk6rwPi7Z5fbNz7P6w1YMfTZ7tklc2lVt/i0xY/G2XsE4R3FG6F1eQX9+JUN919OIeBvEiPRZsp9I4U2LRPa06xDqQXCaD0XnKEEtxKpTl+cuJz9B/sCdWkEaMqwGeqnE36Tqs7QTddEGZuj6MIH40Du0duAAZCmJbqdomg7m6DZrOxA76to4SXSRKRsT5OfalaL4AFjbLSrq7VsAZobwDmHw1J7ZdIUKeSftpSQlyixJ5omZIrr342eDcKewloNl7Kn fQxZsrjk Y+GZXhSMm63VZ4zgQUCukbYrQfJrQtpULlcbEGS/kkp/Ak0gSDI7gxg6+oXLaGfoyZ7jW9cpUrJgcJw8p0M737IVj4J90GxqU6jvOhutpUpjlP6n5C5Q0p2jz7JeLsSAKoez86zH1wmGFqchjMNg/Nuav0zcOYVUDmHWcivGq4JEpK1iE1TMA51iUCOWK7Mq4He6bAVJWeg3y+mKQlm3PlyvtWBs56O9dl2jvYu1bLH6uJiM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now the __GFP_COMP is set only if the higher-order is not 0. However, __GFP_COMP flag can be set unconditionally because compound page can not be created in the order-0 case. And this can also simplify the code a bit (no need to check the order is 0 or not). Signed-off-by: Haifeng Xu Reviewed-by: Matthew Wilcox (Oracle) --- mm/slub.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index e7bf1a1a31a8..49a3ebefab86 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -4461,9 +4461,7 @@ static int calculate_sizes(struct kmem_cache *s) if ((int)order < 0) return 0; - s->allocflags = 0; - if (order) - s->allocflags |= __GFP_COMP; + s->allocflags = __GFP_COMP; if (s->flags & SLAB_CACHE_DMA) s->allocflags |= GFP_DMA; -- 2.25.1