From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F2BC04FF8 for ; Fri, 12 Apr 2024 14:38:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 459BE6B009C; Fri, 12 Apr 2024 10:38:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E3496B009D; Fri, 12 Apr 2024 10:38:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25B706B009E; Fri, 12 Apr 2024 10:38:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 04D726B009C for ; Fri, 12 Apr 2024 10:38:03 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A9A4540EA5 for ; Fri, 12 Apr 2024 14:38:03 +0000 (UTC) X-FDA: 82001134446.11.5718AB2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf20.hostedemail.com (Postfix) with ESMTP id 441281C0023 for ; Fri, 12 Apr 2024 14:38:00 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1N4TA4iS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=91MBCG5d; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1N4TA4iS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=91MBCG5d; dmarc=none; spf=pass (imf20.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712932680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sCsDTBKE5BK0xtqcaioV7AbOpY2+77/u8JnnEMWVVZE=; b=MJGSnrJzUNh2JKS1+AX8+mFutqozuBYFHGKGyVg5UehDS1l82JUoJijvAyi1g2Nxt5TbD2 y2zPpppN9BjVVM2vy96OEc43uJ2EN6YQcdtrDcBOZ5OOTVUGCYg1/+91F0zYMuDypX4qN4 +2hjsQo5V4hKRkfTUSvg7xVrL4V5gNY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1N4TA4iS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=91MBCG5d; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1N4TA4iS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=91MBCG5d; dmarc=none; spf=pass (imf20.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712932680; a=rsa-sha256; cv=none; b=IF2OT9OXoTUM8ODpCvPkalwyJEEZJV9lptDFpG8IdQc6urTRYrKJJRaTb1sRzQXs7qlWsa 4pET/tTblBDti2R5+DomZVd3e7Nq8icZrkcHBk/YEt7UVJZxQbi875DBgIRf8D/P3nQLd0 bS0Uvg+lyTydDB2wITP0SsvN37kmjz8= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7044C5FDFC; Fri, 12 Apr 2024 14:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712932678; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sCsDTBKE5BK0xtqcaioV7AbOpY2+77/u8JnnEMWVVZE=; b=1N4TA4iSTfxUqNz5D936xqF5zCSJDUQBPw+YYsE+KfyhAG1A6dw/HnUR1wLb9WFFP5+ICw R2AomD66IAwSQ0BMGElFbfk95nCAX54OM9vkzuZiryQrdIJOCyBwb46nGoHY9m8+EcsH74 xlIh0Gucar30XspIjssbnGtftd6g8sg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712932678; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sCsDTBKE5BK0xtqcaioV7AbOpY2+77/u8JnnEMWVVZE=; b=91MBCG5d18RAvnFExJRBaS9JJp3FA1woZQ557EaPDYo+k1UrUYikDzgpf8/2VIf3HLGlds oNyFG6cVlEl6KjBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712932678; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sCsDTBKE5BK0xtqcaioV7AbOpY2+77/u8JnnEMWVVZE=; b=1N4TA4iSTfxUqNz5D936xqF5zCSJDUQBPw+YYsE+KfyhAG1A6dw/HnUR1wLb9WFFP5+ICw R2AomD66IAwSQ0BMGElFbfk95nCAX54OM9vkzuZiryQrdIJOCyBwb46nGoHY9m8+EcsH74 xlIh0Gucar30XspIjssbnGtftd6g8sg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712932678; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sCsDTBKE5BK0xtqcaioV7AbOpY2+77/u8JnnEMWVVZE=; b=91MBCG5d18RAvnFExJRBaS9JJp3FA1woZQ557EaPDYo+k1UrUYikDzgpf8/2VIf3HLGlds oNyFG6cVlEl6KjBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5D1371368B; Fri, 12 Apr 2024 14:37:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Sl+yFkZHGWZJdQAAD6G6ig (envelope-from ); Fri, 12 Apr 2024 14:37:58 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 088D3A071E; Fri, 12 Apr 2024 16:37:50 +0200 (CEST) Date: Fri, 12 Apr 2024 16:37:49 +0200 From: Jan Kara To: Alistair Popple Cc: linux-mm@kvack.org, david@fromorbit.com, dan.j.williams@intel.com, jhubbard@nvidia.com, rcampbell@nvidia.com, willy@infradead.org, jgg@nvidia.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, djwong@kernel.org, hch@lst.de, david@redhat.com, ruansy.fnst@fujitsu.com, nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, jglisse@redhat.com Subject: Re: [RFC 05/10] fs/dax: Refactor wait for dax idle page Message-ID: <20240412143749.3tryph4khox3euef@quack3> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: gb9o7ak8yxutm9qfh6nods7jy441f339 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 441281C0023 X-HE-Tag: 1712932680-724938 X-HE-Meta: U2FsdGVkX1+V2I1dxTOCgUgkx+nqh6cupSSkLT/0lMi3TgPCiIwK/3gweOajPzw7UJf2dp1rL9kGZkG9NBOgRqDxMl7R8fjf1ck6427AEoTotACGTc6OpYalLLonHvdGzuJ4RdE27waZHack9GTCyp6YmYGDqVLtLiaP94W37BRNLREoRG2lHjdEN7d6VjqpeUQC9fAqxHEBBNxmerDWffLgOYSeBIoMZAdxtNwhJ1Nrh8BOU3PJBY1i6BOZvpWzqhYx9+z2uMKTq9N9Z0ZKS8Jz5bO3keTWC9rv/7PPwIeYU1L9L5Qp8yljgysKnB5lcd/kIz0I0fKeWOG4opbJ2IA97EVPQSUynHemNywWr+tfg/1YaWDIkRLAQuhpPEf2aVs4U/BnyZy23p5ioitBzIIgePeT11ms2K3/RwrKIE/jIDMJjJgtH10S1b9llKUslnHdn3qfD/wToSKlGdt359RzO6f4vxlIpRxK5QdQdDo37TAEhaQ5yHqNWpA9i8yB6O4J3SnJ4D1I1hArzmMk6KYgMg404rvFREBws5KWBJ2+l+yw65jx/SOv6qzgbKk6ap92FXhiDi4j477tLqiU0gFrxwveCrxr36jrezcSpFLZi4i1CDMXwPnTwI31F9t/PF7r5kRWoiobvSQdxJDFb6DhIiSAVxjYFFlcmJTMWNAV9ib+MonJH2ZCcjjzBeMeUkIBMkPvB0dQjX570V3TrrvnqkDZYhz0RKSCfoB2JdgWKaxvDNOzJbNcvAxXnsYG1/3qTlRS1o0x7sIhgirp4VpJJXz/wC+rLsl5dXnSi57lPPBUgW2El0joP529uqw4a9Rg35d5nfDcqsCxv4HbmlyAFxdmn3WVUT+YiyjoAqg2CehYFqjX4YCeU9IUyafWRN0gBvOjT5iXetLlkClB9AQCVC7rcS1OtTAoejvK2e/KU+U6qTvGkDz6LgV8YZT0HeNJylTCV+CPRVRUtu+ 09J9wVcc fxXNilXmjJqbdIqofUJZ/7zlDXqhzP+xOJR2n2lKR3FRtAgoiG/Qk/Wbe/nl80thoD5q5u+fvDkGGVa7t98iP3fH3IaW25iODd81wbURvCpYq1HFUi8H8IK+IFf5u0IJS4djLlBQNeoF8A2uqIENByrBRMmuBH9vyN/4I5izP22baG2ZBqvmabO4u5BDH8IClink9eYraFvhvwEcaN5V6NNzJ8wNLoT4swA6qdVDOmtQ/gqAJSRWo+DmJ6o/m3hqjTRDKoiQy5+i+4/a7FmwbiejmSgZsTIS8uTQuVtGZW1IsRcJJLFRboVz24A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 11-04-24 10:57:26, Alistair Popple wrote: > A FS DAX page is considered idle when its refcount drops to one. This > is currently open-coded in all file systems supporting FS DAX. Move > the idle detection to a common function to make future changes easier. > > Signed-off-by: Alistair Popple Good cleanup. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/inode.c | 5 +---- > fs/fuse/dax.c | 4 +--- > fs/xfs/xfs_file.c | 4 +--- > include/linux/dax.h | 11 +++++++++++ > 4 files changed, 14 insertions(+), 10 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 4ce35f1..e9cef7d 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -3868,10 +3868,7 @@ int ext4_break_layouts(struct inode *inode) > if (!page) > return 0; > > - error = ___wait_var_event(&page->_refcount, > - atomic_read(&page->_refcount) == 1, > - TASK_INTERRUPTIBLE, 0, 0, > - ext4_wait_dax_page(inode)); > + error = dax_wait_page_idle(page, ext4_wait_dax_page, inode); > } while (error == 0); > > return error; > diff --git a/fs/fuse/dax.c b/fs/fuse/dax.c > index 23904a6..8a62483 100644 > --- a/fs/fuse/dax.c > +++ b/fs/fuse/dax.c > @@ -676,9 +676,7 @@ static int __fuse_dax_break_layouts(struct inode *inode, bool *retry, > return 0; > > *retry = true; > - return ___wait_var_event(&page->_refcount, > - atomic_read(&page->_refcount) == 1, TASK_INTERRUPTIBLE, > - 0, 0, fuse_wait_dax_page(inode)); > + return dax_wait_page_idle(page, fuse_wait_dax_page, inode); > } > > /* dmap_end == 0 leads to unmapping of whole file */ > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 2037002..099cd70 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -849,9 +849,7 @@ xfs_break_dax_layouts( > return 0; > > *retry = true; > - return ___wait_var_event(&page->_refcount, > - atomic_read(&page->_refcount) == 1, TASK_INTERRUPTIBLE, > - 0, 0, xfs_wait_dax_page(inode)); > + return dax_wait_page_idle(page, xfs_wait_dax_page, inode); > } > > int > diff --git a/include/linux/dax.h b/include/linux/dax.h > index 22cd990..bced4d4 100644 > --- a/include/linux/dax.h > +++ b/include/linux/dax.h > @@ -212,6 +212,17 @@ int dax_zero_range(struct inode *inode, loff_t pos, loff_t len, bool *did_zero, > int dax_truncate_page(struct inode *inode, loff_t pos, bool *did_zero, > const struct iomap_ops *ops); > > +static inline int dax_wait_page_idle(struct page *page, > + void (cb)(struct inode *), > + struct inode *inode) > +{ > + int ret; > + > + ret = ___wait_var_event(page, page_ref_count(page) == 1, > + TASK_INTERRUPTIBLE, 0, 0, cb(inode)); > + return ret; > +} > + > #if IS_ENABLED(CONFIG_DAX) > int dax_read_lock(void); > void dax_read_unlock(int id); > -- > git-series 0.9.1 > -- Jan Kara SUSE Labs, CR